89143 2012-06-14 17:32:29 -0700 [chromium] Make TiledLayerChromium robust to unexpected null tiles 2012-06-14 21:59:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne jamesr webkit.review.bot oldest_to_newest 649669 0 enne 2012-06-14 17:32:29 -0700 [chromium] Make TiledLayerChromium robust to unexpected null tiles 649671 1 147689 enne 2012-06-14 17:34:30 -0700 Created attachment 147689 Patch 649673 2 enne 2012-06-14 17:35:20 -0700 See: http://code.google.com/p/chromium/issues/detail?id=116442 This is an attempt to get the crash rate down in the short term. If this makes the updateLayerRect-related crashes go away, that will also be a useful signal. 649679 3 147689 jamesr 2012-06-14 17:39:59 -0700 Comment on attachment 147689 Patch Let's try it 649857 4 147689 webkit.review.bot 2012-06-14 21:59:54 -0700 Comment on attachment 147689 Patch Clearing flags on attachment: 147689 Committed r120398: <http://trac.webkit.org/changeset/120398> 649858 5 webkit.review.bot 2012-06-14 21:59:58 -0700 All reviewed patches have been landed. Closing bug. 147689 2012-06-14 17:34:30 -0700 2012-06-14 21:59:54 -0700 Patch bug-89143-20120614173430.patch text/plain 4660 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjI0OThkNTM3ZTA0YTQw YjViNmIyYjE4NzRhZGY5YmE3OTU5NTg2YS4uYWY5YTAzOTRlMTQ4ZWExYjgwZTA3NjdjOGQzMGVl YThiOWRhYmZjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA2LTE0ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBNYWtl IFRpbGVkTGF5ZXJDaHJvbWl1bSByb2J1c3QgdG8gdW5leHBlY3RlZCBudWxsIHRpbGVzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTE0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsdGhvdWdoIHRoZXJl IHNob3VsZG4ndCBldmVyIGJlIG51bGwgdGlsZXMgaW4gdGhlIG1hcCwgaXQgYXBwZWFycyB0bwor ICAgICAgICBiZSBvY2N1cnJpbmcgZnJlcXVlbnRseSBlbm91Z2ggdG8gc2hvdyB1cCBpbiBjcmFz aCByZXBvcnRzLiBJbiB0aGUKKyAgICAgICAgc2hvcnQgdGVybSwgYmUgcm9idXN0IHRvIHRoaXMg c28gdGhlIHRpbGVyIGRvZXNuJ3QgY3Jhc2guIFRoaXMgc2hvdWxkCisgICAgICAgIGV2ZW50dWFs bHkgYmUgcmV2ZXJ0ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9U aWxlZExheWVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRMYXllckNocm9t aXVtOjpwdXNoUHJvcGVydGllc1RvKToKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkTGF5ZXJDaHJv bWl1bTo6c2V0TGF5ZXJUcmVlSG9zdCk6CisgICAgICAgIChXZWJDb3JlOjpUaWxlZExheWVyQ2hy b21pdW06OmludmFsaWRhdGVSZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVkTGF5ZXJDaHJv bWl1bTo6dXBkYXRlVGlsZXMpOgorICAgICAgICAoV2ViQ29yZTo6VGlsZWRMYXllckNocm9taXVt OjpyZXNldFVwZGF0ZVN0YXRlKToKKwogMjAxMi0wNi0xNCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNo b2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gTW92ZSBjdXJzb3IgcmVsYXRlZCBjb2Rl IGZyb20gV2lkZ2V0RWZsIHRvIGV3a192aWV3IGFuZCBFZmxTY3JlZW5VdGlsaXRpZXMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9UaWxlZExh eWVyQ2hyb21pdW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vVGlsZWRMYXllckNocm9taXVtLmNwcAppbmRleCAxMWU5ZDhkNDNkNWFhMTM1MWE1MzA3Mjg5 MGU5YzllNDhjMGQ1NzhiLi5hN2Q4NzdlMzNlYzlhNmQ4MTAzNTdlMjliMjIyMjJjNzA1YTEwYjY3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9U aWxlZExheWVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL1RpbGVkTGF5ZXJDaHJvbWl1bS5jcHAKQEAgLTIxNiw2ICsyMTYsOSBAQCB2 b2lkIFRpbGVkTGF5ZXJDaHJvbWl1bTo6cHVzaFByb3BlcnRpZXNUbyhDQ0xheWVySW1wbCogbGF5 ZXIpCiAgICAgICAgIGludCBpID0gaXRlci0+Zmlyc3QuZmlyc3Q7CiAgICAgICAgIGludCBqID0g aXRlci0+Zmlyc3Quc2Vjb25kOwogICAgICAgICBVcGRhdGFibGVUaWxlKiB0aWxlID0gc3RhdGlj X2Nhc3Q8VXBkYXRhYmxlVGlsZSo+KGl0ZXItPnNlY29uZC5nZXQoKSk7CisgICAgICAgIC8vIEZJ WE1FOiBUaGlzIHNob3VsZCBub3QgZXZlciBiZSBudWxsLgorICAgICAgICBpZiAoIXRpbGUpCisg ICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgdGlsZS0+aXNJblVzZU9uSW1wbCA9IGZhbHNl OwogICAgICAgICBpZiAoIXRpbGUtPm1hbmFnZWRUZXh0dXJlKCktPmlzVmFsaWQobV90aWxlci0+ dGlsZVNpemUoKSwgbV90ZXh0dXJlRm9ybWF0KSkgewogICAgICAgICAgICAgaW52YWxpZFRpbGVz LmFwcGVuZCh0aWxlKTsKQEAgLTI0Myw2ICsyNDYsOSBAQCB2b2lkIFRpbGVkTGF5ZXJDaHJvbWl1 bTo6c2V0TGF5ZXJUcmVlSG9zdChDQ0xheWVyVHJlZUhvc3QqIGhvc3QpCiAgICAgaWYgKGhvc3Qg JiYgaG9zdCAhPSBsYXllclRyZWVIb3N0KCkpIHsKICAgICAgICAgZm9yIChDQ0xheWVyVGlsaW5n RGF0YTo6VGlsZU1hcDo6Y29uc3RfaXRlcmF0b3IgaXRlciA9IG1fdGlsZXItPnRpbGVzKCkuYmVn aW4oKTsgaXRlciAhPSBtX3RpbGVyLT50aWxlcygpLmVuZCgpOyArK2l0ZXIpIHsKICAgICAgICAg ICAgIFVwZGF0YWJsZVRpbGUqIHRpbGUgPSBzdGF0aWNfY2FzdDxVcGRhdGFibGVUaWxlKj4oaXRl ci0+c2Vjb25kLmdldCgpKTsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBub3Qg ZXZlciBiZSBudWxsLgorICAgICAgICAgICAgaWYgKCF0aWxlKQorICAgICAgICAgICAgICAgIGNv bnRpbnVlOwogICAgICAgICAgICAgdGlsZS0+bWFuYWdlZFRleHR1cmUoKS0+c2V0VGV4dHVyZU1h bmFnZXIoaG9zdC0+Y29udGVudHNUZXh0dXJlTWFuYWdlcigpKTsKICAgICAgICAgfQogICAgIH0K QEAgLTMwMyw2ICszMDksOSBAQCB2b2lkIFRpbGVkTGF5ZXJDaHJvbWl1bTo6aW52YWxpZGF0ZVJl Y3QoY29uc3QgSW50UmVjdCYgbGF5ZXJSZWN0KQogICAgIGZvciAoQ0NMYXllclRpbGluZ0RhdGE6 OlRpbGVNYXA6OmNvbnN0X2l0ZXJhdG9yIGl0ZXIgPSBtX3RpbGVyLT50aWxlcygpLmJlZ2luKCk7 IGl0ZXIgIT0gbV90aWxlci0+dGlsZXMoKS5lbmQoKTsgKytpdGVyKSB7CiAgICAgICAgIFVwZGF0 YWJsZVRpbGUqIHRpbGUgPSBzdGF0aWNfY2FzdDxVcGRhdGFibGVUaWxlKj4oaXRlci0+c2Vjb25k LmdldCgpKTsKICAgICAgICAgQVNTRVJUKHRpbGUpOworICAgICAgICAvLyBGSVhNRTogVGhpcyBz aG91bGQgbm90IGV2ZXIgYmUgbnVsbC4KKyAgICAgICAgaWYgKCF0aWxlKQorICAgICAgICAgICAg Y29udGludWU7CiAgICAgICAgIEludFJlY3QgYm91bmQgPSBtX3RpbGVyLT50aWxlUmVjdCh0aWxl KTsKICAgICAgICAgYm91bmQuaW50ZXJzZWN0KGxheWVyUmVjdCk7CiAgICAgICAgIHRpbGUtPmRp cnR5UmVjdC51bml0ZShib3VuZCk7CkBAIC00MTgsOCArNDI3LDkgQEAgdm9pZCBUaWxlZExheWVy Q2hyb21pdW06OnVwZGF0ZVRpbGVzKGJvb2wgaWRsZSwgaW50IGxlZnQsIGludCB0b3AsIGludCBy aWdodCwgaW4KICAgICBmb3IgKGludCBqID0gdG9wOyBqIDw9IGJvdHRvbTsgKytqKSB7CiAgICAg ICAgIGZvciAoaW50IGkgPSBsZWZ0OyBpIDw9IHJpZ2h0OyArK2kpIHsKICAgICAgICAgICAgIFVw ZGF0YWJsZVRpbGUqIHRpbGUgPSB0aWxlQXQoaSwgaik7CisgICAgICAgICAgICAvLyBGSVhNRTog VGhpcyBzaG91bGQgbm90IGV2ZXIgYmUgbnVsbC4KICAgICAgICAgICAgIGlmICghdGlsZSkKLSAg ICAgICAgICAgICAgICBDUkFTSCgpOworICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICAgICAgaWYgKHRpbGUtPnVwZGF0ZWQpCiAgICAgICAgICAgICAgICAgdGlsZS0+Y29weUFuZENs ZWFyRGlydHkoKTsKICAgICAgICAgICAgIGVsc2UgaWYgKCFpZGxlICYmIG9jY2x1c2lvbiAmJiB0 aWxlLT5pc0RpcnR5KCkpCkBAIC00NTEsNiArNDYxLDkgQEAgdm9pZCBUaWxlZExheWVyQ2hyb21p dW06OnVwZGF0ZVRpbGVzKGJvb2wgaWRsZSwgaW50IGxlZnQsIGludCB0b3AsIGludCByaWdodCwg aW4KICAgICBmb3IgKGludCBqID0gdG9wOyBqIDw9IGJvdHRvbTsgKytqKSB7CiAgICAgICAgIGZv ciAoaW50IGkgPSBsZWZ0OyBpIDw9IHJpZ2h0OyArK2kpIHsKICAgICAgICAgICAgIFVwZGF0YWJs ZVRpbGUqIHRpbGUgPSB0aWxlQXQoaSwgaik7CisgICAgICAgICAgICAvLyBGSVhNRTogVGhpcyBz aG91bGQgbm90IGV2ZXIgYmUgbnVsbC4KKyAgICAgICAgICAgIGlmICghdGlsZSkKKyAgICAgICAg ICAgICAgICBjb250aW51ZTsKIAogICAgICAgICAgICAgSW50UmVjdCB0aWxlUmVjdCA9IG1fdGls ZXItPnRpbGVCb3VuZHMoaSwgaik7CiAKQEAgLTU2MCw2ICs1NzMsOSBAQCB2b2lkIFRpbGVkTGF5 ZXJDaHJvbWl1bTo6cmVzZXRVcGRhdGVTdGF0ZSgpCiAgICAgQ0NMYXllclRpbGluZ0RhdGE6OlRp bGVNYXA6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9IG1fdGlsZXItPnRpbGVzKCkuZW5kKCk7CiAgICAg Zm9yIChDQ0xheWVyVGlsaW5nRGF0YTo6VGlsZU1hcDo6Y29uc3RfaXRlcmF0b3IgaXRlciA9IG1f dGlsZXItPnRpbGVzKCkuYmVnaW4oKTsgaXRlciAhPSBlbmQ7ICsraXRlcikgewogICAgICAgICBV cGRhdGFibGVUaWxlKiB0aWxlID0gc3RhdGljX2Nhc3Q8VXBkYXRhYmxlVGlsZSo+KGl0ZXItPnNl Y29uZC5nZXQoKSk7CisgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCBub3QgZXZlciBiZSBu dWxsLgorICAgICAgICBpZiAoIXRpbGUpCisgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAg dGlsZS0+dXBkYXRlUmVjdCA9IEludFJlY3QoKTsKICAgICAgICAgdGlsZS0+cGFydGlhbFVwZGF0 ZSA9IGZhbHNlOwogICAgICAgICB0aWxlLT51cGRhdGVkID0gZmFsc2U7Cg==