89141 2012-06-14 17:27:05 -0700 [Chromium] Check the result of FontCache::getCachedFontPlatformData() 2012-06-14 22:56:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi tkent tony webkit.review.bot oldest_to_newest 649664 0 bashi 2012-06-14 17:27:05 -0700 The function essentially returns the result of FontCache::createFontPlatformData(), which can be null. We should check the value before dereference. Detail: http://crbug.com/131004 649670 1 147688 bashi 2012-06-14 17:33:02 -0700 Created attachment 147688 Patch 649674 2 bashi 2012-06-14 17:36:22 -0700 Hi tony, kent-san, Could you take a look? I can't come up with a way to test this change because the problem depends on the settings of fontconfig and the problem won't occur with DRT. 649839 3 147688 tkent 2012-06-14 21:38:13 -0700 Comment on attachment 147688 Patch Looks ok 649840 4 147688 bashi 2012-06-14 21:41:17 -0700 Comment on attachment 147688 Patch Thanks! 649901 5 147688 webkit.review.bot 2012-06-14 22:55:58 -0700 Comment on attachment 147688 Patch Clearing flags on attachment: 147688 Committed r120402: <http://trac.webkit.org/changeset/120402> 649902 6 webkit.review.bot 2012-06-14 22:56:02 -0700 All reviewed patches have been landed. Closing bug. 147688 2012-06-14 17:33:02 -0700 2012-06-14 22:55:58 -0700 Patch bug-89141-20120615093301.patch text/plain 2007 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZjNzA5YWU1NDYwZTE3 ODMwYzQ5Yzc5NmIyYTc0NWNmZDE5NTU4YS4uN2QyYjk3YzcyMTQxMWM1YmYzNzZlYTU5YWNhOWIy MWY2NTU1OTQxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTE0ICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1d IENoZWNrIHRoZSByZXN1bHQgb2YgRm9udENhY2hlOjpnZXRDYWNoZWRGb250UGxhdGZvcm1EYXRh KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MTQx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHZh bHVlIG9mIEZvbnRDYWNoZTo6Z2V0Q2FjaGVkRm9udFBsYXRmb3JtRGF0YSgpIGNvdWxkIGJlIGlu dmFsaWQsCisgICAgICAgIHNvIHdlIHNob3VsZCBjaGVjayB0aGUgdmFsdWUgYmVmb3JlIHVzZSBp dC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIE5vIG5ldyBmdW5jdGlvbmFsaXR5LgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Gb250Q2FjaGVTa2lhLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZvbnRDYWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJzKToKKwogMjAxMi0w Ni0xNCAgU2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIEZvciBoaXQgdGVzdGluZyBpbiBDQ0xheWVyVHJlZUhvc3RDb21tb24sIG5lZWQg dG8gY2hlY2sgdGhhdCB0aGUgdHJhbnNmb3JtIGlzIGludmVydGlibGUgYmVmb3JlIGludmVydGlu ZyBpdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEv Rm9udENhY2hlU2tpYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ZvbnRDYWNoZVNraWEuY3BwCmluZGV4IDQwNWIzMzYyMDA1NmI3ZjY0OTMyMzE4MDg3NTY0OGUy MzY2ZGJmODYuLjJhOGQzOTg4ZjljZTA4ZTdjOWYxZmNlYjBiMjlhMWNhMGFjYTc3NDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udENhY2hlU2tp YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Gb250Q2Fj aGVTa2lhLmNwcApAQCAtODQsNyArODQsMTAgQEAgY29uc3QgU2ltcGxlRm9udERhdGEqIEZvbnRD YWNoZTo6Z2V0Rm9udERhdGFGb3JDaGFyYWN0ZXJzKGNvbnN0IEZvbnQmIGZvbnQsCiAgICAgICAg IGRlc2NyaXB0aW9uLnNldEl0YWxpYyhGb250SXRhbGljT2ZmKTsKICAgICB9CiAKLSAgICBGb250 UGxhdGZvcm1EYXRhIHBsYXRmb3JtRGF0YSA9IEZvbnRQbGF0Zm9ybURhdGEoKmdldENhY2hlZEZv bnRQbGF0Zm9ybURhdGEoZGVzY3JpcHRpb24sIGF0b21pY0ZhbWlseSwgRG9Ob3RSZXRhaW4pKTsK KyAgICBGb250UGxhdGZvcm1EYXRhKiBzdWJzdGl0dXRlUGxhdGZvcm1EYXRhID0gZ2V0Q2FjaGVk Rm9udFBsYXRmb3JtRGF0YShkZXNjcmlwdGlvbiwgYXRvbWljRmFtaWx5LCBEb05vdFJldGFpbik7 CisgICAgaWYgKCFzdWJzdGl0dXRlUGxhdGZvcm1EYXRhKQorICAgICAgICByZXR1cm4gMDsKKyAg ICBGb250UGxhdGZvcm1EYXRhIHBsYXRmb3JtRGF0YSA9IEZvbnRQbGF0Zm9ybURhdGEoKnN1YnN0 aXR1dGVQbGF0Zm9ybURhdGEpOwogICAgIHBsYXRmb3JtRGF0YS5zZXRGYWtlQm9sZChzaG91bGRT ZXRGYWtlQm9sZCk7CiAgICAgcGxhdGZvcm1EYXRhLnNldEZha2VJdGFsaWMoc2hvdWxkU2V0RmFr ZUl0YWxpYyk7CiAgICAgcmV0dXJuIGdldENhY2hlZEZvbnREYXRhKCZwbGF0Zm9ybURhdGEsIERv Tm90UmV0YWluKTsK