89129 2012-06-14 15:00:48 -0700 Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms. 2012-06-14 19:05:02 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 dalecurtis webkit-unassigned eric.carlson feature-media-reviews scherkus webkit.review.bot oldest_to_newest 649522 0 dalecurtis 2012-06-14 15:00:48 -0700 Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms. 649526 1 147660 dalecurtis 2012-06-14 15:05:08 -0700 Created attachment 147660 Patch 649527 2 dalecurtis 2012-06-14 15:07:21 -0700 Chromium bug: http://code.google.com/p/chromium/issues/detail?id=18968 @Eric Carlson, @Andrew Scherkus: Please review. If you know of an alternate solution that isn't a rats nest, please let me know. I didn't see a simple way to to subclass MediaDocument just for Chromium, so I used the #define pattern as used elsewhere in WebCore/html. 649752 3 147660 webkit.review.bot 2012-06-14 19:04:58 -0700 Comment on attachment 147660 Patch Clearing flags on attachment: 147660 Committed r120388: <http://trac.webkit.org/changeset/120388> 649753 4 webkit.review.bot 2012-06-14 19:05:02 -0700 All reviewed patches have been landed. Closing bug. 147660 2012-06-14 15:05:08 -0700 2012-06-14 19:04:57 -0700 Patch bug-89129-20120614150508.patch text/plain 6394 dalecurtis U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTZmMjMxOWI5NTVmNjk2 ZmMxM2Y0ZTY3YWY1ZTY5NTdiZDNkMzI1ZC4uMWU3NzA5OGYxZWUwNDk2NTVkMDRhOTNjZWY1NWZk ZjE1MWY3NTFhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTE0ICBEYWxl IEN1cnRpcyAgPGRhbGVjdXJ0aXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIERpc2FibGUgY2xp Y2svZGJsLWNsaWNrIG9uIE1lZGlhRG9jdW1lbnQgZm9yIENocm9taXVtLiBGaXggbGF5b3V0IHRl c3QgZm9yIGFsbCBwbGF0Zm9ybXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04OTEyOQorCisgICAgICAgIEFzIHRpdGxlZCwgY2xpY2stdG8tcGF1c2Ug YW5kIGRvdWJsZS1jbGljay10by1wbGF5IGJlaGF2aW9yIGFyZSB1bndhbnRlZCBvbiBDaHJvbWl1 bS4gIEEKKyAgICAgICAgbG9uZyBzdGFuZGluZyBpc3N1ZSAofjMgeWVhcnMpIGhhcyBiZWVuIHRv IGRpc2FibGUgdGhpcyBmZWF0dXJlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzZXMgZXhpc3RpbmcgY2xpY2svZG91YmxlLWNsaWNrIHRlc3QuCisK KyAgICAgICAgKiBodG1sL01lZGlhRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFEb2N1bWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6CisKIDIwMTItMDYtMTMgIEFuZHJleSBL b3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB1 c2UgQ1NTIGdyYWRpZW50cyBpbnN0ZWFkIG9mIGltYWdlcyBmb3IgdGltZWxpbmUgYmFycywgY2hl Y2tib3hlcyAmIGJ1bGxldHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFE b2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRG9jdW1lbnQuY3BwCmluZGV4 IDU4ZmY0OTYzMzA1NDdhMmNjMDEwY2JiMzQzZGZmNDc4OTM0ODI5ZjAuLmU1MTk0NTQyYTZjMDU2 ZWFmZTNkMjE5OWNmYzQ5MDdjMTRkMGEwNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvTWVkaWFEb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9NZWRpYURvY3Vt ZW50LmNwcApAQCAtMTY2LDYgKzE2Niw3IEBAIHZvaWQgTWVkaWFEb2N1bWVudDo6ZGVmYXVsdEV2 ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCiAgICAgaWYgKCF0YXJnZXROb2RlKQogICAgICAgICBy ZXR1cm47CiAKKyNpZiAhUExBVEZPUk0oQ0hST01JVU0pCiAgICAgaWYgKEhUTUxWaWRlb0VsZW1l bnQqIHZpZGVvID0gYW5jZXN0b3JWaWRlb0VsZW1lbnQodGFyZ2V0Tm9kZSkpIHsKICAgICAgICAg aWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmNsaWNrRXZlbnQpIHsKICAgICAgICAg ICAgIGlmICghdmlkZW8tPmNhblBsYXkoKSkgewpAQCAtMTc5LDcgKzE4MCw4IEBAIHZvaWQgTWVk aWFEb2N1bWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCiAgICAgICAgICAg ICB9CiAgICAgICAgIH0KICAgICB9Ci0gICAgCisjZW5kaWYKKwogICAgIGlmIChldmVudC0+dHlw ZSgpID09IGV2ZW50TmFtZXMoKS5rZXlkb3duRXZlbnQgJiYgZXZlbnQtPmlzS2V5Ym9hcmRFdmVu dCgpKSB7CiAgICAgICAgIEhUTUxWaWRlb0VsZW1lbnQqIHZpZGVvID0gZGVzY2VuZGVudFZpZGVv RWxlbWVudCh0YXJnZXROb2RlKTsKICAgICAgICAgaWYgKCF2aWRlbykKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5MjE0OTk0 NzQ4ZDRmY2U0YmY4ZWMyNmExYTE2ZjY5NTBhYjhhZmYxLi42MzM1YjJjOTJhZWI0NTNkZmQ2YzJk ZmFjZTk5OTI2NGE3ODE5MzM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTItMDYtMTQgIERh bGUgQ3VydGlzICA8ZGFsZWN1cnRpc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGlzYWJsZSBj bGljay9kYmwtY2xpY2sgb24gTWVkaWFEb2N1bWVudCBmb3IgQ2hyb21pdW0uIEZpeCBsYXlvdXQg dGVzdCBmb3IgYWxsIHBsYXRmb3Jtcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg5MTI5CisKKyAgICAgICAgRml4ZXMgbGF5b3V0IHRlc3QgdG8gYWN0 dWFsbHkgdGVzdCB3aGF0IGl0IHNheXMgaXQgdGVzdHMuICBQcmV2aW91c2x5IGl0IHdhcworICAg ICAgICB0ZXN0aW5nIHRoZSBvcHBvc2l0ZSBiZWhhdmlvciBhbmQgcGFzc2luZyBiZWNhdXNlIE1l ZGlhRG9jdW1lbnQgYXV0by1wbGF5cy4KKworICAgICAgICBBZGRpdGlvbmFsbHkgZmFpbGluZyBv bmUgaGFsZiBvZiB0aGUgdGVzdCB3b3VsZCBzdGlsbCBhbGxvdyB5b3UgdG8gcGFzcyB0aGUKKyAg ICAgICAgb3RoZXIgaGFsZi4gIEJvdGggaXNzdWVzIGhhdmUgYmVlbiBmaXhlZC4KKworICAgICAg ICBVcGRhdGVzIHRoZSB0ZXN0IGV4cGVjdGF0aW9ucyBmb3IgQ2hyb21pdW0gdG8gcmVmbGVjdCBh IGZhaWx1cmUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBtZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLWV4cGVjdGVkLnR4dDoK KyAgICAgICAgKiBtZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLmh0bWw6Cisg ICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vbWVkaWEvdmlkZW8tY2xpY2stZGJsY2tpY2stc3Rh bmRhbG9uZS1leHBlY3RlZC50eHQ6IENvcGllZCBmcm9tIExheW91dFRlc3RzL21lZGlhL3ZpZGVv LWNsaWNrLWRibGNraWNrLXN0YW5kYWxvbmUtZXhwZWN0ZWQudHh0LgorCiAyMDEyLTA2LTE0ICBT aW1vbiBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVcGRhdGUgVGVz dEV4cGVjdGF0aW9ucyB3aXRoIHRlc3RzIGNyYXNoaW5nIGluIDY0Yml0cyBEZWJ1ZyBidWlsZApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY2xpY2stZGJsY2tpY2stc3RhbmRh bG9uZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jbGljay1kYmxja2lj ay1zdGFuZGFsb25lLWV4cGVjdGVkLnR4dAppbmRleCA4OTUzNDQ1NWFlNzRiN2UzOTg3YzVjMmQw NDY0MmExNzdiMTgwYjYyLi41ODQyNmZhNGI0ZWYzZjc1ODJlNWQzYWEyNjc0Y2NjZjM4M2RiMmQ5 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFu ZGFsb25lLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jbGljay1k Ymxja2ljay1zdGFuZGFsb25lLWV4cGVjdGVkLnR4dApAQCAtMSw2ICsxLDYgQEAKIAogVGhpcyB0 ZXN0cyB0aGF0IGNsaWNraW5nIG9uIGEgc3RhbmRhbG9uZSB2aWRlbyB3aWxsIHBhdXNlIGFuZCBk b3VibGUtY2xpY2tpbmcgd2lsbCBwbGF5LgogCitQQVNTOiB2aWRlbyBpcyBwYXVzZWQuCiBQQVNT OiB2aWRlbyBpcyBwbGF5aW5nCi1QQVNTOiB2aWRlbyBpcyBwYXVzZWQKIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY2xpY2stZGJsY2tpY2stc3RhbmRhbG9uZS5odG1sIGIv TGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY2xpY2stZGJsY2tpY2stc3RhbmRhbG9uZS5odG1sCmlu ZGV4IDdhMTNlNDMyMDNmMDk5ZjNmOTEyZWQ1ZTYxNTY3MTdhZWZkZDBlZTguLjFlMjJmZThmOGUy YWVlNTQ3MDAwMmNmMWMzMWZmZjUwZWVjZDc2MjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21l ZGlhL3ZpZGVvLWNsaWNrLWRibGNraWNrLXN0YW5kYWxvbmUuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9tZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLmh0bWwKQEAgLTEyLDcgKzEy LDcgQEAKICAgICAgICAgewogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Nv bnNvbGUnKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShtc2cgKyAiXG4iKSk7 CiAgICAgICAgIH0KLSAgICAgICAgCisKICAgICAgICAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAg IHsKICAgICAgICAgICAgIHZpZGVvID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2ZyJykuY29u dGVudERvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycpWzBdOwpAQCAtMjMsMjAg KzIzLDI3IEBACiAgICAgICAgIH0KICAgICAgICAgZnVuY3Rpb24gdGVzdDIoKQogICAgICAgICB7 Ci0gICAgICAgICAgICB2YXIgZG91YmxlQ2xpY2sgPSBkb2N1bWVudC5jcmVhdGVFdmVudCgiTW91 c2VFdmVudHMiKTsKLSAgICAgICAgICAgIGRvdWJsZUNsaWNrLmluaXRNb3VzZUV2ZW50KCJkYmxj bGljayIsIHRydWUsIHRydWUsIHdpbmRvdywgMiwgMCwgMCwgMCwgMCwgZmFsc2UsIGZhbHNlLCBm YWxzZSwgZmFsc2UsIDAsIGRvY3VtZW50KTsKICAgICAgICAgICAgIHZhciBjbGljayA9IGRvY3Vt ZW50LmNyZWF0ZUV2ZW50KCJNb3VzZUV2ZW50cyIpOwogICAgICAgICAgICAgY2xpY2suaW5pdE1v dXNlRXZlbnQoImNsaWNrIiwgdHJ1ZSwgdHJ1ZSwgd2luZG93LCAxLCAwLCAwLCAwLCAwLCBmYWxz ZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgMCwgZG9jdW1lbnQpOworICAgICAgICAgICAgdmlkZW8u ZGlzcGF0Y2hFdmVudChjbGljayk7CisgICAgICAgICAgICBpZiAodmlkZW8ucGF1c2VkKSB7Cisg ICAgICAgICAgICAgICAgbG9nKCJQQVNTOiB2aWRlbyBpcyBwYXVzZWQuIik7CisgICAgICAgICAg ICAgICAgdGVzdDMoKTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgbG9n KCJGQUlMOiB2aWRlbyBzaG91bGQgYmUgcGF1c2VkIik7CisgICAgICAgICAgICAgICAgdmlkZW8u YWRkRXZlbnRMaXN0ZW5lcigncGF1c2UnLCB0ZXN0Myk7CisgICAgICAgICAgICAgICAgdmlkZW8u cGF1c2UoKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgICAgICBmdW5jdGlvbiB0ZXN0 MygpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhciBkb3VibGVDbGljayA9IGRvY3VtZW50LmNy ZWF0ZUV2ZW50KCJNb3VzZUV2ZW50cyIpOworICAgICAgICAgICAgZG91YmxlQ2xpY2suaW5pdE1v dXNlRXZlbnQoImRibGNsaWNrIiwgdHJ1ZSwgdHJ1ZSwgd2luZG93LCAyLCAwLCAwLCAwLCAwLCBm YWxzZSwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgMCwgZG9jdW1lbnQpOwogICAgICAgICAgICAgdmlk ZW8uZGlzcGF0Y2hFdmVudChkb3VibGVDbGljayk7CiAgICAgICAgICAgICBpZiAoIXZpZGVvLnBh dXNlZCkKICAgICAgICAgICAgICAgICBsb2coIlBBU1M6IHZpZGVvIGlzIHBsYXlpbmciKTsKICAg ICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBsb2coIkZBSUw6IHZpZGVvIHNob3VsZCBi ZSBwbGF5aW5nIik7Ci0gICAgICAgICAgICB2aWRlby5kaXNwYXRjaEV2ZW50KGNsaWNrKTsKLSAg ICAgICAgICAgIGlmICh2aWRlby5wYXVzZWQpCi0gICAgICAgICAgICAgICAgbG9nKCJQQVNTOiB2 aWRlbyBpcyBwYXVzZWQiKTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBsb2co IkZBSUw6IHZpZGVvIHNob3VsZCBiZSBwYXVzZWQiKTsKIAogICAgICAgICAgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS9tZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL21lZGlhL3ZpZGVvLWNsaWNrLWRibGNraWNr LXN0YW5kYWxvbmUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE2OWQwZWIyZmJmMzMxZDAyZDEy ZDFiZDdjMmU1NzJiMzM4YmIxYzkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS9tZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLWV4cGVj dGVkLnR4dApAQCAtMCwwICsxLDYgQEAKKworVGhpcyB0ZXN0cyB0aGF0IGNsaWNraW5nIG9uIGEg c3RhbmRhbG9uZSB2aWRlbyB3aWxsIHBhdXNlIGFuZCBkb3VibGUtY2xpY2tpbmcgd2lsbCBwbGF5 LgorCitGQUlMOiB2aWRlbyBzaG91bGQgYmUgcGF1c2VkCitGQUlMOiB2aWRlbyBzaG91bGQgYmUg cGxheWluZworCg==