89126 2012-06-14 13:55:08 -0700 [chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html 2012-06-15 15:24:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr enne kbr senorblanco oldest_to_newest 649460 0 jamesr 2012-06-14 13:55:08 -0700 [chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html 649485 1 147651 jamesr 2012-06-14 14:19:09 -0700 Created attachment 147651 Patch 650131 2 147651 senorblanco 2012-06-15 06:51:24 -0700 Comment on attachment 147651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147651&action=review Thanks for fixing this. r=me > Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:179 > + // If we're rendering into a deferred device, we need to make a deep copy of the source pixels because Skia does not > + // retain a reference to the actual pixels otherwise. We check if we're drawing into a deferred device by seeing if the Nit: Technically, it's a deferred canvas, not a deferred device (SkPicture::beginRecording() returns an SkPictureRecord, which is a subclass of SkCanvas). 650444 3 jamesr 2012-06-15 13:08:04 -0700 Gotcha, I'll fix the comment before landing. Thanks! 650573 4 jamesr 2012-06-15 15:24:20 -0700 Committed r120501: <http://trac.webkit.org/changeset/120501> 147651 2012-06-14 14:19:09 -0700 2012-06-15 06:51:24 -0700 Patch bug-89126-20120614141908.patch text/plain 4781 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTAxNTlhNDVmM2Y5YmMx M2IwNjk3ODEwZWQ5MjRjMjJmNWQ4OTY2Ny4uOWU3N2Y4YzhkMjJmNDQ5ZmU5NDY2YTExMWI4MzBh NGMwMDgxMTIwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDEyLTA2LTE0ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW2Nocm9taXVtXSBG aXggTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vY29tcG9zaXRpbmcvYWNjZWxlcmF0ZWQt ZHJhd2luZy9zdmctZmlsdGVycy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04OTEyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gZHJhd2luZyBhbiBpbWFnZSBidWZmZXIgaW50byBhIGRlZmVy cmVkIGRldmljZSBjb250ZXh0LCB3ZSBoYXZlIHRvIG1ha2UgYSBkZWVwIGNvcHkgb2YgdGhlIHNv dXJjZSAoU2tpYQorICAgICAgICBjYW4ndCBmb3Igc29tZSByZWFzb24pLiBTdGVwaGVuIFdoaXRl IGZpeGVkIHRoaXMgaW4gcjEwMTMyNSBieSBhZGRpbmcgYSBiaXQgb24gUGxhdGZvcm1Db250ZXh0 U2tpYSBpbmRpY2F0aW5nIGlmCisgICAgICAgIGEgZ2l2ZW4gY29udGV4dCBpcyBkZWZlcnJlZCwg YnV0IEkgYnJva2UgdGhpcyBhZ2FpbiBpbiByMTIwMzQ2IGJ5IHJlZmFjdG9yaW5nIHRoZSBTa0Nh bnZhcyBjcmVhdGlvbiB0byBoYXBwZW4gaW4KKyAgICAgICAgYSBkaWZmZXJlbnQgbG9jYXRpb24g ZnJvbSB0aGUgUGxhdGZvcm1Db250ZXh0U2tpYSBjb25zdHJ1Y3Rpb24uCisKKyAgICAgICAgVGhp cyBtb3ZlcyB0aGUgY2hlY2sgaW50byBJbWFnZUJ1ZmZlclNraWEgYW5kIGRpcmVjdGx5IHF1ZXJp ZXMgdGhlIHN0YXRlIG9mIHRoZSBkZXN0aW5hdGlvbiBTa0RldmljZSB0byBiZSBtb3JlCisgICAg ICAgIHJvYnVzdCBhbmQgd29yayB3aXRob3V0IG5lZWRpbmcgc3BlY2lhbCBQbGF0Zm9ybUNvbnRl eHRTa2lhIHNldHVwLgorCisgICAgICAgIENvdmVyZWQgYnkgTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vY29tcG9zaXRpbmcvYWNjZWxlcmF0ZWQtZHJhd2luZy9zdmctZmlsdGVycy5odG1s CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpkcmF3TmVlZHNDb3B5KToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGxhdGZvcm1Db250ZXh0U2tpYTo6UGxhdGZvcm1Db250ZXh0U2tpYSk6CisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmg6CisgICAgICAgIChQbGF0 Zm9ybUNvbnRleHRTa2lhKToKKworMjAxMi0wNi0xNCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JA Y2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtjaHJvbWl1bV0gTW92ZSBvcGFxdWUgcmVjdGFuZ2xl IHRyYWNraW5nIGxvZ2ljIG91dCBvZiBjb21wb3NpdG9yIGNvcmUKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MDMxCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcApp bmRleCAyMmMzY2ZmYWRhYzgyYzE4MWVlMTYwYTk3MWM4YTQ1OTFkNGI3YzI4Li4yOTI1OTk5ODQw MTkyNDhhNmI5ZWFiMjc0Yzc0ZjE1Y2MyYTM1MzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCkBAIC0x NzMsNyArMTczLDEyIEBAIHZvaWQgSW1hZ2VCdWZmZXI6OmNsaXAoR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0LCBjb25zdCBGbG9hdFJlY3QmIHJlY3QpIGNvbnN0CiAKIHN0YXRpYyBib29sIGRyYXdO ZWVkc0NvcHkoR3JhcGhpY3NDb250ZXh0KiBzcmMsIEdyYXBoaWNzQ29udGV4dCogZHN0KQogewot ICAgIHJldHVybiBkc3QtPnBsYXRmb3JtQ29udGV4dCgpLT5pc0RlZmVycmVkKCkgfHwgc3JjID09 IGRzdDsKKyAgICBpZiAoc3JjID09IGRzdCkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgLy8g SWYgd2UncmUgcmVuZGVyaW5nIGludG8gYSBkZWZlcnJlZCBkZXZpY2UsIHdlIG5lZWQgdG8gbWFr ZSBhIGRlZXAgY29weSBvZiB0aGUgc291cmNlIHBpeGVscyBiZWNhdXNlIFNraWEgZG9lcyBub3QK KyAgICAvLyByZXRhaW4gYSByZWZlcmVuY2UgdG8gdGhlIGFjdHVhbCBwaXhlbHMgb3RoZXJ3aXNl LiBXZSBjaGVjayBpZiB3ZSdyZSBkcmF3aW5nIGludG8gYSBkZWZlcnJlZCBkZXZpY2UgYnkgc2Vl aW5nIGlmIHRoZQorICAgIC8vIGRldmljZSdzIGJpdG1hcCBjb25maWd1cmF0aW9uIGlzIHNldCBv ciBub3QgLSBpZiBpdCdzIG5vdCwgdGhlbiB3ZSBtdXN0IG5vdCBoYXZlIGEgYml0bWFwIHRhcmdl dCB5ZXQuCisgICAgcmV0dXJuIGRzdC0+cGxhdGZvcm1Db250ZXh0KCktPmNhbnZhcygpLT5nZXRE ZXZpY2UoKS0+Y29uZmlnKCkgPT0gU2tCaXRtYXA6OmtOb19Db25maWc7CiB9CiAKIHZvaWQgSW1h Z2VCdWZmZXI6OmRyYXcoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBDb2xvclNwYWNlIHN0eWxl Q29sb3JTcGFjZSwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwgY29uc3QgRmxvYXRSZWN0JiBz cmNSZWN0LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKaW5kZXggZDMyODk1YTM2MzI2MzhlYmQy YTQ1MTZmYTNkMDZmMWRjMWEzYWE0Zi4uZDdiYWI0MzkyOWRhOTkwYmI3ODMzMmU2ZDcxZjk2ODc1 ZjliMmJjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCkBAIC0xODIsNyArMTgyLDYgQEAg UGxhdGZvcm1Db250ZXh0U2tpYTo6UGxhdGZvcm1Db250ZXh0U2tpYShTa0NhbnZhcyogY2FudmFz KQogICAgICwgbV90cmFja09wYXF1ZVJlZ2lvbihmYWxzZSkKICAgICAsIG1fcHJpbnRpbmcoZmFs c2UpCiAgICAgLCBtX2FjY2VsZXJhdGVkKGZhbHNlKQotICAgICwgbV9kZWZlcnJlZChmYWxzZSkK ICAgICAsIG1fZHJhd2luZ1RvSW1hZ2VCdWZmZXIoZmFsc2UpCiB7CiAgICAgbV9zdGF0ZVN0YWNr LmFwcGVuZChTdGF0ZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmgKaW5kZXggYjlmY2I3YjQyMDQ0 YzQwZGI0NWIzNzc4MzNiNWQ0NzExNTBmMTMzZi4uMWM4NWVjOTI4YTZlNzdiYzk3YzNmNzgyZjlk MmVkZDRmOGQ4ZTM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmgKQEAgLTE4NiwxMiArMTg2LDYg QEAgcHVibGljOgogICAgIGJvb2wgaXNBY2NlbGVyYXRlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYWNj ZWxlcmF0ZWQ7IH0KICAgICB2b2lkIHNldEFjY2VsZXJhdGVkKGJvb2wgYWNjZWxlcmF0ZWQpIHsg bV9hY2NlbGVyYXRlZCA9IGFjY2VsZXJhdGVkOyB9CiAKLSAgICAvLyBUcnVlIGlmIHRoaXMgY29u dGV4dCBpcyBkZWZlcnJpbmcgZHJhdyBjYWxscyB0byBiZSBleGVjdXRlZCBsYXRlci4KLSAgICAv LyBXZSBuZWVkIHRvIGtub3cgdGhpcyBmb3IgY29udGV4dC10by1jb250ZXh0IGRyYXdzLCBpbiBv cmRlciB0byBrbm93IGlmCi0gICAgLy8gdGhlIHNvdXJjZSBiaXRtYXAgbmVlZHMgdG8gYmUgY29w aWVkLgotICAgIGJvb2wgaXNEZWZlcnJlZCgpIGNvbnN0IHsgcmV0dXJuIG1fZGVmZXJyZWQ7IH0K LSAgICB2b2lkIHNldERlZmVycmVkKGJvb2wgZGVmZXJyZWQpIHsgbV9kZWZlcnJlZCA9IGRlZmVy cmVkOyB9Ci0KICAgICB2b2lkIHNldFRyYWNrT3BhcXVlUmVnaW9uKGJvb2wgdHJhY2spIHsgbV90 cmFja09wYXF1ZVJlZ2lvbiA9IHRyYWNrOyB9CiAKICAgICAvLyBUaGlzIHdpbGwgYmUgYW4gZW1w dHkgcmVnaW9uIHVubGVzcyB0cmFja2luZyBpcyBlbmFibGVkLgpAQCAtMjQxLDcgKzIzNSw2IEBA IHByaXZhdGU6CiAgICAgRmxvYXRTaXplIG1faW1hZ2VSZXNhbXBsaW5nSGludERzdFNpemU7CiAg ICAgYm9vbCBtX3ByaW50aW5nOwogICAgIGJvb2wgbV9hY2NlbGVyYXRlZDsKLSAgICBib29sIG1f ZGVmZXJyZWQ7CiAgICAgYm9vbCBtX2RyYXdpbmdUb0ltYWdlQnVmZmVyOwogfTsKIAo=