89103 2012-06-14 08:02:31 -0700 Should be easier to write cross-platform accessibility layout tests 2013-12-20 11:57:34 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified NEW InRadar P2 Normal --- 1 dmazzoni webkit-unassigned aboxhall cfleizach jcraig mkwst webkit-bug-importer oldest_to_newest 649178 0 dmazzoni 2012-06-14 08:02:31 -0700 Right now any layout test of the role of an element must be customized for each platform. If the author of the test doesn't have the ability to generate different expectations and verify they're correct, many tests end up being written that only work on one platform. Ideas: * Add an accessor to accessibilityUIElement for a cross-platform role string. * Add a method to search the tree for the first instance of a cross-platform role 649181 1 mkwst 2012-06-14 08:06:16 -0700 See https://bugs.webkit.org/show_bug.cgi?id=88911 as an example of such a test that ends up being mac only, though there's nothing really mac-specific about it. 649186 2 mkwst 2012-06-14 08:08:27 -0700 Moving Dominic's comments from that bug here: > > BTW, I would really like to see a way to write "cross-platform" accessibility tests that test for the WebCore role rather than the platform-specific role, I just haven't had a chance to think about how to do that refactoring yet. > > I've only taken a very quick look at the code, but it seems like it should be possible to set up a mechanism to test the "real" role in DumpRenderTree by adding some methods to AccessibilityUIElement. Maybe with an enum hanging around that's mapped onto ARIARoleMap? > > Seomthing like AccessibilityUIElement::isRole([enum]) and AccessibilityUIElement::isRoleDescription([enum])? > > Is there a bug for this sort of refactoring? It sounds like it'd be useful... Added a new bug: https://bugs.webkit.org/show_bug.cgi?id=89103 isRole wouldn't work very well, we'd have to expose the enum to JavaScript. Instead we should just expose the WebCore role name as a string in JavaScript, and make it a compile error to add a new role without adding the role name. I don't think we need to have role descriptions in cross-platform tests, that's a Mac-only concept. The WebCore role enum should encompass all distinct roles, and each platform should map a role to whatever makes sense on that platform - on Mac one role might map to a {role, roleDescription} tuple. 649345 3 cfleizach 2012-06-14 11:46:24 -0700 (In reply to comment #2) > Moving Dominic's comments from that bug here: > > > > BTW, I would really like to see a way to write "cross-platform" accessibility tests that test for the WebCore role rather than the platform-specific role, I just haven't had a chance to think about how to do that refactoring yet. > > > > I've only taken a very quick look at the code, but it seems like it should be possible to set up a mechanism to test the "real" role in DumpRenderTree by adding some methods to AccessibilityUIElement. Maybe with an enum hanging around that's mapped onto ARIARoleMap? > > > > Seomthing like AccessibilityUIElement::isRole([enum]) and AccessibilityUIElement::isRoleDescription([enum])? > > > > Is there a bug for this sort of refactoring? It sounds like it'd be useful... > > Added a new bug: > https://bugs.webkit.org/show_bug.cgi?id=89103 > > isRole wouldn't work very well, we'd have to expose the enum to JavaScript. Instead we should just expose the WebCore role name as a string in JavaScript, and make it a compile error to add a new role without adding the role name. > > I don't think we need to have role descriptions in cross-platform tests, that's a Mac-only concept. The WebCore role enum should encompass all distinct roles, and each platform should map a role to whatever makes sense on that platform - on Mac one role might map to a {role, roleDescription} tuple. I think we should have DRT specific method that can get the roleValue() from AccessibilityObject and then convert that into a neutral string that we can test against in the layout tests 961975 4 webkit-bug-importer 2013-12-20 11:57:34 -0800 <rdar://problem/15710362>