89091 2012-06-14 04:57:29 -0700 [BlackBerry] empty plugin cause browser hang 2012-06-14 22:24:44 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mawu mawu rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 649073 0 mawu 2012-06-14 04:57:29 -0700 related to empty plugin, click an empty "*.swf" link, it launch flash plugin, and shows blank page since no content. however when go back and click other links on the page, it hangs. It's because FrameLoaderBlackBerry didn't check its content when clear m_pluginView. 649081 1 147560 mawu 2012-06-14 05:17:51 -0700 Created attachment 147560 Patch 649151 2 147560 rwlbuis 2012-06-14 07:20:20 -0700 Comment on attachment 147560 Patch LGTM. Should the actual hang be checked as well? I am not sure why calling m_pluginView->didFinishLoading should cause a hang. 649757 3 mawu 2012-06-14 19:09:36 -0700 (In reply to comment #2) > (From update of attachment 147560 [details]) > LGTM. Should the actual hang be checked as well? I am not sure why calling m_pluginView->didFinishLoading should cause a hang. in PlugView.cpp, m_pluginView->didFinishLoading will call "m_manualStream->didFinishLoading(0);" without checking if m_manualStream is null or not. m_manualStream was created in didReceiveResponse which won't be hit for empty plugin. Add check m_hasSentResponseToPlugin before finishLoading so it won't core dump in such case. 649879 4 147560 webkit.review.bot 2012-06-14 22:24:40 -0700 Comment on attachment 147560 Patch Clearing flags on attachment: 147560 Committed r120399: <http://trac.webkit.org/changeset/120399> 649880 5 webkit.review.bot 2012-06-14 22:24:44 -0700 All reviewed patches have been landed. Closing bug. 147560 2012-06-14 05:17:51 -0700 2012-06-14 22:24:40 -0700 Patch bug-89091-20120614201749.patch text/plain 1782 mawu U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAzZThlOGZkYTQ3MGM2N2QyMmFmZmEyMmJjZDUxMjFkYmQ3NzYyZTAyLi4xOGRkYjhhMWJm YzEzMDFhMTcxNTgxNTMzYjExM2Y0ZjMyMTViOWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNi0xNCAgTWFyeSBXdSAgPG1hcnkud3VAdG9y Y2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBlbXB0eSBwbHVnaW4gY2F1 c2UgYnJvd3NlciBoYW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04OTA5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBjaGVjayBiZWZvcmUgY2xlYW4gcGx1Z2luVmlldyBpbiBGcmFtZUxvYWRlckJs YWNrQmVycnkgaW4gY2FzZQorICAgICAgICBpdCBkaWRuJ3QgaGF2ZSBhbnkgY29udGVudC4KKyAg ICAgICAgUklNIFBSIyAxNjUzMzYKKyAgICAgICAgUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBHZW9y Z2UgU3RhaWtvcworCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRC bGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tC ZXJyeTo6ZmluaXNoZWRMb2FkaW5nKToKKwogMjAxMi0wNi0xMSAgSm9uYXRoYW4gRG9uZyAgPGpv bmF0aGFuLmRvbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBB dXRvZmlsbCBmZWF0dXJlIGltcGxlbWVudGF0aW9uIGZvciBCbGFja0JlcnJ5IHBvcnRpbmcKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggMDhlY2NlMDVj OWZiZTlhYjE3NzFlZjc5NzM3YmEwMDIzZDM2ZjAwMi4uMWIxNDYzMjc3OWNiZmVjY2RlMjg3Mjcx NjhhMDRmM2U0OWYzNjk0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tC ZXJyeS5jcHAKQEAgLTM2OSw3ICszNjksOCBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tC ZXJyeTo6cmVjZWl2ZWREYXRhKGNvbnN0IGNoYXIqIGRhdGEsIGludCBsZW5ndGgsIGNvbgogdm9p ZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmZpbmlzaGVkTG9hZGluZyhEb2N1bWVudExv YWRlciopCiB7CiAgICAgaWYgKG1fcGx1Z2luVmlldykgewotICAgICAgICBtX3BsdWdpblZpZXct PmRpZEZpbmlzaExvYWRpbmcoKTsKKyAgICAgICAgaWYgKG1faGFzU2VudFJlc3BvbnNlVG9QbHVn aW4pCisgICAgICAgICAgICBtX3BsdWdpblZpZXctPmRpZEZpbmlzaExvYWRpbmcoKTsKICAgICAg ICAgbV9wbHVnaW5WaWV3ID0gMDsKICAgICAgICAgbV9oYXNTZW50UmVzcG9uc2VUb1BsdWdpbiA9 IGZhbHNlOwogICAgIH0K