89079 2012-06-14 01:57:50 -0700 new-run-webkit-websocketserver must handle TLS related arguments 2012-06-14 11:07:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 toyoshim toyoshim abarth antonm bashi dpranke ojan webkit.review.bot oldest_to_newest 648961 0 toyoshim 2012-06-14 01:57:50 -0700 Currently, new-run-webkit-websocketserver ignores TLS related arguments, -k and -c. Also we need to support --ca-certificate for client certificate authentication. 648964 1 147522 toyoshim 2012-06-14 02:04:35 -0700 Created attachment 147522 Patch 648983 2 147522 bashi 2012-06-14 02:27:21 -0700 Comment on attachment 147522 Patch LGTM. We don't need to modify NRWT? 649029 3 toyoshim 2012-06-14 03:12:45 -0700 Currently, I have no plan to use this feature from usual layout tests on NRWT. In the case of Chromium port, we use new-run-webkit-websocketserver from some unit tests. This is my major motivation to modify new-run-webkit-websocketserver now. Also this change will help some new client certificate layout tests in the future. 649098 4 bashi 2012-06-14 05:47:13 -0700 (In reply to comment #3) > Currently, I have no plan to use this feature from usual layout tests on NRWT. > In the case of Chromium port, we use new-run-webkit-websocketserver from some unit tests. > This is my major motivation to modify new-run-webkit-websocketserver now. > Also this change will help some new client certificate layout tests in the future. I see. Thank you for explanation :) 649277 5 147522 dpranke 2012-06-14 10:26:42 -0700 Comment on attachment 147522 Patch looks fine. 649308 6 147522 webkit.review.bot 2012-06-14 11:06:58 -0700 Comment on attachment 147522 Patch Clearing flags on attachment: 147522 Committed r120342: <http://trac.webkit.org/changeset/120342> 649309 7 webkit.review.bot 2012-06-14 11:07:03 -0700 All reviewed patches have been landed. Closing bug. 147522 2012-06-14 02:04:35 -0700 2012-06-14 11:06:57 -0700 Patch bug-89079-20120614180434.patch text/plain 4109 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMTU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDc1OGE5ZmM1MjU0NTIwMTFhMTYwNGMxYWMxYTVkY2U3 Yjc2NzBjMy4uYmNiZDMxMWNmMzJmN2VhYTc0MDZkN2E5M2RjOWUwMmM0ODFkYmY0MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA2LTE0ICBUYWthc2hpIFRveW9zaGltYSAgPHRveW9zaGltQGNocm9taXVtLm9y Zz4KKworICAgICAgICBuZXctcnVuLXdlYmtpdC13ZWJzb2NrZXRzZXJ2ZXIgbXVzdCBoYW5kbGUg VExTIHJlbGF0ZWQgYXJndW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04OTA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFB5V2ViU29ja2V0IGNsYXNzIG11c3QgYWNjZXB0IHByaXZhdGVfa2V5LCBj ZXJ0aWZpY2F0ZSwgYW5kCisgICAgICAgIGNhX2NlcnRpZmljYXRlIGFyZ3VtZW50cyBhbmQgcGFz cyB0aGVtIHRvIGxhdW5jaGluZyBweXdlYnNvY2tldC4KKyAgICAgICAgQWxzbyBhZGQgY2FfY2Vy dGlmaWNhdGUgaGFuZGxpbmcgdG8gbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2VydmVyLgorCisg ICAgICAgICogU2NyaXB0cy9uZXctcnVuLXdlYmtpdC13ZWJzb2NrZXRzZXJ2ZXI6CisgICAgICAg IChtYWluKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9zZXJ2ZXJz L3dlYnNvY2tldF9zZXJ2ZXIucHk6CisgICAgICAgIChQeVdlYlNvY2tldC5fX2luaXRfXyk6Cisg ICAgICAgIChQeVdlYlNvY2tldC5fcHJlcGFyZV9jb25maWcpOgorCiAyMDEyLTA2LTEyICBMdWNh cyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBXcmFwIGJvdCB0 eXBlcyBpbnNpZGUgKCkuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0 LXdlYnNvY2tldHNlcnZlciBiL1Rvb2xzL1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0 c2VydmVyCmluZGV4IGI4ODgwMDRmZWJjNzYzNTVmOTY3YTBlZDE3NTg4Y2M1NzM1ZWVkNDMuLjE1 ZWQxZjk5ZWZlZDdiZTk4NDgzNWE5YzQ0NzBkZGIxZjQ1ZWMwYmEgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2VydmVyCisrKyBiL1Rvb2xzL1Njcmlw dHMvbmV3LXJ1bi13ZWJraXQtd2Vic29ja2V0c2VydmVyCkBAIC01NSw2ICs1NSw5IEBAIGRlZiBt YWluKCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlZmF1bHQ9JycsIGhlbHA9J1RM UyBwcml2YXRlIGtleSBmaWxlLicpCiAgICAgb3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctYycs ICctLWNlcnRpZmljYXRlJywgZGVzdD0nY2VydGlmaWNhdGUnLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBkZWZhdWx0PScnLCBoZWxwPSdUTFMgY2VydGlmaWNhdGUgZmlsZS4nKQorICAg IG9wdGlvbl9wYXJzZXIuYWRkX29wdGlvbignLS1jYS1jZXJ0aWZpY2F0ZScsIGRlc3Q9J2NhX2Nl cnRpZmljYXRlJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmYXVsdD0nJywgaGVs cD0nVExTIENBIGNlcnRpZmljYXRlIGZpbGUgZm9yICcKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnY2xpZW50IGF1dGhlbnRpY2F0aW9uLicpCiAgICAgb3B0 aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctLWNocm9taXVtJywgYWN0aW9uPSdzdG9yZV90cnVlJywK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVzdD0nY2hyb21pdW0nLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBkZWZhdWx0PUZhbHNlLApAQCAtODgsNiArOTEsOCBAQCBkZWYg bWFpbigpOgogICAgICAgICBrd2RzWydwcml2YXRlX2tleSddID0gb3B0aW9ucy5wcml2YXRlX2tl eQogICAgIGlmIG9wdGlvbnMuY2VydGlmaWNhdGU6CiAgICAgICAgIGt3ZHNbJ2NlcnRpZmljYXRl J10gPSBvcHRpb25zLmNlcnRpZmljYXRlCisgICAgaWYgb3B0aW9ucy5jYV9jZXJ0aWZpY2F0ZToK KyAgICAgICAga3dkc1snY2FfY2VydGlmaWNhdGUnXSA9IG9wdGlvbnMuY2FfY2VydGlmaWNhdGUK ICAgICBpZiBvcHRpb25zLnBpZGZpbGU6CiAgICAgICAgIGt3ZHNbJ3BpZGZpbGUnXSA9IG9wdGlv bnMucGlkZmlsZQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9zZXJ2ZXJzL3dlYnNvY2tldF9zZXJ2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9zZXJ2ZXJzL3dlYnNvY2tldF9zZXJ2ZXIucHkKaW5kZXggMjk2YWI5ODgy ZmQwYjRiYjE2NzA5ZWYxMDk4NTgzNGMxZGU5OTU1MC4uOTM3NDdmNjkwOWNlZjljODRlNmM3ZTA4 NDViZTE5MGM5MGJiMzcxZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvc2VydmVycy93ZWJzb2NrZXRfc2VydmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvd2Vic29ja2V0X3NlcnZlci5weQpAQCAtNTEs NiArNTEsNyBAQCBfREVGQVVMVF9XU1NfUE9SVCA9IDkzMjMKIGNsYXNzIFB5V2ViU29ja2V0KGh0 dHBfc2VydmVyLkxpZ2h0dHBkKToKICAgICBkZWYgX19pbml0X18oc2VsZiwgcG9ydF9vYmosIG91 dHB1dF9kaXIsIHBvcnQ9X0RFRkFVTFRfV1NfUE9SVCwKICAgICAgICAgICAgICAgICAgcm9vdD1O b25lLCB1c2VfdGxzPUZhbHNlLAorICAgICAgICAgICAgICAgICBwcml2YXRlX2tleT1Ob25lLCBj ZXJ0aWZpY2F0ZT1Ob25lLCBjYV9jZXJ0aWZpY2F0ZT1Ob25lLAogICAgICAgICAgICAgICAgICBw aWRmaWxlPU5vbmUpOgogICAgICAgICAiIiJBcmdzOgogICAgICAgICAgIG91dHB1dF9kaXI6IHRo ZSBhYnNvbHV0ZSBwYXRoIHRvIHRoZSBsYXlvdXQgdGVzdCByZXN1bHQgZGlyZWN0b3J5CkBAIC03 MCw4ICs3MSwxNSBAQCBjbGFzcyBQeVdlYlNvY2tldChodHRwX3NlcnZlci5MaWdodHRwZCk6CiAg ICAgICAgIGlmIHNlbGYuX3VzZV90bHM6CiAgICAgICAgICAgICBzZWxmLl9uYW1lID0gJ3B5d2Vi c29ja2V0X3NlY3VyZScKIAotICAgICAgICBzZWxmLl9wcml2YXRlX2tleSA9IHNlbGYuX3BlbV9m aWxlCi0gICAgICAgIHNlbGYuX2NlcnRpZmljYXRlID0gc2VsZi5fcGVtX2ZpbGUKKyAgICAgICAg aWYgcHJpdmF0ZV9rZXk6CisgICAgICAgICAgICBzZWxmLl9wcml2YXRlX2tleSA9IHByaXZhdGVf a2V5CisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBzZWxmLl9wcml2YXRlX2tleSA9IHNlbGYu X3BlbV9maWxlCisgICAgICAgIGlmIGNlcnRpZmljYXRlOgorICAgICAgICAgICAgc2VsZi5fY2Vy dGlmaWNhdGUgPSBjZXJ0aWZpY2F0ZQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgc2VsZi5f Y2VydGlmaWNhdGUgPSBzZWxmLl9wZW1fZmlsZQorICAgICAgICBzZWxmLl9jYV9jZXJ0aWZpY2F0 ZSA9IGNhX2NlcnRpZmljYXRlCiAgICAgICAgIGlmIHNlbGYuX3BvcnQ6CiAgICAgICAgICAgICBz ZWxmLl9wb3J0ID0gaW50KHNlbGYuX3BvcnQpCiAgICAgICAgIHNlbGYuX3dzaW4gPSBOb25lCkBA IC0xMzcsNiArMTQ1LDkgQEAgY2xhc3MgUHlXZWJTb2NrZXQoaHR0cF9zZXJ2ZXIuTGlnaHR0cGQp OgogICAgICAgICBpZiBzZWxmLl91c2VfdGxzOgogICAgICAgICAgICAgc3RhcnRfY21kLmV4dGVu ZChbJy10JywgJy1rJywgc2VsZi5fcHJpdmF0ZV9rZXksCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnLWMnLCBzZWxmLl9jZXJ0aWZpY2F0ZV0pCisgICAgICAgICAgICBpZiBzZWxmLl9j YV9jZXJ0aWZpY2F0ZToKKyAgICAgICAgICAgICAgICBzdGFydF9jbWQuYXBwZW5kKCctLWNhLWNl cnRpZmljYXRlJykKKyAgICAgICAgICAgICAgICBzdGFydF9jbWQuYXBwZW5kKHNlbGYuX2NhX2Nl cnRpZmljYXRlKQogCiAgICAgICAgIHNlbGYuX3N0YXJ0X2NtZCA9IHN0YXJ0X2NtZAogICAgICAg ICBzZXJ2ZXJfbmFtZSA9IHNlbGYuX2ZpbGVzeXN0ZW0uYmFzZW5hbWUocHl3ZWJzb2NrZXRfc2Ny aXB0KQo=