89066 2012-06-13 23:33:10 -0700 Web Inspector: LayoutTest http/tests/inspector/filesystem/* should clean up FileSystem after test. 2012-06-15 02:33:33 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68203 89190 0 tzik tzik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 648845 0 tzik 2012-06-13 23:33:10 -0700 http/tests/inspector/filesystem/read-directory.html leaves some file on FileSystem after test. This causes unexpected error on other FileSystem tests on same DRT instance. 648846 1 147498 tzik 2012-06-13 23:35:30 -0700 Created attachment 147498 Patch 649123 2 147498 vsevik 2012-06-14 06:40:29 -0700 Comment on attachment 147498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147498&action=review > LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:59 > + testRunner.evaluateInWebInspector(999, "InspectorTest.dispatchCallback(unescape(\"" + escape(args) + "\"))"); Why did 0 change to 999? 649809 3 147498 tzik 2012-06-14 20:29:12 -0700 Comment on attachment 147498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147498&action=review >> LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:59 >> + testRunner.evaluateInWebInspector(999, "InspectorTest.dispatchCallback(unescape(\"" + escape(args) + "\"))"); > > Why did 0 change to 999? This is callId of the evaluation and callId == 0 is used as runTestCallId in inspector-test.js. I'd like to avoid using same ID here. 650041 4 147498 webkit.review.bot 2012-06-15 02:33:28 -0700 Comment on attachment 147498 Patch Clearing flags on attachment: 147498 Committed r120430: <http://trac.webkit.org/changeset/120430> 650042 5 webkit.review.bot 2012-06-15 02:33:33 -0700 All reviewed patches have been landed. Closing bug. 147498 2012-06-13 23:35:30 -0700 2012-06-15 02:33:28 -0700 Patch bug-89066-20120614153529.patch text/plain 5243 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMjY0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzI1ZDY3MTQ1NWQ5MDRkMzEwNjRi ZmE2YTNjNGFlMWFkYjBiNzNkMy4uZjZjNWQwMjU2YmMyNjg0ZTg1M2M5MjUzNzFiZjUxOTdjODM2 ZjVjMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTEzICBUYWlqdSBUc3Vpa2kgIDx0 emlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBMYXlvdXRUZXN0IGh0 dHAvdGVzdHMvaW5zcGVjdG9yL2ZpbGVzeXN0ZW0vKiBzaG91bGQgY2xlYW4gdXAgRmlsZVN5c3Rl bSBhZnRlciB0ZXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODkwNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2ZpbGVzeXN0ZW0vZmlsZXN5c3RlbS10ZXN0Lmpz OgorICAgICAgICAoaW5pdGlhbGl6ZV9GaWxlU3lzdGVtVGVzdC5JbnNwZWN0b3JUZXN0LmNsZWFy RmlsZVN5c3RlbSk6CisgICAgICAgIChkaXNwYXRjaENhbGxiYWNrKToKKyAgICAgICAgKGNyZWF0 ZURpcmVjdG9yeS5nb3RGaWxlU3lzdGVtKToKKyAgICAgICAgKGNyZWF0ZURpcmVjdG9yeSk6Cisg ICAgICAgIChjcmVhdGVGaWxlLmdvdEZpbGVTeXN0ZW0pOgorICAgICAgICAoY2xlYXJGaWxlU3lz dGVtLmdvdFJvb3QpOgorICAgICAgICAoY2xlYXJGaWxlU3lzdGVtLmdvdFJvb3QucmVtb3ZlQWxs KToKKyAgICAgICAgKGNsZWFyRmlsZVN5c3RlbS5vbkVycm9yKToKKyAgICAgICAgKiBodHRwL3Rl c3RzL2luc3BlY3Rvci9maWxlc3lzdGVtL3JlYWQtZGlyZWN0b3J5Lmh0bWw6CisKIDIwMTItMDYt MTMgIE1pbiBRaW4gIDxxaW5taW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBBZGRyZXNzIHNvbWUg ZmVlZGJhY2tzIGluIGxheW91dCB0ZXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2luc3BlY3Rvci9maWxlc3lzdGVtL2ZpbGVzeXN0ZW0tdGVzdC5qcyBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvaW5zcGVjdG9yL2ZpbGVzeXN0ZW0vZmlsZXN5c3RlbS10ZXN0LmpzCmluZGV4 IDZkODY1NTBjMTFmYmMyZDQ5ZTA1OGE5M2FmMDM3NDRhZmE3MDJjM2UuLjMwODYzZDdmNTQxYzU4 OWQ4NDU0ZWFjZmVkMGU3YjgyZWVmYTA2NmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAv dGVzdHMvaW5zcGVjdG9yL2ZpbGVzeXN0ZW0vZmlsZXN5c3RlbS10ZXN0LmpzCisrKyBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2ZpbGVzeXN0ZW0vZmlsZXN5c3RlbS10ZXN0Lmpz CkBAIC0yOSw2ICsyOSwxMSBAQCB2YXIgaW5pdGlhbGl6ZV9GaWxlU3lzdGVtVGVzdCA9IGZ1bmN0 aW9uKCkKICAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgiY3JlYXRlRmlsZSh1 bmVzY2FwZShcIiIgKyBlc2NhcGUocGF0aCkgKyAiXCIpLCAiICsgSW5zcGVjdG9yVGVzdC5yZWdp c3RlckNhbGxiYWNrKGNhbGxiYWNrKSArICIpIik7CiAgICAgfTsKIAorICAgIEluc3BlY3RvclRl c3QuY2xlYXJGaWxlU3lzdGVtID0gZnVuY3Rpb24oY2FsbGJhY2spCisgICAgeworICAgICAgICBJ bnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJjbGVhckZpbGVTeXN0ZW0oIiArIEluc3BlY3Rv clRlc3QucmVnaXN0ZXJDYWxsYmFjayhjYWxsYmFjaykgKyAiKSIpOworICAgIH07CisKICAgICBJ bnNwZWN0b3JUZXN0LmR1bXBSZWFkRGlyZWN0b3J5UmVzdWx0ID0gZnVuY3Rpb24ocmVxdWVzdElk LCBlcnJvckNvZGUsIGVudHJpZXMpCiAgICAgewogICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJl c3VsdCgicmVxdWVzdElkOiAiICsgcmVxdWVzdElkKTsKQEAgLTUxLDIzICs1Niw3MSBAQCB2YXIg aW5pdGlhbGl6ZV9GaWxlU3lzdGVtVGVzdCA9IGZ1bmN0aW9uKCkKIGZ1bmN0aW9uIGRpc3BhdGNo Q2FsbGJhY2soKQogewogICAgIHZhciBhcmdzID0gSlNPTi5zdHJpbmdpZnkoQXJyYXkucHJvdG90 eXBlLnNsaWNlLmNhbGwoYXJndW1lbnRzKSk7Ci0gICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZXZh bHVhdGVJbldlYkluc3BlY3RvcigwLCAiSW5zcGVjdG9yVGVzdC5kaXNwYXRjaENhbGxiYWNrKHVu ZXNjYXBlKFwiIiArIGVzY2FwZShhcmdzKSArICJcIikpIik7CisgICAgdGVzdFJ1bm5lci5ldmFs dWF0ZUluV2ViSW5zcGVjdG9yKDk5OSwgIkluc3BlY3RvclRlc3QuZGlzcGF0Y2hDYWxsYmFjayh1 bmVzY2FwZShcIiIgKyBlc2NhcGUoYXJncykgKyAiXCIpKSIpOwogfQogCiBmdW5jdGlvbiBjcmVh dGVEaXJlY3RvcnkocGF0aCwgY2FsbGJhY2spCiB7Ci0gICAgd2Via2l0UmVxdWVzdEZpbGVTeXN0 ZW0oVEVNUE9SQVJZLCAxLCBmdW5jdGlvbihmcykgewotICAgICAgICBmcy5yb290LmdldERpcmVj dG9yeShwYXRoLCB7Y3JlYXRlOnRydWV9LCBmdW5jdGlvbihlbnRyeSkgeworICAgIHdlYmtpdFJl cXVlc3RGaWxlU3lzdGVtKFRFTVBPUkFSWSwgMSwgZ290RmlsZVN5c3RlbSk7CisKKyAgICBmdW5j dGlvbiBnb3RGaWxlU3lzdGVtKGZpbGVTeXN0ZW0pCisgICAgeworICAgICAgICBmaWxlU3lzdGVt LnJvb3QuZ2V0RGlyZWN0b3J5KHBhdGgsIHtjcmVhdGU6dHJ1ZX0sIGZ1bmN0aW9uKGVudHJ5KSB7 CiAgICAgICAgICAgICBjYWxsYmFjaygpOwogICAgICAgICB9KTsKLSAgICB9KTsKKyAgICB9CiB9 CiAKIGZ1bmN0aW9uIGNyZWF0ZUZpbGUocGF0aCwgY2FsbGJhY2spCiB7Ci0gICAgd2Via2l0UmVx dWVzdEZpbGVTeXN0ZW0oVEVNUE9SQVJZLCAxLCBmdW5jdGlvbihmcykgewotICAgICAgICBmcy5y b290LmdldEZpbGUocGF0aCwge2NyZWF0ZTp0cnVlfSwgZnVuY3Rpb24oZW50cnkpIHsKKyAgICB3 ZWJraXRSZXF1ZXN0RmlsZVN5c3RlbShURU1QT1JBUlksIDEsIGdvdEZpbGVTeXN0ZW0pOworCisg ICAgZnVuY3Rpb24gZ290RmlsZVN5c3RlbShmaWxlU3lzdGVtKQorICAgIHsKKyAgICAgICAgZmls ZVN5c3RlbS5yb290LmdldEZpbGUocGF0aCwge2NyZWF0ZTp0cnVlfSwgZnVuY3Rpb24oZW50cnkp IHsKICAgICAgICAgICAgIGNhbGxiYWNrKCk7CiAgICAgICAgIH0pOwotICAgIH0pOworICAgIH0K K30KKworZnVuY3Rpb24gY2xlYXJGaWxlU3lzdGVtKGNhbGxiYWNrKQoreworICAgIHdlYmtpdFJl c29sdmVMb2NhbEZpbGVTeXN0ZW1VUkwoImZpbGVzeXN0ZW06IiArIGxvY2F0aW9uLm9yaWdpbiAr ICIvdGVtcG9yYXJ5LyIsIGdvdFJvb3QsIG9uRXJyb3IpOworCisgICAgZnVuY3Rpb24gZ290Um9v dChyb290KQorICAgIHsKKyAgICAgICAgdmFyIHJlYWRlciA9IHJvb3QuY3JlYXRlUmVhZGVyKCk7 CisgICAgICAgIHJlYWRlci5yZWFkRW50cmllcyhkaWRSZWFkRW50cmllcyk7CisKKyAgICAgICAg dmFyIGVudHJpZXMgPSBbXTsKKyAgICAgICAgZnVuY3Rpb24gZGlkUmVhZEVudHJpZXMobmV3RW50 cmllcykKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKG5ld0VudHJpZXMubGVuZ3RoID09PSAw KSB7CisgICAgICAgICAgICAgICAgcmVtb3ZlQWxsKCk7CisgICAgICAgICAgICAgICAgcmV0dXJu OworICAgICAgICAgICAgfQorICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBuZXdFbnRy aWVzLmxlbmd0aDsgKytpKQorICAgICAgICAgICAgICAgIGVudHJpZXMucHVzaChuZXdFbnRyaWVz W2ldKTsKKyAgICAgICAgICAgIHJlYWRlci5yZWFkRW50cmllcyhkaWRSZWFkRW50cmllcyk7Cisg ICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiByZW1vdmVBbGwoKQorICAgICAgICB7CisgICAg ICAgICAgICBpZiAoZW50cmllcy5sZW5ndGggPT09IDApIHsKKyAgICAgICAgICAgICAgICBjYWxs YmFjaygpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIHZhciBlbnRyeSA9IGVudHJpZXMuc2hpZnQoKTsKKyAgICAgICAgICAgIGlmIChlbnRyeS5p c0RpcmVjdG9yeSkKKyAgICAgICAgICAgICAgICBlbnRyeS5yZW1vdmVSZWN1cnNpdmVseShyZW1v dmVBbGwpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGVudHJ5LnJlbW92ZShy ZW1vdmVBbGwpOworICAgICAgICB9CisgICAgfQorCisgICAgZnVuY3Rpb24gb25FcnJvcigpCisg ICAgeworICAgICAgICAvLyBBc3N1bWUgdGhlIEZpbGVTeXN0ZW0gaXMgdW5pbml0aWFsaXplZCBh bmQgdGhlcmVmb3JlIGVtcHR5LgorICAgICAgICBjYWxsYmFjaygpOworICAgIH0KIH0KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2ZpbGVzeXN0ZW0vcmVhZC1k aXJlY3RvcnkuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2ZpbGVzeXN0 ZW0vcmVhZC1kaXJlY3RvcnkuaHRtbAppbmRleCA1OTEyNDUyMTc1MTBjMjQ4NzQxYjQ1NGI1ZjE3 YzhiZGE3YmYzMjJlLi4zMjE5YTBlNGU5NDE3ODU5YWMyNzQwZjRkNDc3N2M4ODU4MjgwMjJlIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9maWxlc3lzdGVtL3Jl YWQtZGlyZWN0b3J5Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3Iv ZmlsZXN5c3RlbS9yZWFkLWRpcmVjdG9yeS5odG1sCkBAIC0xNiw3ICsxNiw3IEBAIGZ1bmN0aW9u IHRlc3QoKQogICAgIEluc3BlY3RvckJhY2tlbmQucmVnaXN0ZXJGaWxlU3lzdGVtRGlzcGF0Y2hl cihuZXcgRmlsZVN5c3RlbURpc3BhdGNoZXIoKSk7CiAgICAgRmlsZVN5c3RlbUFnZW50LmVuYWJs ZSgpOwogCi0gICAgc3RlcDEoKTsKKyAgICBJbnNwZWN0b3JUZXN0LmNsZWFyRmlsZVN5c3RlbShz dGVwMSk7CiAKICAgICBmdW5jdGlvbiBzdGVwMSgpCiAgICAgewpAQCAtNTIsNiArNTIsMTEgQEAg ZnVuY3Rpb24gdGVzdCgpCiAgICAgZnVuY3Rpb24gc3RlcDYocmVxdWVzdElkLCBlcnJvckNvZGUs IGVudHJpZXMpIHsKICAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wUmVhZERpcmVjdG9yeVJlc3Vs dChyZXF1ZXN0SWQsIGVycm9yQ29kZSwgZW50cmllcyk7CiAKKyAgICAgICAgSW5zcGVjdG9yVGVz dC5jbGVhckZpbGVTeXN0ZW0oc3RlcDcpOworICAgIH0KKworICAgIGZ1bmN0aW9uIHN0ZXA3KCkK KyAgICB7CiAgICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCk7CiAgICAgfQogfQo=