89065 2012-06-13 23:23:48 -0700 [Chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug 2012-06-14 17:37:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dominicc shawnsingh jamesr oldest_to_newest 648836 0 dominicc 2012-06-13 23:23:48 -0700 CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer is failing on Mac10.6 (Dbg) and Linux (Dbg) on the canary bots: <http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/7986> 648842 1 dominicc 2012-06-13 23:30:43 -0700 I disabled this test in r120283. 649321 2 147621 shawnsingh 2012-06-14 11:16:09 -0700 Created attachment 147621 Patch 649322 3 shawnsingh 2012-06-14 11:17:09 -0700 dominicc@ thanks for reporting this =) 649675 4 shawnsingh 2012-06-14 17:36:23 -0700 Committed r120380: <http://trac.webkit.org/changeset/120380> 649677 5 shawnsingh 2012-06-14 17:37:24 -0700 FYI a follow-up cleanup bug - https://bugs.webkit.org/show_bug.cgi?id=89139 grouping into test fixtures will avoid needing to duplicate that DebugScopedSetImplThread line of code in so many places. 147621 2012-06-14 11:16:09 -0700 2012-06-14 17:02:29 -0700 Patch bug-89065-20120614111608.patch text/plain 5408 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZjYmY2ODM1NGM0MDYwMjhmY2VkZTVhYjI4NTcyMDU4NGM5ZGZlYjcuLjMzZDQ0NTE4ZGRkYWI2 Y2IzMmQ3YTZhOGI1MmJiMTY3MWVmMDFlZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDYtMTQgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBDQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0 LnZlcmlmeUhpdFRlc3RpbmdGb3JTaW5nbGVMYXllciBmYWlsaW5nIGluIGRlYnVnCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTA2NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgZGVidWcgYXNzZXJ0aW9u IHdhcyBiZWluZyB0cmlnZ2VyZWQgaW4gdGhlIGhpdC10ZXN0aW5nIHVuaXQKKyAgICAgICAgdGVz dHMgYmVjYXVzZSBJIGFjY2lkZW50YWxseSBmb3Jnb3QgdG8gc2V0IHRoZQorICAgICAgICBEZWJ1 Z1Njb3BlZFNldEltcGxUaHJlYWQgZm9yIHRoZSB0ZXN0cy4KKworICAgICAgICBUaGlzIHBhdGNo IGFsc28gcmUtZW5hYmxlcyB0aGUgZGlzYWJsZWQgYnJva2VuIHRlc3QuCisKKyAgICAgICAgKiB0 ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LmNwcDoKKwogMjAxMi0wNi0xNCAgQWxleGFu ZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0g VW5yZXZpZXdlZCwgYnVpbGQgZml4IGZvciBNYWMgMTAuNQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdC5jcHAKaW5k ZXggMGFhZDcwZjkxNmY5NzgyMzhhMjVmMmIzNjBiNWU5YzM3MjVkZDE2NC4uNDJmYzA4NjlhZjgx ZGZjNmVlZGEwMDAzNWZhZDNmYmRkMmE0YzU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QuY3BwCkBAIC0y OTEzLDYgKzI5MTMsNyBAQCBURVNUKENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QsIHZlcmlmeUJh Y2tGYWNlQ3VsbGluZ1dpdGhQcmVzZXJ2ZXMzZEZvckZsYXR0ZW5pbgogVEVTVChDQ0xheWVyVHJl ZUhvc3RDb21tb25UZXN0LCB2ZXJpZnlIaXRUZXN0aW5nRm9yRW1wdHlMYXllckxpc3QpCiB7CiAg ICAgLy8gSGl0IHRlc3Rpbmcgb24gYW4gZW1wdHkgcmVuZGVyU3VyZmFjZUxheWVyTGlzdCBzaG91 bGQgcmV0dXJuIGEgbnVsbCBwb2ludGVyLgorICAgIERlYnVnU2NvcGVkU2V0SW1wbFRocmVhZCB0 aGlzU2NvcGVJc09uSW1wbFRocmVhZDsKIAogICAgIFZlY3RvcjxDQ0xheWVySW1wbCo+IHJlbmRl clN1cmZhY2VMYXllckxpc3Q7CiAKQEAgLTI5MjUsOCArMjkyNiwxMCBAQCBURVNUKENDTGF5ZXJU cmVlSG9zdENvbW1vblRlc3QsIHZlcmlmeUhpdFRlc3RpbmdGb3JFbXB0eUxheWVyTGlzdCkKICAg ICBFWFBFQ1RfRkFMU0UocmVzdWx0TGF5ZXIpOwogfQogCi1URVNUKENDTGF5ZXJUcmVlSG9zdENv bW1vblRlc3QsIERJU0FCTEVEX3ZlcmlmeUhpdFRlc3RpbmdGb3JTaW5nbGVMYXllcikKK1RFU1Qo Q0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5SGl0VGVzdGluZ0ZvclNpbmdsZUxheWVy KQogeworICAgIERlYnVnU2NvcGVkU2V0SW1wbFRocmVhZCB0aGlzU2NvcGVJc09uSW1wbFRocmVh ZDsKKwogICAgIE93blB0cjxDQ0xheWVySW1wbD4gcm9vdCA9IENDTGF5ZXJJbXBsOjpjcmVhdGUo MTIzNDUpOwogICAgIHJvb3QtPmNyZWF0ZVJlbmRlclN1cmZhY2UoKTsKICAgICByb290LT5yZW5k ZXJTdXJmYWNlKCktPnNldENvbnRlbnRSZWN0KEludFJlY3QoSW50UG9pbnQ6Onplcm8oKSwgSW50 U2l6ZSgxMDAsIDEwMCkpKTsKQEAgLTI5NzIsNiArMjk3NSw4IEBAIFRFU1QoQ0NMYXllclRyZWVI b3N0Q29tbW9uVGVzdCwgRElTQUJMRURfdmVyaWZ5SGl0VGVzdGluZ0ZvclNpbmdsZUxheWVyKQog CiBURVNUKENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QsIHZlcmlmeUhpdFRlc3RpbmdGb3JTaW5n bGVQb3NpdGlvbmVkTGF5ZXIpCiB7CisgICAgRGVidWdTY29wZWRTZXRJbXBsVGhyZWFkIHRoaXNT Y29wZUlzT25JbXBsVGhyZWFkOworCiAgICAgT3duUHRyPENDTGF5ZXJJbXBsPiByb290ID0gQ0NM YXllckltcGw6OmNyZWF0ZSgxMjM0NSk7CiAgICAgcm9vdC0+Y3JlYXRlUmVuZGVyU3VyZmFjZSgp OwogICAgIHJvb3QtPnJlbmRlclN1cmZhY2UoKS0+c2V0Q29udGVudFJlY3QoSW50UmVjdChJbnRQ b2ludDo6emVybygpLCBJbnRTaXplKDEwMCwgMTAwKSkpOwpAQCAtMzAxOCw2ICszMDIzLDggQEAg VEVTVChDQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LCB2ZXJpZnlIaXRUZXN0aW5nRm9yU2luZ2xl UG9zaXRpb25lZExheWVyKQogCiBURVNUKENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QsIHZlcmlm eUhpdFRlc3RpbmdGb3JTaW5nbGVSb3RhdGVkTGF5ZXIpCiB7CisgICAgRGVidWdTY29wZWRTZXRJ bXBsVGhyZWFkIHRoaXNTY29wZUlzT25JbXBsVGhyZWFkOworCiAgICAgT3duUHRyPENDTGF5ZXJJ bXBsPiByb290ID0gQ0NMYXllckltcGw6OmNyZWF0ZSgxMjM0NSk7CiAgICAgcm9vdC0+Y3JlYXRl UmVuZGVyU3VyZmFjZSgpOwogICAgIHJvb3QtPnJlbmRlclN1cmZhY2UoKS0+c2V0Q29udGVudFJl Y3QoSW50UmVjdChJbnRQb2ludDo6emVybygpLCBJbnRTaXplKDEwMCwgMTAwKSkpOwpAQCAtMzA3 Miw2ICszMDc5LDggQEAgVEVTVChDQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LCB2ZXJpZnlIaXRU ZXN0aW5nRm9yU2luZ2xlUm90YXRlZExheWVyKQogCiBURVNUKENDTGF5ZXJUcmVlSG9zdENvbW1v blRlc3QsIHZlcmlmeUhpdFRlc3RpbmdGb3JTaW5nbGVQZXJzcGVjdGl2ZUxheWVyKQogeworICAg IERlYnVnU2NvcGVkU2V0SW1wbFRocmVhZCB0aGlzU2NvcGVJc09uSW1wbFRocmVhZDsKKwogICAg IE93blB0cjxDQ0xheWVySW1wbD4gcm9vdCA9IENDTGF5ZXJJbXBsOjpjcmVhdGUoMTIzNDUpOwog ICAgIHJvb3QtPmNyZWF0ZVJlbmRlclN1cmZhY2UoKTsKICAgICByb290LT5yZW5kZXJTdXJmYWNl KCktPnNldENvbnRlbnRSZWN0KEludFJlY3QoSW50UG9pbnQ6Onplcm8oKSwgSW50U2l6ZSgxMDAs IDEwMCkpKTsKQEAgLTMxMzgsNiArMzE0Nyw3IEBAIFRFU1QoQ0NMYXllclRyZWVIb3N0Q29tbW9u VGVzdCwgdmVyaWZ5SGl0VGVzdGluZ0ZvclNpbmdsZUxheWVyV2l0aFNjYWxlZENvbnRlbnRzCiAg ICAgLy8gY29udGVudHNTY2FsZSBpcyBpZ25vcmVkLCB0aGVuIGhpdCB0ZXN0aW5nIHdpbGwgbWlz LWludGVycHJldCB0aGUgdmlzaWJsZUxheWVyUmVjdAogICAgIC8vIGFzIGJlaW5nIGxhcmdlciB0 aGFuIHRoZSBhY3R1YWwgYm91bmRzIG9mIHRoZSBsYXllci4KICAgICAvLworICAgIERlYnVnU2Nv cGVkU2V0SW1wbFRocmVhZCB0aGlzU2NvcGVJc09uSW1wbFRocmVhZDsKIAogICAgIE93blB0cjxD Q0xheWVySW1wbD4gcm9vdCA9IENDTGF5ZXJJbXBsOjpjcmVhdGUoMTIzNDUpOwogICAgIHJvb3Qt PmNyZWF0ZVJlbmRlclN1cmZhY2UoKTsKQEAgLTMxOTIsNiArMzIwMiw3IEBAIFRFU1QoQ0NMYXll clRyZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5SGl0VGVzdGluZ0ZvclNpbXBsZUNsaXBwZWRMYXll cikKIHsKICAgICAvLyBUZXN0IHRoYXQgaGl0LXRlc3Rpbmcgd2lsbCBvbmx5IHdvcmsgZm9yIHRo ZSB2aXNpYmxlIHBvcnRpb24gb2YgYSBsYXllciwgYW5kIG5vdAogICAgIC8vIHRoZSBlbnRpcmUg bGF5ZXIgYm91bmRzLiBIZXJlIHdlIGp1c3QgdGVzdCB0aGUgc2ltcGxlIGF4aXMtYWxpZ25lZCBj YXNlLgorICAgIERlYnVnU2NvcGVkU2V0SW1wbFRocmVhZCB0aGlzU2NvcGVJc09uSW1wbFRocmVh ZDsKIAogICAgIE93blB0cjxDQ0xheWVySW1wbD4gcm9vdCA9IENDTGF5ZXJJbXBsOjpjcmVhdGUo MTIzKTsKICAgICByb290LT5jcmVhdGVSZW5kZXJTdXJmYWNlKCk7CkBAIC0zMjU5LDYgKzMyNzAs NyBAQCBURVNUKENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QsIHZlcmlmeUhpdFRlc3RpbmdGb3JN dWx0aUNsaXBwZWRSb3RhdGVkTGF5ZXIpCiAgICAgLy8gY29tYmluZWQgY3JlYXRlIGEgdHJpYW5n bGUuIFRoZSByb3RhdGVkTGVhZiB3aWxsIG9ubHkgYmUgdmlzaWJsZSB3aGVyZSBpdCBvdmVybGFw cwogICAgIC8vIHRoaXMgdHJpYW5nbGUuCiAgICAgLy8KKyAgICBEZWJ1Z1Njb3BlZFNldEltcGxU aHJlYWQgdGhpc1Njb3BlSXNPbkltcGxUaHJlYWQ7CiAKICAgICBPd25QdHI8Q0NMYXllckltcGw+ IHJvb3QgPSBDQ0xheWVySW1wbDo6Y3JlYXRlKDEyMyk7CiAgICAgcm9vdC0+Y3JlYXRlUmVuZGVy U3VyZmFjZSgpOwpAQCAtMzM2MSw2ICszMzczLDggQEAgVEVTVChDQ0xheWVyVHJlZUhvc3RDb21t b25UZXN0LCB2ZXJpZnlIaXRUZXN0aW5nRm9yTXVsdGlDbGlwcGVkUm90YXRlZExheWVyKQogCiBU RVNUKENDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QsIHZlcmlmeUhpdFRlc3RpbmdGb3JNdWx0aXBs ZUxheWVycykKIHsKKyAgICBEZWJ1Z1Njb3BlZFNldEltcGxUaHJlYWQgdGhpc1Njb3BlSXNPbklt cGxUaHJlYWQ7CisKICAgICBPd25QdHI8Q0NMYXllckltcGw+IHJvb3QgPSBDQ0xheWVySW1wbDo6 Y3JlYXRlKDEpOwogICAgIHJvb3QtPmNyZWF0ZVJlbmRlclN1cmZhY2UoKTsKICAgICByb290LT5y ZW5kZXJTdXJmYWNlKCktPnNldENvbnRlbnRSZWN0KEludFJlY3QoSW50UG9pbnQ6Onplcm8oKSwg SW50U2l6ZSgxMDAsIDEwMCkpKTsKQEAgLTM0NjksNiArMzQ4Myw3IEBAIFRFU1QoQ0NMYXllclRy ZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5SGl0VGVzdGluZ0Zvck11bHRpcGxlTGF5ZXJMaXN0cykK ICAgICAvLyBUaGUgZ2VvbWV0cnkgaXMgc2V0IHVwIHNpbWlsYXJseSB0byB0aGUgcHJldmlvdXMg Y2FzZSwgYnV0CiAgICAgLy8gYWxsIGxheWVycyBhcmUgZm9yY2VkIHRvIGJlIHJlbmRlclN1cmZh Y2VzIG5vdy4KICAgICAvLworICAgIERlYnVnU2NvcGVkU2V0SW1wbFRocmVhZCB0aGlzU2NvcGVJ c09uSW1wbFRocmVhZDsKIAogICAgIE93blB0cjxDQ0xheWVySW1wbD4gcm9vdCA9IENDTGF5ZXJJ bXBsOjpjcmVhdGUoMSk7CiAgICAgcm9vdC0+Y3JlYXRlUmVuZGVyU3VyZmFjZSgpOwo=