89062 2012-06-13 23:03:35 -0700 [Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi 2012-06-14 03:57:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin tkent webkit.review.bot oldest_to_newest 648825 0 yosin 2012-06-13 23:03:35 -0700 There are ENABLE_INPUT_TYPE_MONTH=0, TIME=0, and so on, in WebKit/chromium/features.gyp. It prevents us to use overriding them in ~/.gyp/include.gypi. 648830 1 147495 yosin 2012-06-13 23:19:29 -0700 Created attachment 147495 Patch 1 648833 2 147495 yosin 2012-06-13 23:21:03 -0700 Comment on attachment 147495 Patch 1 Could you review this patch? Thanks in advance. * Local build on CR-Linux with ~/.gyp/include.gypi which contains ENABLE_INPUT_TYPE_TIME=1, and so on. * Confirm local build Chrome support these input types. 648941 3 147495 tkent 2012-06-14 01:43:16 -0700 Comment on attachment 147495 Patch 1 ok 649058 4 147495 webkit.review.bot 2012-06-14 03:57:55 -0700 Comment on attachment 147495 Patch 1 Clearing flags on attachment: 147495 Committed r120312: <http://trac.webkit.org/changeset/120312> 649059 5 webkit.review.bot 2012-06-14 03:57:59 -0700 All reviewed patches have been landed. Closing bug. 147495 2012-06-13 23:19:29 -0700 2012-06-14 03:57:55 -0700 Patch 1 bug-89062-20120614151928.patch text/plain 1745 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQzYzBkOGI5ZGQxMjAzYzUwZDRlNzM4ZDUwYjliMDJmYzFjZjBmNzMuLjM5OGMwZDZiOWViNjJk MDQ1YWJkN2VmZThkYTY4NWY4NzViYmViODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMTMgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dW0Zvcm1zXSBXZSBzaG91bGQgcmVtb3ZlIEVO QUJMRV9JTlBVVF9UWVBFX1RJTUU9MCBhbmQgc28gb24gdG8gYWxsb3dzIHVzIHRvIG92ZXJyaWRl IHRoZW0gYnkgfi8uZ3lwL2luY2x1ZGUuZ3lwaQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkwNjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgRU5BQkxFX0lOUFVUX1RZUEVf Kj0wIGZyb20gZGVmYXVsdCBlbnRyeSBvZiBmZWF0dXJlX2RlZmluZXMgdG8KKyAgICAgICAgYWxs b3dzIHVzIG92ZXJyaWRpbmcgYnkgfi8uZ3lwL2luY2x1ZGUuZ3lwaQorCisgICAgICAgICogZmVh dHVyZXMuZ3lwaTogUmVtb3ZlIEVOQUJMRV9JTlBVVF9UWVBFX0RBVEVUSU1FPTAsIEVOQUJMRV9J TlBVVF9UWVBFX0RBVEVUSU1FTE9DQUw9MCwKKyAgICAgICAgYW5kIHNvIG9uLgorCiAyMDEyLTA2 LTEzICBTaGF3biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtj aHJvbWl1bV0gSW1wbGVtZW50IGhpdC10ZXN0aW5nIGZvciBpbXBsLXNpZGUgaW5wdXQgaGFuZGxp bmcgaW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9mZWF0dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpCmluZGV4IDk5NDVmMDRiY2E0NjU3NzdkZmI4NmQ3MjdkZWVmMGNiMmU3YTcyYWEuLjcyNzcy NjcwNzUyODU3Yzc0MDhjNzYxNDgyNzQ2ODkzNzE5Yzc2YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L2ZlYXR1cmVzLmd5cGkKQEAgLTE2MywxMSArMTYzLDYgQEAKICAgICAgICAgICAnRU5BQkxFX0ZP TlRfQk9PU1RJTkc9MCcsCiAgICAgICAgICAgJ0VOQUJMRV9GVUxMU0NSRUVOX01FRElBX0NPTlRS T0xTPTAnLAogICAgICAgICAgICdFTkFCTEVfSU5QVVRfU1BFRUNIPTEnLAotICAgICAgICAgICdF TkFCTEVfSU5QVVRfVFlQRV9EQVRFVElNRT0wJywKLSAgICAgICAgICAnRU5BQkxFX0lOUFVUX1RZ UEVfREFURVRJTUVMT0NBTD0wJywKLSAgICAgICAgICAnRU5BQkxFX0lOUFVUX1RZUEVfTU9OVEg9 MCcsCi0gICAgICAgICAgJ0VOQUJMRV9JTlBVVF9UWVBFX1RJTUU9MCcsCi0gICAgICAgICAgJ0VO QUJMRV9JTlBVVF9UWVBFX1dFRUs9MCcsCiAgICAgICAgICAgJ0VOQUJMRV9KQVZBU0NSSVBUX0kx OE5fQVBJPTEnLAogICAgICAgICAgICdFTkFCTEVfTEVHQUNZX05PVElGSUNBVElPTlM9MScsCiAg ICAgICAgICAgJ0VOQUJMRV9NRURJQV9DQVBUVVJFPTAnLAo=