89057 2012-06-13 20:41:51 -0700 REGRESSION (r120252): run-webkit-tests on Mac fails 2012-06-13 21:00:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton abarth dpranke enrica mitz ojan simon.fraser webkit.review.bot oldest_to_newest 648740 0 thorton 2012-06-13 20:41:51 -0700 Traceback (most recent call last): File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 454, in <module> sys.exit(main()) File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 449, in main return run(port, options, args) File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 118, in run manager.parse_expectations() File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 367, in parse_expectations self._expectations = test_expectations.TestExpectations(self._port, self._test_files) File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 741, in __init__ self._add_expectations(self._expectations) File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py", line 882, in _add_expectations if self._is_lint_mode or self._test_config in expectation_line.matching_configurations: File "/Volumes/Data/Shared/src/WebKit/OpenSource/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py", line 57, in __hash__ return hash(self.version + self.architecture + self.build_type) TypeError: cannot concatenate 'str' and 'NoneType' objects I have a fix. 648741 1 147475 thorton 2012-06-13 20:42:42 -0700 Created attachment 147475 patch 648746 2 thorton 2012-06-13 20:48:07 -0700 Landed in http://trac.webkit.org/changeset/120272 648750 3 147475 dpranke 2012-06-13 20:54:19 -0700 Comment on attachment 147475 patch darn ... I keep meaning to fix this stupid interface; it's bug 87413. This was a regression I introduced in http://trac.webkit.org/changeset/120252 . I noticed this earlier today but forgot about it when I went on to test something using my chromium build instead :( Thanks for fixing! 648760 4 147475 dpranke 2012-06-13 21:00:02 -0700 Comment on attachment 147475 patch I thought we had unit tests that at least instantiated all of ports, so I'm surprised we didn't catch this in the unit tests. I'll have to add something for that. 147475 2012-06-13 20:42:42 -0700 2012-06-13 21:00:01 -0700 patch test.diff text/plain 1596 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNzEz ZDZkLi4zYjVjMTMzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMTMgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyMDI1Mik6IHJ1bi13 ZWJraXQtdGVzdHMgb24gTWFjIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04OTA1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGdldF9vcHRpb24gd2lsbCBoYXBwaWx5IHJldHVybiBOb25lICh0aGUg ZGVmYXVsdCBvbmx5IGtpY2tzIGluIGlmCisgICAgICAgIHRoZSBvcHRpb24gaXMgYWN0dWFsbHkg Km5vdCBzZXQqKS4gV2Ugc2hvdWxkIGluc3RlYWQgY2hlY2sgZ2V0X29wdGlvbidzCisgICAgICAg IHJldHVybiB2YWx1ZSBhbmQgZGVmYXVsdCB0byAieDg2XzY0IiBhcmNoaXRlY3R1cmUgb3Vyc2Vs dmVzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMu cHk6CisgICAgICAgIChNYWNQb3J0Ll9faW5pdF9fKToKKwogMjAxMi0wNi0xMyAgRGlyayBQcmFu a2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBuZXctcnVuLXdlYmtpdC10ZXN0 cyBkb2VzIG5vdCBzdXBwb3J0IC0tMzItYml0IGxpa2UgT1JXVCBkaWQKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKaW5kZXggNmEwNGI4OC4uNTYx MmVkYyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9tYWMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9t YWMucHkKQEAgLTUzLDcgKzUzLDExIEBAIGNsYXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKIAogICAg IGRlZiBfX2luaXRfXyhzZWxmLCBob3N0LCBwb3J0X25hbWUsICoqa3dhcmdzKToKICAgICAgICAg QXBwbGVQb3J0Ll9faW5pdF9fKHNlbGYsIGhvc3QsIHBvcnRfbmFtZSwgKiprd2FyZ3MpCi0gICAg ICAgIHNlbGYuX2FyY2hpdGVjdHVyZSA9IHNlbGYuZ2V0X29wdGlvbignYXJjaGl0ZWN0dXJlJywg J3g4Nl82NCcpCisgICAgICAgIHNlbGYuX2FyY2hpdGVjdHVyZSA9IHNlbGYuZ2V0X29wdGlvbign YXJjaGl0ZWN0dXJlJykKKworICAgICAgICBpZiBub3Qgc2VsZi5fYXJjaGl0ZWN0dXJlOgorICAg ICAgICAgICAgc2VsZi5fYXJjaGl0ZWN0dXJlID0gJ3g4Nl82NCcKKwogICAgICAgICBzZWxmLl9s ZWFrX2RldGVjdG9yID0gTGVha0RldGVjdG9yKHNlbGYpCiAgICAgICAgIGlmIHNlbGYuZ2V0X29w dGlvbigibGVha3MiKToKICAgICAgICAgICAgICMgRHVtcFJlbmRlclRyZWUgc2xvd3MgZG93biBu b3RpY2FibHkgaWYgd2UgcnVuIG1vcmUgdGhhbiBhYm91dCAxMDAwIHRlc3RzIGluIGEgYmF0Y2gK