89037 2012-06-13 14:02:48 -0700 Rename _swapView:with: to _replaceView:with: 2012-06-13 21:20:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca jer.noble oldest_to_newest 648440 0 thorton 2012-06-13 14:02:48 -0700 "swap" would imply that both views end up... swapped. That's not what this function does, it replaces one with another. 648446 1 147406 thorton 2012-06-13 14:05:37 -0700 Created attachment 147406 patch 648778 2 thorton 2012-06-13 21:20:19 -0700 Thanks, Darin! Landed in http://trac.webkit.org/changeset/120277 147406 2012-06-13 14:05:37 -0700 2012-06-13 20:20:10 -0700 patch rename-swapview.diff text/plain 2941 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2YmYzNmUzLi4yMzc5NGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDYtMTMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVuYW1lIF9zd2FwVmlldzp3aXRoOiB0byBfcmVwbGFjZVZpZXc6d2l0aDoKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MDM3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBfc3dh cFZpZXc6d2l0aDogaXMgYSBtaXNub21lciAtIGFmdGVyIGNhbGxpbmcgaXQsIHRoZSBmaXJzdCB2 aWV3IGlzIG5vIGxvbmdlcgorICAgICAgICBjb250YWluZWQgd2l0aGluIHRoZSB2aWV3IGhpZXJh cmNoeS4gIlJlcGxhY2UiIGlzIGEgbW9yZSBhY2N1cmF0ZSB0ZXJtLgorCisgICAgICAgICogVUlQ cm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtX S0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGVudGVyRnVsbFNjcmVlbjpdKToKKyAgICAgICAg KC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBmaW5pc2hlZEV4aXRGdWxsU2NyZWVuQW5p bWF0aW9uOl0pOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIF9yZXBs YWNlVmlldzp3aXRoOl0pOgorCiAyMDEyLTA2LTEzICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxh bGxhbi5qZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gRml4ZWQgdmlzaWJsZSBjb250 ZW50IHJlY3QgbG9zdCBkdXJpbmcgcGFnZS1sb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0gYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KaW5k ZXggNjhlMmNkMy4uYjk2NGVmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpAQCAtNTUsNyAr NTUsNyBAQCBzdGF0aWMgY29uc3QgTlNUaW1lSW50ZXJ2YWwgRGVmYXVsdFdhdGNoZG9nVGltZXJJ bnRlcnZhbCA9IDE7CiAKIEBpbnRlcmZhY2UgV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlcihQ cml2YXRlKTxOU0FuaW1hdGlvbkRlbGVnYXRlPgogLSAodm9pZClfdXBkYXRlTWVudUFuZERvY2tG b3JGdWxsU2NyZWVuOwotLSAodm9pZClfc3dhcFZpZXc6KE5TVmlldyopdmlldyB3aXRoOihOU1Zp ZXcqKW90aGVyVmlldzsKKy0gKHZvaWQpX3JlcGxhY2VWaWV3OihOU1ZpZXcqKXZpZXcgd2l0aDoo TlNWaWV3KilvdGhlclZpZXc7CiAtIChXZWJQYWdlUHJveHkqKV9wYWdlOwogLSAoV2ViRnVsbFNj cmVlbk1hbmFnZXJQcm94eSopX21hbmFnZXI7CiAtICh2b2lkKV9zdGFydEVudGVyRnVsbFNjcmVl bkFuaW1hdGlvbldpdGhEdXJhdGlvbjooTlNUaW1lSW50ZXJ2YWwpZHVyYXRpb247CkBAIC0yNDUs NyArMjQ1LDcgQEAgLSAodm9pZCllbnRlckZ1bGxTY3JlZW46KE5TU2NyZWVuICopc2NyZWVuCiAg ICAgICAgIFtfd2ViVmlld1BsYWNlaG9sZGVyLmdldCgpIHNldFdhbnRzTGF5ZXI6WUVTXTsKICAg ICB9CiAgICAgW1tfd2ViVmlld1BsYWNlaG9sZGVyLmdldCgpIGxheWVyXSBzZXRDb250ZW50czoo aWQpd2ViVmlld0NvbnRlbnRzLmdldCgpXTsKLSAgICBbc2VsZiBfc3dhcFZpZXc6X3dlYlZpZXcg d2l0aDpfd2ViVmlld1BsYWNlaG9sZGVyLmdldCgpXTsKKyAgICBbc2VsZiBfcmVwbGFjZVZpZXc6 X3dlYlZpZXcgd2l0aDpfd2ViVmlld1BsYWNlaG9sZGVyLmdldCgpXTsKICAgICAKICAgICAvLyBU aGVuIGluc2VydCB0aGUgV2ViVmlldyBpbnRvIHRoZSBmdWxsIHNjcmVlbiB3aW5kb3cKICAgICBO U1ZpZXcqIGNvbnRlbnRWaWV3ID0gW1tzZWxmIHdpbmRvd10gY29udGVudFZpZXddOwpAQCAtMzgw LDcgKzM4MCw3IEBAIC0gKHZvaWQpZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjooYm9v bCljb21wbGV0ZWQKICAgICBbW193ZWJWaWV3UGxhY2Vob2xkZXIuZ2V0KCkgd2luZG93XSBzZXRB dXRvZGlzcGxheTpOT107CiAKICAgICBOU1Jlc3BvbmRlciAqZmlyc3RSZXNwb25kZXIgPSBbW3Nl bGYgd2luZG93XSBmaXJzdFJlc3BvbmRlcl07Ci0gICAgW3NlbGYgX3N3YXBWaWV3Ol93ZWJWaWV3 UGxhY2Vob2xkZXIuZ2V0KCkgd2l0aDpfd2ViVmlld107CisgICAgW3NlbGYgX3JlcGxhY2VWaWV3 Ol93ZWJWaWV3UGxhY2Vob2xkZXIuZ2V0KCkgd2l0aDpfd2ViVmlld107CiAgICAgW1tfd2ViVmll dyB3aW5kb3ddIG1ha2VSZXNwb25kZXI6Zmlyc3RSZXNwb25kZXIgZmlyc3RSZXNwb25kZXJJZkRl c2NlbmRhbnRPZlZpZXc6X3dlYlZpZXddOwogCiAgICAgTlNSZWN0IHdpbmRvd0JvdW5kcyA9IFtb c2VsZiB3aW5kb3ddIGZyYW1lXTsKQEAgLTQ4Nyw3ICs0ODcsNyBAQCAtIChXZWJGdWxsU2NyZWVu TWFuYWdlclByb3h5KilfbWFuYWdlcgogICAgIHJldHVybiB3ZWJQYWdlLT5mdWxsU2NyZWVuTWFu YWdlcigpOwogfQogCi0tICh2b2lkKV9zd2FwVmlldzooTlNWaWV3Kil2aWV3IHdpdGg6KE5TVmll dyopb3RoZXJWaWV3CistICh2b2lkKV9yZXBsYWNlVmlldzooTlNWaWV3Kil2aWV3IHdpdGg6KE5T Vmlldyopb3RoZXJWaWV3CiB7CiAgICAgW0NBVHJhbnNhY3Rpb24gYmVnaW5dOwogICAgIFtDQVRy YW5zYWN0aW9uIHNldERpc2FibGVBY3Rpb25zOllFU107Cg==