89030 2012-06-13 12:27:06 -0700 el.getAttribute('type') returns 'null' when setting el.type to null 2012-06-14 01:31:48 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 edaena edaena abarth ojan webkit.review.bot oldest_to_newest 648358 0 147388 edaena 2012-06-13 12:27:06 -0700 Created attachment 147388 test After setting the type of a button to null using btn.type = null, btn.getAttribute('type') should return a JavaScript null and not the string 'null'. 648467 1 147413 edaena 2012-06-13 14:31:17 -0700 Created attachment 147413 Proposed fix and updated tests. 648477 2 147413 ap 2012-06-13 14:39:10 -0700 Comment on attachment 147413 Proposed fix and updated tests. View in context: https://bugs.webkit.org/attachment.cgi?id=147413&action=review > Source/WebCore/ChangeLog:14 > + * html/HTMLButtonElement.cpp: > + (WebCore::HTMLButtonElement::setType): > + * html/HTMLButtonElement.h: > + (HTMLButtonElement): > + * html/HTMLButtonElement.idl: This is a good place to explain changes in your files. For example, the change from String to AtomicString definitely needs an explanation, because it's not even part of fixing this bug. E.g. "Address another unrelated review comment from bug 14439." > LayoutTests/fast/dom/HTMLButtonElement/change-type.html:64 > shouldBe("btn.getAttribute('type')", "undefined + ''"); As you are addressing unrelated feedback, you can consider changing this to "'undefined'", too. 648478 3 ap 2012-06-13 14:39:42 -0700 > E.g. "Address another unrelated review comment from bug 14439." Better yet, "Address another unrelated review comment from bug 14439 for slightly better performance." 648487 4 147413 darin 2012-06-13 14:52:55 -0700 Comment on attachment 147413 Proposed fix and updated tests. View in context: https://bugs.webkit.org/attachment.cgi?id=147413&action=review >> LayoutTests/fast/dom/HTMLButtonElement/change-type.html:64 >> shouldBe("btn.getAttribute('type')", "undefined + ''"); > > As you are addressing unrelated feedback, you can consider changing this to "'undefined'", too. I agree, you should do that. 648493 5 147413 darin 2012-06-13 14:59:26 -0700 Comment on attachment 147413 Proposed fix and updated tests. For what it’s worth, I agree with all of Alexey’s comments and suggest you post a new patch dealing with them. 648505 6 147424 edaena 2012-06-13 15:14:51 -0700 Created attachment 147424 Proposed fix and updated tests. 648528 7 147424 ap 2012-06-13 15:42:50 -0700 Comment on attachment 147424 Proposed fix and updated tests. + Reviewed by NOBODY (OOPS!). For minor changes like these, you could have edited ChangeLogs to say "Reviewed by Darin Adler", and post a new patch with "commit-queue?" flag alone, no "review?" flag. + (HTMLButtonElement): Changed parameter to be AtomicString to address an unrelated + review comment from bug 14439 for slightly better performance. We traditionally just say "Ditto" for repeated comments. 648934 8 147424 webkit.review.bot 2012-06-14 01:31:43 -0700 Comment on attachment 147424 Proposed fix and updated tests. Clearing flags on attachment: 147424 Committed r120296: <http://trac.webkit.org/changeset/120296> 648935 9 webkit.review.bot 2012-06-14 01:31:48 -0700 All reviewed patches have been landed. Closing bug. 147388 2012-06-13 12:27:06 -0700 2012-06-13 12:27:06 -0700 test null-type.html text/html 227 edaena PGJvZHk+CiAgPGJ1dHRvbiBpZD0iYiI+dGVzdDwvYnV0dG9uPgo8c2NyaXB0Pgp0cnkgewogICAg YnRuID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImIiKTsKICAgIGJ0bi50eXBlID0gbnVsbDsK ICAgIGEgPSBidG4uZ2V0QXR0cmlidXRlKCd0eXBlJyk7CiAgICAKICAgIGFsZXJ0KHR5cGVvZiBh KTsKICAgIAp9IGNhdGNoIChleCkgewogIGFsZXJ0KGV4KTsKfQo8L3NjcmlwdD4KPC9ib2R5Pgo= 147413 2012-06-13 14:31:17 -0700 2012-06-13 15:14:51 -0700 Proposed fix and updated tests. NewTypePatch.txt text/plain 4648 edaena SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDI0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTEzICBFZGFlbmEg U2FsaW5hcyBKYXNzbyAgPGVkYWVuYUBhcHBsZS5jb20+CisKKyAgICAgICAgZWwuZ2V0QXR0cmli dXRlKCd0eXBlJykgcmV0dXJucyAnbnVsbCcgd2hlbiBzZXR0aW5nIGVsLnR5cGUgdG8gbnVsbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkwMzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0 L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9jaGFuZ2UtdHlwZS5odG1sCisKKyAgICAgICAgKiBodG1s L0hUTUxCdXR0b25FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxCdXR0b25FbGVt ZW50OjpzZXRUeXBlKToKKyAgICAgICAgKiBodG1sL0hUTUxCdXR0b25FbGVtZW50Lmg6CisgICAg ICAgIChIVE1MQnV0dG9uRWxlbWVudCk6CisgICAgICAgICogaHRtbC9IVE1MQnV0dG9uRWxlbWVu dC5pZGw6CisKIDIwMTItMDYtMTMgIFNpbHZpYSBQZmVpZmZlciAgPHNpbHZpYXBmQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBVcGRhdGUgcmFuZ2Ugc2xpZGVycyByZW5kZXJpbmcgZm9yIHZvbHVt ZSBhbmQgcGxheWJhY2sgcG9zaXRpb24gb2YgbmV3IENocm9tZSB2aWRlbyBjb250cm9scy4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuY3BwCShyZXZpc2lvbiAx MjAyMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTMsNyArNTMsNyBAQCBQYXNzUmVmUHRyPEhUTUxCdXR0b25FbGVtZW50 PiBIVE1MQnV0dG9uCiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBIVE1MQnV0dG9uRWxlbWVudCh0 YWdOYW1lLCBkb2N1bWVudCwgZm9ybSkpOwogfQogCi12b2lkIEhUTUxCdXR0b25FbGVtZW50Ojpz ZXRUeXBlKGNvbnN0IFN0cmluZyYgdHlwZSkKK3ZvaWQgSFRNTEJ1dHRvbkVsZW1lbnQ6OnNldFR5 cGUoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlKQogewogICAgIHNldEF0dHJpYnV0ZSh0eXBlQXR0 ciwgdHlwZSk7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5o CShyZXZpc2lvbiAxMjAyMjQpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVt ZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDcgQEAgY2xhc3MgSFRNTEJ1dHRvbkVs ZW1lbnQgOiBwdWJsaWMgSFRNTEZvcgogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPEhU TUxCdXR0b25FbGVtZW50PiBjcmVhdGUoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50Kiwg SFRNTEZvcm1FbGVtZW50Kik7CiAKLSAgICB2b2lkIHNldFR5cGUoY29uc3QgU3RyaW5nJik7Cisg ICAgdm9pZCBzZXRUeXBlKGNvbnN0IEF0b21pY1N0cmluZyYpOwogICAgIAogICAgIFN0cmluZyB2 YWx1ZSgpIGNvbnN0OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVt ZW50LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVt ZW50LmlkbAkocmV2aXNpb24gMTIwMjI0KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0 dG9uRWxlbWVudC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcgKzMwLDcgQEAgbW9kdWxlIGh0 bWwgewogICAgICAgICBhdHRyaWJ1dGUgW1JlZmxlY3RdIGJvb2xlYW4gZm9ybU5vVmFsaWRhdGU7 CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIGZvcm1UYXJnZXQ7CiAgICAg ICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIG5hbWU7Ci0gICAgICAgIGF0dHJpYnV0 ZSBET01TdHJpbmcgdHlwZTsKKyAgICAgICAgYXR0cmlidXRlIFtUcmVhdE51bGxBcz1OdWxsU3Ry aW5nXSBET01TdHJpbmcgdHlwZTsKICAgICAgICAgYXR0cmlidXRlIFtSZWZsZWN0XSBET01TdHJp bmcgdmFsdWU7CiAKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gd2lsbFZhbGlk YXRlOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTIwMjQ4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDYtMTMgIEVkYWVuYSBTYWxp bmFzIEphc3NvICA8ZWRhZW5hQGFwcGxlLmNvbT4KKworICAgICAgICBlbC5nZXRBdHRyaWJ1dGUo J3R5cGUnKSByZXR1cm5zICdudWxsJyB3aGVuIHNldHRpbmcgZWwudHlwZSB0byBudWxsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTAzMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9kb20vSFRN TEJ1dHRvbkVsZW1lbnQvY2hhbmdlLXR5cGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3Qv ZG9tL0hUTUxCdXR0b25FbGVtZW50L2NoYW5nZS10eXBlLmh0bWw6CisKIDIwMTItMDYtMTIgIFZp bmNlbnQgU2NoZWliICA8c2NoZWliQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgZHVw bGljYXRlIHdlYmtpdHBvaW50ZXJsb2NrY2hhbmdlIGV2ZW50cyB3aGVuIHVubG9ja2luZy4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L2NoYW5nZS10eXBlLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQnV0dG9u RWxlbWVudC9jaGFuZ2UtdHlwZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEyMDIyNCkKKysrIExh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L2NoYW5nZS10eXBlLWV4cGVjdGVk LnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQCBQQVNTIGJ0bi5nZXRBdHRyaWJ1 dGUoJ3R5cGUnKSBpcyAnYnV0dG9uCiBQQVNTIGJ0bi50eXBlID0gJyBiIHUgdCB0IG8gbiAnOyBi dG4udHlwZSBpcyAnc3VibWl0JwogUEFTUyBidG4uZ2V0QXR0cmlidXRlKCd0eXBlJykgaXMgJyBi IHUgdCB0IG8gbiAnCiBQQVNTIGJ0bi50eXBlID0gbnVsbDsgYnRuLnR5cGUgaXMgJ3N1Ym1pdCcK LVBBU1MgYnRuLmdldEF0dHJpYnV0ZSgndHlwZScpIGlzIG51bGwgKyAnJworUEFTUyBidG4uZ2V0 QXR0cmlidXRlKCd0eXBlJykgaXMgbnVsbAogUEFTUyBidG4udHlwZSA9IHVuZGVmaW5lZDsgYnRu LnR5cGUgaXMgJ3N1Ym1pdCcKIFBBU1MgYnRuLmdldEF0dHJpYnV0ZSgndHlwZScpIGlzIHVuZGVm aW5lZCArICcnCiBQQVNTIGJ0bi50eXBlID0gJ3Jlc2V0JzsgdHh0LnZhbHVlID0gJ2hlbGxvJzsg YnRuLmNsaWNrKCk7IHR4dC52YWx1ZSBpcyAnJwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20v SFRNTEJ1dHRvbkVsZW1lbnQvY2hhbmdlLXR5cGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9jaGFuZ2UtdHlwZS5odG1sCShyZXZpc2lv biAxMjAyMjQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9jaGFu Z2UtdHlwZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC01OCw3ICs1OCw3IEBAIGZ1bmN0aW9uIHRl c3RUeXBlVmFsdWUoKQogICAgIHNob3VsZEJlKCJidG4uZ2V0QXR0cmlidXRlKCd0eXBlJykiLCAi JyBiIHUgdCB0IG8gbiAnIik7CiAgICAgCiAgICAgc2hvdWxkQmUoImJ0bi50eXBlID0gbnVsbDsg YnRuLnR5cGUiLCAiJ3N1Ym1pdCciKTsKLSAgICBzaG91bGRCZSgiYnRuLmdldEF0dHJpYnV0ZSgn dHlwZScpIiwgIm51bGwgKyAnJyIpOworICAgIHNob3VsZEJlKCJidG4uZ2V0QXR0cmlidXRlKCd0 eXBlJykiLCAibnVsbCIpOwogICAgIAogICAgIHNob3VsZEJlKCJidG4udHlwZSA9IHVuZGVmaW5l ZDsgYnRuLnR5cGUiLCAiJ3N1Ym1pdCciKTsKICAgICBzaG91bGRCZSgiYnRuLmdldEF0dHJpYnV0 ZSgndHlwZScpIiwgInVuZGVmaW5lZCArICcnIik7Cg== 147424 2012-06-13 15:14:51 -0700 2012-06-14 01:31:43 -0700 Proposed fix and updated tests. NewTypePatch.txt text/plain 5521 edaena SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDI0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTEzICBFZGFlbmEg U2FsaW5hcyBKYXNzbyAgPGVkYWVuYUBhcHBsZS5jb20+CisKKyAgICAgICAgZWwuZ2V0QXR0cmli dXRlKCd0eXBlJykgcmV0dXJucyAnbnVsbCcgd2hlbiBzZXR0aW5nIGVsLnR5cGUgdG8gbnVsbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkwMzAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0 L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9jaGFuZ2UtdHlwZS5odG1sCisKKyAgICAgICAgKiBodG1s L0hUTUxCdXR0b25FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxCdXR0b25FbGVt ZW50OjpzZXRUeXBlKTogQ2hhbmdlZCBwYXJhbWV0ZXIgdG8gYmUgQXRvbWljU3RyaW5nIHRvIAor ICAgICAgICBhZGRyZXNzIGFuIHVucmVsYXRlZCByZXZpZXcgY29tbWVudCBmcm9tIGJ1ZyAxNDQz OSBmb3Igc2xpZ2h0bHkgYmV0dGVyIHBlcmZvcm1hbmNlLgorICAgICAgICAqIGh0bWwvSFRNTEJ1 dHRvbkVsZW1lbnQuaDoKKyAgICAgICAgKEhUTUxCdXR0b25FbGVtZW50KTogQ2hhbmdlZCBwYXJh bWV0ZXIgdG8gYmUgQXRvbWljU3RyaW5nIHRvIGFkZHJlc3MgYW4gdW5yZWxhdGVkIAorICAgICAg ICByZXZpZXcgY29tbWVudCBmcm9tIGJ1ZyAxNDQzOSBmb3Igc2xpZ2h0bHkgYmV0dGVyIHBlcmZv cm1hbmNlLgorICAgICAgICAqIGh0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuaWRsOiBTcGVjaWZpZWQg VHJlYXROdWxsQXMgTnVsbFN0cmluZyBmb3IgdGhlIHR5cGUgYXR0cmlidXRlLgorCiAyMDEyLTA2 LTEzICBTaWx2aWEgUGZlaWZmZXIgIDxzaWx2aWFwZkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg VXBkYXRlIHJhbmdlIHNsaWRlcnMgcmVuZGVyaW5nIGZvciB2b2x1bWUgYW5kIHBsYXliYWNrIHBv c2l0aW9uIG9mIG5ldyBDaHJvbWUgdmlkZW8gY29udHJvbHMuCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmNwcAkocmV2aXNpb24gMTIwMjI0KQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUz LDcgKzUzLDcgQEAgUGFzc1JlZlB0cjxIVE1MQnV0dG9uRWxlbWVudD4gSFRNTEJ1dHRvbgogICAg IHJldHVybiBhZG9wdFJlZihuZXcgSFRNTEJ1dHRvbkVsZW1lbnQodGFnTmFtZSwgZG9jdW1lbnQs IGZvcm0pKTsKIH0KIAotdm9pZCBIVE1MQnV0dG9uRWxlbWVudDo6c2V0VHlwZShjb25zdCBTdHJp bmcmIHR5cGUpCit2b2lkIEhUTUxCdXR0b25FbGVtZW50OjpzZXRUeXBlKGNvbnN0IEF0b21pY1N0 cmluZyYgdHlwZSkKIHsKICAgICBzZXRBdHRyaWJ1dGUodHlwZUF0dHIsIHR5cGUpOwogfQpJbmRl eDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuaAkocmV2aXNpb24gMTIwMjI0 KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5oCSh3b3JraW5nIGNv cHkpCkBAIC0zMiw3ICszMiw3IEBAIGNsYXNzIEhUTUxCdXR0b25FbGVtZW50IDogcHVibGljIEhU TUxGb3IKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxIVE1MQnV0dG9uRWxlbWVudD4g Y3JlYXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCosIEhUTUxGb3JtRWxlbWVudCop OwogCi0gICAgdm9pZCBzZXRUeXBlKGNvbnN0IFN0cmluZyYpOworICAgIHZvaWQgc2V0VHlwZShj b25zdCBBdG9taWNTdHJpbmcmKTsKICAgICAKICAgICBTdHJpbmcgdmFsdWUoKSBjb25zdDsKIApJ bmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5pZGwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5pZGwJKHJldmlzaW9u IDEyMDIyNCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJ1dHRvbkVsZW1lbnQuaWRsCSh3 b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgYXR0 cmlidXRlIFtSZWZsZWN0XSBib29sZWFuIGZvcm1Ob1ZhbGlkYXRlOwogICAgICAgICBhdHRyaWJ1 dGUgW1JlZmxlY3RdIERPTVN0cmluZyBmb3JtVGFyZ2V0OwogICAgICAgICBhdHRyaWJ1dGUgW1Jl ZmxlY3RdIERPTVN0cmluZyBuYW1lOwotICAgICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIHR5cGU7 CisgICAgICAgIGF0dHJpYnV0ZSBbVHJlYXROdWxsQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIHR5 cGU7CiAgICAgICAgIGF0dHJpYnV0ZSBbUmVmbGVjdF0gRE9NU3RyaW5nIHZhbHVlOwogCiAgICAg ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29sZWFuIHdpbGxWYWxpZGF0ZTsKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyMDI0OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTEzICBFZGFlbmEgU2FsaW5hcyBKYXNzbyAgPGVkYWVu YUBhcHBsZS5jb20+CisKKyAgICAgICAgZWwuZ2V0QXR0cmlidXRlKCd0eXBlJykgcmV0dXJucyAn bnVsbCcgd2hlbiBzZXR0aW5nIGVsLnR5cGUgdG8gbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkwMzAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L2No YW5nZS10eXBlLWV4cGVjdGVkLnR4dDogVXBkYXRlZCB0aGUgZXhwZWN0ZWQgb3V0cHV0CisgICAg ICAgIHNvIHRoYXQgaXQgbWF0Y2hlcyB0aGUgbnVsbCByZXR1cm4gdHlwZSBvZiBnZXRBdHRyaWJ1 dGUoJ3R5cGUnKS4KKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9jaGFuZ2Ut dHlwZS5odG1sOiBDaGFuZ2UgdGVzdCBvZiBnZXRBdHRyaWJ1dGUoJ3R5cGUnKQorICAgICAgICB0 byBiZSBudWxsIGluc3RlYWQgb2YgJ251bGwnLiBBZGRyZXNzZWQgYW5kIHVucmVsYXRlZCByZXZp ZXcgY29tbWVudCBmcm9tIGJ1ZyAxNDQzOQorICAgICAgICBhYm91dCBob3cgJ3VuZGVmaW5lZCcg aXMgc3BlY2lmaWVkIGluIHRoZSBzaG91bGRCZSBmdW5jdGlvbi4KKwogMjAxMi0wNi0xMiAgVmlu Y2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBkdXBs aWNhdGUgd2Via2l0cG9pbnRlcmxvY2tjaGFuZ2UgZXZlbnRzIHdoZW4gdW5sb2NraW5nLgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEJ1dHRvbkVsZW1lbnQvY2hhbmdlLXR5cGUtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25F bGVtZW50L2NoYW5nZS10eXBlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTIwMjI0KQorKysgTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTEJ1dHRvbkVsZW1lbnQvY2hhbmdlLXR5cGUtZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw5ICszMCw5IEBAIFBBU1MgYnRuLmdldEF0dHJpYnV0 ZSgndHlwZScpIGlzICdidXR0b24KIFBBU1MgYnRuLnR5cGUgPSAnIGIgdSB0IHQgbyBuICc7IGJ0 bi50eXBlIGlzICdzdWJtaXQnCiBQQVNTIGJ0bi5nZXRBdHRyaWJ1dGUoJ3R5cGUnKSBpcyAnIGIg dSB0IHQgbyBuICcKIFBBU1MgYnRuLnR5cGUgPSBudWxsOyBidG4udHlwZSBpcyAnc3VibWl0Jwot UEFTUyBidG4uZ2V0QXR0cmlidXRlKCd0eXBlJykgaXMgbnVsbCArICcnCitQQVNTIGJ0bi5nZXRB dHRyaWJ1dGUoJ3R5cGUnKSBpcyBudWxsCiBQQVNTIGJ0bi50eXBlID0gdW5kZWZpbmVkOyBidG4u dHlwZSBpcyAnc3VibWl0JwotUEFTUyBidG4uZ2V0QXR0cmlidXRlKCd0eXBlJykgaXMgdW5kZWZp bmVkICsgJycKK1BBU1MgYnRuLmdldEF0dHJpYnV0ZSgndHlwZScpIGlzICd1bmRlZmluZWQnCiBQ QVNTIGJ0bi50eXBlID0gJ3Jlc2V0JzsgdHh0LnZhbHVlID0gJ2hlbGxvJzsgYnRuLmNsaWNrKCk7 IHR4dC52YWx1ZSBpcyAnJwogUEFTUyBkaWRTdWJtaXQgaXMgZmFsc2UKIFBBU1MgYnRuLnR5cGUg PSAnYnV0dG9uJzsgdHh0LnZhbHVlID0gJ2hlbGxvJzsgYnRuLmNsaWNrKCk7IHR4dC52YWx1ZSBp cyAnaGVsbG8nCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQnV0dG9uRWxlbWVudC9j aGFuZ2UtdHlwZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxC dXR0b25FbGVtZW50L2NoYW5nZS10eXBlLmh0bWwJKHJldmlzaW9uIDEyMDIyNCkKKysrIExheW91 dFRlc3RzL2Zhc3QvZG9tL0hUTUxCdXR0b25FbGVtZW50L2NoYW5nZS10eXBlLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTU4LDEwICs1OCwxMCBAQCBmdW5jdGlvbiB0ZXN0VHlwZVZhbHVlKCkKICAg ICBzaG91bGRCZSgiYnRuLmdldEF0dHJpYnV0ZSgndHlwZScpIiwgIicgYiB1IHQgdCBvIG4gJyIp OwogICAgIAogICAgIHNob3VsZEJlKCJidG4udHlwZSA9IG51bGw7IGJ0bi50eXBlIiwgIidzdWJt aXQnIik7Ci0gICAgc2hvdWxkQmUoImJ0bi5nZXRBdHRyaWJ1dGUoJ3R5cGUnKSIsICJudWxsICsg JyciKTsKKyAgICBzaG91bGRCZSgiYnRuLmdldEF0dHJpYnV0ZSgndHlwZScpIiwgIm51bGwiKTsK ICAgICAKICAgICBzaG91bGRCZSgiYnRuLnR5cGUgPSB1bmRlZmluZWQ7IGJ0bi50eXBlIiwgIidz dWJtaXQnIik7Ci0gICAgc2hvdWxkQmUoImJ0bi5nZXRBdHRyaWJ1dGUoJ3R5cGUnKSIsICJ1bmRl ZmluZWQgKyAnJyIpOworICAgIHNob3VsZEJlKCJidG4uZ2V0QXR0cmlidXRlKCd0eXBlJykiLCAi J3VuZGVmaW5lZCciKTsKIH0KIAogZnVuY3Rpb24gdGVzdFR5cGVCZWhhdmlvcigpCg==