89028 2012-06-13 11:56:49 -0700 [chromium] Rename WebFrameClient::userAgent() to better reflect what it does 2012-06-15 14:02:25 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dfalcantara dfalcantara abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 648321 0 dfalcantara 2012-06-13 11:56:49 -0700 WebFrameClient::userAgent() was added in https://bugs.webkit.org/show_bug.cgi?id=83959 However, the name isn't as clear as it could be because it returns a boolean and has an out parameter. The signature of the function should be changed from: "bool userAgent(URL, *WebString)" to something like: "WebString userAgentOverride(URL)" where the WebString directly contains the user agent override if one is necessary, and "" if not. 648486 1 147417 dfalcantara 2012-06-13 14:52:30 -0700 Created attachment 147417 Patch 648489 2 webkit.review.bot 2012-06-13 14:57:49 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 648894 3 147417 webkit.review.bot 2012-06-14 00:36:31 -0700 Comment on attachment 147417 Patch Clearing flags on attachment: 147417 Committed r120292: <http://trac.webkit.org/changeset/120292> 648895 4 webkit.review.bot 2012-06-14 00:36:36 -0700 All reviewed patches have been landed. Closing bug. 649876 5 147417 fishd 2012-06-14 22:18:46 -0700 Comment on attachment 147417 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147417&action=review > Source/WebKit/chromium/public/WebFrameClient.h:403 > + virtual WebString userAgentOverride(const WebURL& url) { return WebString(); } By the way, WebFrameClient methods generally all start with a WebFrame pointer. That way, the embedder can determine the context for a request. It is not always needed by Chrome, but we have tried to be consistent with this interface. 650482 6 dfalcantara 2012-06-15 14:02:25 -0700 (In reply to comment #5) > By the way, WebFrameClient methods generally all start with a WebFrame pointer. > That way, the embedder can determine the context for a request. It is not > always needed by Chrome, but we have tried to be consistent with this interface. I opened and filed a patch under https://bugs.webkit.org/show_bug.cgi?id=89233 to fix it. Thanks for catching it! 147417 2012-06-13 14:52:30 -0700 2012-06-14 22:18:46 -0700 Patch bug-89028-20120613145229.patch text/plain 3318 dfalcantara SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjAyNTApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA2LTEzICBEYW4gQWxjYW50YXJhICA8ZGZhbGNhbnRhcmFAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gUmVuYW1lIFdlYkZyYW1lQ2xpZW50Ojp1c2VyQWdlbnQo KSB0byBiZXR0ZXIgcmVmbGVjdCB3aGF0IGl0IGRvZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuYW1lcyBXZWJGcmFtZUNsaWVudDo6dXNlckFnZW50 KCkgdG8gdXNlckFnZW50T3ZlcnJpZGUoKSBhbmQgbWFrZXMgaXQgcmV0dXJuCisgICAgICAgIHRo ZSB1c2VyIGFnZW50IG92ZXJyaWRlIHN0cmluZyBkaXJlY3RseS4KKworICAgICAgICAqIHB1Ymxp Yy9XZWJGcmFtZUNsaWVudC5oOgorICAgICAgICAoV2ViRnJhbWVDbGllbnQpOgorICAgICAgICAo V2ViS2l0OjpXZWJGcmFtZUNsaWVudDo6dXNlckFnZW50T3ZlcnJpZGUpOgorICAgICAgICAqIHNy Yy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRl ckNsaWVudEltcGw6OnVzZXJBZ2VudCk6CisgICAgICAgICogdGVzdHMvRnJhbWVMb2FkZXJDbGll bnRJbXBsVGVzdC5jcHA6CisKIDIwMTItMDYtMTMgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmll dy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjAy MjAuCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZUNsaWVudC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xp ZW50LmgJKHJldmlzaW9uIDEyMDIzOSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkZyYW1lQ2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTM5OCw5ICszOTgsOSBAQCBwdWJs aWM6CiAgICAgICAgIFdlYkRPTU1lc3NhZ2VFdmVudCkgeyByZXR1cm4gZmFsc2U7IH0KIAogICAg IC8vIEFza3MgdGhlIGVtYmVkZGVyIGlmIGEgc3BlY2lmaWMgdXNlciBhZ2VudCBzaG91bGQgYmUg dXNlZCBmb3IgdGhlIGdpdmVuCi0gICAgLy8gVVJMLiBSZXR1cm5zIHRydWUgaWYgaXQgc2hvdWxk LCBhbG9uZyB3aXRoIHRoZSB1c2VyIGFnZW50LiBJZiBmYWxzZSwKKyAgICAvLyBVUkwuIE5vbi1l bXB0eSBzdHJpbmdzIGluZGljYXRlIGFuIG92ZXJyaWRlIHNob3VsZCBiZSB1c2VkLiBPdGhlcndp c2UsCiAgICAgLy8gV2ViS2l0UGxhdGZvcm1TdXBwb3J0Ojp1c2VyQWdlbnQoKSB3aWxsIGJlIGNh bGxlZCB0byBwcm92aWRlIG9uZS4KLSAgICB2aXJ0dWFsIGJvb2wgdXNlckFnZW50KGNvbnN0IFdl YlVSTCYgdXJsLCBXZWJTdHJpbmcqIHVzZXJBZ2VudCkgeyByZXR1cm4gZmFsc2U7IH0KKyAgICB2 aXJ0dWFsIFdlYlN0cmluZyB1c2VyQWdlbnRPdmVycmlkZShjb25zdCBXZWJVUkwmIHVybCkgeyBy ZXR1cm4gV2ViU3RyaW5nKCk7IH0KIAogcHJvdGVjdGVkOgogICAgIH5XZWJGcmFtZUNsaWVudCgp IHsgfQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJ bXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxv YWRlckNsaWVudEltcGwuY3BwCShyZXZpc2lvbiAxMjAyMzkpCisrKyBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MzgzLDggKzEzODMsOCBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50SW1wbDo6c2V0VGl0bGUoY29u CiAKIFN0cmluZyBGcmFtZUxvYWRlckNsaWVudEltcGw6OnVzZXJBZ2VudChjb25zdCBLVVJMJiB1 cmwpCiB7Ci0gICAgV2ViU3RyaW5nIG92ZXJyaWRlOwotICAgIGlmIChtX3dlYkZyYW1lLT5jbGll bnQoKS0+dXNlckFnZW50KFdlYlVSTCh1cmwpLCAmb3ZlcnJpZGUpKQorICAgIFdlYlN0cmluZyBv dmVycmlkZSA9IG1fd2ViRnJhbWUtPmNsaWVudCgpLT51c2VyQWdlbnRPdmVycmlkZShXZWJVUkwo dXJsKSk7CisgICAgaWYgKCFvdmVycmlkZS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBvdmVy cmlkZTsKIAogICAgIHJldHVybiBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPnVzZXJBZ2Vu dCh1cmwpOwpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9GcmFtZUxvYWRlckNs aWVudEltcGxUZXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbFRlc3QuY3BwCShyZXZpc2lvbiAxMjAyMzkpCisrKyBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbFRlc3QuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00NiwxMyArNDYsMTIgQEAgbmFtZXNwYWNlIHsKIAogY2xhc3Mg VGVzdFdlYkZyYW1lQ2xpZW50IDogcHVibGljIFdlYkZyYW1lQ2xpZW50IHsKIHB1YmxpYzoKLSAg ICBib29sIHVzZXJBZ2VudChjb25zdCBXZWJVUkwmIHVybCwgV2ViU3RyaW5nKiB1c2VyQWdlbnQp IE9WRVJSSURFCisgICAgV2ViU3RyaW5nIHVzZXJBZ2VudE92ZXJyaWRlKGNvbnN0IFdlYlVSTCYg dXJsKSBPVkVSUklERQogICAgIHsKICAgICAgICAgaWYgKG1fdXNlckFnZW50T3ZlcnJpZGUuaXNF bXB0eSgpKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgcmV0dXJuIFdl YlN0cmluZygpOwogCi0gICAgICAgICp1c2VyQWdlbnQgPSBtX3VzZXJBZ2VudE92ZXJyaWRlOwot ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgcmV0dXJuIG1fdXNlckFnZW50T3ZlcnJpZGU7 CiAgICAgfQogCiAgICAgdm9pZCBzZXRVc2VyQWdlbnRPdmVycmlkZShjb25zdCBXZWJTdHJpbmcm IHVzZXJBZ2VudCkK