89015 2012-06-13 10:18:25 -0700 [CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake 2012-06-14 17:51:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis charles.wei rakuco robin.webkit tonikitoo webkit.review.bot oldest_to_newest 648200 0 naginenis 2012-06-13 10:18:25 -0700 Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake. 648220 1 147356 naginenis 2012-06-13 10:30:05 -0700 Created attachment 147356 Patch 648695 2 robin.webkit 2012-06-13 19:25:05 -0700 Thanks for the patch. I agree this file should move to UseJSC.cmake. 648702 3 147356 rakuco 2012-06-13 19:35:46 -0700 Comment on attachment 147356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review > Source/WebCore/UseJSC.cmake:300 > +IF (ENABLE_MEDIA_STREAM) > + LIST (APPEND WebCore_SOURCES > + bindings/js/JSDeprecatedPeerConnectionCustom.cpp > + ) > +ENDIF () I think you can add this file to the list unconditionally, as it is already protected by an #ifdef. 649043 4 147356 naginenis 2012-06-14 03:31:48 -0700 Comment on attachment 147356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147356&action=review >> Source/WebCore/UseJSC.cmake:300 >> +ENDIF () > > I think you can add this file to the list unconditionally, as it is already protected by an #ifdef. Yes, it can be moved outside of ifdef guards. I just followed same as other modules included the .cpp files. 649051 5 147548 naginenis 2012-06-14 03:41:58 -0700 Created attachment 147548 Patch Fixed review comment #3. 649617 6 rakuco 2012-06-14 16:22:50 -0700 Looks fine to me. 649686 7 147548 webkit.review.bot 2012-06-14 17:51:21 -0700 Comment on attachment 147548 Patch Clearing flags on attachment: 147548 Committed r120382: <http://trac.webkit.org/changeset/120382> 649687 8 webkit.review.bot 2012-06-14 17:51:27 -0700 All reviewed patches have been landed. Closing bug. 147356 2012-06-13 10:30:05 -0700 2012-06-14 03:41:58 -0700 Patch 89015.patch text/plain 1755 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggZjM1OTQxYy4uYTUwYTJjNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTI0ODcsNyArMjQ4Nyw2IEBAIElGIChFTkFCTEVfTUVESUFfU1RSRUFNKQogICAg ICAgICBNb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYUNvbnRyb2xsZXIuY3BwCiAgICAgICAg IE1vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKIAotICAgICAgICBiaW5k aW5ncy9qcy9KU0RlcHJlY2F0ZWRQZWVyQ29ubmVjdGlvbkN1c3RvbS5jcHAKICAgICAgICAgcGxh dGZvcm0vbWVkaWFzdHJlYW0vSWNlQ2FuZGlkYXRlRGVzY3JpcHRvci5jcHAKICAgICAgICAgcGxh dGZvcm0vbWVkaWFzdHJlYW0vSWNlT3B0aW9ucy5jcHAKICAgICAgICAgcGxhdGZvcm0vbWVkaWFz dHJlYW0vTWVkaWFIaW50cy5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NzgxOTEzLi4xODJiMmJhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDYtMTMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0NNQUtFXSBN b3ZlIEpTRGVwcmVjYXRlZFBlZXJDb25uZWN0aW9uQ3VzdG9tLmNwcCBmcm9tIENNYWtlTGlzdHMu dHh0IHRvIFVzZUpTQy5jbWFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODkwMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbmNsdWRlIEpTRGVwcmVjYXRlZFBlZXJDb25uZWN0aW9uQ3VzdG9tLmNwcCBp biBVc2VKU0MuY21ha2UKKyAgICAgICAgaW5zdGVhZCBvZiBDTWFrZUxpc3RzLnR4dC4KKworICAg ICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAg ICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBVc2VKU0MuY21ha2U6CisKIDIwMTItMDYt MTMgIFJvYmluIENhbyAgPHJvYmluLmNhb0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAg W0JsYWNrQmVycnldIEVuYWJsZSBNRURJQV9TVFJFQU0gYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvVXNlSlNDLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvVXNlSlNDLmNtYWtl CmluZGV4IDIwMTVlM2IuLmQ1Y2Q2ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1VzZUpT Qy5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UKQEAgLTI5Myw2ICsyOTMs MTIgQEAgSUYgKEVOQUJMRV9XRUJfSU5URU5UUykKICAgICApCiBFTkRJRiAoKQogCitJRiAoRU5B QkxFX01FRElBX1NUUkVBTSkKKyAgICBMSVNUIChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAg ICAgIGJpbmRpbmdzL2pzL0pTRGVwcmVjYXRlZFBlZXJDb25uZWN0aW9uQ3VzdG9tLmNwcAorICAg ICkKK0VORElGICgpCisKIExJU1QoQVBQRU5EIFNDUklQVFNfQklORElOR1MKICAgICAke1dFQkNP UkVfRElSfS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0KICkK 147548 2012-06-14 03:41:58 -0700 2012-06-14 17:51:21 -0700 Patch 89015.patch text/plain 1775 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggZTFhYzNmOC4uZTI3M2MwZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKQEAgLTI0ODksNyArMjQ4OSw2IEBAIElGIChFTkFCTEVfTUVESUFfU1RSRUFNKQogICAg ICAgICBNb2R1bGVzL21lZGlhc3RyZWFtL1VzZXJNZWRpYUNvbnRyb2xsZXIuY3BwCiAgICAgICAg IE1vZHVsZXMvbWVkaWFzdHJlYW0vVXNlck1lZGlhUmVxdWVzdC5jcHAKIAotICAgICAgICBiaW5k aW5ncy9qcy9KU0RlcHJlY2F0ZWRQZWVyQ29ubmVjdGlvbkN1c3RvbS5jcHAKICAgICAgICAgcGxh dGZvcm0vbWVkaWFzdHJlYW0vSWNlQ2FuZGlkYXRlRGVzY3JpcHRvci5jcHAKICAgICAgICAgcGxh dGZvcm0vbWVkaWFzdHJlYW0vSWNlT3B0aW9ucy5jcHAKICAgICAgICAgcGxhdGZvcm0vbWVkaWFz dHJlYW0vTWVkaWFIaW50cy5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjZWM5MmFhLi44NjNhNmQ1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDYtMTMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0NNQUtFXSBN b3ZlIEpTRGVwcmVjYXRlZFBlZXJDb25uZWN0aW9uQ3VzdG9tLmNwcCBmcm9tIENNYWtlTGlzdHMu dHh0IHRvIFVzZUpTQy5jbWFrZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODkwMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbmNsdWRlIEpTRGVwcmVjYXRlZFBlZXJDb25uZWN0aW9uQ3VzdG9tLmNwcCBp biBVc2VKU0MuY21ha2UKKyAgICAgICAgaW5zdGVhZCBvZiBDTWFrZUxpc3RzLnR4dC4KKworICAg ICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eSBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAg ICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBVc2VKU0MuY21ha2U6CisKIDIwMTItMDYt MTQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBhIHR5 cG8gaW4gcjEyMDMwNC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFrZSBi L1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFrZQppbmRleCBmNzE0OGYyLi5jZTY5MGVmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUv VXNlSlNDLmNtYWtlCkBAIC00OSw2ICs0OSw3IEBAIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNF UwogICAgIGJpbmRpbmdzL2pzL0pTQ29vcmRpbmF0ZXNDdXN0b20uY3BwCiAgICAgYmluZGluZ3Mv anMvSlNDdXN0b21Wb2lkQ2FsbGJhY2suY3BwCiAgICAgYmluZGluZ3MvanMvSlNDdXN0b21YUGF0 aE5TUmVzb2x2ZXIuY3BwCisgICAgYmluZGluZ3MvanMvSlNEZXByZWNhdGVkUGVlckNvbm5lY3Rp b25DdXN0b20uY3BwCiAgICAgYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmNwcAogICAgIGJpbmRp bmdzL2pzL0pTRE9NQmluZGluZy5jcHAKICAgICBiaW5kaW5ncy9qcy9KU0RPTUZvcm1EYXRhQ3Vz dG9tLmNwcAo=