89003 2012-06-13 08:26:09 -0700 Web Inspector: Breakpoint's _uiLocationRemoved() method is never called. 2012-06-13 10:33:10 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 648052 0 vsevik 2012-06-13 08:26:09 -0700 When _locationUpdated is called on breakpoint, _uiLocationRemoved should be called for primaryUILocation and oldUILocation. It doesn't now because map is used incorrectly. 648054 1 147322 vsevik 2012-06-13 08:28:22 -0700 Created attachment 147322 Patch 648125 2 147322 pfeldman 2012-06-13 09:26:37 -0700 Comment on attachment 147322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147322&action=review > Source/WebCore/inspector/front-end/BreakpointManager.js:265 > + /** @type {Object.<string, WebInspector.UILocation>} */ swap the two 648230 3 vsevik 2012-06-13 10:33:10 -0700 Committed r120223: <http://trac.webkit.org/changeset/120223> 147322 2012-06-13 08:28:22 -0700 2012-06-13 09:26:37 -0700 Patch bug-89003-20120613192820.patch text/plain 4765 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBkODY1ZTA1ZTgxMjdj ZDdlNmEzZWI3MWU5Zjk0NWEzNjZhZGUxZC4uN2Q3NWU5Mjk2ODM5ZTQxZTM3NjQ5NjE3ZDEzOWUy YTNjMDdhODE3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTEzICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEJyZWFrcG9pbnQncyBfdWlMb2NhdGlvblJlbW92ZWQoKSBtZXRob2QgaXMgbmV2ZXIgY2Fs bGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkw MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludE1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuQnJlYWtwb2ludE1hbmFnZXIucHJvdG90eXBlLmJyZWFrcG9pbnRMb2NhdGlvbnNGb3JV SVNvdXJjZUNvZGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRNYW5hZ2VyLkJy ZWFrcG9pbnQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRNYW5hZ2VyLkJyZWFr cG9pbnQucHJvdG90eXBlLl9sb2NhdGlvblVwZGF0ZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkJyZWFrcG9pbnRNYW5hZ2VyLkJyZWFrcG9pbnQucHJvdG90eXBlLl9yZXNldExvY2F0aW9ucyk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludE1hbmFnZXIuQnJlYWtwb2ludC5wcm90 b3R5cGUuX2Zha2VCcmVha3BvaW50QXRQcmltYXJ5TG9jYXRpb24pOgorCiAyMDEyLTA2LTEyICBI YW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU3BlZWNoIEphdmFT Y3JpcHQgQVBJOiBBZGQgdGVzdCBmb3IgY29uc3RydWN0aW5nIFNwZWVjaFJlY29nbml0aW9uRXJy b3IgZXZlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0JyZWFrcG9pbnRNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9CcmVha3BvaW50TWFuYWdlci5qcwppbmRleCBmMWJmOTM1Y2M2ZDQyYjQ1ZDQzNmVmNWJiZjMz OTYyZjFiMjU0YjAyLi5lNjE2MzQzMmU5YTllZmQ5ZTllZDJkMjk5ZTU2NDU4ZmM4NDRjMTY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRN YW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQnJlYWtw b2ludE1hbmFnZXIuanMKQEAgLTEyOCw5ICsxMjgsOCBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2lu dE1hbmFnZXIucHJvdG90eXBlID0gewogICAgICAgICB2YXIgcmVzdWx0ID0gW107CiAgICAgICAg IGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fYnJlYWtwb2ludHMubGVuZ3RoOyArK2kpIHsKICAg ICAgICAgICAgIHZhciBicmVha3BvaW50ID0gdGhpcy5fYnJlYWtwb2ludHNbaV07Ci0gICAgICAg ICAgICB2YXIgdWlMb2NhdGlvbnMgPSBicmVha3BvaW50Ll91aUxvY2F0aW9ucy52YWx1ZXMoKTsK LSAgICAgICAgICAgIGZvciAodmFyIGogPSAwOyBqIDwgdWlMb2NhdGlvbnMubGVuZ3RoOyArK2op IHsKLSAgICAgICAgICAgICAgICB2YXIgdWlMb2NhdGlvbiA9IHVpTG9jYXRpb25zW2pdOworICAg ICAgICAgICAgZm9yICh2YXIgc3RyaW5naWZpZWRMb2NhdGlvbiBpbiB0aGlzLl91aUxvY2F0aW9u cykgeworICAgICAgICAgICAgICAgIHZhciB1aUxvY2F0aW9uID0gdGhpcy5fdWlMb2NhdGlvbnNb c3RyaW5naWZpZWRMb2NhdGlvbl07CiAgICAgICAgICAgICAgICAgaWYgKHVpTG9jYXRpb24udWlT b3VyY2VDb2RlID09PSB1aVNvdXJjZUNvZGUpCiAgICAgICAgICAgICAgICAgICAgIHJlc3VsdC5w dXNoKHticmVha3BvaW50OiBicmVha3BvaW50LCB1aUxvY2F0aW9uOiB1aUxvY2F0aW9ufSk7CiAg ICAgICAgICAgICB9CkBAIC0yNjMsOCArMjYyLDEwIEBAIFdlYkluc3BlY3Rvci5CcmVha3BvaW50 TWFuYWdlci5CcmVha3BvaW50ID0gZnVuY3Rpb24oYnJlYWtwb2ludE1hbmFnZXIsIHVpU291cmNl CiAgICAgdGhpcy5fYnJlYWtwb2ludE1hbmFnZXIgPSBicmVha3BvaW50TWFuYWdlcjsKICAgICB0 aGlzLl9wcmltYXJ5VUlMb2NhdGlvbiA9IG5ldyBXZWJJbnNwZWN0b3IuVUlMb2NhdGlvbih1aVNv dXJjZUNvZGUsIGxpbmVOdW1iZXIsIDApOwogICAgIHRoaXMuX3NvdXJjZUNvZGVTdG9yYWdlSWQg PSB1aVNvdXJjZUNvZGUuYnJlYWtwb2ludFN0b3JhZ2VJZCgpOworICAgIC8qKiBAdHlwZSB7T2Jq ZWN0LjxzdHJpbmcsIFdlYkluc3BlY3Rvci5VSUxvY2F0aW9uPn0gKi8gCiAgICAgdGhpcy5fbGl2 ZUxvY2F0aW9ucyA9IFtdOwotICAgIHRoaXMuX3VpTG9jYXRpb25zID0gbmV3IE1hcCgpOworICAg IC8qKiBAdHlwZSB7QXJyYXkuPFdlYkluc3BlY3Rvci5TY3JpcHQuTG9jYXRpb24+fSAqLyAKKyAg ICB0aGlzLl91aUxvY2F0aW9ucyA9IHt9OwogCiAgICAgLy8gRm9yY2UgYnJlYWtwb2ludCB1cGRh dGUuCiAgICAgLyoqIEB0eXBlIHtzdHJpbmd9ICovIHRoaXMuX2NvbmRpdGlvbjsKQEAgLTI5NSwx MCArMjk2LDE1IEBAIFdlYkluc3BlY3Rvci5CcmVha3BvaW50TWFuYWdlci5CcmVha3BvaW50LnBy b3RvdHlwZSA9IHsKICAgICAgKi8KICAgICBfbG9jYXRpb25VcGRhdGVkOiBmdW5jdGlvbihsb2Nh dGlvbiwgdWlMb2NhdGlvbikKICAgICB7Ci0gICAgICAgIHZhciBvbGRVSUxvY2F0aW9uID0gLyoq IEB0eXBlIHtXZWJJbnNwZWN0b3IuVUlMb2NhdGlvbn0gKi8gdGhpcy5fdWlMb2NhdGlvbnMuZ2V0 KGxvY2F0aW9uKTsKKyAgICAgICAgdmFyIHN0cmluZ2lmaWVkTG9jYXRpb24gPSBsb2NhdGlvbi5z Y3JpcHRJZCArICI6IiArIGxvY2F0aW9uLmxpbmVOdW1iZXIgKyAiOiIgKyBsb2NhdGlvbi5jb2x1 bW5OdW1iZXI7CisgICAgICAgIHZhciBvbGRVSUxvY2F0aW9uID0gLyoqIEB0eXBlIHtXZWJJbnNw ZWN0b3IuVUlMb2NhdGlvbn0gKi8gdGhpcy5fdWlMb2NhdGlvbnNbc3RyaW5naWZpZWRMb2NhdGlv bl07CiAgICAgICAgIGlmIChvbGRVSUxvY2F0aW9uKQogICAgICAgICAgICAgdGhpcy5fYnJlYWtw b2ludE1hbmFnZXIuX3VpTG9jYXRpb25SZW1vdmVkKHRoaXMsIG9sZFVJTG9jYXRpb24pOwotICAg ICAgICB0aGlzLl91aUxvY2F0aW9ucy5wdXQobG9jYXRpb24sIHVpTG9jYXRpb24pOworICAgICAg ICBpZiAodGhpcy5fdWlMb2NhdGlvbnNbIiJdKSB7CisgICAgICAgICAgICBkZWxldGUgdGhpcy5f dWlMb2NhdGlvbnNbIiJdOworICAgICAgICAgICAgdGhpcy5fYnJlYWtwb2ludE1hbmFnZXIuX3Vp TG9jYXRpb25SZW1vdmVkKHRoaXMsIHRoaXMuX3ByaW1hcnlVSUxvY2F0aW9uKTsKKyAgICAgICAg fQorICAgICAgICB0aGlzLl91aUxvY2F0aW9uc1tzdHJpbmdpZmllZExvY2F0aW9uXSA9IHVpTG9j YXRpb247CiAgICAgICAgIHRoaXMuX2JyZWFrcG9pbnRNYW5hZ2VyLl91aUxvY2F0aW9uQWRkZWQo dGhpcywgdWlMb2NhdGlvbik7CiAgICAgfSwKIApAQCAtNDE4LDE1ICs0MjQsMTQgQEAgV2ViSW5z cGVjdG9yLkJyZWFrcG9pbnRNYW5hZ2VyLkJyZWFrcG9pbnQucHJvdG90eXBlID0gewogCiAgICAg X3Jlc2V0TG9jYXRpb25zOiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICB2YXIgdWlMb2NhdGlv bnMgPSB0aGlzLl91aUxvY2F0aW9ucy52YWx1ZXMoKTsKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7 IGkgPCB1aUxvY2F0aW9ucy5sZW5ndGg7ICsraSkKLSAgICAgICAgICAgIHRoaXMuX2JyZWFrcG9p bnRNYW5hZ2VyLl91aUxvY2F0aW9uUmVtb3ZlZCh0aGlzLCB1aUxvY2F0aW9uc1tpXSk7CisgICAg ICAgIGZvciAodmFyIHN0cmluZ2lmaWVkTG9jYXRpb24gaW4gdGhpcy5fdWlMb2NhdGlvbnMpCisg ICAgICAgICAgICB0aGlzLl9icmVha3BvaW50TWFuYWdlci5fdWlMb2NhdGlvblJlbW92ZWQodGhp cywgdGhpcy5fdWlMb2NhdGlvbnNbc3RyaW5naWZpZWRMb2NhdGlvbl0pOwogCiAgICAgICAgIGZv ciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fbGl2ZUxvY2F0aW9ucy5sZW5ndGg7ICsraSkKICAgICAg ICAgICAgIHRoaXMuX2xpdmVMb2NhdGlvbnNbaV0uZGlzcG9zZSgpOwogICAgICAgICB0aGlzLl9s aXZlTG9jYXRpb25zID0gW107CiAKLSAgICAgICAgdGhpcy5fdWlMb2NhdGlvbnMgPSBuZXcgTWFw KCk7CisgICAgICAgIHRoaXMuX3VpTG9jYXRpb25zID0ge307CiAgICAgfSwKIAogICAgIC8qKgpA QCAtNDQwLDcgKzQ0NSw3IEBAIFdlYkluc3BlY3Rvci5CcmVha3BvaW50TWFuYWdlci5CcmVha3Bv aW50LnByb3RvdHlwZSA9IHsKICAgICBfZmFrZUJyZWFrcG9pbnRBdFByaW1hcnlMb2NhdGlvbjog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5fcmVzZXRMb2NhdGlvbnMoKTsKLSAgICAg ICAgdGhpcy5fdWlMb2NhdGlvbnMucHV0KHt9LCB0aGlzLl9wcmltYXJ5VUlMb2NhdGlvbik7Cisg ICAgICAgIHRoaXMuX3VpTG9jYXRpb25zWyIiXSA9IHRoaXMuX3ByaW1hcnlVSUxvY2F0aW9uOwog ICAgICAgICB0aGlzLl9icmVha3BvaW50TWFuYWdlci5fdWlMb2NhdGlvbkFkZGVkKHRoaXMsIHRo aXMuX3ByaW1hcnlVSUxvY2F0aW9uKTsKICAgICB9CiB9Cg==