88998 2012-06-13 07:55:30 -0700 Remove return statement in void method 2012-06-13 14:59:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik kpiascik rwlbuis tkent tonikitoo webkit.review.bot oldest_to_newest 648009 0 kpiascik 2012-06-13 07:55:30 -0700 Remove return statement in void method 648034 1 147318 kpiascik 2012-06-13 08:14:10 -0700 Created attachment 147318 Patch 648248 2 147318 kling 2012-06-13 10:54:26 -0700 Comment on attachment 147318 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147318&action=review > Source/WebCore/ChangeLog:8 > + Tested with compiler. What? 648263 3 147364 kpiascik 2012-06-13 11:08:39 -0700 Created attachment 147364 Patch 648491 4 147364 webkit.review.bot 2012-06-13 14:59:15 -0700 Comment on attachment 147364 Patch Clearing flags on attachment: 147364 Committed r120251: <http://trac.webkit.org/changeset/120251> 648492 5 webkit.review.bot 2012-06-13 14:59:19 -0700 All reviewed patches have been landed. Closing bug. 147318 2012-06-13 08:14:10 -0700 2012-06-13 11:08:13 -0700 Patch bug-88998-20120613111413.patch text/plain 1488 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAzMzM4NTliYzhlMTNk Y2U5NDRhZjEyOTQwZjllMGI0ZTA4Yzg3Ni4uNWU1ZTgyN2Y0MmEyZDZkNGVjNWNmMWFhZDYzYWQw ZjdlOTU3NzkzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTEzICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJldHVybiBz dGF0ZW1lbnQgaW4gdm9pZCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg4OTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGVzdGVkIHdpdGggY29tcGlsZXIuCisKKyAgICAgICAgKiBodG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6 Y29sbGVjdFN0eWxlRm9yQXR0cmlidXRlKToKKwogMjAxMi0wNi0wNyAgQXJ2aWQgTmlsc3NvbiAg PGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFsbG93IFdlYlBhZ2VD b21wb3NpdG9yIHRvIGJsZW5kIGEgdHJhbnNwYXJlbnQgd2ViIHBhZ2UKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IDIzMTE0MmU1YjY2ZTZiZDM5ZTA4YWZiMzA2 MzhkYjk1OWZmNDdlYWIuLmQ0YTlkYjFkY2UyYzg3MjA3NzQ4MDQyOTkwNGRmZTQ1NDRkM2I3OWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtNTUzLDcgKzU1 Myw3IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6Y29sbGVjdFN0eWxlRm9yQXR0cmlidXRlKGNv bnN0IEF0dHJpYnV0ZSYgYXR0cmlidXRlLCBTdHlsCiAgICAgfSBlbHNlIGlmIChhdHRyaWJ1dGUu bmFtZSgpID09IGJvcmRlckF0dHIgJiYgaXNJbWFnZUJ1dHRvbigpKQogICAgICAgICBhcHBseUJv cmRlckF0dHJpYnV0ZVRvU3R5bGUoYXR0cmlidXRlLCBzdHlsZSk7CiAgICAgZWxzZQotICAgICAg ICByZXR1cm4gSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OmNvbGxlY3RTdHlsZUZvckF0dHJp YnV0ZShhdHRyaWJ1dGUsIHN0eWxlKTsKKyAgICAgICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1l bnQ6OmNvbGxlY3RTdHlsZUZvckF0dHJpYnV0ZShhdHRyaWJ1dGUsIHN0eWxlKTsKIH0KIAogdm9p ZCBIVE1MSW5wdXRFbGVtZW50OjpwYXJzZUF0dHJpYnV0ZShjb25zdCBBdHRyaWJ1dGUmIGF0dHJp YnV0ZSkK 147364 2012-06-13 11:08:39 -0700 2012-06-13 14:59:15 -0700 Patch bug-88998-20120613140842.patch text/plain 1453 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAzMzM4NTliYzhlMTNk Y2U5NDRhZjEyOTQwZjllMGI0ZTA4Yzg3Ni4uYWM3OWVjNjMyNjE0Y2JhYjI4NjMxN2Q3NjIwNjMw YzJhODZhOTNhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA2LTEzICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJldHVybiBz dGF0ZW1lbnQgaW4gdm9pZCBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg4OTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu ZworCisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmNvbGxlY3RTdHlsZUZvckF0dHJpYnV0ZSk6CisKIDIwMTIt MDYtMDcgIEFydmlkIE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFj a0JlcnJ5XSBBbGxvdyBXZWJQYWdlQ29tcG9zaXRvciB0byBibGVuZCBhIHRyYW5zcGFyZW50IHdl YiBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCAyMzEx NDJlNWI2NmU2YmQzOWUwOGFmYjMwNjM4ZGI5NTlmZjQ3ZWFiLi5kNGE5ZGIxZGNlMmM4NzIwNzc0 ODA0Mjk5MDRkZmU0NTQ0ZDNiNzlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxl bWVudC5jcHAKQEAgLTU1Myw3ICs1NTMsNyBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OmNvbGxl Y3RTdHlsZUZvckF0dHJpYnV0ZShjb25zdCBBdHRyaWJ1dGUmIGF0dHJpYnV0ZSwgU3R5bAogICAg IH0gZWxzZSBpZiAoYXR0cmlidXRlLm5hbWUoKSA9PSBib3JkZXJBdHRyICYmIGlzSW1hZ2VCdXR0 b24oKSkKICAgICAgICAgYXBwbHlCb3JkZXJBdHRyaWJ1dGVUb1N0eWxlKGF0dHJpYnV0ZSwgc3R5 bGUpOwogICAgIGVsc2UKLSAgICAgICAgcmV0dXJuIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50 Ojpjb2xsZWN0U3R5bGVGb3JBdHRyaWJ1dGUoYXR0cmlidXRlLCBzdHlsZSk7CisgICAgICAgIEhU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojpjb2xsZWN0U3R5bGVGb3JBdHRyaWJ1dGUoYXR0cmli dXRlLCBzdHlsZSk7CiB9CiAKIHZvaWQgSFRNTElucHV0RWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUo Y29uc3QgQXR0cmlidXRlJiBhdHRyaWJ1dGUpCg==