88995 2012-06-13 07:22:24 -0700 check-webkit-style needs to respect Qt API coding style 2012-06-13 08:16:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zoltan zoltan abarth dpranke levin ojan webkit.review.bot oldest_to_newest 647985 0 zoltan 2012-06-13 07:22:24 -0700 Add -whitespace/declaration exception to Qt API files. In the comment of: https://bugs.webkit.org/show_bug.cgi?id=88785#c4 I got a false positive alarm for Source/WebKit/qt/Api/qwebframe.cpp:1767: Declaration has space between type name and * in QImage *pix [whitespace/declaration] [3] 647989 1 147311 zoltan 2012-06-13 07:24:07 -0700 Created attachment 147311 proposed patch 647993 2 147311 ossy 2012-06-13 07:31:09 -0700 Comment on attachment 147311 proposed patch rs=me 648040 3 147311 zoltan 2012-06-13 08:15:54 -0700 Comment on attachment 147311 proposed patch Clearing flags on attachment: 147311 Committed r120212: <http://trac.webkit.org/changeset/120212> 648041 4 zoltan 2012-06-13 08:16:04 -0700 All reviewed patches have been landed. Closing bug. 147311 2012-06-13 07:24:07 -0700 2012-06-13 08:15:54 -0700 proposed patch wkstyle.patch text/plain 1529 zoltan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4OWMw MGU0Li44MzJmYmU4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDYtMTMgIFpvbHRhbiBIb3J2YXRoICA8em9s dGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIG5lZWRzIHRvIHJl c3BlY3QgUXQgQVBJIGNvZGluZyBzdHlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODg5OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgLXdoaXRlc3BhY2UvZGVjbGFyYXRpb24gZXhjZXB0aW9uIHRv IFF0IEFQSSBmaWxlcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl ci5weToKKwogMjAxMi0wNi0xMyAgSm9lbCBEaWxsb24gIDxqb2VsLmRpbGxvbkBjb2RldGhpbmsu Y28udWs+CiAKICAgICAgICAgW1F0XVtXaW5dUXRUZXN0QnJvd3NlciBzb21laG93IHBpY2tzIHVw IER1bXBSZW5kZXJUcmVlJ3MgbWFpbi5jcHAsIGNhdXNpbmcgYSBmYWlsdXJlIHRvIGxpbmsKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQppbmRleCBjZDhmNTY1Li40ZDI5Njg0 IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CkBAIC0xNDAsMTEgKzE0 MCwxNyBAQCBfUEFUSF9SVUxFU19TUEVDSUZJRVIgPSBbCiAgICAgICAjIFF0IGNvZGUgdXNlcyAn XycgaW4gc29tZSBwbGFjZXMgKHN1Y2ggYXMgcHJpdmF0ZSBzbG90cwogICAgICAgIyBhbmQgb24g dGVzdCB4eHhfZGF0YSBtZXRob3Mgb24gdGVzdHMpCiAgICAgICAiU291cmNlL0phdmFTY3JpcHRD b3JlL3F0LyIsCi0gICAgICAiU291cmNlL1dlYktpdC9xdC9BcGkvIiwKICAgICAgICJTb3VyY2Uv V2ViS2l0L3F0L3Rlc3RzLyIsCiAgICAgICAiU291cmNlL1dlYktpdC9xdC9kZWNsYXJhdGl2ZS8i LAogICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvZXhhbXBsZXMvIl0sCiAgICAgIFsiLXJlYWRhYmls aXR5L25hbWluZyJdKSwKKworICAgIChbIyBUaGUgUXQgQVBJcyB1c2UgUXQgZGVjbGFyYXRpb24g c3R5bGUsIGl0IHB1dHMgdGhlICogdG8KKyAgICAgICMgdGhlIHZhcmlhYmxlIG5hbWUsIG5vdCB0 byB0aGUgY2xhc3MuCisgICAgICAiU291cmNlL1dlYktpdC9xdC9BcGkvIl0sCisgICAgIFsiLXJl YWRhYmlsaXR5L25hbWluZyIsCisgICAgICAiLXdoaXRlc3BhY2UvZGVjbGFyYXRpb24iXSksCisK ICAgICAgKFsjIFF0J3MgTWluaUJyb3dzZXIgaGFzIG5vIGNvbmZpZy5oCiAgICAgICAgIlRvb2xz L01pbmlCcm93c2VyL3F0Il0sCiAgICAgICBbIi1idWlsZC9pbmNsdWRlIl0pLAo=