88987 2012-06-13 04:28:10 -0700 [Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1 2012-06-13 08:29:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peter peter eric.carlson feature-media-reviews hans webkit.review.bot oldest_to_newest 647897 0 peter 2012-06-13 04:28:10 -0700 [Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1 647898 1 147288 peter 2012-06-13 04:29:52 -0700 Created attachment 147288 Patch 647928 2 hans 2012-06-13 05:26:56 -0700 Looks good to me. Note that this does not just "fix the Clang build". It also presumably makes the code work, because without the const qualifier, the function doesn't override anything, and won't get called. 648017 3 147288 hausmann 2012-06-13 08:01:49 -0700 Comment on attachment 147288 Patch r=me 648056 4 147288 webkit.review.bot 2012-06-13 08:29:53 -0700 Comment on attachment 147288 Patch Clearing flags on attachment: 147288 Committed r120213: <http://trac.webkit.org/changeset/120213> 648057 5 webkit.review.bot 2012-06-13 08:29:59 -0700 All reviewed patches have been landed. Closing bug. 147288 2012-06-13 04:29:52 -0700 2012-06-13 08:29:52 -0700 Patch bug-88987-20120613122951.patch text/plain 2389 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDMxN2M1ZTVkYzU4NTVhMDY5YzBjZTNhMGU2OWQ5ZjEzZTA3OGE2YmUuLmU1NzgyNjI5YjVjZTYz NjkyZTMyN2JmNTk4MjBkMThkNGIzNDQyNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMDYtMTMgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRml4IENsYW5nIGJ1aWxkIHdpdGggVVNFKE5B VElWRV9GVUxMU0NSRUVOX1ZJREVPKT0xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODk4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBlbnRlckZ1bGxzY3JlZW4gbWV0aG9kIGlzIGRlY2xhcmVkIGFz IGNvbnN0IGJ5IE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSwKKyAgICAgICAgc28gdGhpcyBv bmUgc2hvdWxkIGJlIGRlY2xhcmVkIGFzIHN1Y2ggYXMgd2VsbC4KKworICAgICAgICBQYXRjaCBi eSBFdmdlbml5IFN0ZXBhbm92IDxldWdlbmlzQGdvb2dsZS5jb20+CisKKyAgICAgICAgKiBzcmMv V2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTWVkaWFQ bGF5ZXJDbGllbnRJbXBsOjplbnRlckZ1bGxzY3JlZW4pOgorICAgICAgICAqIHNyYy9XZWJNZWRp YVBsYXllckNsaWVudEltcGwuaDoKKyAgICAgICAgKFdlYk1lZGlhUGxheWVyQ2xpZW50SW1wbCk6 CisKIDIwMTItMDYtMTMgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAg ICAgICAgUkVHUkVTU0lPTihyMTE4MDk4KTogPGNvbnRlbnQ+IGVsZW1lbnQgZG9lcyBub3QgcmVu ZGVyIGRpc3RyaWJ1dGVkIGNoaWxkcmVuIHdoZW4gY2xvbmVkIGZyb20gYW5vdGhlciBkb2N1bWVu dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJD bGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhUGxheWVy Q2xpZW50SW1wbC5jcHAKaW5kZXggOTUxODZkZDg2OTI0OGMwMzU2MWI1MjM4ZTIxNTNlMDY2NDg4 M2QyNS4uOTE2ZWZiNTdkZGEzMDg1ZThmYTcwMjFhOTJiMjZiNzI4MzdhODFmYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudElt cGwuY3BwCkBAIC0zNzAsNyArMzcwLDcgQEAgdm9pZCBXZWJNZWRpYVBsYXllckNsaWVudEltcGw6 OnBhdXNlKCkKIH0KIAogI2lmIFVTRShOQVRJVkVfRlVMTFNDUkVFTl9WSURFTykKLXZvaWQgV2Vi TWVkaWFQbGF5ZXJDbGllbnRJbXBsOjplbnRlckZ1bGxzY3JlZW4oKQordm9pZCBXZWJNZWRpYVBs YXllckNsaWVudEltcGw6OmVudGVyRnVsbHNjcmVlbigpIGNvbnN0CiB7CiAgICAgaWYgKG1fd2Vi TWVkaWFQbGF5ZXIpCiAgICAgICAgIG1fd2ViTWVkaWFQbGF5ZXItPmVudGVyRnVsbHNjcmVlbigp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJD bGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNs aWVudEltcGwuaAppbmRleCA1M2EyNGQ2NjYyMDU4MWJmM2ExYzI2MjBmZDIyOTFjZmMzY2Y2OTZj Li5kZWFjZmFjMTVmNDNhOTAyZjE3OTQ3OGI3NWNlNTJlZDgzOWQwMmU5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuaApA QCAtMTM5LDcgKzEzOSw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHVuc2lnbmVkIGF1ZGlvRGVj b2RlZEJ5dGVDb3VudCgpIGNvbnN0OwogICAgIHZpcnR1YWwgdW5zaWduZWQgdmlkZW9EZWNvZGVk Qnl0ZUNvdW50KCkgY29uc3Q7CiAjaWYgVVNFKE5BVElWRV9GVUxMU0NSRUVOX1ZJREVPKQotICAg IHZpcnR1YWwgdm9pZCBlbnRlckZ1bGxzY3JlZW4oKTsKKyAgICB2aXJ0dWFsIHZvaWQgZW50ZXJG dWxsc2NyZWVuKCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIGV4aXRGdWxsc2NyZWVuKCk7CiAg ICAgdmlydHVhbCBib29sIGNhbkVudGVyRnVsbHNjcmVlbigpIGNvbnN0OwogI2VuZGlmCg==