88963 2012-06-12 22:58:51 -0700 [Qt] New css3/flexbox/flexitem.html fails 2014-02-03 03:21:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID Qt, QtTriaged P2 Normal --- 87008 87068 1 ossy tony ojan ossy tony oldest_to_newest 647713 0 ossy 2012-06-12 22:58:51 -0700 css3/flexbox/flexitem.html introduced in http://trac.webkit.org/changeset/120132 and fails on Qt: --- /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/css3/flexbox/flexitem-expected.txt +++ /home/webkitbuildbot/slaves/release32bit-qt5/buildslave/qt-linux-32-release-qt5/build/layout-test-results/css3/flexbox/flexitem-actual.txt @@ -2,7 +2,24 @@ object -PASS +FAIL: +Expected 100 for width, but got 95. +Expected 100 for width, but got 95. +Expected 100 for width, but got 95. +Expected 100 for width, but got 95. +Expected 100 for width, but got 123. +Expected 100 for width, but got 95. + +<div class="flexbox"> + <button data-expected-display="block" data-expected-width="100">button</button> + <canvas data-expected-display="block" data-expected-width="100">canvas</canvas> + <iframe data-expected-display="block" data-expected-width="100" src="data:text/html,<body bgcolor=#fff>iframe</body>"></iframe> + <object data-expected-display="block" data-expected-width="100">object</object> + <select data-expected-display="block" data-expected-width="100"> + <option>select</option> + </select> + <textarea data-expected-display="block" data-expected-width="100">textarea</textarea> +</div> PASS @@ -17,7 +34,7 @@ FAIL: Expected 100 for height, but got 20. -Expected 100 for height, but got 20. +Expected 100 for height, but got 21. <div class="flexbox"> <img data-expected-display="block" data-expected-width="200" style="-webkit-flex: 1 0 auto;" src="../images/resources/blue-100.png"> 647718 1 ossy 2012-06-12 23:01:56 -0700 I skipped it to paint the bot green - r120163. Please unskip it with the proper fix. 648343 2 tony 2012-06-13 12:16:53 -0700 I investigated this failure. This is because in WebKitQt, the padding on <select>s (MenuLists) are hard coded. This happens in Source/WebKit/qt/WebCoreSupport/RenderThemeQStyle.cpp in RenderThemeQStyle::setPopupPadding. The test tries to set the padding to 0, but it doesn't stick. I think the bug is that the user can't set padding on <select>s. The second failure must be the alt text being taller than 20px. I can fix that. 648344 3 tony 2012-06-13 12:17:48 -0700 Oh, if it's intentional that setting padding on a <select> does nothing, then we could just rebaseline for Qt. 648350 4 147386 tony 2012-06-13 12:20:51 -0700 Created attachment 147386 Patch 649242 5 tony 2012-06-14 09:44:33 -0700 Committed r120330: <http://trac.webkit.org/changeset/120330> 649244 6 tony 2012-06-14 09:46:14 -0700 (In reply to comment #5) > Committed r120330: <http://trac.webkit.org/changeset/120330> @@ -17,7 +34,7 @@ FAIL: Expected 100 for height, but got 20. -Expected 100 for height, but got 20. +Expected 100 for height, but got 21. Should now be fixed. I need guidance from Qt on whether it's a bug that you can't set padding on <select>s or if we should check in a Qt specific baseline. 975477 7 jturcotte 2014-02-03 03:21:13 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 147386 2012-06-13 12:20:51 -0700 2012-06-14 02:15:57 -0700 Patch bug-88963-20120613122052.patch text/plain 1299 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMTM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggM2U0ZmJjNGM1ODkzYmZhOTQ0OTlj MjU4YWEyZTU0OTMwZTRiZjJjZS4uMGUzZWU5Njg0NWM1ODQ1MWIxNjdlOWE3Zjk0NTg5N2QxNWJm MzJkMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTEzICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1F0XSBOZXcgY3NzMy9mbGV4Ym94L2ZsZXhpdGVt Lmh0bWwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4OTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBjc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRtbDogVGhlIGhlaWdodCBvZiB0aGUgYWx0IHRl eHQgd2FzIHRhbGxlcgorICAgICAgICB0aGFuIHRoZSBoZWlnaHQgb2YgdGhlIG1pc3NpbmcgaW1h Z2UgcGxhY2Vob2xkZXIgZ3JhcGhpYyBvbiBRdC4gVG8KKyAgICAgICAgZ2V0IHRoZSBzYW1lIHJl c3VsdHMsIGZvcmNlIHRoZSBmb250IHNpemUgdG8gc29tZXRoaW5nIHNtYWxsLgorICAgICAgICBU aGUgdGVzdCBzdGlsbCBmYWlscyBvbiBRdCBzbyBsZWF2aW5nIGl0IGluIHRoZSBTa2lwcGVkIGZp bGUgZm9yIG5vdy4KKwogMjAxMi0wNi0xMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIERGRyBzaG91bGQgbm90IEFTU0VSVCBpZiB5b3UgaGF2ZSBhIGRvdWJsZSB1 c2Ugb2YgYSB2YXJpYWJsZSB0aGF0IGlzIG5vdCByZXZlYWxlZCB0byBiZSBhIGRvdWJsZQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXhpdGVtLmh0bWwgYi9MYXlvdXRU ZXN0cy9jc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRtbAppbmRleCAxZjU2NzAwMDgxYWNhMTJiMGRl ZDBhNTYwNzAyMTM2ZDM3ZjUyNDQwLi42MTM3OGEwYWY1YWZhNGIyNGFhZDBjOTBlM2ZiZDQ2YzQz NjI5MjVlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRt bAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZsZXhib3gvZmxleGl0ZW0uaHRtbApAQCAtMTMsNiAr MTMsNyBAQAogICAgIG1hcmdpbjogMDsKICAgICBib3JkZXI6IDA7CiAgICAgcGFkZGluZzogMDsK KyAgICBmb250LXNpemU6IDEycHg7CiB9CiA8L3N0eWxlPgogPHNjcmlwdD4K