<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>88950</bug_id>
          
          <creation_ts>2012-06-12 20:01:47 -0700</creation_ts>
          <short_desc>[Blackberry] add a new Api named setAllowNotification</short_desc>
          <delta_ts>2012-06-14 02:33:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Chris.Guan">logingx</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>647625</commentid>
    <comment_count>0</comment_count>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-12 20:01:47 -0700</bug_when>
    <thetext>I would like to add a new API named setAllowNotification in webpage to let client set those allowed domains in notifications.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>647719</commentid>
    <comment_count>1</comment_count>
      <attachid>147240</attachid>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-12 23:08:59 -0700</bug_when>
    <thetext>Created attachment 147240
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>647795</commentid>
    <comment_count>2</comment_count>
      <attachid>147257</attachid>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 01:12:46 -0700</bug_when>
    <thetext>Created attachment 147257
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648005</commentid>
    <comment_count>3</comment_count>
      <attachid>147257</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-06-13 07:46:13 -0700</bug_when>
    <thetext>Comment on attachment 147257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147257&amp;action=review

It looks good. I wonder if it fits better to WebSettings instead of WebPage. What you you think?

&gt; Source/WebKit/blackberry/Api/WebPage.cpp:6346
&gt; +void WebPage::setAllowNotification(const WebString&amp; domain, bool allow)

I think you need UNUSED_PARAM for &apos;domain&apos; and &apos;allow&apos; in an #else block</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648012</commentid>
    <comment_count>4</comment_count>
      <attachid>147257</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-06-13 07:58:10 -0700</bug_when>
    <thetext>Comment on attachment 147257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147257&amp;action=review

&gt; Source/WebKit/blackberry/ChangeLog:9
&gt; +        Add a new API named setAllowNotification in webpage class to
&gt; +        let client set those allowed domains into notifications.

could you tell more about the use cases?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648014</commentid>
    <comment_count>5</comment_count>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 08:00:24 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 147257 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=147257&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/blackberry/ChangeLog:9
&gt; &gt; +        Add a new API named setAllowNotification in webpage class to
&gt; &gt; +        let client set those allowed domains into notifications.
&gt; 
&gt; could you tell more about the use cases?

Antonio, Thanks, please see PR #141125 for more.:)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648016</commentid>
    <comment_count>6</comment_count>
      <attachid>147257</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-06-13 08:00:58 -0700</bug_when>
    <thetext>Comment on attachment 147257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147257&amp;action=review

&gt; Source/WebKit/blackberry/Api/WebPage.cpp:6349
&gt; +    static_cast&lt;NotificationPresenterImpl*&gt;(NotificationPresenterImpl::instance())-&gt;onPermission(domain.utf8(), allow);

Since this is a singleton, is it a problem that a new page will &quot;inherit&quot; this?

&gt; Source/WebKit/blackberry/Api/WebPage.h:269
&gt; +    void setAllowNotification(const WebString&amp; domain, bool allow);

Would it make sense for the whole method to be wrapped in #if ENABLE(NOTIFICATIONS) ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648028</commentid>
    <comment_count>7</comment_count>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 08:08:31 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 147257 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=147257&amp;action=review
&gt; 
&gt; It looks good. I wonder if it fits better to WebSettings instead of WebPage. What you you think?
&gt; 
&gt; &gt; Source/WebKit/blackberry/Api/WebPage.cpp:6346
&gt; &gt; +void WebPage::setAllowNotification(const WebString&amp; domain, bool allow)
&gt; 
&gt; I think you need UNUSED_PARAM for &apos;domain&apos; and &apos;allow&apos; in an #else block


yes, UNUSED_PARAM is good, :)  I am thinking refactor notification, because upstream code has changed a lot since we started implementing notification, I feel notificationClient is a better candidate class by which QT port is using.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648032</commentid>
    <comment_count>8</comment_count>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 08:12:38 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 147257 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=147257&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/blackberry/Api/WebPage.cpp:6349
&gt; &gt; +    static_cast&lt;NotificationPresenterImpl*&gt;(NotificationPresenterImpl::instance())-&gt;onPermission(domain.utf8(), allow);
&gt; 
&gt; Since this is a singleton, is it a problem that a new page will &quot;inherit&quot; this?
I am thinking refactor our notification implementation.
&gt; 
&gt; &gt; Source/WebKit/blackberry/Api/WebPage.h:269
&gt; &gt; +    void setAllowNotification(const WebString&amp; domain, bool allow);
&gt; 
&gt; Would it make sense for the whole method to be wrapped in #if ENABLE(NOTIFICATIONS) ?

Both are okay to me, I was searching other ports, I remember that I kept the same with it, Mac or QT probably(not sure) :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648033</commentid>
    <comment_count>9</comment_count>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 08:13:51 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 147257 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=147257&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/blackberry/ChangeLog:9
&gt; &gt; +        Add a new API named setAllowNotification in webpage class to
&gt; &gt; +        let client set those allowed domains into notifications.
&gt; 
&gt; could you tell more about the use cases?

this is very similar with Geoloaction.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648064</commentid>
    <comment_count>10</comment_count>
      <attachid>147257</attachid>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 08:36:02 -0700</bug_when>
    <thetext>Comment on attachment 147257
Patch

I will make a new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648699</commentid>
    <comment_count>11</comment_count>
      <attachid>147468</attachid>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 19:28:19 -0700</bug_when>
    <thetext>Created attachment 147468
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648706</commentid>
    <comment_count>12</comment_count>
      <attachid>147468</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-06-13 19:39:09 -0700</bug_when>
    <thetext>Comment on attachment 147468
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=147468&amp;action=review

&gt; Source/WebKit/blackberry/Api/WebPage.cpp:6358
&gt; +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
&gt; +void WebPage::setAllowNotification(const WebString&amp; domain, bool allow)
&gt; +{
&gt; +    static_cast&lt;NotificationPresenterImpl*&gt;(NotificationPresenterImpl::instance())-&gt;onPermission(domain.utf8(), allow);
&gt; +}
&gt; +#endif

I am not sure I like the whole method being wrapped by #if. If you disable it, how will the client side build? the #if macro is not visible outside webkit.

&gt; Source/WebKit/blackberry/Api/WebPage.h:270
&gt;  
&gt; +    void setAllowNotification(const WebString&amp; domain, bool allow);
&gt; +

you did not wrap the method in the header.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648714</commentid>
    <comment_count>13</comment_count>
      <attachid>147469</attachid>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 19:54:36 -0700</bug_when>
    <thetext>Created attachment 147469
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648715</commentid>
    <comment_count>14</comment_count>
    <who name="Chris.Guan">logingx</who>
    <bug_when>2012-06-13 19:57:46 -0700</bug_when>
    <thetext>(In reply to comment #12)
&gt; (From update of attachment 147468 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=147468&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/blackberry/Api/WebPage.cpp:6358
&gt; &gt; +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
&gt; &gt; +void WebPage::setAllowNotification(const WebString&amp; domain, bool allow)
&gt; &gt; +{
&gt; &gt; +    static_cast&lt;NotificationPresenterImpl*&gt;(NotificationPresenterImpl::instance())-&gt;onPermission(domain.utf8(), allow);
&gt; &gt; +}
&gt; &gt; +#endif
&gt; 
&gt; I am not sure I like the whole method being wrapped by #if. If you disable it, how will the client side build? the #if macro is not visible outside webkit.
&gt; 
&gt; &gt; Source/WebKit/blackberry/Api/WebPage.h:270
&gt; &gt;  
&gt; &gt; +    void setAllowNotification(const WebString&amp; domain, bool allow);
&gt; &gt; +
&gt; 
&gt; you did not wrap the method in the header.
we can not wrap this method in header file, because libwebview build fails because it does not know the macro of &quot;ENABLE&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648994</commentid>
    <comment_count>15</comment_count>
      <attachid>147469</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-14 02:32:55 -0700</bug_when>
    <thetext>Comment on attachment 147469
Patch

Clearing flags on attachment: 147469

Committed r120300: &lt;http://trac.webkit.org/changeset/120300&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>648996</commentid>
    <comment_count>16</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-14 02:33:07 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>147240</attachid>
            <date>2012-06-12 23:08:59 -0700</date>
            <delta_ts>2012-06-13 01:12:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88950-20120613140851.patch</filename>
            <type>text/plain</type>
            <size>2246</size>
            <attacher name="Chris.Guan">logingx</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp
bmRleCBhNTIxOWE3N2UyYzNiY2ZmMGFlNDY5NjE2YTMzZGQwNDhkMWQ5NGVlLi43ODhkNTRlMTc4
NDc1YTRiN2U4NGI1MGM5Yjk0Y2JiYjg5MDQwOGMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNi0xMiAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1
YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBhZGQgYSBuZXcg
QXBpIG5hbWVkIHNldEFsbG93Tm90aWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5ldyBBUEkgbmFtZWQgc2V0QWxsb3dOb3RpZmlj
YXRpb24gaW4gd2VicGFnZSBjbGFzcyB0bworICAgICAgICBsZXQgY2xpZW50IHNldCB0aG9zZSBh
bGxvd2VkIGRvbWFpbnMgaW50byBub3RpZmljYXRpb25zLgorCisgICAgICAgICogQXBpL1dlYlBh
Z2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpzZXRBbGxvd05v
dGlmaWNhdGlvbik6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6
CisKIDIwMTItMDYtMTIgIEFydmlkIE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAg
ICAgIFtCbGFja0JlcnJ5XSBDcmFzaCB3aGVuIHJlbmRlcmluZyB3ZWIgcGFnZSB0aGF0J3MgYmVp
bmcgZGVzdHJveWVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl
YlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRl
eCA5Mjg3Y2IzZTYzOGVlNjlkZDg5YTI4MGFkNGU1M2FhYWI3MjM0NTJmLi41MmFlMWMzY2VmZjNj
MTY4M2E1Yzc4ZWE5ODY2MjIzYjdkMmM3NmU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B
cGkvV2ViUGFnZS5jcHAKQEAgLTYzNDMsNiArNjM0MywxMyBAQCBXZWJTdHJpbmcgV2ViUGFnZTo6
dGV4dEhhc0F0dHJpYnV0ZShjb25zdCBXZWJTdHJpbmcmIHF1ZXJ5KSBjb25zdAogICAgIHJldHVy
biAiIjsKIH0KIAordm9pZCBXZWJQYWdlOjpzZXRBbGxvd05vdGlmaWNhdGlvbihjb25zdCBXZWJT
dHJpbmcmIGRvbWFpbiwgYm9vbCBhbGxvdykKK3sKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykK
KyAgICBzdGF0aWNfY2FzdDxOb3RpZmljYXRpb25QcmVzZW50ZXJJbXBsKj4oTm90aWZpY2F0aW9u
UHJlc2VudGVySW1wbDo6aW5zdGFuY2UoKSktPm9uUGVybWlzc2lvbihkb21haW4udXRmOCgpLCBh
bGxvdyk7CisjZW5kaWYKK30KKwogdm9pZCBXZWJQYWdlOjpzZXRKYXZhU2NyaXB0Q2FuQWNjZXNz
Q2xpcGJvYXJkKGJvb2wgZW5hYmxlZCkKIHsKICAgICBkLT5tX3BhZ2UtPnNldHRpbmdzKCktPnNl
dEphdmFTY3JpcHRDYW5BY2Nlc3NDbGlwYm9hcmQoZW5hYmxlZCk7CmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti
ZXJyeS9BcGkvV2ViUGFnZS5oCmluZGV4IGJjZjM4N2Y0Mzk4ZGU0YTE0YmU5MjNhN2UyMTVhNWNi
ZWRjNzM4NjMuLjhhMDM3ZGRlMTY4YTgzYjY2ZThhNjM5MWIzOWZiMDVmMTY2MjdhNjggMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oCisrKyBiL1NvdXJj
ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oCkBAIC0yNjYsNiArMjY2LDggQEAgcHVi
bGljOgogCiAgICAgV2ViU3RyaW5nIHRleHRIYXNBdHRyaWJ1dGUoY29uc3QgV2ViU3RyaW5nJiBx
dWVyeSkgY29uc3Q7CiAKKyAgICB2b2lkIHNldEFsbG93Tm90aWZpY2F0aW9uKGNvbnN0IFdlYlN0
cmluZyYgZG9tYWluLCBib29sIGFsbG93KTsKKwogICAgIFBsYXRmb3JtOjpXZWJDb250ZXh0IHdl
YkNvbnRleHQoVGFyZ2V0RGV0ZWN0aW9uU3RyYXRlZ3kpIGNvbnN0OwogCiAgICAgdHlwZWRlZiBp
bnRwdHJfdCBCYWNrRm9yd2FyZElkOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>147257</attachid>
            <date>2012-06-13 01:12:46 -0700</date>
            <delta_ts>2012-06-13 08:36:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88950-20120613161241.patch</filename>
            <type>text/plain</type>
            <size>2278</size>
            <attacher name="Chris.Guan">logingx</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp
bmRleCBhNTIxOWE3N2UyYzNiY2ZmMGFlNDY5NjE2YTMzZGQwNDhkMWQ5NGVlLi43ODhkNTRlMTc4
NDc1YTRiN2U4NGI1MGM5Yjk0Y2JiYjg5MDQwOGMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNi0xMiAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1
YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBhZGQgYSBuZXcg
QXBpIG5hbWVkIHNldEFsbG93Tm90aWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5ldyBBUEkgbmFtZWQgc2V0QWxsb3dOb3RpZmlj
YXRpb24gaW4gd2VicGFnZSBjbGFzcyB0bworICAgICAgICBsZXQgY2xpZW50IHNldCB0aG9zZSBh
bGxvd2VkIGRvbWFpbnMgaW50byBub3RpZmljYXRpb25zLgorCisgICAgICAgICogQXBpL1dlYlBh
Z2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpzZXRBbGxvd05v
dGlmaWNhdGlvbik6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6
CisKIDIwMTItMDYtMTIgIEFydmlkIE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAg
ICAgIFtCbGFja0JlcnJ5XSBDcmFzaCB3aGVuIHJlbmRlcmluZyB3ZWIgcGFnZSB0aGF0J3MgYmVp
bmcgZGVzdHJveWVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl
YlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRl
eCA5Mjg3Y2IzZTYzOGVlNjlkZDg5YTI4MGFkNGU1M2FhYWI3MjM0NTJmLi4wNDc2MzNlYmZiOWNh
Y2IzNjU3YWYwOGU0NDdlODVkMjEwZGI1MDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B
cGkvV2ViUGFnZS5jcHAKQEAgLTYzNDMsNiArNjM0MywxMyBAQCBXZWJTdHJpbmcgV2ViUGFnZTo6
dGV4dEhhc0F0dHJpYnV0ZShjb25zdCBXZWJTdHJpbmcmIHF1ZXJ5KSBjb25zdAogICAgIHJldHVy
biAiIjsKIH0KIAordm9pZCBXZWJQYWdlOjpzZXRBbGxvd05vdGlmaWNhdGlvbihjb25zdCBXZWJT
dHJpbmcmIGRvbWFpbiwgYm9vbCBhbGxvdykKK3sKKyNpZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykg
fHwgRU5BQkxFKExFR0FDWV9OT1RJRklDQVRJT05TKQorICAgIHN0YXRpY19jYXN0PE5vdGlmaWNh
dGlvblByZXNlbnRlckltcGwqPihOb3RpZmljYXRpb25QcmVzZW50ZXJJbXBsOjppbnN0YW5jZSgp
KS0+b25QZXJtaXNzaW9uKGRvbWFpbi51dGY4KCksIGFsbG93KTsKKyNlbmRpZgorfQorCiB2b2lk
IFdlYlBhZ2U6OnNldEphdmFTY3JpcHRDYW5BY2Nlc3NDbGlwYm9hcmQoYm9vbCBlbmFibGVkKQog
ewogICAgIGQtPm1fcGFnZS0+c2V0dGluZ3MoKS0+c2V0SmF2YVNjcmlwdENhbkFjY2Vzc0NsaXBi
b2FyZChlbmFibGVkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv
V2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXgg
YmNmMzg3ZjQzOThkZTRhMTRiZTkyM2E3ZTIxNWE1Y2JlZGM3Mzg2My4uOGEwMzdkZGUxNjhhODNi
NjZlOGE2MzkxYjM5ZmIwNWYxNjYyN2E2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFj
a2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X
ZWJQYWdlLmgKQEAgLTI2Niw2ICsyNjYsOCBAQCBwdWJsaWM6CiAKICAgICBXZWJTdHJpbmcgdGV4
dEhhc0F0dHJpYnV0ZShjb25zdCBXZWJTdHJpbmcmIHF1ZXJ5KSBjb25zdDsKIAorICAgIHZvaWQg
c2V0QWxsb3dOb3RpZmljYXRpb24oY29uc3QgV2ViU3RyaW5nJiBkb21haW4sIGJvb2wgYWxsb3cp
OworCiAgICAgUGxhdGZvcm06OldlYkNvbnRleHQgd2ViQ29udGV4dChUYXJnZXREZXRlY3Rpb25T
dHJhdGVneSkgY29uc3Q7CiAKICAgICB0eXBlZGVmIGludHB0cl90IEJhY2tGb3J3YXJkSWQ7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>147468</attachid>
            <date>2012-06-13 19:28:19 -0700</date>
            <delta_ts>2012-06-13 19:54:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88950-20120614102812.patch</filename>
            <type>text/plain</type>
            <size>5430</size>
            <attacher name="Chris.Guan">logingx</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp
bmRleCA4Mzk1ODkzNmM4MjIwZjc5ZGQ4MjMxNGNkNTYwYTE1MDU3ZTczNWUxLi41NjYwOGQ5M2Iz
MmRlYzgzNTY2NWRhMDJhZDk3NDA0YTM5Y2VlMDYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNi0xMyAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1
YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBhZGQgYSBuZXcg
QXBpIG5hbWVkIHNldEFsbG93Tm90aWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0
KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6c2V0QWxsb3dOb3RpZmlj
YXRpb24pOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisKIDIwMTItMDYtMTMgIEFteSBPdXN0
ZXJob3V0ICA8YW91c3RlcmhAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbmFtZSBjdXJyZW50
RGV2aWNlTW90aW9uIHRvIGxhc3RNb3Rpb24gaW4gRGV2aWNlTW90aW9uQ2xpZW50CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl
YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCBlYmNhOGY3NWZjNzM3NDRkOGJi
YWI1YTM2ZjYxMmQxZWQ0ZjFiNDdmLi41MTBmYTBhMzM1ZGU4YWExYzA2YWQ5NTJjNTQyNDMzZWU1
ZDgyYThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2Uu
Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTYz
NTAsNiArNjM1MCwxMyBAQCBXZWJTdHJpbmcgV2ViUGFnZTo6dGV4dEhhc0F0dHJpYnV0ZShjb25z
dCBXZWJTdHJpbmcmIHF1ZXJ5KSBjb25zdAogICAgIHJldHVybiAiIjsKIH0KIAorI2lmIEVOQUJM
RShOT1RJRklDQVRJT05TKSB8fCBFTkFCTEUoTEVHQUNZX05PVElGSUNBVElPTlMpCit2b2lkIFdl
YlBhZ2U6OnNldEFsbG93Tm90aWZpY2F0aW9uKGNvbnN0IFdlYlN0cmluZyYgZG9tYWluLCBib29s
IGFsbG93KQoreworICAgIHN0YXRpY19jYXN0PE5vdGlmaWNhdGlvblByZXNlbnRlckltcGwqPihO
b3RpZmljYXRpb25QcmVzZW50ZXJJbXBsOjppbnN0YW5jZSgpKS0+b25QZXJtaXNzaW9uKGRvbWFp
bi51dGY4KCksIGFsbG93KTsKK30KKyNlbmRpZgorCiB2b2lkIFdlYlBhZ2U6OnNldEphdmFTY3Jp
cHRDYW5BY2Nlc3NDbGlwYm9hcmQoYm9vbCBlbmFibGVkKQogewogICAgIGQtPm1fcGFnZS0+c2V0
dGluZ3MoKS0+c2V0SmF2YVNjcmlwdENhbkFjY2Vzc0NsaXBib2FyZChlbmFibGVkKTsKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291cmNlL1dl
YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXggYmNmMzg3ZjQzOThkZTRhMTRiZTky
M2E3ZTIxNWE1Y2JlZGM3Mzg2My4uOGEwMzdkZGUxNjhhODNiNjZlOGE2MzkxYjM5ZmIwNWYxNjYy
N2E2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgK
KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTI2Niw2ICsy
NjYsOCBAQCBwdWJsaWM6CiAKICAgICBXZWJTdHJpbmcgdGV4dEhhc0F0dHJpYnV0ZShjb25zdCBX
ZWJTdHJpbmcmIHF1ZXJ5KSBjb25zdDsKIAorICAgIHZvaWQgc2V0QWxsb3dOb3RpZmljYXRpb24o
Y29uc3QgV2ViU3RyaW5nJiBkb21haW4sIGJvb2wgYWxsb3cpOworCiAgICAgUGxhdGZvcm06Oldl
YkNvbnRleHQgd2ViQ29udGV4dChUYXJnZXREZXRlY3Rpb25TdHJhdGVneSkgY29uc3Q7CiAKICAg
ICB0eXBlZGVmIGludHB0cl90IEJhY2tGb3J3YXJkSWQ7CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg
Yi9DaGFuZ2VMb2cKaW5kZXggMWMyYWQxMWVjM2UwMjQyMmYxZDRmYTUxNjJiYTAyYTYxMDgwNGRl
ZC4uYTQ3YjgxMDkwOWI2MmRjMzE1ZWY4ZTEwZWViMzcwZjU1MzBmNjFlOSAxMDA2NDQKLS0tIGEv
Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTEzICBD
aHJpcyBHdWFuICA8Y2hyaXMuZ3VhbkB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0Js
YWNrYmVycnldIGFkZCBhIG5ldyBBcGkgbmFtZWQgc2V0QWxsb3dOb3RpZmljYXRpb24KKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4OTUwCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IEFQSSBu
YW1lZCBzZXRBbGxvd05vdGlmaWNhdGlvbiBpbiB3ZWJwYWdlIGNsYXNzIHRvCisgICAgICAgIGxl
dCBjbGllbnQgc2V0IHRob3NlIGFsbG93ZWQgZG9tYWlucyBpbnRvIG5vdGlmaWNhdGlvbnMuCisK
KyAgICAgICAgVGVzdCBjYXNlOgorICAgICAgICAqIE1hbnVhbFRlc3RzL2JsYWNrYmVycnkvbm90
aWZpY2F0aW9uLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA2LTEzICBaYW4gRG9iZXJzZWsgIDx6YW5k
b2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgW0d0a10gRW5hYmxlIGxpbmsgcHJlZmV0Y2gg
c3VwcG9ydCBpbiB0aGUgZGV2ZWxvcGVyIGJ1aWxkcwpkaWZmIC0tZ2l0IGEvTWFudWFsVGVzdHMv
YmxhY2tiZXJyeS9ub3RpZmljYXRpb24uaHRtbCBiL01hbnVhbFRlc3RzL2JsYWNrYmVycnkvbm90
aWZpY2F0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2YyMmQ3YTI5OWYyMmMzYmZmN2M0ZWVlNWFmNzA5
OGFmMWEzNzI5MwotLS0gL2Rldi9udWxsCisrKyBiL01hbnVhbFRlc3RzL2JsYWNrYmVycnkvbm90
aWZpY2F0aW9uLmh0bWwKQEAgLTAsMCArMSw1MyBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQg
dHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK3ZhciBuOworZnVuY3Rpb24gc2V0Tm90aWZpY2F0aW9u
KCkKK3sKKyAgICBpZiAod2luZG93LndlYmtpdE5vdGlmaWNhdGlvbnMuY2hlY2tQZXJtaXNzaW9u
KCkgIT0gMCkgeworICAgICAgICBhbGVydCgieW91IGRvbid0IGhhdmUgcGVybWlzc2lvbiB0byBw
b3N0IG5vdGlmaWNhdGlvbnMsIHBsZWFzZSBhbGxvdyBub3RpZmljYXRpb25zIGJ5IGNsaWNraW5n
IHRoYXQgbGluayIpOworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYWxsb3dOb3Rp
ZmljYXRpb25MaW5rJykuc3R5bGUuYmFja2dyb3VuZENvbG9yID0gJ1JlZCc7CisgICAgICAgIHJl
dHVybiAwOworICAgIH0KKyAgICBuID0gd2luZG93LndlYmtpdE5vdGlmaWNhdGlvbnMuY3JlYXRl
Tm90aWZpY2F0aW9uKHdpbmRvdy5sb2NhdGlvbi5ocmVmICsgJy9mYXZpY29uLmljbycsICdOb3Rp
ZnkgbWUnLCAnVGhpcyBpcyB0aGUgbm90aWZpY2F0aW9uIGJvZHknKTsKKyAgICBsb2cgPSBkb2N1
bWVudC5nZXRFbGVtZW50QnlJZCgicGxhY2UiKTsKKyAgICBuLm9uc2hvdyA9IGZ1bmN0aW9uKCkg
IHsgbG9nLmlubmVyVGV4dCA9ICJub3RpZmljYXRpb24gc2hvd2luZyI7IH0KKyAgICBuLm9uY2xp
Y2sgPSBmdW5jdGlvbigpIHsgbG9nLmlubmVyVGV4dCA9ICJub3RpZmljYXRpb24gY2xpY2tlZCI7
IH0KKyAgICBuLm9uZXJyb3IgPSBmdW5jdGlvbigpIHsgbG9nLmlubmVyVGV4dCA9ICJub3RpZmlj
YXRpb24gZXJyb3IiOyB9CisgICAgbi5vbmNsb3NlID0gZnVuY3Rpb24oKSB7IGxvZy5pbm5lclRl
eHQgPSAibm90aWZpY2F0aW9uIGNsb3NlZCI7IH0KKyAgICBuLnNob3coKTsKKyAgICBsb2cuaW5u
ZXJUZXh0ID0gIkRpZCB5b3Ugbm90aWNlIHRoZSBub3RpZmljYXRpb24gPyBUaGVyZSBhcmUgMyB3
YXlzIHRoZSBub3RpZmljYXRpb24gd2lsbCBnbyBhd2F5OlxuIDEuIEl0IGF1dG9taWNhbGx5IGdv
ZXMgYXdheSBpbiAzMCBzZWNvbmRzO1xuIDIuIHlvdSBjYW4gY2xpY2sgdGhlIGNsb3NlIGJ1dHRv
biBvbiB0aGUgbm90aWZpY2F0aW9uIHRvIGNsb3NlIGl0O1xuIDMuIENsaWNrIGFib3ZlIGxpbmsg
J0NsaWNrIHRvIGNhbmNlbCB0aGUgbm90aWZpY2F0aW9uLlxuXG4gUGxlYXNlIHZlcmlmeSBhbGwg
d29yazsgV2hlbmV2ZXIgdGhlIGljb24gaXMgY2xpY2tlZCwgY2FuY2VsbGVkLCBjbG9zZWQsIGV0
Yy4gdGhlcmUgd2lsbCBiZSBjb3JyZXNwb25kaW5nIGxvZyBpcyB0aGlzIGFyZWEsIHBsZWFzZSBu
b3RpY2UgaWYgdGhleSBzaG93IHVwLiI7CisKKyAgICBzZXRUaW1lb3V0KHRpbWVvdXQsIDMwMDAw
KTsKKyAgICBmdW5jdGlvbiB0aW1lb3V0KCkgeworICAgICAgICBuLmNhbmNlbCgpOworICAgIH0K
K30KKworZnVuY3Rpb24gc2V0QWxsb3dOb3RpZmljYXRpb24oKQoreworICAgIHdpbmRvdy53ZWJr
aXROb3RpZmljYXRpb25zLnJlcXVlc3RQZXJtaXNzaW9uKHBlcm1pc3Npb25HcmFudGVkKTsKK30K
KworZnVuY3Rpb24gcGVybWlzc2lvbkdyYW50ZWQoKQoreworICAgIGlmICh3aW5kb3cud2Via2l0
Tm90aWZpY2F0aW9ucy5jaGVja1Blcm1pc3Npb24oKSA9PSAwKQorICAgICAgICBhbGVydCgieW91
IG5vdyBoYXZlIHBlcm1pc3Npb24gdG8gcG9zdCBOb3RpZmljYXRpb25zIik7CisgICAgZWxzZQor
ICAgICAgICBhbGVydCgieW91IGRvbid0IGhhdmUgcGVybWlzc2lvbiB0byBwb3N0IE5vdGlmaWNh
dGlvbnMiKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorCis8Ym9keSBzdHlsZT0iZm9udC1zaXpl
OngtbGFyZ2UiPgorPGEgc3R5bGU9Im1hcmdpbi1sZWZ0OiAyMHB4OyIgaWQ9ImFsbG93Tm90aWZp
Y2F0aW9uTGluayIgIG9uY2xpY2s9InNldEFsbG93Tm90aWZpY2F0aW9uKCk7IHJldHVybiBmYWxz
ZTsiIGhyZWY9IiMiPkNsaWNrIHRvIHNldCBhbGxvdyBub3RpZmljYXRpb25zIGZpcnN0PC9hPiA8
YnI+CisKKzxhIHN0eWxlPSJtYXJnaW4tbGVmdDogMjBweDsiIG9uY2xpY2s9InNldE5vdGlmaWNh
dGlvbigpOyByZXR1cm4gZmFsc2U7IiBocmVmPSIjIj5DbGljayB0byBzZXQgbm90aWZpY2F0aW9u
PC9hPiA8YnI+Cis8YSBzdHlsZT0ibWFyZ2luLWxlZnQ6IDIwcHg7IiBvbmNsaWNrPSJuLmNhbmNl
bCgpOyByZXR1cm4gZmFsc2U7IiBocmVmPSIjIj5DbGljayB0byBjYW5jZWwgdGhlIG5vdGlmaWNh
dGlvbjwvYT4gPGJyPgorPGJyPjxicj4KKzxkaXYgaWQ9InBsYWNlIj4KKzwvZGl2PgorCis8L2Jv
ZHk+Cis8L2h0bWw+CisK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>147469</attachid>
            <date>2012-06-13 19:54:36 -0700</date>
            <delta_ts>2012-06-14 02:32:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-88950-20120614105431.patch</filename>
            <type>text/plain</type>
            <size>5474</size>
            <attacher name="Chris.Guan">logingx</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp
bmRleCBkM2U2MWUyYTc1MGM5NzhkYmEyN2Y0ZjIyZTcyZWMzZTliMTBhYzk5Li5jMTMyNzAwMzNi
MTJlZDA3OTQwMmMwOGIyODAyM2YwNjZlNmIxZTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNi0xMyAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1
YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBhZGQgYSBuZXcg
QXBpIG5hbWVkIHNldEFsbG93Tm90aWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tC
ZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpzZXRBbGxvd05vdGlmaWNhdGlvbik6CisgICAgICAgIChX
ZWJLaXQpOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisKIDIwMTItMDYtMTMgIENyeXN0YWwg
WmhhbmcgIDxoYWl6aGFuZ0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBcHBseSBO
ZXcgU3R5bGUgYW5kIEpTIGZvciBTZWxlY3QgUG9wdXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv
QXBpL1dlYlBhZ2UuY3BwCmluZGV4IGViY2E4Zjc1ZmM3Mzc0NGQ4YmJhYjVhMzZmNjEyZDFlZDRm
MWI0N2YuLjllNzdjZGFlMjM2M2E4N2M3ZjAwYjRjY2JmNjQ3NTI0OGZhMTM3M2MgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNjM1MCw2ICs2MzUwLDE2IEBA
IFdlYlN0cmluZyBXZWJQYWdlOjp0ZXh0SGFzQXR0cmlidXRlKGNvbnN0IFdlYlN0cmluZyYgcXVl
cnkpIGNvbnN0CiAgICAgcmV0dXJuICIiOwogfQogCit2b2lkIFdlYlBhZ2U6OnNldEFsbG93Tm90
aWZpY2F0aW9uKGNvbnN0IFdlYlN0cmluZyYgZG9tYWluLCBib29sIGFsbG93KQoreworI2lmIEVO
QUJMRShOT1RJRklDQVRJT05TKSB8fCBFTkFCTEUoTEVHQUNZX05PVElGSUNBVElPTlMpCisgICAg
c3RhdGljX2Nhc3Q8Tm90aWZpY2F0aW9uUHJlc2VudGVySW1wbCo+KE5vdGlmaWNhdGlvblByZXNl
bnRlckltcGw6Omluc3RhbmNlKCkpLT5vblBlcm1pc3Npb24oZG9tYWluLnV0ZjgoKSwgYWxsb3cp
OworI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oZG9tYWluKTsKKyAgICBVTlVTRURfUEFSQU0oYWxs
b3cpOworI2VuZGlmCit9CisKIHZvaWQgV2ViUGFnZTo6c2V0SmF2YVNjcmlwdENhbkFjY2Vzc0Ns
aXBib2FyZChib29sIGVuYWJsZWQpCiB7CiAgICAgZC0+bV9wYWdlLT5zZXR0aW5ncygpLT5zZXRK
YXZhU2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkKGVuYWJsZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy
cnkvQXBpL1dlYlBhZ2UuaAppbmRleCBiY2YzODdmNDM5OGRlNGExNGJlOTIzYTdlMjE1YTVjYmVk
YzczODYzLi44YTAzN2RkZTE2OGE4M2I2NmU4YTYzOTFiMzlmYjA1ZjE2NjI3YTY4IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2Uv
V2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuaApAQCAtMjY2LDYgKzI2Niw4IEBAIHB1Ymxp
YzoKIAogICAgIFdlYlN0cmluZyB0ZXh0SGFzQXR0cmlidXRlKGNvbnN0IFdlYlN0cmluZyYgcXVl
cnkpIGNvbnN0OwogCisgICAgdm9pZCBzZXRBbGxvd05vdGlmaWNhdGlvbihjb25zdCBXZWJTdHJp
bmcmIGRvbWFpbiwgYm9vbCBhbGxvdyk7CisKICAgICBQbGF0Zm9ybTo6V2ViQ29udGV4dCB3ZWJD
b250ZXh0KFRhcmdldERldGVjdGlvblN0cmF0ZWd5KSBjb25zdDsKIAogICAgIHR5cGVkZWYgaW50
cHRyX3QgQmFja0ZvcndhcmRJZDsKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwpp
bmRleCAxYzJhZDExZWMzZTAyNDIyZjFkNGZhNTE2MmJhMDJhNjEwODA0ZGVkLi5hNDdiODEwOTA5
YjYyZGMzMTVlZjhlMTBlZWIzNzBmNTUzMGY2MWU5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysr
IGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMTMgIENocmlzIEd1YW4gIDxj
aHJpcy5ndWFuQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tiZXJyeV0gYWRk
IGEgbmV3IEFwaSBuYW1lZCBzZXRBbGxvd05vdGlmaWNhdGlvbgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg5NTAKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBuZXcgQVBJIG5hbWVkIHNldEFsbG93
Tm90aWZpY2F0aW9uIGluIHdlYnBhZ2UgY2xhc3MgdG8KKyAgICAgICAgbGV0IGNsaWVudCBzZXQg
dGhvc2UgYWxsb3dlZCBkb21haW5zIGludG8gbm90aWZpY2F0aW9ucy4KKworICAgICAgICBUZXN0
IGNhc2U6CisgICAgICAgICogTWFudWFsVGVzdHMvYmxhY2tiZXJyeS9ub3RpZmljYXRpb24uaHRt
bDogQWRkZWQuCisKIDIwMTItMDYtMTMgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWls
LmNvbT4KIAogICAgICAgICBbR3RrXSBFbmFibGUgbGluayBwcmVmZXRjaCBzdXBwb3J0IGluIHRo
ZSBkZXZlbG9wZXIgYnVpbGRzCmRpZmYgLS1naXQgYS9NYW51YWxUZXN0cy9ibGFja2JlcnJ5L25v
dGlmaWNhdGlvbi5odG1sIGIvTWFudWFsVGVzdHMvYmxhY2tiZXJyeS9ub3RpZmljYXRpb24uaHRt
bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwLi5jZjIyZDdhMjk5ZjIyYzNiZmY3YzRlZWU1YWY3MDk4YWYxYTM3MjkzCi0t
LSAvZGV2L251bGwKKysrIGIvTWFudWFsVGVzdHMvYmxhY2tiZXJyeS9ub3RpZmljYXRpb24uaHRt
bApAQCAtMCwwICsxLDUzIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2ph
dmFzY3JpcHQiPgordmFyIG47CitmdW5jdGlvbiBzZXROb3RpZmljYXRpb24oKQoreworICAgIGlm
ICh3aW5kb3cud2Via2l0Tm90aWZpY2F0aW9ucy5jaGVja1Blcm1pc3Npb24oKSAhPSAwKSB7Cisg
ICAgICAgIGFsZXJ0KCJ5b3UgZG9uJ3QgaGF2ZSBwZXJtaXNzaW9uIHRvIHBvc3Qgbm90aWZpY2F0
aW9ucywgcGxlYXNlIGFsbG93IG5vdGlmaWNhdGlvbnMgYnkgY2xpY2tpbmcgdGhhdCBsaW5rIik7
CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdhbGxvd05vdGlmaWNhdGlvbkxpbmsn
KS5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSAnUmVkJzsKKyAgICAgICAgcmV0dXJuIDA7CisgICAg
fQorICAgIG4gPSB3aW5kb3cud2Via2l0Tm90aWZpY2F0aW9ucy5jcmVhdGVOb3RpZmljYXRpb24o
d2luZG93LmxvY2F0aW9uLmhyZWYgKyAnL2Zhdmljb24uaWNvJywgJ05vdGlmeSBtZScsICdUaGlz
IGlzIHRoZSBub3RpZmljYXRpb24gYm9keScpOworICAgIGxvZyA9IGRvY3VtZW50LmdldEVsZW1l
bnRCeUlkKCJwbGFjZSIpOworICAgIG4ub25zaG93ID0gZnVuY3Rpb24oKSAgeyBsb2cuaW5uZXJU
ZXh0ID0gIm5vdGlmaWNhdGlvbiBzaG93aW5nIjsgfQorICAgIG4ub25jbGljayA9IGZ1bmN0aW9u
KCkgeyBsb2cuaW5uZXJUZXh0ID0gIm5vdGlmaWNhdGlvbiBjbGlja2VkIjsgfQorICAgIG4ub25l
cnJvciA9IGZ1bmN0aW9uKCkgeyBsb2cuaW5uZXJUZXh0ID0gIm5vdGlmaWNhdGlvbiBlcnJvciI7
IH0KKyAgICBuLm9uY2xvc2UgPSBmdW5jdGlvbigpIHsgbG9nLmlubmVyVGV4dCA9ICJub3RpZmlj
YXRpb24gY2xvc2VkIjsgfQorICAgIG4uc2hvdygpOworICAgIGxvZy5pbm5lclRleHQgPSAiRGlk
IHlvdSBub3RpY2UgdGhlIG5vdGlmaWNhdGlvbiA/IFRoZXJlIGFyZSAzIHdheXMgdGhlIG5vdGlm
aWNhdGlvbiB3aWxsIGdvIGF3YXk6XG4gMS4gSXQgYXV0b21pY2FsbHkgZ29lcyBhd2F5IGluIDMw
IHNlY29uZHM7XG4gMi4geW91IGNhbiBjbGljayB0aGUgY2xvc2UgYnV0dG9uIG9uIHRoZSBub3Rp
ZmljYXRpb24gdG8gY2xvc2UgaXQ7XG4gMy4gQ2xpY2sgYWJvdmUgbGluayAnQ2xpY2sgdG8gY2Fu
Y2VsIHRoZSBub3RpZmljYXRpb24uXG5cbiBQbGVhc2UgdmVyaWZ5IGFsbCB3b3JrOyBXaGVuZXZl
ciB0aGUgaWNvbiBpcyBjbGlja2VkLCBjYW5jZWxsZWQsIGNsb3NlZCwgZXRjLiB0aGVyZSB3aWxs
IGJlIGNvcnJlc3BvbmRpbmcgbG9nIGlzIHRoaXMgYXJlYSwgcGxlYXNlIG5vdGljZSBpZiB0aGV5
IHNob3cgdXAuIjsKKworICAgIHNldFRpbWVvdXQodGltZW91dCwgMzAwMDApOworICAgIGZ1bmN0
aW9uIHRpbWVvdXQoKSB7CisgICAgICAgIG4uY2FuY2VsKCk7CisgICAgfQorfQorCitmdW5jdGlv
biBzZXRBbGxvd05vdGlmaWNhdGlvbigpCit7CisgICAgd2luZG93LndlYmtpdE5vdGlmaWNhdGlv
bnMucmVxdWVzdFBlcm1pc3Npb24ocGVybWlzc2lvbkdyYW50ZWQpOworfQorCitmdW5jdGlvbiBw
ZXJtaXNzaW9uR3JhbnRlZCgpCit7CisgICAgaWYgKHdpbmRvdy53ZWJraXROb3RpZmljYXRpb25z
LmNoZWNrUGVybWlzc2lvbigpID09IDApCisgICAgICAgIGFsZXJ0KCJ5b3Ugbm93IGhhdmUgcGVy
bWlzc2lvbiB0byBwb3N0IE5vdGlmaWNhdGlvbnMiKTsKKyAgICBlbHNlCisgICAgICAgIGFsZXJ0
KCJ5b3UgZG9uJ3QgaGF2ZSBwZXJtaXNzaW9uIHRvIHBvc3QgTm90aWZpY2F0aW9ucyIpOworfQor
PC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5IHN0eWxlPSJmb250LXNpemU6eC1sYXJnZSI+Cis8
YSBzdHlsZT0ibWFyZ2luLWxlZnQ6IDIwcHg7IiBpZD0iYWxsb3dOb3RpZmljYXRpb25MaW5rIiAg
b25jbGljaz0ic2V0QWxsb3dOb3RpZmljYXRpb24oKTsgcmV0dXJuIGZhbHNlOyIgaHJlZj0iIyI+
Q2xpY2sgdG8gc2V0IGFsbG93IG5vdGlmaWNhdGlvbnMgZmlyc3Q8L2E+IDxicj4KKworPGEgc3R5
bGU9Im1hcmdpbi1sZWZ0OiAyMHB4OyIgb25jbGljaz0ic2V0Tm90aWZpY2F0aW9uKCk7IHJldHVy
biBmYWxzZTsiIGhyZWY9IiMiPkNsaWNrIHRvIHNldCBub3RpZmljYXRpb248L2E+IDxicj4KKzxh
IHN0eWxlPSJtYXJnaW4tbGVmdDogMjBweDsiIG9uY2xpY2s9Im4uY2FuY2VsKCk7IHJldHVybiBm
YWxzZTsiIGhyZWY9IiMiPkNsaWNrIHRvIGNhbmNlbCB0aGUgbm90aWZpY2F0aW9uPC9hPiA8YnI+
Cis8YnI+PGJyPgorPGRpdiBpZD0icGxhY2UiPgorPC9kaXY+CisKKzwvYm9keT4KKzwvaHRtbD4K
Kwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>