88913 2012-06-12 13:57:07 -0700 [Qt]REGRESSION(r120107): It made http/tests/xmlhttprequest/origin-exact-matching.html fails 2012-10-09 21:55:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 79666 88896 1 ossy pf darin ossy pf oldest_to_newest 647274 0 ossy 2012-06-12 13:57:07 -0700 r120107 made http/tests/xmlhttprequest/origin-exact-matching.html fail on Qt. See http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r120107%20%2838626%29/http/tests/xmlhttprequest/origin-exact-matching-pretty-diff.html for details. Could you check it, please? 647372 1 ossy 2012-06-12 14:57:15 -0700 I skipped it on Qt to paint the bot green. (r120126) Please unskip it with the proper fix. 647426 2 pf 2012-06-12 15:47:53 -0700 The only suspect i can find is this line: $origin = isset($_GET['origin']) ? $_GET['origin'] : $_SERVER['HTTP_ORIGIN']; The tests that fail are the ones where the origin starts with a null character. Maybe that's fooling isset() in that platform? *preventively curses php* I can make a patch to use the origin directly without checking and see if that's the problem. I don't have the ability to build a linux64 qt, is there a way to test if it would work or is landing a patch and looking at what happens the only way to move forward? 737510 3 ossy 2012-10-09 01:11:44 -0700 The bug is still valid now. 738193 4 167849 pf 2012-10-09 14:35:03 -0700 Created attachment 167849 Patch Would you mind trying this patch somewhere and checking if the test still fails? 738503 5 167849 ossy 2012-10-09 21:29:16 -0700 Comment on attachment 167849 Patch It works for me now, r=me. I'll land it manually with unskipping this test. 738531 6 ossy 2012-10-09 21:55:38 -0700 Landed in r130845 167849 2012-10-09 14:35:03 -0700 2012-10-09 21:29:16 -0700 Patch bug-88913-20121009143404.patch text/plain 3050 pf U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzc2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjJiMjBmNTFkMjRmMWIzNWNmMTAz ZDdjODk3OTkwYzY4ZTVmMWZjMi4uZjRiYmU2M2ZhZTA2MGI5MzUyZWE2NmRjMDU4MTBmYTc2NjA0 MzczZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTA5ICBQYWJsbyBGbG91cmV0ICA8 cGFibG9mQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBbUXRdUkVHUkVTU0lPTihyMTIwMTA3KTog SXQgbWFkZSBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L29yaWdpbi1leGFjdC1tYXRjaGluZy5o dG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODkxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEJsaW5kIGZpeCB0byB0cnkgdG8gZml4IHRoZSB0ZXN0LgorCisgICAgICAgICogaHR0cC90ZXN0 cy94bWxodHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1hbGxvdy1saXN0cy1zdGFydGluZy13aXRo LWNvbW1hLmh0bWw6CisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZXNvdXJj ZXMvYWNjZXNzLWNvbnRyb2wtYWxsb3ctbGlzdHMucGhwOgorCiAyMDEyLTEwLTA4ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBEUlQvV1RS IGltcGxlbWVudGF0aW9ucyBvZiBsYXllclRyZWVBc1RleHQKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtYWxsb3ctbGlzdHMt c3RhcnRpbmctd2l0aC1jb21tYS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRw cmVxdWVzdC9hY2Nlc3MtY29udHJvbC1hbGxvdy1saXN0cy1zdGFydGluZy13aXRoLWNvbW1hLmh0 bWwKaW5kZXggYTRiZmVlMzM2YmE2ZjFhNjkyZGY4MDAyNzc0ZjUwNmI2YWYwYjE5Ni4uZjVjZmRi ODUwNWIzNzAyZWU4YjY4ZDg0YjMyYWQxMDhkMmE0ZmNjNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1hbGxvdy1saXN0cy1z dGFydGluZy13aXRoLWNvbW1hLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxo dHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1hbGxvdy1saXN0cy1zdGFydGluZy13aXRoLWNvbW1h Lmh0bWwKQEAgLTcsNyArNyw3IEBACiA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CiBk ZXNjcmlwdGlvbigiQWxsb3cgbGlzdHMgc3RhcnRpbmcgd2l0aCBhIGNvbW1hIHNob3VsZCBiZSBw YXJzZWQgY29ycmVjdGx5LiIpOwogdmFyIHhociA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwotdmFy IHVybCA9ICJodHRwOi8vbG9jYWxob3N0OjgwMDAveG1saHR0cHJlcXVlc3QvcmVzb3VyY2VzL2Fj Y2Vzcy1jb250cm9sLWFsbG93LWxpc3RzLnBocD9oZWFkZXJzPSx5LWxvbCx4LXByaW50LCUyMCws LHktcHJpbnQiOwordmFyIHVybCA9ICJodHRwOi8vbG9jYWxob3N0OjgwMDAveG1saHR0cHJlcXVl c3QvcmVzb3VyY2VzL2FjY2Vzcy1jb250cm9sLWFsbG93LWxpc3RzLnBocD9oZWFkZXJzPSx5LWxv bCx4LXByaW50LCUyMCwsLHktcHJpbnQmb3JpZ2luPWh0dHA6Ly8xMjcuMC4wLjE6ODAwMCI7CiB4 aHIub3BlbigiR0VUIiwgdXJsLCBmYWxzZSk7CiB4aHIuc2V0UmVxdWVzdEhlYWRlcigneC1wcmlu dCcsICd1bmljb3JuJykKIHhoci5zZXRSZXF1ZXN0SGVhZGVyKCd5LXByaW50JywgJ25hcndoYWwn KQpAQCAtMTcsNyArMTcsNyBAQCB2YXIgcmVzcG9uc2UgPSBKU09OLnBhcnNlKHhoci5yZXNwb25z ZSkKIHNob3VsZEJlRXF1YWxUb1N0cmluZygicmVzcG9uc2VbJ3gtcHJpbnQnXSIsICJ1bmljb3Ju Iik7CiBzaG91bGRCZUVxdWFsVG9TdHJpbmcoInJlc3BvbnNlWyd5LXByaW50J10iLCAibmFyd2hh bCIpOwogCi11cmwgPSAiaHR0cDovL2xvY2FsaG9zdDo4MDAwL3htbGh0dHByZXF1ZXN0L3Jlc291 cmNlcy9hY2Nlc3MtY29udHJvbC1hbGxvdy1saXN0cy5waHA/bWV0aG9kcz0sLFBVVCxHRVQiOwor dXJsID0gImh0dHA6Ly9sb2NhbGhvc3Q6ODAwMC94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvYWNj ZXNzLWNvbnRyb2wtYWxsb3ctbGlzdHMucGhwP21ldGhvZHM9LCxQVVQsR0VUJm9yaWdpbj1odHRw Oi8vMTI3LjAuMC4xOjgwMDAiOwogeGhyLm9wZW4oIlBVVCIsIHVybCwgZmFsc2UpOwogZGVidWco IlNlbmRpbmcgUFVUIHJlcXVlc3QuIik7CiBzaG91bGRCZVVuZGVmaW5lZCgieGhyLnNlbmQobnVs bCkiKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv cmVzb3VyY2VzL2FjY2Vzcy1jb250cm9sLWFsbG93LWxpc3RzLnBocCBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVzb3VyY2VzL2FjY2Vzcy1jb250cm9sLWFsbG93LWxp c3RzLnBocAppbmRleCA0Nzk1MjM0M2I1MWUwM2MzZDUxYzcwYjNhNDFlOGZhOGQ3MGM2YjBiLi44 ZjBhZjVjZjNlZDA4OGM1ODMxNmM5MTU4MzIzODA2ZGVjOTM4NTM2IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jlc291cmNlcy9hY2Nlc3MtY29udHJv bC1hbGxvdy1saXN0cy5waHAKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVx dWVzdC9yZXNvdXJjZXMvYWNjZXNzLWNvbnRyb2wtYWxsb3ctbGlzdHMucGhwCkBAIC0xLDYgKzEs NiBAQAogPD9waHAKIAotJG9yaWdpbiA9IGlzc2V0KCRfR0VUWydvcmlnaW4nXSkgPyAkX0dFVFsn b3JpZ2luJ10gOiAkX1NFUlZFUlsnSFRUUF9PUklHSU4nXTsKKyRvcmlnaW4gPSAkX0dFVFsnb3Jp Z2luJ107CiAKIGlmICgkb3JpZ2luICE9ICdub25lJykKICAgICBoZWFkZXIoIkFjY2Vzcy1Db250 cm9sLUFsbG93LU9yaWdpbjogJG9yaWdpbiIpOwo=