88901 2012-06-12 13:14:21 -0700 [chromium] Return empty visibleLayerRect for layers with empty content bounds 2012-06-12 14:57:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj cc-bugs enne jamesr piman webkit.review.bot wjmaclean zlieber oldest_to_newest 647210 0 danakj 2012-06-12 13:14:21 -0700 [chromium] Return empty visibleLayerRect for layers with empty content bounds 647212 1 147137 danakj 2012-06-12 13:17:22 -0700 Created attachment 147137 Patch 647305 2 147137 enne 2012-06-12 14:09:34 -0700 Comment on attachment 147137 Patch R=me. Thanks. That old code looks quite wrong. 647373 3 147137 webkit.review.bot 2012-06-12 14:57:23 -0700 Comment on attachment 147137 Patch Clearing flags on attachment: 147137 Committed r120127: <http://trac.webkit.org/changeset/120127> 647374 4 webkit.review.bot 2012-06-12 14:57:27 -0700 All reviewed patches have been landed. Closing bug. 147137 2012-06-12 13:17:22 -0700 2012-06-12 14:57:23 -0700 Patch bug-88901-20120612161721.patch text/plain 5242 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdjNmYzYmEyM2NjN2Q3 ZTU5M2YwZjZkM2Q2MzExNmJiMzJlYjk1OS4uY2FjMWI4MjU1NmFiOTUxZWVlNGI1YmRiYjgxNTgx YTE2ZDczMmE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTEyICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gUmV0 dXJuIGVtcHR5IHZpc2libGVMYXllclJlY3QgZm9yIGxheWVycyB3aXRoIGVtcHR5IGNvbnRlbnQg Ym91bmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 ODkwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgY2hhbmdlIHNob3VsZCBvbmx5IGFmZmVjdCB0ZXN0cy4gQ3VycmVudGx5IGlmIHlvdSBzZXQg dXAgYQorICAgICAgICBDQ0xheWVySW1wbCB3aXRoIHNvbWUgYm91bmRzLCBidXQgZG9uJ3Qgc2V0 IHRoZSBjb250ZW50Qm91bmRzLCB0aGVuCisgICAgICAgIHRoZXkgYXJlIGVtcHR5IGJ5IGRlZmF1 bHQuIEluIHRoaXMgY2FzZSB0aGUgdmlzaWJsZUxheWVyUmVjdCBnZXRzCisgICAgICAgIHNldCBp bmFwcHJvcHJpYXRlbHkgdG8gdGhlIGxheWVyJ3MgdGFyZ2V0IHN1cmZhY2UgY29udGVudFJlY3Qg d2hpY2gKKyAgICAgICAgaW4gYSBjb21wbGV0ZWx5IGRpZmZlcmVudCBjb29yZGluYXRlIHNwYWNl LgorCisgICAgICAgIEZpeGVkIHVwIHRlc3RzIHRoYXQgd2VyZSBwYXNzaW5nIGJvZ3VzbHkgYW5k IGZhaWxlZCBhZnRlciB0aGlzIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpjYWxjdWxhdGVWaXNpYmxlTGF5ZXJSZWN0KToKKwogMjAxMi0wNi0xMiAgU2FtaSBLeW9zdGls YSAgPHNreW9zdGlsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIERvbid0IGNy YXNoIGluIENDTGF5ZXJJdGVyYXRvciBpZiB0aGUgcm9vdCBsYXllciBkb2Vzbid0IGhhdmUgYSBy ZW5kZXIgc3VyZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA3YmJmZDRkNzdkNGU0 OGFmODdmODIzNDgxNGQ5OGZlYzUyNDQ4NDdiLi43Yzc4MDgzZTRjNjBlYzU2ZjI3NzJiMDM2MmVh MGNiYWU3OTk0ZmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTA2LTEyICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFtjaHJvbWl1bV0gUmV0dXJuIGVtcHR5IHZpc2libGVMYXllclJlY3QgZm9yIGxheWVycyB3 aXRoIGVtcHR5IGNvbnRlbnQgYm91bmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODkwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogdGVzdHMvQ0NMYXllclRyZWVIb3N0SW1wbFRlc3QuY3BwOgorCiAy MDEyLTA2LTEyICBTaGF3biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtjaHJvbWl1bV0gTWFrZSBkYW1hZ2UgdHJhY2tpbmcgbW9yZSByb2J1c3QgdG8gZWFybHkg ZXhpdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RDb21tb24uY3BwCmluZGV4IDdk ZmMyMTZjMjg4Zjk1NjAyNjFkZWQwZGFkMjM4N2NlZTAyODAwMTMuLjVhZTcyMDU3ZDUyYjU3ZWVm ZjVhMmQ0NDljN2QxOTMzMzY1ZjdlMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9zdENvbW1vbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVI b3N0Q29tbW9uLmNwcApAQCAtMTY1LDcgKzE2NSw3IEBAIHN0YXRpYyBJbnRSZWN0IGNhbGN1bGF0 ZVZpc2libGVMYXllclJlY3QoTGF5ZXJUeXBlKiBsYXllcikKICAgICAgICAgdGFyZ2V0U3VyZmFj ZVJlY3QuaW50ZXJzZWN0KGxheWVyLT5jbGlwUmVjdCgpKTsKIAogICAgIGlmICh0YXJnZXRTdXJm YWNlUmVjdC5pc0VtcHR5KCkgfHwgbGF5ZXItPmNvbnRlbnRCb3VuZHMoKS5pc0VtcHR5KCkpCi0g ICAgICAgIHJldHVybiB0YXJnZXRTdXJmYWNlUmVjdDsKKyAgICAgICAgcmV0dXJuIEludFJlY3Qo KTsKIAogICAgIC8vIE5vdGUgY2FyZWZ1bGx5IHRoZXNlIGFyZSBhbGlhc2VzCiAgICAgY29uc3Qg SW50U2l6ZSYgYm91bmRzID0gbGF5ZXItPmJvdW5kcygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAppbmRleCBh YjlhMDg4Y2FkMTFkYWJhMDRjYjFjZDY5MWMxNjFhYWRmMjE4ODhjLi4wYzVmZjM4NWE1ZWExMDVm OTI4ZWNiNGY4NmQ2YmFiZjVlNTZlZmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcApAQCAtOTUsNiArOTUs NyBAQCBwdWJsaWM6CiAgICAgICAgIHJvb3QtPnNldEFuY2hvclBvaW50KEZsb2F0UG9pbnQoMCwg MCkpOwogICAgICAgICByb290LT5zZXRQb3NpdGlvbihGbG9hdFBvaW50KDAsIDApKTsKICAgICAg ICAgcm9vdC0+c2V0Qm91bmRzKEludFNpemUoMTAsIDEwKSk7CisgICAgICAgIHJvb3QtPnNldENv bnRlbnRCb3VuZHMoSW50U2l6ZSgxMCwgMTApKTsKICAgICAgICAgcm9vdC0+c2V0VmlzaWJsZUxh eWVyUmVjdChJbnRSZWN0KDAsIDAsIDEwLCAxMCkpOwogICAgICAgICByb290LT5zZXREcmF3c0Nv bnRlbnQodHJ1ZSk7CiAgICAgICAgIG15SG9zdEltcGwtPnNldFJvb3RMYXllcihyb290LnJlbGVh c2UoKSk7CkBAIC03MjIsNiArNzIzLDcgQEAgcHJpdmF0ZToKICAgICB7CiAgICAgICAgIHNldEFu Y2hvclBvaW50KEZsb2F0UG9pbnQoMCwgMCkpOwogICAgICAgICBzZXRCb3VuZHMoSW50U2l6ZSgx MCwgMTApKTsKKyAgICAgICAgc2V0Q29udGVudEJvdW5kcyhJbnRTaXplKDEwLCAxMCkpOwogICAg ICAgICBzZXREcmF3c0NvbnRlbnQodHJ1ZSk7CiAgICAgfQogCkBAIC03NDIsNiArNzQ0LDcgQEAg VEVTVF9GKENDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LCBibGVuZGluZ09mZldoZW5EcmF3aW5nT3Bh cXVlTGF5ZXJzKQogICAgICAgICBPd25QdHI8Q0NMYXllckltcGw+IHJvb3QgPSBDQ0xheWVySW1w bDo6Y3JlYXRlKDApOwogICAgICAgICByb290LT5zZXRBbmNob3JQb2ludChGbG9hdFBvaW50KDAs IDApKTsKICAgICAgICAgcm9vdC0+c2V0Qm91bmRzKEludFNpemUoMTAsIDEwKSk7CisgICAgICAg IHJvb3QtPnNldENvbnRlbnRCb3VuZHMocm9vdC0+Ym91bmRzKCkpOwogICAgICAgICByb290LT5z ZXREcmF3c0NvbnRlbnQoZmFsc2UpOwogICAgICAgICBtX2hvc3RJbXBsLT5zZXRSb290TGF5ZXIo cm9vdC5yZWxlYXNlKCkpOwogICAgIH0KQEAgLTEzOTMsNiArMTM5Niw3IEBAIHN0YXRpYyBQYXNz T3duUHRyPENDTGF5ZXJUcmVlSG9zdEltcGw+IHNldHVwTGF5ZXJzRm9yT3BhY2l0eShib29sIHBh cnRpYWxTd2FwLCBDCiAgICAgcm9vdC0+c2V0QW5jaG9yUG9pbnQoRmxvYXRQb2ludCgwLCAwKSk7 CiAgICAgcm9vdC0+c2V0UG9zaXRpb24oRmxvYXRQb2ludChyb290UmVjdC54KCksIHJvb3RSZWN0 LnkoKSkpOwogICAgIHJvb3QtPnNldEJvdW5kcyhJbnRTaXplKHJvb3RSZWN0LndpZHRoKCksIHJv b3RSZWN0LmhlaWdodCgpKSk7CisgICAgcm9vdC0+c2V0Q29udGVudEJvdW5kcyhyb290LT5ib3Vu ZHMoKSk7CiAgICAgcm9vdC0+c2V0VmlzaWJsZUxheWVyUmVjdChyb290UmVjdCk7CiAgICAgcm9v dC0+c2V0RHJhd3NDb250ZW50KGZhbHNlKTsKICAgICByb290LT5yZW5kZXJTdXJmYWNlKCktPnNl dENvbnRlbnRSZWN0KEludFJlY3QoSW50UG9pbnQoKSwgSW50U2l6ZShyb290UmVjdC53aWR0aCgp LCByb290UmVjdC5oZWlnaHQoKSkpKTsKQEAgLTE0MDEsMTIgKzE0MDUsMTQgQEAgc3RhdGljIFBh c3NPd25QdHI8Q0NMYXllclRyZWVIb3N0SW1wbD4gc2V0dXBMYXllcnNGb3JPcGFjaXR5KGJvb2wg cGFydGlhbFN3YXAsIEMKICAgICBjaGlsZC0+c2V0UG9zaXRpb24oRmxvYXRQb2ludChjaGlsZFJl Y3QueCgpLCBjaGlsZFJlY3QueSgpKSk7CiAgICAgY2hpbGQtPnNldE9wYWNpdHkoMC41Zik7CiAg ICAgY2hpbGQtPnNldEJvdW5kcyhJbnRTaXplKGNoaWxkUmVjdC53aWR0aCgpLCBjaGlsZFJlY3Qu aGVpZ2h0KCkpKTsKKyAgICBjaGlsZC0+c2V0Q29udGVudEJvdW5kcyhjaGlsZC0+Ym91bmRzKCkp OwogICAgIGNoaWxkLT5zZXRWaXNpYmxlTGF5ZXJSZWN0KGNoaWxkUmVjdCk7CiAgICAgY2hpbGQt PnNldERyYXdzQ29udGVudChmYWxzZSk7CiAKICAgICBncmFuZENoaWxkLT5zZXRBbmNob3JQb2lu dChGbG9hdFBvaW50KDAsIDApKTsKICAgICBncmFuZENoaWxkLT5zZXRQb3NpdGlvbihJbnRQb2lu dChncmFuZENoaWxkUmVjdC54KCksIGdyYW5kQ2hpbGRSZWN0LnkoKSkpOwogICAgIGdyYW5kQ2hp bGQtPnNldEJvdW5kcyhJbnRTaXplKGdyYW5kQ2hpbGRSZWN0LndpZHRoKCksIGdyYW5kQ2hpbGRS ZWN0LmhlaWdodCgpKSk7CisgICAgZ3JhbmRDaGlsZC0+c2V0Q29udGVudEJvdW5kcyhncmFuZENo aWxkLT5ib3VuZHMoKSk7CiAgICAgZ3JhbmRDaGlsZC0+c2V0VmlzaWJsZUxheWVyUmVjdChncmFu ZENoaWxkUmVjdCk7CiAgICAgZ3JhbmRDaGlsZC0+c2V0RHJhd3NDb250ZW50KHRydWUpOwogCg==