88897 2012-06-12 11:47:52 -0700 Disable autoplay when user gesture is required for media playback 2012-06-12 13:57:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 0 qinmin webkit-unassigned abarth eric.carlson feature-media-reviews webkit.review.bot oldest_to_newest 647139 0 qinmin 2012-06-12 11:47:52 -0700 Disable autoplay when user gesture is required for media playback 647147 1 147129 qinmin 2012-06-12 11:52:25 -0700 Created attachment 147129 Patch 647155 2 147131 qinmin 2012-06-12 11:56:37 -0700 Created attachment 147131 Patch 647203 3 147131 abarth 2012-06-12 12:59:46 -0700 Comment on attachment 147131 Patch Makes sense. 647229 4 147131 eric.carlson 2012-06-12 13:29:04 -0700 Comment on attachment 147131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147131&action=review > LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:10 > + function cleanGestureRequirement() { Nit: a function's opening brace should be on a new line. 647239 5 147131 eric.carlson 2012-06-12 13:34:24 -0700 Comment on attachment 147131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147131&action=review > LayoutTests/media/no-autoplay-with-user-gesture-requirement.html:31 > + function canplaythrough() > + { > + setTimeout(testPaused, 500); > + } 500ms is a *very* long time for a test to hang out waiting for nothing to happen. The 'play' event handler will make the test fail immediately if playback does start, so I think a much shorter timeout should be used here. 647244 6 147131 webkit.review.bot 2012-06-12 13:37:39 -0700 Comment on attachment 147131 Patch Clearing flags on attachment: 147131 Committed r120112: <http://trac.webkit.org/changeset/120112> 647245 7 webkit.review.bot 2012-06-12 13:37:44 -0700 All reviewed patches have been landed. Closing bug. 647254 8 eric.carlson 2012-06-12 13:45:44 -0700 (In reply to comment #7) > All reviewed patches have been landed. Closing bug. Hmm, guess I should have cleared the cq+ flag :-( @Min, can you please file to do the cleanup work needed? 647263 9 qinmin 2012-06-12 13:50:20 -0700 Hi,Eric I Created patch https://bugs.webkit.org/show_bug.cgi?id=88909 to fix the comments. Fixed the bracket and reduced the timeout to 100 ms (In reply to comment #8) > (In reply to comment #7) > > All reviewed patches have been landed. Closing bug. > > Hmm, guess I should have cleared the cq+ flag :-( > > @Min, can you please file to do the cleanup work needed? 647273 10 eric.carlson 2012-06-12 13:57:02 -0700 (In reply to comment #9) > Hi,Eric > I Created patch https://bugs.webkit.org/show_bug.cgi?id=88909 to fix the comments. > Fixed the bracket and reduced the timeout to 100 ms > Thank you very much for the quick fix! 147129 2012-06-12 11:52:25 -0700 2012-06-12 11:56:34 -0700 Patch bug-88897-20120612115224.patch text/plain 1827 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBlMDQ0YWEwMWUzZjAx YjRhZDJjMTJhMDFmNzdjOTQwMTAwOTZkMS4uMDQ5YmMxN2M3ODg5ZGMxNTBjZGFlNThiYzA2ZWJi OTM3ZTY3YmVlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTEyICBNaW4g UWluICA8cWlubWluQGdvb2dsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBhdXRvcGxheSB3aGVu IHVzZXIgZ2VzdHVyZSBpcyByZXF1aXJlZCBmb3IgbWVkaWEgcGxheWJhY2sKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB1c2VyIGdlc3R1cmUgaXMg cmVxdWlyZWQgZm9yIG1lZGlhIHBsYXliYWNrLCB3ZSBzaG91bGQgYmxvY2sgYXV0b3BsYXkuCisg ICAgICAgIE90aGVyd2lzZSwgcGVvcGxlIHdpbGwgdXNlIGF1dG9wbGF5IGluc3RlYWQgb2Ygdmlk ZW8ucGxheSgpIHRvIGJ5cGFzcyB0aGUgZ2VzdHVyZSByZXF1aXJlbWVudC4KKyAgICAgICAgVGVz dDogbWVkaWEvbm8tYXV0b3BsYXktd2l0aC11c2VyLWdlc3R1cmUtcmVxdWlyZW1lbnQuaHRtbAor CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxNZWRpYUVsZW1lbnQ6OnNldFJlYWR5U3RhdGUpOgorCiAyMDEyLTA2LTEyICBQYXZlbCBG ZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGFsbG93IGNsZWFyaW5nIHJldmlzaW9uIGhpc3RvcnkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAppbmRleCBjZmI2OGEzZTAxZmRhYTAxOTA5MzFmZTk3ZGUwMTZmMzE3 OGU0OTE3Li5jMzAwOGU5MzllMzdlM2YzNzI5ZGFlNTNlNTUxZmJkNGVhZTYyNmRmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTE2OTMsNyArMTY5Myw3IEBA IHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0UmVhZHlTdGF0ZShNZWRpYVBsYXllcjo6UmVhZHlT dGF0ZSBzdGF0ZSkKICAgICAgICAgaWYgKGlzUG90ZW50aWFsbHlQbGF5aW5nICYmIG9sZFN0YXRl IDw9IEhBVkVfQ1VSUkVOVF9EQVRBKQogICAgICAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5h bWVzKCkucGxheWluZ0V2ZW50KTsKIAotICAgICAgICBpZiAobV9hdXRvcGxheWluZyAmJiBtX3Bh dXNlZCAmJiBhdXRvcGxheSgpICYmICFkb2N1bWVudCgpLT5pc1NhbmRib3hlZChTYW5kYm94QXV0 b21hdGljRmVhdHVyZXMpKSB7CisgICAgICAgIGlmIChtX2F1dG9wbGF5aW5nICYmIG1fcGF1c2Vk ICYmIGF1dG9wbGF5KCkgJiYgIWRvY3VtZW50KCktPmlzU2FuZGJveGVkKFNhbmRib3hBdXRvbWF0 aWNGZWF0dXJlcykgJiYgIXVzZXJHZXN0dXJlUmVxdWlyZWRGb3JSYXRlQ2hhbmdlKCkpIHsKICAg ICAgICAgICAgIG1fcGF1c2VkID0gZmFsc2U7CiAgICAgICAgICAgICBpbnZhbGlkYXRlQ2FjaGVk VGltZSgpOwogICAgICAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVzKCkucGxheUV2ZW50 KTsK 147131 2012-06-12 11:56:37 -0700 2012-06-12 13:37:39 -0700 Patch bug-88897-20120612115637.patch text/plain 4376 qinmin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBlMDQ0YWEwMWUzZjAx YjRhZDJjMTJhMDFmNzdjOTQwMTAwOTZkMS4uMDQ5YmMxN2M3ODg5ZGMxNTBjZGFlNThiYzA2ZWJi OTM3ZTY3YmVlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTEyICBNaW4g UWluICA8cWlubWluQGdvb2dsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBhdXRvcGxheSB3aGVu IHVzZXIgZ2VzdHVyZSBpcyByZXF1aXJlZCBmb3IgbWVkaWEgcGxheWJhY2sKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODk3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB1c2VyIGdlc3R1cmUgaXMg cmVxdWlyZWQgZm9yIG1lZGlhIHBsYXliYWNrLCB3ZSBzaG91bGQgYmxvY2sgYXV0b3BsYXkuCisg ICAgICAgIE90aGVyd2lzZSwgcGVvcGxlIHdpbGwgdXNlIGF1dG9wbGF5IGluc3RlYWQgb2Ygdmlk ZW8ucGxheSgpIHRvIGJ5cGFzcyB0aGUgZ2VzdHVyZSByZXF1aXJlbWVudC4KKyAgICAgICAgVGVz dDogbWVkaWEvbm8tYXV0b3BsYXktd2l0aC11c2VyLWdlc3R1cmUtcmVxdWlyZW1lbnQuaHRtbAor CisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxNZWRpYUVsZW1lbnQ6OnNldFJlYWR5U3RhdGUpOgorCiAyMDEyLTA2LTEyICBQYXZlbCBG ZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IGFsbG93IGNsZWFyaW5nIHJldmlzaW9uIGhpc3RvcnkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmNwcAppbmRleCBjZmI2OGEzZTAxZmRhYTAxOTA5MzFmZTk3ZGUwMTZmMzE3 OGU0OTE3Li5jMzAwOGU5MzllMzdlM2YzNzI5ZGFlNTNlNTUxZmJkNGVhZTYyNmRmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTE2OTMsNyArMTY5Myw3IEBA IHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6c2V0UmVhZHlTdGF0ZShNZWRpYVBsYXllcjo6UmVhZHlT dGF0ZSBzdGF0ZSkKICAgICAgICAgaWYgKGlzUG90ZW50aWFsbHlQbGF5aW5nICYmIG9sZFN0YXRl IDw9IEhBVkVfQ1VSUkVOVF9EQVRBKQogICAgICAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5h bWVzKCkucGxheWluZ0V2ZW50KTsKIAotICAgICAgICBpZiAobV9hdXRvcGxheWluZyAmJiBtX3Bh dXNlZCAmJiBhdXRvcGxheSgpICYmICFkb2N1bWVudCgpLT5pc1NhbmRib3hlZChTYW5kYm94QXV0 b21hdGljRmVhdHVyZXMpKSB7CisgICAgICAgIGlmIChtX2F1dG9wbGF5aW5nICYmIG1fcGF1c2Vk ICYmIGF1dG9wbGF5KCkgJiYgIWRvY3VtZW50KCktPmlzU2FuZGJveGVkKFNhbmRib3hBdXRvbWF0 aWNGZWF0dXJlcykgJiYgIXVzZXJHZXN0dXJlUmVxdWlyZWRGb3JSYXRlQ2hhbmdlKCkpIHsKICAg ICAgICAgICAgIG1fcGF1c2VkID0gZmFsc2U7CiAgICAgICAgICAgICBpbnZhbGlkYXRlQ2FjaGVk VGltZSgpOwogICAgICAgICAgICAgc2NoZWR1bGVFdmVudChldmVudE5hbWVzKCkucGxheUV2ZW50 KTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL25vLWF1dG9wbGF5LXdpdGgtdXNlci1n ZXN0dXJlLXJlcXVpcmVtZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL25vLWF1 dG9wbGF5LXdpdGgtdXNlci1nZXN0dXJlLXJlcXVpcmVtZW50LWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi40YjAyZTUzYTRjMmM2Y2E3NzUyMTU1MDRmNDA1YzkwNDM3OTRjZGJkCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbm8tYXV0b3BsYXktd2l0aC11c2VyLWdlc3R1cmUt cmVxdWlyZW1lbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorVGVzdCB0aGF0IG1lZGlh IGF1dG9wbGF5IHNob3VsZCBub3Qgd29yayBpZiB1c2VyIGdlc3R1cmUgaXMgcmVxdWlyZWQgZm9y IHBsYXliYWNrLgorCitFWFBFQ1RFRCAodmlkZW8ucGF1c2VkID09ICd0cnVlJykgT0sKK0VWRU5U KGNhbnBsYXl0aHJvdWdoKQorRVhQRUNURUQgKHZpZGVvLnBhdXNlZCA9PSAndHJ1ZScpIE9LCitF TkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9uby1hdXRvcGxheS13 aXRoLXVzZXItZ2VzdHVyZS1yZXF1aXJlbWVudC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbm8t YXV0b3BsYXktd2l0aC11c2VyLWdlc3R1cmUtcmVxdWlyZW1lbnQuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4z NTg3YTZlZjVlNjdmMzQwMmM5NGM2NjJjNjEyMGNmYjQyMjU5YTg2Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvbWVkaWEvbm8tYXV0b3BsYXktd2l0aC11c2VyLWdlc3R1cmUtcmVxdWly ZW1lbnQuaHRtbApAQCAtMCwwICsxLDQ4IEBACis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAg PHRpdGxlPlRlc3QgdGhhdCBtZWRpYSBhdXRvcGxheSBzaG91bGQgbm90IHdvcmsgaWYgdXNlciBn ZXN0dXJlIGlzIHJlcXVpcmVkIGZvciBwbGF5YmFjazwvdGl0bGU+CisgICAgICAgIDxzY3JpcHQg c3JjPW1lZGlhLWZpbGUuanM+PC9zY3JpcHQ+CisgICAgICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRl c3QuanM+PC9zY3JpcHQ+CisgICAgICAgIDxzY3JpcHQ+CisgICAgICAgICAgICBpZiAod2luZG93 LmludGVybmFscykgCisgICAgICAgICAgICAgICAgd2luZG93LmludGVybmFscy5zZXR0aW5ncy5z ZXRNZWRpYVBsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVyZSh0cnVlKTsKKworICAgICAgICAgICAg ZnVuY3Rpb24gY2xlYW5HZXN0dXJlUmVxdWlyZW1lbnQoKSB7CisgICAgICAgICAgICAgICAgaWYg KHdpbmRvdy5pbnRlcm5hbHMpIAorICAgICAgICAgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxz LnNldHRpbmdzLnNldE1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKGZhbHNlKTsKKyAg ICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gdGVzdFBsYXkoKQorICAgICAgICAg ICAgeworICAgICAgICAgICAgICAgIGNsZWFuR2VzdHVyZVJlcXVpcmVtZW50KCk7CisgICAgICAg ICAgICAgICAgZmFpbFRlc3QoInBsYXkgZXZlbnQgc2hvdWxkIG5vdCBmaXJlIHdpdGhvdXQgdXNl ciBnZXN0dXJlLiIpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0 UGF1c2VkKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZp ZGVvLnBhdXNlZCIsIHRydWUpOworICAgICAgICAgICAgICAgIGNsZWFuR2VzdHVyZVJlcXVpcmVt ZW50KCk7IAorICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgICAgIH0KKworICAg ICAgICAgICAgZnVuY3Rpb24gY2FucGxheXRocm91Z2goKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgICBzZXRUaW1lb3V0KHRlc3RQYXVzZWQsIDUwMCk7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAg ICAgICAgZmluZE1lZGlhRWxlbWVudCgpOworICAgICAgICAgICAgICAgICB2aWRlby5zcmMgPSBm aW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJjb250ZW50L3Rlc3QiKTsKKyAgICAgICAgICAgICAgICAg dGVzdEV4cGVjdGVkKCJ2aWRlby5wYXVzZWQiLCB0cnVlKTsKKyAgICAgICAgICAgICAgICAgd2Fp dEZvckV2ZW50KCdjYW5wbGF5dGhyb3VnaCcsIGNhbnBsYXl0aHJvdWdoKTsKKyAgICAgICAgICAg ICAgICAgd2FpdEZvckV2ZW50KCdwbGF5JywgdGVzdFBsYXkpOworICAgICAgICAgICAgfQorICAg ICAgICA8L3NjcmlwdD4KKyAgICA8L2hlYWQ+CisKKyAgICA8Ym9keSBvbmxvYWQ9InN0YXJ0KCki PgorICAgIDxwPlRlc3QgdGhhdCBtZWRpYSBhdXRvcGxheSBzaG91bGQgbm90IHdvcmsgaWYgdXNl ciBnZXN0dXJlIGlzIHJlcXVpcmVkIGZvciBwbGF5YmFjay48L3A+CisgICAgPHZpZGVvIGNvbnRy b2xzIGF1dG9wbGF5PjwvdmlkZW8+CisgICAgPC9ib2R5PgorPC9odG1sPgo=