88887 2012-06-12 10:27:29 -0700 [chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages 2012-06-12 12:55:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88145 1 enne enne enne jamesr webkit.review.bot oldest_to_newest 647044 0 enne 2012-06-12 10:27:29 -0700 [chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages 647050 1 147111 enne 2012-06-12 10:32:23 -0700 Created attachment 147111 Patch 647052 2 147111 jamesr 2012-06-12 10:34:54 -0700 Comment on attachment 147111 Patch R=me seems pretty testable though - make an RTL page with scrollbars and x-overflow, scroll it to the left a bit, dump pixels? 647055 3 enne 2012-06-12 10:39:20 -0700 This is the same as bug 88882: the problem only when you are using ScrollbarLayerChromium. My latest patch in bug 88145 will turn on ScrollbarLayerChromium even when using single-threaded mode, so we will get the benefit of layout tests hitting this code. 647198 4 147111 webkit.review.bot 2012-06-12 12:55:46 -0700 Comment on attachment 147111 Patch Clearing flags on attachment: 147111 Committed r120105: <http://trac.webkit.org/changeset/120105> 647199 5 webkit.review.bot 2012-06-12 12:55:50 -0700 All reviewed patches have been landed. Closing bug. 147111 2012-06-12 10:32:23 -0700 2012-06-12 12:55:46 -0700 Patch bug-88887-20120612103222.patch text/plain 7277 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDI2YzU2ODVlMmQ4MjgwZDMwNjk3NDFjN2NiNjhhMjQ3ODE4YmFhM2MuLjkzYWJlZGRlZWY1ZDEx MmRhMmVhOWRjMWVlZGFkY2UyOTY1YWM5YmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjkgQEAKKzIwMTItMDYtMTIgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xl LmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBpbmNvcnJlY3QgTGF5ZXJDaHJvbWl1bSBz Y3JvbGwgcG9zaXRpb24gZm9yIFJUTCBvdmVyZmxvdyBwYWdlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg4ODcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2Nyb2xsIHBvc2l0aW9uIG9uIGxheWVy cyBuZWVkcyB0byB0YWtlIGludG8gYWNjb3VudCB0aGUgc2Nyb2xsCisgICAgICAgIG9yaWdpbiwg c2luY2UgUlRMIHBhZ2VzIHN0YXJ0IHNjcm9sbGVkIGFsbCB0aGUgd2F5IHRvIHRoZSByaWdodC4K KyAgICAgICAgT3RoZXJ3aXNlLCB3aGVuIHNjcm9sbGluZyBsZWZ0IHRoZSBzY3JvbGwgcG9zaXRp b24gaW5jb3JyZWN0bHkgd2lsbCBnbworICAgICAgICBuZWdhdGl2ZSwgY2F1c2luZyBoYXZvayBp biBzY3JvbGxiYXIgdGhlbWUgY29kZSB0aGF0IGp1c3QgYXNzdW1lcyB0aGF0CisgICAgICAgIGl0 J3MgYWx3YXlzIHNjcm9sbGVkIGFsbCB0aGUgd2F5IHRvIHRoZSBsZWZ0LgorCisgICAgICAgIEFs c28sIG5vdyB0aGF0IHRoZSBzY3JvbGwgb3JpZ2luIGlzIHBhc3NlZCBpbnRvIE5DQ0gsIGhhbmRs ZQorICAgICAgICBzY3JvbGxPcmlnaW4ueSgpIGZvciBsYXllciBhZGp1c3RpbmcuIFRoaXMgaXMg YWx3YXlzIHplcm8gaW4gcHJhY3RpY2UsCisgICAgICAgIGJ1dCBpdCBzZWVtZWQgYXdrd2FyZCB0 byBqdXN0IGRyb3AgaXQgYW5kIHRoYXQgYXNzdW1wdGlvbiBjb3VsZCBhbHdheXMKKyAgICAgICAg Y2hhbmdlIGluIHRoZSBmdXR1cmUuCisKKyAgICAgICAgKiBzcmMvTm9uQ29tcG9zaXRlZENvbnRl bnRIb3N0LmNwcDoKKyAgICAgICAgKFdlYktpdDo6Tm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0Ojpz ZXRWaWV3cG9ydCk6CisgICAgICAgIChXZWJLaXQ6Ok5vbkNvbXBvc2l0ZWRDb250ZW50SG9zdDo6 cGFpbnRDb250ZW50cyk6CisgICAgICAgICogc3JjL05vbkNvbXBvc2l0ZWRDb250ZW50SG9zdC5o OgorICAgICAgICAoTm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0KToKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6dXBkYXRlTGF5ZXJU cmVlVmlld3BvcnQpOgorCiAyMDEyLTA2LTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTIwMDUx LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvTm9uQ29tcG9zaXRlZENv bnRlbnRIb3N0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL05vbkNvbXBvc2l0ZWRD b250ZW50SG9zdC5jcHAKaW5kZXggOWFhNmYxNjdmYjc4OWE1MDYxMjJlNDEyYmIwZWNiZjQxZmM4 NWNmNi4uYzc2MTVlOGM0YmFlNzkxMzgzZTE2MTVkNzcyYTk4YmVlNDk1ODhhOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvTm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Ob25Db21wb3NpdGVkQ29udGVudEhv c3QuY3BwCkBAIC05OCw3ICs5OCw3IEBAIHN0YXRpYyB2b2lkIHJlc2VydmVTY3JvbGxiYXJMYXll cnMoV2ViQ29yZTo6TGF5ZXJDaHJvbWl1bSogbGF5ZXIsIFdlYkNvcmU6OkxheWVyCiAgICAgICAg IGxheWVyLT5zZXRBbHdheXNSZXNlcnZlVGV4dHVyZXModHJ1ZSk7CiB9CiAKLXZvaWQgTm9uQ29t cG9zaXRlZENvbnRlbnRIb3N0OjpzZXRWaWV3cG9ydChjb25zdCBXZWJDb3JlOjpJbnRTaXplJiB2 aWV3cG9ydFNpemUsIGNvbnN0IFdlYkNvcmU6OkludFNpemUmIGNvbnRlbnRzU2l6ZSwgY29uc3Qg V2ViQ29yZTo6SW50UG9pbnQmIHNjcm9sbFBvc2l0aW9uLCBmbG9hdCBkZXZpY2VTY2FsZSwgaW50 IGxheWVyQWRqdXN0WCkKK3ZvaWQgTm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0OjpzZXRWaWV3cG9y dChjb25zdCBXZWJDb3JlOjpJbnRTaXplJiB2aWV3cG9ydFNpemUsIGNvbnN0IFdlYkNvcmU6Oklu dFNpemUmIGNvbnRlbnRzU2l6ZSwgY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmIHNjcm9sbFBvc2l0 aW9uLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgc2Nyb2xsT3JpZ2luLCBmbG9hdCBkZXZpY2VT Y2FsZSkKIHsKICAgICBpZiAoIXNjcm9sbExheWVyKCkpCiAgICAgICAgIHJldHVybjsKQEAgLTEw Niw3ICsxMDYsOCBAQCB2b2lkIE5vbkNvbXBvc2l0ZWRDb250ZW50SG9zdDo6c2V0Vmlld3BvcnQo Y29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgdmlld3BvcnRTaXplLAogICAgIGJvb2wgdmlzaWJsZVJl Y3RDaGFuZ2VkID0gbV92aWV3cG9ydFNpemUgIT0gdmlld3BvcnRTaXplOwogCiAgICAgbV92aWV3 cG9ydFNpemUgPSB2aWV3cG9ydFNpemU7Ci0gICAgc2Nyb2xsTGF5ZXIoKS0+c2V0U2Nyb2xsUG9z aXRpb24oc2Nyb2xsUG9zaXRpb24pOworCisgICAgc2Nyb2xsTGF5ZXIoKS0+c2V0U2Nyb2xsUG9z aXRpb24oc2Nyb2xsUG9zaXRpb24gKyB0b1NpemUoc2Nyb2xsT3JpZ2luKSk7CiAgICAgc2Nyb2xs TGF5ZXIoKS0+c2V0UG9zaXRpb24oLXNjcm9sbFBvc2l0aW9uKTsKICAgICAvLyBEdWUgdG8gdGhl IHBvc3NpYmlsaXR5IG9mIHBpbmNoIHpvb20sIHRoZSBub25jb21wb3NpdGVkIGxheWVyIGlzIGFs d2F5cwogICAgIC8vIGFzc3VtZWQgdG8gYmUgc2Nyb2xsYWJsZS4KQEAgLTExNSwxMCArMTE2LDE0 IEBAIHZvaWQgTm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0OjpzZXRWaWV3cG9ydChjb25zdCBXZWJD b3JlOjpJbnRTaXplJiB2aWV3cG9ydFNpemUsCiAgICAgbV9ncmFwaGljc0xheWVyLT5kZXZpY2VP clBhZ2VTY2FsZUZhY3RvckNoYW5nZWQoKTsKICAgICBtX2dyYXBoaWNzTGF5ZXItPnNldFNpemUo Y29udGVudHNTaXplKTsKIAotICAgIG1fbGF5ZXJBZGp1c3RYID0gbGF5ZXJBZGp1c3RYOwotICAg IGlmIChtX2dyYXBoaWNzTGF5ZXItPnRyYW5zZm9ybSgpLm00MSgpICE9IG1fbGF5ZXJBZGp1c3RY KSB7CisgICAgLy8gSW4gUlRMLXN0eWxlIHBhZ2VzLCB0aGUgb3JpZ2luIG9mIHRoZSBpbml0aWFs IGNvbnRhaW5pbmcgYmxvY2sgZm9yIHRoZQorICAgIC8vIHJvb3QgbGF5ZXIgbWF5IGJlIHBvc2l0 aXZlOyB0cmFuc2xhdGUgdGhlIGxheWVyIHRvIGF2b2lkIG5lZ2F0aXZlCisgICAgLy8gY29vcmRp bmF0ZXMuCisgICAgbV9sYXllckFkanVzdCA9IC10b1NpemUoc2Nyb2xsT3JpZ2luKTsKKyAgICBp ZiAobV9ncmFwaGljc0xheWVyLT50cmFuc2Zvcm0oKS5tNDEoKSAhPSBtX2xheWVyQWRqdXN0Lndp ZHRoKCkgfHwgbV9ncmFwaGljc0xheWVyLT50cmFuc2Zvcm0oKS5tNDIoKSAhPSBtX2xheWVyQWRq dXN0LmhlaWdodCgpKSB7CiAgICAgICAgIFdlYkNvcmU6OlRyYW5zZm9ybWF0aW9uTWF0cml4IHRy YW5zZm9ybSA9IG1fZ3JhcGhpY3NMYXllci0+dHJhbnNmb3JtKCk7Ci0gICAgICAgIHRyYW5zZm9y bS5zZXRNNDEobV9sYXllckFkanVzdFgpOworICAgICAgICB0cmFuc2Zvcm0uc2V0TTQxKG1fbGF5 ZXJBZGp1c3Qud2lkdGgoKSk7CisgICAgICAgIHRyYW5zZm9ybS5zZXRNNDIobV9sYXllckFkanVz dC5oZWlnaHQoKSk7CiAgICAgICAgIG1fZ3JhcGhpY3NMYXllci0+c2V0VHJhbnNmb3JtKHRyYW5z Zm9ybSk7CiAKICAgICAgICAgLy8gSWYgYSB0aWxlZCBsYXllciBpcyBzaGlmdGVkIGxlZnQgb3Ig cmlnaHQsIHRoZSBjb250ZW50IHRoYXQgZ29lcyBpbnRvCkBAIC0xNjAsOSArMTY1LDkgQEAgdm9p ZCBOb25Db21wb3NpdGVkQ29udGVudEhvc3Q6Om5vdGlmeVN5bmNSZXF1aXJlZChjb25zdCBXZWJD b3JlOjpHcmFwaGljc0xheWVyKikKIAogdm9pZCBOb25Db21wb3NpdGVkQ29udGVudEhvc3Q6OnBh aW50Q29udGVudHMoY29uc3QgV2ViQ29yZTo6R3JhcGhpY3NMYXllciosIFdlYkNvcmU6OkdyYXBo aWNzQ29udGV4dCYgY29udGV4dCwgV2ViQ29yZTo6R3JhcGhpY3NMYXllclBhaW50aW5nUGhhc2Us IGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIGNsaXBSZWN0KQogewotICAgIGNvbnRleHQudHJhbnNs YXRlKC1tX2xheWVyQWRqdXN0WCwgMCk7CisgICAgY29udGV4dC50cmFuc2xhdGUoLW1fbGF5ZXJB ZGp1c3QpOwogICAgIFdlYkNvcmU6OkludFJlY3QgYWRqdXN0ZWRDbGlwUmVjdCA9IGNsaXBSZWN0 OwotICAgIGFkanVzdGVkQ2xpcFJlY3QubW92ZShtX2xheWVyQWRqdXN0WCwgMCk7CisgICAgYWRq dXN0ZWRDbGlwUmVjdC5tb3ZlKG1fbGF5ZXJBZGp1c3QpOwogICAgIG1fY29udGVudFBhaW50LT5w YWludChjb250ZXh0LCBhZGp1c3RlZENsaXBSZWN0KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvTm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0LmggYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9Ob25Db21wb3NpdGVkQ29udGVudEhvc3QuaAppbmRleCBjODdi ZDhjMDk4OWJhNDhkMDgyNjIwMjJlMmNjMTA5OGMwMmZlYmE1Li43Y2FlMjBhMTQzM2Q1NDJhZjM0 YWI0ZTk3ZTgxMzhhMjc5MGMzYzhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9Ob25Db21wb3NpdGVkQ29udGVudEhvc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9Ob25Db21wb3NpdGVkQ29udGVudEhvc3QuaApAQCAtNTgsNyArNTgsNyBAQCBwdWJs aWM6CiAgICAgdm9pZCBzZXRCYWNrZ3JvdW5kQ29sb3IoY29uc3QgV2ViQ29yZTo6Q29sb3ImKTsK ICAgICB2b2lkIHNldE9wYXF1ZShib29sKTsKICAgICB2b2lkIHNldFNjcm9sbExheWVyKFdlYkNv cmU6OkdyYXBoaWNzTGF5ZXIqKTsKLSAgICB2b2lkIHNldFZpZXdwb3J0KGNvbnN0IFdlYkNvcmU6 OkludFNpemUmIHZpZXdwb3J0U2l6ZSwgY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgY29udGVudHNT aXplLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgc2Nyb2xsUG9zaXRpb24sIGZsb2F0IGRldmlj ZVNjYWxlLCBpbnQgbGF5ZXJBZGp1c3RYKTsKKyAgICB2b2lkIHNldFZpZXdwb3J0KGNvbnN0IFdl YkNvcmU6OkludFNpemUmIHZpZXdwb3J0U2l6ZSwgY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgY29u dGVudHNTaXplLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgc2Nyb2xsUG9zaXRpb24sIGNvbnN0 IFdlYkNvcmU6OkludFBvaW50JiBzY3JvbGxPcmlnaW4sIGZsb2F0IGRldmljZVNjYWxlKTsKICAg ICBXZWJDb3JlOjpHcmFwaGljc0xheWVyKiB0b3BMZXZlbFJvb3RMYXllcigpIGNvbnN0IHsgcmV0 dXJuIG1fZ3JhcGhpY3NMYXllci5nZXQoKTsgfQogCiAgICAgdm9pZCBzZXRTaG93RGVidWdCb3Jk ZXJzKGJvb2wpOwpAQCAtODQsNyArODQsOCBAQCBwcml2YXRlOgogICAgIE93blB0cjxXZWJDb3Jl OjpHcmFwaGljc0xheWVyPiBtX2dyYXBoaWNzTGF5ZXI7CiAgICAgT3duUHRyPFdlYkNvcmU6Okxh eWVyUGFpbnRlckNocm9taXVtPiBtX2NvbnRlbnRQYWludDsKICAgICBXZWJDb3JlOjpJbnRTaXpl IG1fdmlld3BvcnRTaXplOwotICAgIGludCBtX2xheWVyQWRqdXN0WDsKKyAgICBXZWJDb3JlOjpJ bnRTaXplIG1fbGF5ZXJBZGp1c3Q7CisKICAgICBib29sIG1fc2hvd0RlYnVnQm9yZGVyczsKICAg ICBmbG9hdCBtX2RldmljZVNjYWxlRmFjdG9yOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBhNDQwOTdiYTRiODdhOTI3ZmM4MzAyODljYmE0Zjhm ZTliZDc3NmIwLi45MzBhMjIzZmNkOGM0ZmZmNTJkNjlhYTZjYWY5MDVjY2Y1NTJkZDZlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBAIC0zNjM3LDE1ICsz NjM3LDEwIEBAIHZvaWQgV2ViVmlld0ltcGw6OnVwZGF0ZUxheWVyVHJlZVZpZXdwb3J0KCkKICAg ICBJbnRSZWN0IHZpc2libGVSZWN0ID0gdmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0KHRydWUgLyog aW5jbHVkZSBzY3JvbGxiYXJzICovKTsKICAgICBJbnRQb2ludCBzY3JvbGwodmlldy0+c2Nyb2xs WCgpLCB2aWV3LT5zY3JvbGxZKCkpOwogCi0gICAgLy8gSW4gUlRMLXN0eWxlIHBhZ2VzLCB0aGUg b3JpZ2luIG9mIHRoZSBpbml0aWFsIGNvbnRhaW5pbmcgYmxvY2sgZm9yIHRoZQotICAgIC8vIHJv b3QgbGF5ZXIgbWF5IGJlIHBvc2l0aXZlOyB0cmFuc2xhdGUgdGhlIGxheWVyIHRvIGF2b2lkIG5l Z2F0aXZlCi0gICAgLy8gY29vcmRpbmF0ZXMuCi0gICAgaW50IGxheWVyQWRqdXN0WCA9IC12aWV3 LT5zY3JvbGxPcmlnaW4oKS54KCk7Ci0KICAgICAvLyBUaGlzIHBhcnQgb2YgdGhlIGRldmljZVNj YWxlIHdpbGwgYmUgdXNlZCB0byBzY2FsZSB0aGUgY29udGVudHMgb2YKICAgICAvLyB0aGUgTkND SCdzIEdyYXBoaWNzTGF5ZXIuCiAgICAgZmxvYXQgZGV2aWNlU2NhbGUgPSBtX2RldmljZVNjYWxl SW5Db21wb3NpdG9yOwotICAgIG1fbm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0LT5zZXRWaWV3cG9y dCh2aXNpYmxlUmVjdC5zaXplKCksIHZpZXctPmNvbnRlbnRzU2l6ZSgpLCBzY3JvbGwsIGRldmlj ZVNjYWxlLCBsYXllckFkanVzdFgpOworICAgIG1fbm9uQ29tcG9zaXRlZENvbnRlbnRIb3N0LT5z ZXRWaWV3cG9ydCh2aXNpYmxlUmVjdC5zaXplKCksIHZpZXctPmNvbnRlbnRzU2l6ZSgpLCBzY3Jv bGwsIHZpZXctPnNjcm9sbE9yaWdpbigpLCBkZXZpY2VTY2FsZSk7CiAKICAgICBtX2xheWVyVHJl ZVZpZXcuc2V0Vmlld3BvcnRTaXplKHNpemUoKSk7CiAgICAgbV9sYXllclRyZWVWaWV3LnNldFBh Z2VTY2FsZUZhY3RvckFuZExpbWl0cyhwYWdlU2NhbGVGYWN0b3IoKSwgbV9taW5pbXVtUGFnZVNj YWxlRmFjdG9yLCBtX21heGltdW1QYWdlU2NhbGVGYWN0b3IpOwo=