88885 2012-06-12 10:17:36 -0700 [Chromium] WebFrameImpl::find doesn't work for searching from a selection. 2012-06-13 09:41:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified All RESOLVED FIXED P2 Normal --- 1 mkosiba mkosiba abarth webkit.review.bot oldest_to_newest 647035 0 mkosiba 2012-06-12 10:17:36 -0700 This is related to http://code.google.com/p/chromium/issues/detail?id=129552. When a user is doing a FindInPage search it comes in as a series of WebFrameImpl::find calls (find("f"), find("fo"), find("foo")). All of the calls have the findNext option set to false. If the user additionally selected text before typing in the search term all of the find calls need to start searching at the same point. In other words a find call with !options.findNext doesn't necessarily mean that this is a new search, it could also be a refinement. The current implementation loses state (m_activeMatch is set to 0) if !options.findNext. What we really want is to preserve the active find match until the user stops interacting with the find widget. 647041 1 147108 mkosiba 2012-06-12 10:21:21 -0700 Created attachment 147108 Patch 648100 2 147108 abarth 2012-06-13 09:10:03 -0700 Comment on attachment 147108 Patch Ok. 648142 3 147108 webkit.review.bot 2012-06-13 09:41:24 -0700 Comment on attachment 147108 Patch Clearing flags on attachment: 147108 Committed r120219: <http://trac.webkit.org/changeset/120219> 648143 4 webkit.review.bot 2012-06-13 09:41:28 -0700 All reviewed patches have been landed. Closing bug. 147108 2012-06-12 10:21:21 -0700 2012-06-13 09:41:24 -0700 Patch bug-88885-20120612182120.patch text/plain 2620 mkosiba U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDlhYjNjZjFjYjc4MjgzY2U1NzdjMDNkNTM5MGRlODY1OWZmZjQ0OWEuLjMyNjM0MzZiYmIxYmYw YWFhNDViYjlkOTI4NWRkYTk4NDIwZjExNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMTIgIE1hcnRpbiBLb3NpYmEgIDxta29zaWJhQGdvb2ds ZS5jb20+CisKKyAgICAgICAgW0Nocm9taXVtXSBXZWJGcmFtZUltcGw6OmZpbmQgZG9lc24ndCB3 b3JrIGZvciBzZWFyY2hpbmcgZnJvbSBhIHNlbGVjdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtZW1iZXIgdGhlIGFjdGl2ZSBtYXRjaCBub3Qg anVzdCB1bnRpbCB0aGUgc2VhdGNoVGV4dCBjaGFuZ2VzIGJ1dCBmb3IgdGhlIGVudGlyZSBmaW5k IHNlc3Npb24uCisKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViRnJhbWVJbXBsOjpmaW5kKToKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBs OjpzZXRGaW5kRW5kc3RhdGVGb2N1c0FuZFNlbGVjdGlvbik6CisKIDIwMTItMDYtMTEgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgbWVt YmVyIHZhcmlhYmxlcyBmb3VuZCBieSBjbGFuZydzIC1XdW51c2VkLXByaXZhdGUtZmllbGQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IGM3OGUzYWY3 MjgwYTA3ZTVkMzY5NGUwZTQxZDMzZDhhNWI2ZDE4OWUuLmUyY2QwNWQyNDNkMGQwNTMzMGViOThm YWNjMTkwNmEyNjEwNTMyZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkZyYW1lSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJh bWVJbXBsLmNwcApAQCAtMTU3MiwxMiArMTU3MiwxNCBAQCBib29sIFdlYkZyYW1lSW1wbDo6Zmlu ZChpbnQgaWRlbnRpZmllciwKIHsKICAgICBXZWJGcmFtZUltcGwqIG1haW5GcmFtZUltcGwgPSB2 aWV3SW1wbCgpLT5tYWluRnJhbWVJbXBsKCk7CiAKLSAgICBpZiAoIW9wdGlvbnMuZmluZE5leHQp IHsKKyAgICBpZiAoIW9wdGlvbnMuZmluZE5leHQpCiAgICAgICAgIGZyYW1lKCktPnBhZ2UoKS0+ dW5tYXJrQWxsVGV4dE1hdGNoZXMoKTsKLSAgICAgICAgbV9hY3RpdmVNYXRjaCA9IDA7Ci0gICAg fSBlbHNlCisgICAgZWxzZQogICAgICAgICBzZXRNYXJrZXJBY3RpdmUobV9hY3RpdmVNYXRjaC5n ZXQoKSwgZmFsc2UpOwogCisgICAgaWYgKG1fYWN0aXZlTWF0Y2ggJiYgbV9hY3RpdmVNYXRjaC0+ b3duZXJEb2N1bWVudCgpICE9IGZyYW1lKCktPmRvY3VtZW50KCkpCisgICAgICAgIG1fYWN0aXZl TWF0Y2ggPSAwOworCiAgICAgLy8gSWYgdGhlIHVzZXIgaGFzIHNlbGVjdGVkIHNvbWV0aGluZyBz aW5jZSB0aGUgbGFzdCBGaW5kIG9wZXJhdGlvbiB3ZSB3YW50CiAgICAgLy8gdG8gc3RhcnQgZnJv bSB0aGVyZS4gT3RoZXJ3aXNlLCB3ZSBzdGFydCBzZWFyY2hpbmcgZnJvbSB3aGVyZSB0aGUgbGFz dCBGaW5kCiAgICAgLy8gb3BlcmF0aW9uIGxlZnQgb2ZmIChlaXRoZXIgYSBGaW5kIG9yIGEgRmlu ZE5leHQgb3BlcmF0aW9uKS4KQEAgLTIyMjAsNiArMjIyMiwxNCBAQCB2b2lkIFdlYkZyYW1lSW1w bDo6c2V0RmluZEVuZHN0YXRlRm9jdXNBbmRTZWxlY3Rpb24oKQogICAgICAgICAvLyBhIGxpbmsg Zm9jdXNlZCwgd2hpY2ggaXMgd2VpcmQpLgogICAgICAgICBmcmFtZSgpLT5zZWxlY3Rpb24oKS0+ c2V0U2VsZWN0aW9uKG1fYWN0aXZlTWF0Y2guZ2V0KCkpOwogICAgICAgICBmcmFtZSgpLT5kb2N1 bWVudCgpLT5zZXRGb2N1c2VkTm9kZSgwKTsKKworICAgICAgICAvLyBGaW5hbGx5IGNsZWFyIHRo ZSBhY3RpdmUgbWF0Y2gsIGZvciB0d28gcmVhc29uczoKKyAgICAgICAgLy8gV2UganVzdCBmaW5p c2hlZCB0aGUgZmluZCAnc2Vzc2lvbicgYW5kIHdlIGRvbid0IHdhbnQgZnV0dXJlIChwb3RlbnRp YWxseQorICAgICAgICAvLyB1bnJlbGF0ZWQpIGZpbmQgJ3Nlc3Npb25zJyBvcGVyYXRpb25zIHRv IHN0YXJ0IGF0IHRoZSBzYW1lIHBsYWNlLgorICAgICAgICAvLyBUaGUgV2ViRnJhbWVJbXBsIGNv dWxkIGdldCByZXVzZWQgYW5kIHRoZSBtX2FjdGl2ZU1hdGNoIGNvdWxkIGVuZCB1cCBwb2ludGlu ZworICAgICAgICAvLyB0byBhIGRvY3VtZW50IHRoYXQgaXMgbm8gbG9uZ2VyIHZhbGlkLiBLZWVw aW5nIGFuIGludmFsaWQgcmVmZXJlbmNlIGFyb3VuZAorICAgICAgICAvLyBpcyBqdXN0IGFza2lu ZyBmb3IgdHJvdWJsZS4KKyAgICAgICAgbV9hY3RpdmVNYXRjaCA9IDA7CiAgICAgfQogfQogCg==