88884 2012-06-12 10:17:34 -0700 Web Inspector: working copy should be committed even if domain binding returns error. 2012-07-04 08:24:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck johnjbarton keishi loislo pfeldman pmuellr rik timothy vsevik yurys oldest_to_newest 647034 0 pfeldman 2012-06-12 10:17:34 -0700 Committing working copy is about saving file. It should always succeed. 647040 1 147107 pfeldman 2012-06-12 10:20:08 -0700 Created attachment 147107 Patch 647910 2 pfeldman 2012-06-13 04:51:30 -0700 Committed r120186: <http://trac.webkit.org/changeset/120186> 657271 3 johnjbarton 2012-06-25 21:50:40 -0700 I don't think this fix succeeds because the line this.contentChanged(newContent, this._mimeType); is a notification, not an action causing save. The save action is in DebuggerResourceBinding.js, in didEditScriptSource(error); the save is still blocked if (error). function didEditScriptSource(error) { if (error) { callback(error); return; } var resource = javaScriptSource.resource(); if (resource) resource.addRevision(newSource); callback(null); } See https://code.google.com/p/chromium/issues/detail?id=123242 662975 4 vsevik 2012-07-04 08:24:17 -0700 (In reply to comment #3) > I don't think this fix succeeds because the line > > this.contentChanged(newContent, this._mimeType); > > is a notification, not an action causing save. > > The save action is in DebuggerResourceBinding.js, in didEditScriptSource(error); > the save is still blocked if (error). > > function didEditScriptSource(error) > { > if (error) { > callback(error); > return; > } > > var resource = javaScriptSource.resource(); > if (resource) > resource.addRevision(newSource); > > callback(null); > } > > See https://code.google.com/p/chromium/issues/detail?id=123242 Fixed in https://bugs.webkit.org/show_bug.cgi?id=90549 147107 2012-06-12 10:20:08 -0700 2012-07-04 08:24:43 -0700 Patch bug-88884-20120612212006.patch text/plain 1562 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBlMDQ0YWEwMWUzZjAx YjRhZDJjMTJhMDFmNzdjOTQwMTAwOTZkMS4uNzY0ZTNlYmEwMGNlZjgwNzFkY2RjNjA1ZTNiOWQx OGY3MjhlZmQ2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTA2LTEyICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHdvcmtpbmcgY29weSBzaG91bGQgYmUgY29tbWl0dGVkIGV2ZW4gaWYgZG9tYWluIGJpbmRp bmcgcmV0dXJucyBlcnJvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg4ODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ29tbWl0dGluZyB3b3JraW5nIGNvcHkgaXMgYWJvdXQgc2F2aW5nIGZpbGUuIEl0 IHNob3VsZCBhbHdheXMgc3VjY2VlZC4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv VUlTb3VyY2VDb2RlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlVJU291cmNlQ29kZS5wcm90 b3R5cGUuY29tbWl0V29ya2luZ0NvcHkpOgorCisyMDEyLTA2LTEyICBQYXZlbCBGZWxkbWFuICA8 cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFsbG93IGNs ZWFyaW5nIHJldmlzaW9uIGhpc3RvcnkuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODg0NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1VJU291cmNlQ29kZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvVUlTb3VyY2VDb2RlLmpzCmluZGV4IDU2YzFlMzEzN2Q0MjBhODkwNjUwODM0 MTQ4YjU4ZmQxNDNmMzQ1ZWMuLmUxOWNiZGU1MzY1MDVhYjBlYzk3YmJmMjBmOWExM2UxYWE4ODFk YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVUlTb3Vy Y2VDb2RlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVUlTb3Vy Y2VDb2RlLmpzCkBAIC0yMDYsOCArMjA2LDcgQEAgV2ViSW5zcGVjdG9yLlVJU291cmNlQ29kZS5w cm90b3R5cGUgPSB7CiAgICAgICAgIGZ1bmN0aW9uIGlubmVyQ2FsbGJhY2soZXJyb3IpCiAgICAg ICAgIHsKICAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9jb21taXR0aW5nV29ya2luZ0NvcHk7Ci0g ICAgICAgICAgICBpZiAoIWVycm9yKQotICAgICAgICAgICAgICAgIHRoaXMuY29udGVudENoYW5n ZWQobmV3Q29udGVudCwgdGhpcy5fbWltZVR5cGUpOworICAgICAgICAgICAgdGhpcy5jb250ZW50 Q2hhbmdlZChuZXdDb250ZW50LCB0aGlzLl9taW1lVHlwZSk7CiAgICAgICAgICAgICBjYWxsYmFj ayhlcnJvcik7CiAgICAgICAgIH0KIAo=