88882 2012-06-12 10:14:50 -0700 [chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids 2012-06-12 14:46:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88145 1 enne enne andersca cc-bugs enne jamesr tonikitoo webkit.review.bot oldest_to_newest 647030 0 enne 2012-06-12 10:14:50 -0700 [chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids 647038 1 147106 enne 2012-06-12 10:19:32 -0700 Created attachment 147106 Patch 647042 2 enne 2012-06-12 10:21:50 -0700 As a part of 88145, I want to turn on ScrollbarLayerChromium even when the thread proxy isn't enabled. However, there are two bugs that need to be fixed before scrollbars render the same with and without ScrollbarLayerChromium. So, no testing for this in this patch itself, but I wanted to separate out this fix for preexisting bug from the already large 88145. 647343 3 147106 jamesr 2012-06-12 14:32:00 -0700 Comment on attachment 147106 Patch R=me 647358 4 147106 webkit.review.bot 2012-06-12 14:46:46 -0700 Comment on attachment 147106 Patch Clearing flags on attachment: 147106 Committed r120125: <http://trac.webkit.org/changeset/120125> 647359 5 webkit.review.bot 2012-06-12 14:46:51 -0700 All reviewed patches have been landed. Closing bug. 147106 2012-06-12 10:19:32 -0700 2012-06-12 14:46:46 -0700 Patch bug-88882-20120612101932.patch text/plain 7287 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBlMDQ0YWEwMWUzZjAx YjRhZDJjMTJhMDFmNzdjOTQwMTAwOTZkMS4uYWRkODI3YmM4NmVmMjBiNjUxYmRmOGFhZDdhZWM0 MmFkYWViNzk5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA2LTEyICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBTY3Jv bGxpbmdDb29yZGluYXRvcjo6c2V0U2Nyb2xsTGF5ZXIgc2hvdWxkIHVwZGF0ZSBzY3JvbGwgbGF5 ZXIgaWRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 ODg4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRl c3RlZCBtYW51YWxseSwgYXMgc2Nyb2xsYmFyIGxheWVycyBhcmUgY3VycmVudGx5IG9ubHkgY3Jl YXRlZCB3aGVuCisgICAgICAgIHRocmVhZGVkIGNvbXBvc2l0aW5nIGlzIGVuYWJsZWQgYW5kIG5v bmUgb2YgdGhvc2UgbGF5b3V0IHRlc3RzIHRyaWdnZXIKKyAgICAgICAgdGhpcyBidWcuCisKKyAg ICAgICAgKiBwYWdlL3Njcm9sbGluZy9jaHJvbWl1bS9TY3JvbGxpbmdDb29yZGluYXRvckNocm9t aXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yUHJpdmF0ZTo6 c2V0U2Nyb2xsTGF5ZXIpOgorICAgICAgICAoU2Nyb2xsaW5nQ29vcmRpbmF0b3JQcml2YXRlKToK KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yUHJpdmF0ZTo6c2V0SG9yaXpv bnRhbFNjcm9sbGJhckxheWVyKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5h dG9yUHJpdmF0ZTo6c2V0VmVydGljYWxTY3JvbGxiYXJMYXllcik6CisgICAgICAgIChXZWJDb3Jl OjpjcmVhdGVTY3JvbGxiYXJMYXllcik6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29y ZGluYXRvcjo6ZnJhbWVWaWV3SG9yaXpvbnRhbFNjcm9sbGJhckxheWVyRGlkQ2hhbmdlKToKKyAg ICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpmcmFtZVZpZXdWZXJ0aWNhbFNj cm9sbGJhckxheWVyRGlkQ2hhbmdlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9TY3JvbGxiYXJMYXllckNocm9taXVtLmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxi YXJMYXllckNocm9taXVtOjpzZXRTY3JvbGxMYXllcklkKToKKyAgICAgICAgKFNjcm9sbGJhckxh eWVyQ2hyb21pdW0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1RyZWVT eW5jaHJvbml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VHJlZVN5bmNocm9uaXplcjo6dXBk YXRlU2Nyb2xsYmFyTGF5ZXJQb2ludGVyc1JlY3Vyc2l2ZSk6CisKIDIwMTItMDYtMTIgIFBhdmVs IEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogYWxsb3cgY2xlYXJpbmcgcmV2aXNpb24gaGlzdG9yeS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL2Nocm9taXVtL1Njcm9sbGluZ0Nvb3JkaW5hdG9yQ2hyb21p dW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvY2hyb21pdW0vU2Nyb2xsaW5n Q29vcmRpbmF0b3JDaHJvbWl1bS5jcHAKaW5kZXggYzE4ZTdlMzk3NjYwNDhhZWQwZTg1YzNhNzBk OTIyMmI4NTRjOGQ3Yi4uYmNlMzkxZmYzYmJkOTlkNGY5NDJiY2Q5YTVmODMzOWE4ZjYzNmE3MSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvY2hyb21pdW0vU2Nyb2xs aW5nQ29vcmRpbmF0b3JDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3Jv bGxpbmcvY2hyb21pdW0vU2Nyb2xsaW5nQ29vcmRpbmF0b3JDaHJvbWl1bS5jcHAKQEAgLTQ1LDEx ICs0NSwzMyBAQCBwdWJsaWM6CiAgICAgU2Nyb2xsaW5nQ29vcmRpbmF0b3JQcml2YXRlKCkgeyB9 CiAgICAgflNjcm9sbGluZ0Nvb3JkaW5hdG9yUHJpdmF0ZSgpIHsgfQogCi0gICAgdm9pZCBzZXRT Y3JvbGxMYXllcihMYXllckNocm9taXVtKiBsYXllcikgeyBtX3Njcm9sbExheWVyID0gbGF5ZXI7 IH0KKyAgICB2b2lkIHNldFNjcm9sbExheWVyKExheWVyQ2hyb21pdW0qIGxheWVyKQorICAgIHsK KyAgICAgICAgbV9zY3JvbGxMYXllciA9IGxheWVyOworCisgICAgICAgIGludCBpZCA9IGxheWVy ID8gbGF5ZXItPmlkKCkgOiAwOworICAgICAgICBpZiAobV9ob3Jpem9udGFsU2Nyb2xsYmFyTGF5 ZXIpCisgICAgICAgICAgICBtX2hvcml6b250YWxTY3JvbGxiYXJMYXllci0+c2V0U2Nyb2xsTGF5 ZXJJZChpZCk7CisgICAgICAgIGlmIChtX3ZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXIpCisgICAgICAg ICAgICBtX3ZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXItPnNldFNjcm9sbExheWVySWQoaWQpOworICAg IH0KKworICAgIHZvaWQgc2V0SG9yaXpvbnRhbFNjcm9sbGJhckxheWVyKFBhc3NSZWZQdHI8U2Ny b2xsYmFyTGF5ZXJDaHJvbWl1bT4gbGF5ZXIpCisgICAgeworICAgICAgICBtX2hvcml6b250YWxT Y3JvbGxiYXJMYXllciA9IGxheWVyOworICAgIH0KKworICAgIHZvaWQgc2V0VmVydGljYWxTY3Jv bGxiYXJMYXllcihQYXNzUmVmUHRyPFNjcm9sbGJhckxheWVyQ2hyb21pdW0+IGxheWVyKQorICAg IHsKKyAgICAgICAgbV92ZXJ0aWNhbFNjcm9sbGJhckxheWVyID0gbGF5ZXI7CisgICAgfQorCiAg ICAgTGF5ZXJDaHJvbWl1bSogc2Nyb2xsTGF5ZXIoKSBjb25zdCB7IHJldHVybiBtX3Njcm9sbExh eWVyLmdldCgpOyB9CiAKIHByaXZhdGU6CiAgICAgUmVmUHRyPExheWVyQ2hyb21pdW0+IG1fc2Ny b2xsTGF5ZXI7CisgICAgUmVmUHRyPFNjcm9sbGJhckxheWVyQ2hyb21pdW0+IG1faG9yaXpvbnRh bFNjcm9sbGJhckxheWVyOworICAgIFJlZlB0cjxTY3JvbGxiYXJMYXllckNocm9taXVtPiBtX3Zl cnRpY2FsU2Nyb2xsYmFyTGF5ZXI7CiB9OwogCiBQYXNzUmVmUHRyPFNjcm9sbGluZ0Nvb3JkaW5h dG9yPiBTY3JvbGxpbmdDb29yZGluYXRvcjo6Y3JlYXRlKFBhZ2UqIHBhZ2UpCkBAIC04MSw3ICsx MDMsNyBAQCBzdGF0aWMgR3JhcGhpY3NMYXllciogc2Nyb2xsTGF5ZXJGb3JGcmFtZVZpZXcoRnJh bWVWaWV3KiBmcmFtZVZpZXcpCiAjZW5kaWYKIH0KIAotc3RhdGljIHZvaWQgc2Nyb2xsYmFyTGF5 ZXJEaWRDaGFuZ2UoU2Nyb2xsYmFyKiBzY3JvbGxiYXIsIExheWVyQ2hyb21pdW0qIHNjcm9sbExh eWVyLCBHcmFwaGljc0xheWVyKiBzY3JvbGxiYXJHcmFwaGljc0xheWVyLCBGcmFtZVZpZXcqIGZy YW1lVmlldykKK3N0YXRpYyBQYXNzUmVmUHRyPFNjcm9sbGJhckxheWVyQ2hyb21pdW0+IGNyZWF0 ZVNjcm9sbGJhckxheWVyKFNjcm9sbGJhciogc2Nyb2xsYmFyLCBMYXllckNocm9taXVtKiBzY3Jv bGxMYXllciwgR3JhcGhpY3NMYXllciogc2Nyb2xsYmFyR3JhcGhpY3NMYXllciwgRnJhbWVWaWV3 KiBmcmFtZVZpZXcpCiB7CiAgICAgQVNTRVJUKHNjcm9sbGJhcik7CiAgICAgQVNTRVJUKHNjcm9s bGJhckdyYXBoaWNzTGF5ZXIpOwpAQCAtMTA4LDEzICsxMzAsMTUgQEAgc3RhdGljIHZvaWQgc2Ny b2xsYmFyTGF5ZXJEaWRDaGFuZ2UoU2Nyb2xsYmFyKiBzY3JvbGxiYXIsIExheWVyQ2hyb21pdW0q IHNjcm9sbEwKICAgICBpZiAoc2Nyb2xsYmFyLT5pc0N1c3RvbVNjcm9sbGJhcigpIHx8ICFDQ1By b3h5OjpoYXNJbXBsVGhyZWFkKCkgfHwgIXBsYXRmb3JtU3VwcG9ydGVkKSB7CiAgICAgICAgIHNj cm9sbGJhckdyYXBoaWNzTGF5ZXItPnNldENvbnRlbnRzVG9NZWRpYSgwKTsKICAgICAgICAgc2Ny b2xsYmFyR3JhcGhpY3NMYXllci0+c2V0RHJhd3NDb250ZW50KHRydWUpOwotICAgICAgICByZXR1 cm47CisgICAgICAgIHJldHVybiAwOwogICAgIH0KIAogICAgIFJlZlB0cjxTY3JvbGxiYXJMYXll ckNocm9taXVtPiBzY3JvbGxiYXJMYXllciA9IFNjcm9sbGJhckxheWVyQ2hyb21pdW06OmNyZWF0 ZShzY3JvbGxiYXIsIHNjcm9sbExheWVyLT5pZCgpKTsKICAgICBzY3JvbGxiYXJHcmFwaGljc0xh eWVyLT5zZXRDb250ZW50c1RvTWVkaWEoc2Nyb2xsYmFyTGF5ZXIuZ2V0KCkpOwogICAgIHNjcm9s bGJhckdyYXBoaWNzTGF5ZXItPnNldERyYXdzQ29udGVudChmYWxzZSk7CiAgICAgc2Nyb2xsYmFy TGF5ZXItPnNldE9wYXF1ZShzY3JvbGxiYXJHcmFwaGljc0xheWVyLT5jb250ZW50c09wYXF1ZSgp KTsKKworICAgIHJldHVybiBzY3JvbGxiYXJMYXllci5yZWxlYXNlKCk7CiB9CiAKIHZvaWQgU2Ny b2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmlld0hvcml6b250YWxTY3JvbGxiYXJMYXllckRpZENo YW5nZShGcmFtZVZpZXcqIGZyYW1lVmlldywgR3JhcGhpY3NMYXllciogaG9yaXpvbnRhbFNjcm9s bGJhckxheWVyKQpAQCAtMTIyLDcgKzE0Niw3IEBAIHZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6 OmZyYW1lVmlld0hvcml6b250YWxTY3JvbGxiYXJMYXllckRpZENoYW5nZShGcmFtZVZpZXcqCiAg ICAgaWYgKCFob3Jpem9udGFsU2Nyb2xsYmFyTGF5ZXIgfHwgIWNvb3JkaW5hdGVzU2Nyb2xsaW5n Rm9yRnJhbWVWaWV3KGZyYW1lVmlldykpCiAgICAgICAgIHJldHVybjsKIAotICAgIHNjcm9sbGJh ckxheWVyRGlkQ2hhbmdlKGZyYW1lVmlldy0+aG9yaXpvbnRhbFNjcm9sbGJhcigpLCBtX3ByaXZh dGUtPnNjcm9sbExheWVyKCksIGhvcml6b250YWxTY3JvbGxiYXJMYXllciwgZnJhbWVWaWV3KTsK KyAgICBtX3ByaXZhdGUtPnNldEhvcml6b250YWxTY3JvbGxiYXJMYXllcihjcmVhdGVTY3JvbGxi YXJMYXllcihmcmFtZVZpZXctPmhvcml6b250YWxTY3JvbGxiYXIoKSwgbV9wcml2YXRlLT5zY3Jv bGxMYXllcigpLCBob3Jpem9udGFsU2Nyb2xsYmFyTGF5ZXIsIGZyYW1lVmlldykpOwogfQogCiB2 b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpmcmFtZVZpZXdWZXJ0aWNhbFNjcm9sbGJhckxheWVy RGlkQ2hhbmdlKEZyYW1lVmlldyogZnJhbWVWaWV3LCBHcmFwaGljc0xheWVyKiB2ZXJ0aWNhbFNj cm9sbGJhckxheWVyKQpAQCAtMTMwLDcgKzE1NCw3IEBAIHZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0 b3I6OmZyYW1lVmlld1ZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXJEaWRDaGFuZ2UoRnJhbWVWaWV3KiBm CiAgICAgaWYgKCF2ZXJ0aWNhbFNjcm9sbGJhckxheWVyIHx8ICFjb29yZGluYXRlc1Njcm9sbGlu Z0ZvckZyYW1lVmlldyhmcmFtZVZpZXcpKQogICAgICAgICByZXR1cm47CiAKLSAgICBzY3JvbGxi YXJMYXllckRpZENoYW5nZShmcmFtZVZpZXctPnZlcnRpY2FsU2Nyb2xsYmFyKCksIG1fcHJpdmF0 ZS0+c2Nyb2xsTGF5ZXIoKSwgdmVydGljYWxTY3JvbGxiYXJMYXllciwgZnJhbWVWaWV3KTsKKyAg ICBtX3ByaXZhdGUtPnNldFZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXIoY3JlYXRlU2Nyb2xsYmFyTGF5 ZXIoZnJhbWVWaWV3LT52ZXJ0aWNhbFNjcm9sbGJhcigpLCBtX3ByaXZhdGUtPnNjcm9sbExheWVy KCksIHZlcnRpY2FsU2Nyb2xsYmFyTGF5ZXIsIGZyYW1lVmlldykpOwogfQogCiB2b2lkIFNjcm9s bGluZ0Nvb3JkaW5hdG9yOjpzZXRTY3JvbGxMYXllcihHcmFwaGljc0xheWVyKiBzY3JvbGxMYXll cikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1Njcm9sbGJhckxheWVyQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL1Njcm9sbGJhckxheWVyQ2hyb21pdW0uaAppbmRleCBhZDI1MzllMjVlNjQ4 ZWUyYzM5YmIyNWM0ZWJiNDM5ZmU0MTk2NzZlLi44OTI2YTRkN2ZmNmEyYjMwN2ZlZGFhM2M5MmY5 MzBmYzA3NjRiOGU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9TY3JvbGxiYXJMYXllckNocm9taXVtLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2Nyb2xsYmFyTGF5ZXJDaHJvbWl1bS5oCkBAIC00 Myw2ICs0Myw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgcHVzaFByb3BlcnRpZXNUbyhD Q0xheWVySW1wbCopOwogCiAgICAgaW50IHNjcm9sbExheWVySWQoKSBjb25zdCB7IHJldHVybiBt X3Njcm9sbExheWVySWQ7IH0KKyAgICB2b2lkIHNldFNjcm9sbExheWVySWQoaW50IGlkKSB7IG1f c2Nyb2xsTGF5ZXJJZCA9IGlkOyB9CisKICAgICB2aXJ0dWFsIFNjcm9sbGJhckxheWVyQ2hyb21p dW0qIHRvU2Nyb2xsYmFyTGF5ZXJDaHJvbWl1bSgpIHsgcmV0dXJuIHRoaXM7IH0KIAogcHJvdGVj dGVkOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vVHJlZVN5bmNocm9uaXplci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9UcmVlU3luY2hyb25pemVyLmNwcAppbmRleCBlOTM3M2ZlMGRjNmU0ZTY5OGQ1 YTUxNTg4ODM0ZmY2M2Y0ZGMxN2I4Li41Y2Q0N2M4ODBmZTYyNWM1YTFjYWE3MmE3MGVlOWM4NzVl NjI0YzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9UcmVlU3luY2hyb25pemVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9UcmVlU3luY2hyb25pemVyLmNwcApAQCAtMTE0LDYgKzExNCw5IEBA IHZvaWQgVHJlZVN5bmNocm9uaXplcjo6dXBkYXRlU2Nyb2xsYmFyTGF5ZXJQb2ludGVyc1JlY3Vy c2l2ZShjb25zdCBSYXdQdHJDQ0xheWVyCiAgICAgQ0NTY3JvbGxiYXJMYXllckltcGwqIGNjU2Ny b2xsYmFyTGF5ZXJJbXBsID0gc3RhdGljX2Nhc3Q8Q0NTY3JvbGxiYXJMYXllckltcGwqPihuZXdM YXllcnMuZ2V0KHNjcm9sbGJhckxheWVyLT5pZCgpKSk7CiAgICAgQVNTRVJUKGNjU2Nyb2xsYmFy TGF5ZXJJbXBsKTsKICAgICBjY1Njcm9sbGJhckxheWVySW1wbC0+c2V0U2Nyb2xsTGF5ZXIobmV3 TGF5ZXJzLmdldChzY3JvbGxiYXJMYXllci0+c2Nyb2xsTGF5ZXJJZCgpKSk7CisKKyAgICAvLyBT Y3JvbGxiYXIgbGF5ZXJzIGluIHRoZSB0cmVlIHNob3VsZCBhbHdheXMgcG9pbnQgdG8gYSB2YWxp ZCBzY3JvbGwgbGF5ZXIKKyAgICBBU1NFUlQobmV3TGF5ZXJzLmdldChzY3JvbGxiYXJMYXllci0+ c2Nyb2xsTGF5ZXJJZCgpKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK