88881 2012-06-12 09:12:51 -0700 REGRESSION(r120072): It broke !ENABLE(VIDEO) builds 2012-06-12 15:18:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 87835 1 ossy silviapf eric.carlson ossy silviapf tkent webkit.review.bot oldest_to_newest 646989 0 ossy 2012-06-12 09:12:51 -0700 ../../../../Source/WebCore/html/shadow/SliderThumbElement.cpp: In function 'bool WebCore::hasVerticalAppearance(WebCore::HTMLInputElement*)': ../../../../Source/WebCore/html/shadow/SliderThumbElement.cpp:68: error: 'class WebCore::RenderTheme' has no member named 'usesVerticalVolumeSlider' Could you check and fix it, please? 647005 1 silviapf 2012-06-12 09:27:42 -0700 My fault - I'm taking this. 647047 2 147110 silviapf 2012-06-12 10:29:59 -0700 Created attachment 147110 patch of hasVerticalAppearance function 647051 3 147110 ossy 2012-06-12 10:32:29 -0700 Comment on attachment 147110 patch of hasVerticalAppearance function rs=me 647071 4 147110 ossy 2012-06-12 10:53:08 -0700 Comment on attachment 147110 patch of hasVerticalAppearance function Clearing flags on attachment: 147110 Committed r120092: <http://trac.webkit.org/changeset/120092> 647072 5 ossy 2012-06-12 10:53:16 -0700 All reviewed patches have been landed. Closing bug. 647078 6 147110 darin 2012-06-12 10:57:53 -0700 Comment on attachment 147110 patch of hasVerticalAppearance function View in context: https://bugs.webkit.org/attachment.cgi?id=147110&action=review > Source/WebCore/html/shadow/SliderThumbElement.cpp:73 > +#if ENABLE(VIDEO) > RenderTheme* sliderTheme = input->renderer()->theme(); > > return sliderStyle->appearance() == SliderVerticalPart > || (sliderStyle->appearance() == MediaVolumeSliderPart && sliderTheme->usesVerticalVolumeSlider()); > +#else > + return sliderStyle->appearance() == SliderVerticalPart; > +#endif It would be better to do this with an if statement so we would be able to share the SliderVerticalPart code. #if ENABLE(VIDEO) if (sliderStyle->appearance() == MediaVolumeSliderPart && input->renderer()->theme()->usesVerticalVolumeSlider()) return true; #endif return sliderStyle->appearance() == SliderVerticalPart; 647400 7 silviapf 2012-06-12 15:18:11 -0700 Registered bug 88930 for cleanup. 147110 2012-06-12 10:29:59 -0700 2012-06-12 10:57:53 -0700 patch of hasVerticalAppearance function bug-88881-20120613032958.patch text/plain 1823 silviapf U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBiMzA1N2I1OGIxOWYz MGZjNjg3NDlhY2RjYzg5ZmRmMGZhNTY5ZC4uNDI0MGFkMzRmZGEyYjk0NWUxYjkwMGI1YTg3Y2Jj Njg4NWFjYzcyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTEyICBTaWx2 aWEgUGZlaWZmZXIgIDxzaWx2aWFwZkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU3VwcG9ydCAh RU5BQkxFKFZJREVPKSBidWlsZHMgd2l0aCBob3Jpem9udGFsbHkgbGF5ZWQgb3V0IHZpZGVvIGNv bnRyb2xzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODg4ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMgYXMgdGhpcyBpcyBhIHJlZ3Jlc3Npb24gZnJvbSBXSzg3ODM1LgorCisgICAg ICAgICogaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Omhhc1ZlcnRpY2FsQXBwZWFyYW5jZSk6CisgICAgICAgIElmZGVmIG91dCB2aWRlbyByZWxh dGVkIGZ1bmN0aW9uYWxpdHksIHNpbmNlIHVzZXNWZXJ0aWNhbFZvbHVtZVNsaWRlcgorICAgICAg ICBkb2VzIG5vdCBleGlzdCBpbiB0aGF0IGNhc2UuCisKIDIwMTItMDYtMTIgIENocmlzdG9waGUg RHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVy XSBodHRwL3Rlc3RzL21lZGlhL3ZpZGVvLWJ1ZmZlcmVkLXJhbmdlLWNvbnRhaW5zLWN1cnJlbnRU aW1lLmh0bWwgaXMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFk b3cvU2xpZGVyVGh1bWJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1Ns aWRlclRodW1iRWxlbWVudC5jcHAKaW5kZXggYWE3NTBjYWIxZDYwNGY2Y2YwZmViMWIwNWFhMGE0 MGZmMTJiZWIzZS4uODM3NzVhMjcxM2Q5NjQzZjdlYjZlMGM1NjkxYTY1OTUxYjUzOGVkNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvU2xpZGVyVGh1bWJFbGVtZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9TbGlkZXJUaHVtYkVsZW1lbnQuY3Bw CkBAIC02MiwxMCArNjIsMTUgQEAgaW5saW5lIHN0YXRpYyBib29sIGhhc1ZlcnRpY2FsQXBwZWFy YW5jZShIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCkKIHsKICAgICBBU1NFUlQoaW5wdXQtPnJlbmRl cmVyKCkpOwogICAgIFJlbmRlclN0eWxlKiBzbGlkZXJTdHlsZSA9IGlucHV0LT5yZW5kZXJlcigp LT5zdHlsZSgpOworCisjaWYgRU5BQkxFKFZJREVPKQogICAgIFJlbmRlclRoZW1lKiBzbGlkZXJU aGVtZSA9IGlucHV0LT5yZW5kZXJlcigpLT50aGVtZSgpOwogCiAgICAgcmV0dXJuIHNsaWRlclN0 eWxlLT5hcHBlYXJhbmNlKCkgPT0gU2xpZGVyVmVydGljYWxQYXJ0CiAgICAgICAgIHx8IChzbGlk ZXJTdHlsZS0+YXBwZWFyYW5jZSgpID09IE1lZGlhVm9sdW1lU2xpZGVyUGFydCAmJiBzbGlkZXJU aGVtZS0+dXNlc1ZlcnRpY2FsVm9sdW1lU2xpZGVyKCkpOworI2Vsc2UKKyAgICByZXR1cm4gc2xp ZGVyU3R5bGUtPmFwcGVhcmFuY2UoKSA9PSBTbGlkZXJWZXJ0aWNhbFBhcnQ7CisjZW5kaWYKIH0K IAogU2xpZGVyVGh1bWJFbGVtZW50KiBzbGlkZXJUaHVtYkVsZW1lbnRPZihOb2RlKiBub2RlKQo=