88858 2012-06-12 04:39:06 -0700 Fix packing in StyleBoxData for Windows. 2012-06-12 16:07:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 menard menard eric tony webkit.review.bot oldest_to_newest 646822 0 menard 2012-06-12 04:39:06 -0700 Fix packing in StyleBoxData for Windows. 646826 1 147057 menard 2012-06-12 04:42:56 -0700 Created attachment 147057 Patch 647083 2 147057 tony 2012-06-12 11:03:14 -0700 Comment on attachment 147057 Patch Please add a compile assert. See RenderStyle.cpp for an example of a SameSizeAs COMPILE_ASSERT. 647262 3 147150 menard 2012-06-12 13:50:18 -0700 Created attachment 147150 Patch 647288 4 147150 tony 2012-06-12 14:04:19 -0700 Comment on attachment 147150 Patch Thanks! I want to see the win bot pass before setting cq+. 647294 5 menard 2012-06-12 14:05:41 -0700 (In reply to comment #4) > (From update of attachment 147150 [details]) > Thanks! I want to see the win bot pass before setting cq+. Sounds like a plan :) 647442 6 147150 webkit.review.bot 2012-06-12 16:07:39 -0700 Comment on attachment 147150 Patch Clearing flags on attachment: 147150 Committed r120136: <http://trac.webkit.org/changeset/120136> 647443 7 webkit.review.bot 2012-06-12 16:07:44 -0700 All reviewed patches have been landed. Closing bug. 147057 2012-06-12 04:42:56 -0700 2012-06-12 13:50:11 -0700 Patch bug-88858-20120612084232.patch text/plain 1460 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMwOGExNzQ5OWExYTgz NzQ2NWNiNmJjNjdlMDg0ZjI2NTc3NTcyYS4uOTI0NmQzMmM0NGRlOWZiZDQ2NzI5ZGE2YmNmNzRj ZDU2MTAwNDliZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTEyICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEZpeCBw YWNraW5nIGluIFN0eWxlQm94RGF0YSBmb3IgV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTVNWQyBkb2Vzbid0IHBhY2sgYml0ZmllbGRzIGlm IHRoZSB0eXBlcyBhcmUgbWl4ZWQuCisgICAgICAgIFdlIGNhbiBzYWZlbHkgY2hhbmdlIHRoZSBi b29sIHR5cGUgdG8gYW4gdW5zaWduZWQgc28KKyAgICAgICAgdGhlIHBhY2tpbmcgd2lsbCBoYXBw ZW4uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogd2Ugc2hvdWxkIG5vdCBzZWUgYW55IHJlZ3Jl c3Npb25zLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxlQm94RGF0YS5oOgorICAg ICAgICAoU3R5bGVCb3hEYXRhKToKKwogMjAxMi0wNi0xMiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjEyMDA1MS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHls ZUJveERhdGEuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZUJveERhdGEu aAppbmRleCBjMGQyNDliMWY1ZTcyMWY3YTVlM2ZjN2Y3YzRjMzBhMDA2ZmZlNzQzLi44NmZkNmU5 MjIyNDY3ZmQ5YTY0OTRlZDg0NTYzMWI2ODAwNzIxNDVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVCb3hEYXRhLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1N0eWxlQm94RGF0YS5oCkBAIC04MCw3ICs4MCw3IEBAIHByaXZhdGU6 CiAgICAgTGVuZ3RoIG1fdmVydGljYWxBbGlnbjsKIAogICAgIGludCBtX3pJbmRleDsKLSAgICBi b29sIG1faGFzQXV0b1pJbmRleCA6IDE7CisgICAgdW5zaWduZWQgbV9oYXNBdXRvWkluZGV4IDog MTsKICAgICB1bnNpZ25lZCBtX2JveFNpemluZyA6IDE7IC8vIEVCb3hTaXppbmcKICNpZiBFTkFC TEUoQ1NTX0JPWF9ERUNPUkFUSU9OX0JSRUFLKQogICAgIHVuc2lnbmVkIG1fYm94RGVjb3JhdGlv bkJyZWFrIDogMTsgLy8gRUJveERlY29yYXRpb25CcmVhawo= 147150 2012-06-12 13:50:18 -0700 2012-06-12 16:07:39 -0700 Patch bug-88858-20120612174954.patch text/plain 2365 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDIxZDFiNjc4OGFiOGMz MjgyMTI2YTc1OWYwYzQ3ZDQ1ZWEwZmM5My4uN2U4OWZmN2I3YWY3ZWQyODczNzQ4NDhkYzEwMWY5 YzgzNzM4NzQ3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTEyICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIEZpeCBw YWNraW5nIGluIFN0eWxlQm94RGF0YSBmb3IgV2luZG93cy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTVNWQyBkb2Vzbid0IHBhY2sgYml0ZmllbGRzIGlm IHRoZSB0eXBlcyBhcmUgbWl4ZWQuCisgICAgICAgIFdlIGNhbiBzYWZlbHkgY2hhbmdlIHRoZSBi b29sIHR5cGUgdG8gYW4gdW5zaWduZWQgc28KKyAgICAgICAgdGhlIHBhY2tpbmcgd2lsbCBoYXBw ZW4uIEkgaGF2ZSBhZGRlZCBhIGNvbXBpbGUgYXNzZXJ0CisgICAgICAgIGZvciBmdXR1cmUgcmVn cmVzc2lvbnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIDogd2Ugc2hvdWxkIG5vdCBzZWUgYW55 IHJlZ3Jlc3Npb25zLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxlQm94RGF0YS5o OgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TdHlsZUJveERhdGEuY3BwOgorICAgICAgICAo U3R5bGVCb3hEYXRhKToKKwogMjAxMi0wNi0xMiAgUmFodWwgVGl3YXJpICA8cmFodWx0aXdhcmku Y3NlLmlpdHJAZ21haWwuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb3ZpZGUgY29u dGV4dCBtZW51IGZvciBkZWxldGluZyByZWNvcmRlZCBwcm9maWxlIG9uIFByb2ZpbGVzIFBhbmVs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVCb3hEYXRh LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZUJveERhdGEuY3BwCmlu ZGV4IGEzNzg2OTU5YzhmNmUyMWU2YzllMzQ4YjE3YzRjODUzZTNkMWUwNTkuLjNmYzAwYzhkYzQz NTlhZDgzNjZmOWE1OTY0ZjAzNmUyYzBlYWQzOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdHlsZS9TdHlsZUJveERhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9TdHlsZUJveERhdGEuY3BwCkBAIC0yNyw2ICsyNywxNCBAQAogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKK3N0cnVjdCBTYW1lU2l6ZUFzU3R5bGVCb3hEYXRhIDogcHVibGlj IFJlZkNvdW50ZWQ8U2FtZVNpemVBc1N0eWxlQm94RGF0YT4geworICAgIExlbmd0aCBsZW5ndGhb N107CisgICAgaW50IG1fekluZGV4OworICAgIHVpbnQzMl90IGJpdGZpZWxkczsKK307CisKK0NP TVBJTEVfQVNTRVJUKHNpemVvZihTdHlsZUJveERhdGEpID09IHNpemVvZihTYW1lU2l6ZUFzU3R5 bGVCb3hEYXRhKSwgU3R5bGVCb3hEYXRhX3Nob3VsZF9ub3RfZ3Jvdyk7CisKIFN0eWxlQm94RGF0 YTo6U3R5bGVCb3hEYXRhKCkKICAgICA6IG1fbWluV2lkdGgoUmVuZGVyU3R5bGU6OmluaXRpYWxN aW5TaXplKCkpCiAgICAgLCBtX21heFdpZHRoKFJlbmRlclN0eWxlOjppbml0aWFsTWF4U2l6ZSgp KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlQm94RGF0 YS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlQm94RGF0YS5oCmluZGV4 IGMwZDI0OWIxZjVlNzIxZjdhNWUzZmM3ZjdjNGMzMGEwMDZmZmU3NDMuLjg2ZmQ2ZTkyMjI0Njdm ZDlhNjQ5NGVkODQ1NjMxYjY4MDA3MjE0NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9TdHlsZUJveERhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvU3R5bGVCb3hEYXRhLmgKQEAgLTgwLDcgKzgwLDcgQEAgcHJpdmF0ZToKICAgICBM ZW5ndGggbV92ZXJ0aWNhbEFsaWduOwogCiAgICAgaW50IG1fekluZGV4OwotICAgIGJvb2wgbV9o YXNBdXRvWkluZGV4IDogMTsKKyAgICB1bnNpZ25lZCBtX2hhc0F1dG9aSW5kZXggOiAxOwogICAg IHVuc2lnbmVkIG1fYm94U2l6aW5nIDogMTsgLy8gRUJveFNpemluZwogI2lmIEVOQUJMRShDU1Nf Qk9YX0RFQ09SQVRJT05fQlJFQUspCiAgICAgdW5zaWduZWQgbV9ib3hEZWNvcmF0aW9uQnJlYWsg OiAxOyAvLyBFQm94RGVjb3JhdGlvbkJyZWFrCg==