88848 2012-06-12 02:27:15 -0700 Removing unused parameter Page* 2012-06-12 05:06:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 aousterh webkit-unassigned hans haraken webkit.review.bot oldest_to_newest 646759 0 aousterh 2012-06-12 02:27:15 -0700 Removing unused parameter Page 646762 1 147043 aousterh 2012-06-12 02:35:35 -0700 Created attachment 147043 Patch 646764 2 147043 hans 2012-06-12 02:40:57 -0700 Comment on attachment 147043 Patch Looks good to me! 646781 3 147043 haraken 2012-06-12 03:52:55 -0700 Comment on attachment 147043 Patch Looks OK. 646784 4 aousterh 2012-06-12 03:56:51 -0700 thanks for the review! 646841 5 147043 webkit.review.bot 2012-06-12 05:06:36 -0700 Comment on attachment 147043 Patch Clearing flags on attachment: 147043 Committed r120061: <http://trac.webkit.org/changeset/120061> 646842 6 webkit.review.bot 2012-06-12 05:06:45 -0700 All reviewed patches have been landed. Closing bug. 147043 2012-06-12 02:35:35 -0700 2012-06-12 05:06:36 -0700 Patch bug-88848-20120612103534.patch text/plain 3983 aousterh U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVmMjZjNjAwM2RmMGRi NjM1NThmMjQ0NzZkM2Q3YThkZjNjZGE4OS4uZTdmOThiMDkyNmZmNjc4Mjc0YWMzNTM0ZmYwZGU5 NzJjNTExMjNkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA2LTEyICBBbXkg T3VzdGVyaG91dCAgPGFvdXN0ZXJoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmluZyB1 bnVzZWQgcGFyYW1ldGVyIFBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg4ODQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVtb3ZlZCB0aGUgdW51c2VkIHBhcmFtZXRlciBQYWdlKiBzdXBwbGllZCB0 byB0aGUgY3JlYXRlIGZ1bmN0aW9uCisgICAgICAgIGFuZCBjb25zdHJ1Y3RvciBpbiBEZXZpY2VP cmllbnRhdGlvbkNvbnRyb2xsZXIuCisKKyAgICAgICAgVGhlIHBhcmFtZXRlciBQYWdlKiB3YXMg cHJldmlvdXNseSBzdG9yZWQgaW4gYW4gaW5zdGFuY2UgdmFyaWFibGUKKyAgICAgICAgbV9wYWdl LCBidXQgdGhpcyB3YXMgcmVtb3ZlZCAoc2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04ODgxMikuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlIHJl bW92ZWQgcGFyYW1ldGVyIHdhcyB1bnVzZWQgYW5kIHVudGVzdGVkLgorCisgICAgICAgICogZG9t L0RldmljZU9yaWVudGF0aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEZXZp Y2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OkRldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcik6Cisg ICAgICAgIChXZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OmNyZWF0ZSk6Cisg ICAgICAgIChXZWJDb3JlOjpwcm92aWRlRGV2aWNlT3JpZW50YXRpb25Ubyk6CisgICAgICAgICog ZG9tL0RldmljZU9yaWVudGF0aW9uQ29udHJvbGxlci5oOgorICAgICAgICAoRGV2aWNlT3JpZW50 YXRpb25Db250cm9sbGVyKToKKwogMjAxMi0wNi0xMSAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBtZW1iZXIgdmFyaWFibGVzIGZvdW5k IGJ5IGNsYW5nJ3MgLVd1bnVzZWQtcHJpdmF0ZS1maWVsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0RldmljZU9yaWVudGF0aW9uQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyLmNwcAppbmRleCA3ZjE4YzI0YjA3NTk4 OWI2YmU3MjJhMmU3NjRlYmJiMGMxYzBkMTA4Li41ZDRiY2RkZmYxYjU5ZDUyODZhODJiYTUxZjk4 Y2NhYzRhOTgwMmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50 YXRpb25Db250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50 YXRpb25Db250cm9sbGVyLmNwcApAQCAtMzIsNyArMzIsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKLURldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjo6RGV2aWNlT3JpZW50YXRpb25Db250 cm9sbGVyKFBhZ2UqLCBEZXZpY2VPcmllbnRhdGlvbkNsaWVudCogY2xpZW50KQorRGV2aWNlT3Jp ZW50YXRpb25Db250cm9sbGVyOjpEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXIoRGV2aWNlT3Jp ZW50YXRpb25DbGllbnQqIGNsaWVudCkKICAgICA6IG1fY2xpZW50KGNsaWVudCkKICAgICAsIG1f dGltZXIodGhpcywgJkRldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjo6dGltZXJGaXJlZCkKIHsK QEAgLTQ1LDkgKzQ1LDkgQEAgRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyOjp+RGV2aWNlT3Jp ZW50YXRpb25Db250cm9sbGVyKCkKICAgICBtX2NsaWVudC0+ZGV2aWNlT3JpZW50YXRpb25Db250 cm9sbGVyRGVzdHJveWVkKCk7CiB9CiAKLVBhc3NPd25QdHI8RGV2aWNlT3JpZW50YXRpb25Db250 cm9sbGVyPiBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OmNyZWF0ZShQYWdlKiBwYWdlLCBE ZXZpY2VPcmllbnRhdGlvbkNsaWVudCogY2xpZW50KQorUGFzc093blB0cjxEZXZpY2VPcmllbnRh dGlvbkNvbnRyb2xsZXI+IERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjo6Y3JlYXRlKERldmlj ZU9yaWVudGF0aW9uQ2xpZW50KiBjbGllbnQpCiB7Ci0gICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBE ZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXIocGFnZSwgY2xpZW50KSk7CisgICAgcmV0dXJuIGFk b3B0UHRyKG5ldyBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXIoY2xpZW50KSk7CiB9CiAKIHZv aWQgRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyOjp0aW1lckZpcmVkKFRpbWVyPERldmljZU9y aWVudGF0aW9uQ29udHJvbGxlcj4qIHRpbWVyKQpAQCAtMTUxLDcgKzE1MSw3IEBAIGJvb2wgRGV2 aWNlT3JpZW50YXRpb25Db250cm9sbGVyOjppc0FjdGl2ZUF0KFBhZ2UqIHBhZ2UpCiAKIHZvaWQg cHJvdmlkZURldmljZU9yaWVudGF0aW9uVG8oUGFnZSogcGFnZSwgRGV2aWNlT3JpZW50YXRpb25D bGllbnQqIGNsaWVudCkKIHsKLSAgICBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OnByb3Zp ZGVUbyhwYWdlLCBEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI6OnN1cHBsZW1lbnROYW1lKCks IERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjo6Y3JlYXRlKHBhZ2UsIGNsaWVudCkpOworICAg IERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcjo6cHJvdmlkZVRvKHBhZ2UsIERldmljZU9yaWVu dGF0aW9uQ29udHJvbGxlcjo6c3VwcGxlbWVudE5hbWUoKSwgRGV2aWNlT3JpZW50YXRpb25Db250 cm9sbGVyOjpjcmVhdGUoY2xpZW50KSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXIu aCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXIuaAppbmRl eCBjZmRhYmZlMWQ4NjhkYzNkYTE5YzY5YWNiNjM5NDk5MTdkNDQ0YWQyLi43ZjhjMDA4ZjA1NmNi OTQ4ZDI1NjA1YzM1MWRkOTVmYTE1MzhhM2U3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k b20vRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RldmljZU9yaWVudGF0aW9uQ29udHJvbGxlci5oCkBAIC00MSw3ICs0MSw3IEBAIGNsYXNzIERl dmljZU9yaWVudGF0aW9uQ29udHJvbGxlciA6IHB1YmxpYyBTdXBwbGVtZW50PFBhZ2U+IHsKIHB1 YmxpYzoKICAgICB+RGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyKCk7CiAKLSAgICBzdGF0aWMg UGFzc093blB0cjxEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXI+IGNyZWF0ZShQYWdlKiwgRGV2 aWNlT3JpZW50YXRpb25DbGllbnQqKTsKKyAgICBzdGF0aWMgUGFzc093blB0cjxEZXZpY2VPcmll bnRhdGlvbkNvbnRyb2xsZXI+IGNyZWF0ZShEZXZpY2VPcmllbnRhdGlvbkNsaWVudCopOwogCiAg ICAgdm9pZCBhZGRMaXN0ZW5lcihET01XaW5kb3cqKTsKICAgICB2b2lkIHJlbW92ZUxpc3RlbmVy KERPTVdpbmRvdyopOwpAQCAtNjEsNyArNjEsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIGJvb2wg aXNBY3RpdmVBdChQYWdlKik7CiAKIHByaXZhdGU6Ci0gICAgRGV2aWNlT3JpZW50YXRpb25Db250 cm9sbGVyKFBhZ2UqLCBEZXZpY2VPcmllbnRhdGlvbkNsaWVudCopOworICAgIERldmljZU9yaWVu dGF0aW9uQ29udHJvbGxlcihEZXZpY2VPcmllbnRhdGlvbkNsaWVudCopOwogCiAgICAgdm9pZCB0 aW1lckZpcmVkKFRpbWVyPERldmljZU9yaWVudGF0aW9uQ29udHJvbGxlcj4qKTsKIAo=