88839 2012-06-11 22:51:30 -0700 webcore should depend on webcore_arm_neon for only arm target_arch 2012-06-12 22:01:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 james.wei james.wei abarth thakis webkit.review.bot oldest_to_newest 646641 0 james.wei 2012-06-11 22:51:30 -0700 webcore should depend on webcore_arm_neon for only arm target_arch 646642 1 147011 james.wei 2012-06-11 22:52:05 -0700 Created attachment 147011 Patch 646958 2 thakis 2012-06-12 08:24:16 -0700 Why do you need this? Since https://bugs.webkit.org/show_bug.cgi?id=80626 , webcore_arm_neon is an empty target on non-arm, and depending on that should be harmless. 647304 3 james.wei 2012-06-12 14:09:20 -0700 (In reply to comment #2) > Why do you need this? Since https://bugs.webkit.org/show_bug.cgi?id=80626 , webcore_arm_neon is an empty target on non-arm, and depending on that should be harmless. yes, it is harmless. But it is very strange I found webcore_arm_neon.stamp in somewhere when I was building other targets. 647306 4 thakis 2012-06-12 14:10:37 -0700 I'm fine with this landing, but I'm not a webkit reviewer, so I can't r+ 647312 5 james.wei 2012-06-12 14:13:35 -0700 (In reply to comment #4) > I'm fine with this landing, but I'm not a webkit reviewer, so I can't r+ +abarth. could you kindly help to review it? thanks 647388 6 147011 abarth 2012-06-12 15:06:04 -0700 Comment on attachment 147011 Patch ok 647671 7 147011 webkit.review.bot 2012-06-12 22:01:10 -0700 Comment on attachment 147011 Patch Clearing flags on attachment: 147011 Committed r120160: <http://trac.webkit.org/changeset/120160> 647672 8 webkit.review.bot 2012-06-12 22:01:15 -0700 All reviewed patches have been landed. Closing bug. 147011 2012-06-11 22:52:05 -0700 2012-06-12 22:01:10 -0700 Patch bug-88839-20120612135211.patch text/plain 1456 james.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjk5MjdjZjgwZTljMDhk NDdkYzRiNDFhOGI2YzJiMmE5NWIzZmVjMy4uNTQ5YjJiZDVkNTQyNmQyOWE0ZjM3MGYxYTVhOGFh MzkxY2NmZTk2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA2LTExICBXZWkg SmFtZXMgIDxqYW1lcy53ZWlAaW50ZWwuY29tPgorCisgICAgICAgIHdlYmNvcmUgc2hvdWxkIGRl cGVuZCBvbiB3ZWJjb3JlX2FybV9uZW9uIGZvciBvbmx5IGFybSB0YXJnZXRfYXJjaAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg4MzkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUuZ3lwL1dl YkNvcmUuZ3lwOgorCiAyMDEyLTA2LTExICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtDU1MzIEJhY2tncm91bmRzIGFuZCBCb3JkZXJzXSBQ cm90ZWN0IGJveC1kZWNvcmF0aW9uLWJyZWFrIGJlaGluZCBhIGZlYXR1cmUgZmxhZy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5kZXggNWMxNGYwMzc2MTYyMTY0YTViNjZh NmM4OGVlZmJlOWFlYjJhN2U0OC4uNDA1ODczODZjN2QzY2ZhOGZkMjc4ZmM4YTMxNTMwYzViMjMw NzI2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAK KysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTE5OTEsNyAr MTk5MSw2IEBACiAgICAgICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZScsCiAgICAgICAndHlwZSc6 ICdub25lJywKICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCi0gICAgICAgICd3ZWJjb3JlX2FybV9u ZW9uJywKICAgICAgICAgJ3dlYmNvcmVfZG9tJywKICAgICAgICAgJ3dlYmNvcmVfaHRtbCcsCiAg ICAgICAgICd3ZWJjb3JlX3BsYXRmb3JtJywKQEAgLTIwMTksNiArMjAxOCwxMSBAQAogICAgICAg ICBdLAogICAgICAgfSwKICAgICAgICdjb25kaXRpb25zJzogWworICAgICAgICBbJ3RhcmdldF9h cmNoPT0iYXJtIicsIHsKKyAgICAgICAgICAnZGVwZW5kZW5jaWVzJzogWworICAgICAgICAgICAg J3dlYmNvcmVfYXJtX25lb24nLAorICAgICAgICAgIF0sCisgICAgICAgIH1dLAogICAgICAgICBb J09TPT0ibWFjIicsIHsKICAgICAgICAgICAnZGlyZWN0X2RlcGVuZGVudF9zZXR0aW5ncyc6IHsK ICAgICAgICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCg==