88835 2012-06-11 20:43:14 -0700 Checking a radio button doesn't uncheck other buttons in the same group in some cases 2012-06-12 21:01:33 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 88825 1 rniwa tkent adamk adele rakeshchaitan tkent webkit.review.bot oldest_to_newest 646593 0 147002 rniwa 2012-06-11 20:43:14 -0700 Created attachment 147002 Demonstrates the assertion failure ASSERTION FAILED: m_nameToGroupMap /Volumes/Data/webkit3/Source/WebCore/dom/CheckedRadioButtons.cpp(199) : void WebCore::CheckedRadioButtons::updateCheckedState(WebCore::HTMLInputElement*) 1 0x102d9175d WebCore::CheckedRadioButtons::updateCheckedState(WebCore::HTMLInputElement*) 2 0x1036df1f7 WebCore::HTMLInputElement::setChecked(bool, WebCore::TextFieldEventBehavior) 3 0x103a1e216 WebCore::setJSHTMLInputElementChecked(JSC::ExecState*, JSC::JSObject*, JSC::JSValue) 4 0x103a1fe95 bool JSC::lookupPut<WebCore::JSHTMLInputElement>(JSC::ExecState*, JSC::PropertyName, JSC::JSValue, JSC::HashTable const*, WebCore::JSHTMLInputElement*, bool) 5 0x103a1ff26 void JSC::lookupPut<WebCore::JSHTMLInputElement, WebCore::JSHTMLElement>(JSC::ExecState*, JSC::PropertyName, JSC::JSValue, JSC::HashTable const*, WebCore::JSHTMLInputElement*, JSC::PutPropertySlot&) 6 0x103a1e31a WebCore::JSHTMLInputElement::put(JSC::JSCell*, JSC::ExecState*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) 7 0x101e5bbdd JSC::JSValue::put(JSC::ExecState*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) 8 0x10206141f llint_slow_path_put_by_id 9 0x10206a6ac llint_op_put_by_id 646594 1 rniwa 2012-06-11 20:44:44 -0700 Note please place the attached file in fast/forms or other paths that's 2-directories below LayoutTests. 646640 2 tkent 2012-06-11 22:50:02 -0700 I identified the problem. http://trac.webkit.org/changeset/111051 was incomplete. r111051 changed the behavior so that radio buttons in an orphan form make groups. However the current code unregisters a radio button from its group whenever a tree including the radio button is detached from a tree. 646683 3 147023 tkent 2012-06-11 23:49:29 -0700 Created attachment 147023 Patch 646699 4 147023 rniwa 2012-06-12 00:18:21 -0700 Comment on attachment 147023 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147023&action=review > Source/WebCore/ChangeLog:5 > + Fix a bug that checking a radio button in a radio button group in a from > + detached from a document tree doesn't uncheck another radio button in > + the radio button group. Why is this different from the bug title? I should go below the reviewed by line. > Source/WebCore/ChangeLog:14 > + Register this to CheckedRadioButtons only if new owner is Document. Did you mean only if the new owner is in the document? Also, could you explain why doing so fixes the bug? > Source/WebCore/ChangeLog:16 > + Unregister this from CheckedRadioButtons only if old owner was Document. Ditto. 646726 5 147033 tkent 2012-06-12 01:28:33 -0700 Created attachment 147033 Patch 2 Update ChangeLog 646982 6 147033 rniwa 2012-06-12 09:01:18 -0700 Comment on attachment 147033 Patch 2 Thanks for the detailed description! 647290 7 147033 webkit.review.bot 2012-06-12 14:04:23 -0700 Comment on attachment 147033 Patch 2 Clearing flags on attachment: 147033 Committed r120118: <http://trac.webkit.org/changeset/120118> 647291 8 webkit.review.bot 2012-06-12 14:04:28 -0700 All reviewed patches have been landed. Closing bug. 147002 2012-06-11 20:43:14 -0700 2012-06-11 20:43:14 -0700 Demonstrates the assertion failure radionodelist-whose-form-element-detached-from-domtree.html text/html 2826 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KPG1ldGEgY2hhcnNldD0idXRmLTgiPgo8c2Ny aXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KPC9oZWFk Pgo8Ym9keT4KPGRpdiBpZD0iY29udGFpbmVyIj4KPGZvcm0gaWQ9InRlc3RGb3JtIj4KICAgIFJh ZGlvIGJ1dHRvbiBhcnJheToKICAgIDxpbnB1dCB0eXBlPSJyYWRpbyIgbmFtZT0idHlwZTEiIHZh bHVlPSJ2YWx1ZTEiPgogICAgPGlucHV0IHR5cGU9InJhZGlvIiBuYW1lPSJ0eXBlMSIgdmFsdWU9 InZhbHVlMiI+CiAgICA8aW5wdXQgdHlwZT0icmFkaW8iIG5hbWU9InR5cGUyIiB2YWx1ZT0idmFs dWU0Ij4KICAgIDxpbnB1dCB0eXBlPSJyYWRpbyIgbmFtZT0idHlwZTIiIHZhbHVlPSJ2YWx1ZTUi PgogICAgPGJyPgogICAgU2luZ2xlIGNoZWNrYm94OgogICAgPGlucHV0IHR5cGU9ImNoZWNrYm94 IiBuYW1lPSJjaGtib3giIHZhbHVlPSJjaGtib3h2YWx1ZSI+CiAgICA8YnI+CjwvZm9ybT4KPGRp diBpZD0iZXh0ZXJuYWwtZWxlbWVudHMiPgo8aW5wdXQgdHlwZT0icmFkaW8iIGZvcm09InRlc3RG b3JtIiBuYW1lPSJ0eXBlMSIgdmFsdWU9InZhbHVlMyI+CjxpbnB1dCB0eXBlPSJyYWRpbyIgZm9y bT0idGVzdEZvcm0iIG5hbWU9InR5cGUyIiB2YWx1ZT0idmFsdWU2Ij4KPC9kaXY+CjwvZGl2Pgo8 ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KPHNjcmlwdD4KCmRlc2NyaXB0aW9uKCJSYWRpb05vZGVM aXN0IHNob3VsZCBiZSByb290ZWQgYXQgZm9ybSBpdHNlbGYgaWYgZGV0YWNoZWQgZnJvbSBkb20g dHJlZSIpOwpkZWJ1ZygiIik7CnZhciBvd25lciA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0 ZXN0Rm9ybScpOwp2YXIgcmFkaW9Ob2RlTGlzdDEgPSBvd25lci5lbGVtZW50c1sndHlwZTEnXTsK dmFyIHJhZGlvTm9kZUxpc3QyID0gb3duZXIuZWxlbWVudHNbJ3R5cGUyJ107CnZhciBjb250YWlu ZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29udGFpbmVyJyk7CgpmdW5jdGlvbiB0ZXN0 UmFkaW9Ob2RlTGlzdChleHBlY3RlZE51bWJlck9mSXRlbXMpIHsKICAgIHNob3VsZEJlKCdyYWRp b05vZGVMaXN0MS5sZW5ndGgnLCBleHBlY3RlZE51bWJlck9mSXRlbXMgKyAnJyk7CiAgICBzaG91 bGRCZSgncmFkaW9Ob2RlTGlzdDIubGVuZ3RoJywgZXhwZWN0ZWROdW1iZXJPZkl0ZW1zICsgJycp OwoKICAgIHNob3VsZEJlKCdyYWRpb05vZGVMaXN0MVswXS52YWx1ZScsICIndmFsdWUxJyIpOwog ICAgc2hvdWxkQmUoJ3JhZGlvTm9kZUxpc3QxWzFdLnZhbHVlJywgIid2YWx1ZTInIik7CiAgICBp ZiAoZXhwZWN0ZWROdW1iZXJPZkl0ZW1zID09IDMpCiAgICAgICAgc2hvdWxkQmUoJ3JhZGlvTm9k ZUxpc3QxWzJdLnZhbHVlJywgIid2YWx1ZTMnIik7CiAgICBzaG91bGRCZSgncmFkaW9Ob2RlTGlz dDJbMF0udmFsdWUnLCAiJ3ZhbHVlNCciKTsKICAgIHNob3VsZEJlKCdyYWRpb05vZGVMaXN0Mlsx XS52YWx1ZScsICIndmFsdWU1JyIpOwogICAgaWYgKGV4cGVjdGVkTnVtYmVyT2ZJdGVtcyA9PSAz KQogICAgICAgIHNob3VsZEJlKCdyYWRpb05vZGVMaXN0MlsyXS52YWx1ZScsICIndmFsdWU2JyIp Owp9CgpkZWJ1ZygiZm9ybSBpbiBkb20gdHJlZSIpOwp0ZXN0UmFkaW9Ob2RlTGlzdCgzKTsKCmRl YnVnKCJDaGVjayBSYWRpb05vZGVMaXN0LnZhbHVlIik7CnNob3VsZEJlKCdyYWRpb05vZGVMaXN0 MS52YWx1ZScsICciIicpOwpzaG91bGRCZSgncmFkaW9Ob2RlTGlzdDIudmFsdWUnLCAnIiInKTsK c2hvdWxkQmUoJ3JhZGlvTm9kZUxpc3QxWzJdLmNoZWNrZWQgPSB0cnVlOyByYWRpb05vZGVMaXN0 MS52YWx1ZScsICIndmFsdWUzJyIpOwoKY29udGFpbmVyLnJlbW92ZUNoaWxkKG93bmVyKTsKCmRl YnVnKCIiKTsKZGVidWcoImZvcm0gZGV0YWNoZWQgZnJvbSBkb20gdHJlZSIpOwp0ZXN0UmFkaW9O b2RlTGlzdCgyKTsKCmRlYnVnKCJDaGVjayBSYWRpb05vZGVMaXN0LnZhbHVlIik7CnNob3VsZEJl KCdyYWRpb05vZGVMaXN0MVsxXS5jaGVja2VkID0gdHJ1ZTsgcmFkaW9Ob2RlTGlzdDEudmFsdWUn LCAiJ3ZhbHVlMiciKTsKCmNvbnRhaW5lci5hcHBlbmRDaGlsZChvd25lcik7CnZhciBleHRlcm5h bEVsZW1lbnRzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2V4dGVybmFsLWVsZW1lbnRzJyk7 CmV4dGVybmFsRWxlbWVudHMucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChleHRlcm5hbEVsZW1lbnRz KTsKY29udGFpbmVyLmFwcGVuZENoaWxkKGV4dGVybmFsRWxlbWVudHMpOwoKZGVidWcoIiIpOwpk ZWJ1ZygiZm9ybSBhZ2FpbiBhZGRlZCB0byBkb20gdHJlZSIpOwp0ZXN0UmFkaW9Ob2RlTGlzdCgz KTsKCmNvbnRhaW5lci5wYXJlbnROb2RlLnJlbW92ZUNoaWxkKGNvbnRhaW5lcik7CgpkZWJ1Zygi Iik7CmRlYnVnKCJmb3JtJ3MgYW5jZXN0b3IgZGV0YWNoZWQgZnJvbSBkb20gdHJlZSIpOwp0ZXN0 UmFkaW9Ob2RlTGlzdCgyKTsKCmRlYnVnKCJDaGVjayBSYWRpb05vZGVMaXN0LnZhbHVlIik7CnNo b3VsZEJlKCdyYWRpb05vZGVMaXN0MVsxXS5jaGVja2VkID0gdHJ1ZTsgcmFkaW9Ob2RlTGlzdDEu dmFsdWUnLCAiJ3ZhbHVlMiciKTsKCmRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoY29udGFpbmVy KTsKCmRlYnVnKCIiKTsKZGVidWcoImZvcm0gYWdhaW4gYWRkZWQgdG8gZG9tIHRyZWUiKTsKdGVz dFJhZGlvTm9kZUxpc3QoMyk7Cgpjb250YWluZXIucGFyZW50Tm9kZS5yZW1vdmVDaGlsZChjb250 YWluZXIpOwo8L3NjcmlwdD4KPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBv c3QuanMiPjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 147023 2012-06-11 23:49:29 -0700 2012-06-12 01:28:27 -0700 Patch bug-88835-20120612154928.patch text/plain 4892 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ1YmVjYmRlNDc0MWRi MjJjMTYwMDhmNDM2Y2U5MzcxNjc5YjBiOC4uODRlODM1YWIyNTI1MzAwOTRlMTQ3OTM2N2IyOGU4 N2E0YmRmYzExYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTExICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSBidWcgdGhhdCBj aGVja2luZyBhIHJhZGlvIGJ1dHRvbiBpbiBhIHJhZGlvIGJ1dHRvbiBncm91cCBpbiBhIGZyb20K KyAgICAgICAgZGV0YWNoZWQgZnJvbSBhIGRvY3VtZW50IHRyZWUgZG9lc24ndCB1bmNoZWNrIGFu b3RoZXIgcmFkaW8gYnV0dG9uIGluCisgICAgICAgIHRoZSByYWRpbyBidXR0b24gZ3JvdXAuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODgzNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IEFkZCB0 ZXN0IGNhc2VzIHRvIGZhc3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3JvdXAuaHRtbAorCisgICAgICAg ICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1 dEVsZW1lbnQ6Omluc2VydGVkSW50byk6CisgICAgICAgIFJlZ2lzdGVyIHRoaXMgdG8gQ2hlY2tl ZFJhZGlvQnV0dG9ucyBvbmx5IGlmIG5ldyBvd25lciBpcyBEb2N1bWVudC4KKyAgICAgICAgKFdl YkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OnJlbW92ZWRGcm9tKToKKyAgICAgICAgVW5yZWdpc3Rl ciB0aGlzIGZyb20gQ2hlY2tlZFJhZGlvQnV0dG9ucyBvbmx5IGlmIG9sZCBvd25lciB3YXMgRG9j dW1lbnQuCisKIDIwMTItMDYtMTAgIFBhYmxvIEZsb3VyZXQgIDxwYWJsb2ZAbW90b3JvbGEuY29t PgogCiAgICAgICAgIEFjY2VzcyBjb250cm9sIGFsbG93IGxpc3RzIHN0YXJ0aW5nIHdpdGggYSBj b21tYSBhcmUgcGFyc2VkIGluY29ycmVjdGx5IChDT1JTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TElucHV0RWxlbWVudC5jcHAKaW5kZXggYzZjZjFmNDk3MWU2YWQ2MmRkYmM1ZjM3OWRkYjc4Yjkz YzM0Y2U4Yy4uZTJlYmRiNTI3NTkzMzNmNGIwMmJiNjNlMGVkOWRmMWRlNjY0NzE1MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC0xMzUyLDE2ICsxMzUyLDE0 IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6ZGlkQ2hhbmdlRm9ybSgpCiBOb2RlOjpJbnNlcnRp b25Ob3RpZmljYXRpb25SZXF1ZXN0IEhUTUxJbnB1dEVsZW1lbnQ6Omluc2VydGVkSW50byhDb250 YWluZXJOb2RlKiBpbnNlcnRpb25Qb2ludCkKIHsKICAgICBIVE1MVGV4dEZvcm1Db250cm9sRWxl bWVudDo6aW5zZXJ0ZWRJbnRvKGluc2VydGlvblBvaW50KTsKLSAgICBpZiAoIWluc2VydGlvblBv aW50LT5pbkRvY3VtZW50KCkpCi0gICAgICAgIHJldHVybiBJbnNlcnRpb25Eb25lOwotICAgIEFT U0VSVChpbkRvY3VtZW50KCkpOwotICAgIGFkZFRvUmFkaW9CdXR0b25Hcm91cCgpOworICAgIGlm IChpbnNlcnRpb25Qb2ludC0+aW5Eb2N1bWVudCgpICYmICFmb3JtKCkpCisgICAgICAgIGFkZFRv UmFkaW9CdXR0b25Hcm91cCgpOwogICAgIHJldHVybiBJbnNlcnRpb25Eb25lOwogfQogCiB2b2lk IEhUTUxJbnB1dEVsZW1lbnQ6OnJlbW92ZWRGcm9tKENvbnRhaW5lck5vZGUqIGluc2VydGlvblBv aW50KQogewotICAgIGlmIChpbnNlcnRpb25Qb2ludC0+aW5Eb2N1bWVudCgpKQorICAgIGlmIChp bnNlcnRpb25Qb2ludC0+aW5Eb2N1bWVudCgpICYmICFmb3JtKCkpCiAgICAgICAgIHJlbW92ZUZy b21SYWRpb0J1dHRvbkdyb3VwKCk7CiAgICAgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnJl bW92ZWRGcm9tKGluc2VydGlvblBvaW50KTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNWQ0YjBlOWViNWE0MWRkYmMw M2E2MzI3NzRmYThkMjgxODMwZGZmLi41Nzg4OWZjZDMyODYxMDA1YTBiMTI1NDQ2Y2E4MjI2OTRm YzM5NDZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDYtMTEgIEtlbnQgVGFtdXJhICA8 dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBhIGJ1ZyB0aGF0IGNoZWNraW5nIGEg cmFkaW8gYnV0dG9uIGluIGEgcmFkaW8gYnV0dG9uIGdyb3VwIGluIGEgZnJvbQorICAgICAgICBk ZXRhY2hlZCBmcm9tIGEgZG9jdW1lbnQgdHJlZSBkb2Vzbid0IHVuY2hlY2sgYW5vdGhlciByYWRp byBidXR0b24gaW4KKyAgICAgICAgdGhlIHJhZGlvIGJ1dHRvbiBncm91cC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODM1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3JhZGlvL3Jh ZGlvLWdyb3VwLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3JhZGlvL3JhZGlv LWdyb3VwLmh0bWw6IEFkZCB0ZXN0IGNhc2VzLgorCiAyMDEyLTA2LTEwICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEV4cG9zZSBsYXlvdXRUZXN0Q29udHJvbGxl ciBhcyB0ZXN0UnVubmVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlv L3JhZGlvLWdyb3VwLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8v cmFkaW8tZ3JvdXAtZXhwZWN0ZWQudHh0CmluZGV4IGJhNzA4OTVmZTA4NTkyMzk4YzMwMGViOTk1 MmM4ZjczYjMxOTU2OGQuLjZhNmI5YzUzODQ2NjE5ZWU2MTZmYWQzNmVmZDgzMzQwNzhmMDI3YTgg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3JvdXAtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3JvdXAt ZXhwZWN0ZWQudHh0CkBAIC04LDYgKzgsMTQgQEAgUEFTUyAkKCJyYWRpbzEtMSIpLmNoZWNrZWQg aXMgdHJ1ZQogUEFTUyAkKCJyYWRpbzEtMiIpLmNoZWNrZWQgaXMgdHJ1ZQogUEFTUyAkKCJyYWRp bzEtMSIpLmNoZWNrZWQgaXMgZmFsc2UKIFBBU1MgJCgicmFkaW8xLTIiKS5jaGVja2VkIGlzIHRy dWUKK1BBU1MgJCgicmFkaW8xLTEiKS5jaGVja2VkID0gdHJ1ZTsgJCgicmFkaW8xLTEiKS5jaGVj a2VkIGlzIHRydWUKK1BBU1MgJCgicmFkaW8xLTIiKS5jaGVja2VkIGlzIGZhbHNlCisKK0RldGFj aCB0aGUgZnJvbSBmcm9tIHRoZSBkb2N1bWVudCB0cmVlOgorUEFTUyByYWRpb0J1dHRvbnNbMF0u Y2hlY2tlZCBpcyB0cnVlCitQQVNTIHJhZGlvQnV0dG9uc1sxXS5jaGVja2VkIGlzIGZhbHNlCitQ QVNTIHJhZGlvQnV0dG9uc1sxXS5jaGVja2VkID0gdHJ1ZTsgcmFkaW9CdXR0b25zWzBdLmNoZWNr ZWQgaXMgZmFsc2UKK1BBU1MgcmFkaW9CdXR0b25zWzFdLmNoZWNrZWQgaXMgdHJ1ZQogCiBDaGFu Z2luZyB0aGUgdHlwZSBvZiBhbiBpbnB1dCBlbGVtZW50IHRvIHJhZGlvOgogUEFTUyAkKCJyYWRp bzEtMSIpLmNoZWNrZWQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9yYWRpby9yYWRpby1ncm91cC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYWRpby9y YWRpby1ncm91cC5odG1sCmluZGV4IGNlN2ZhYjllOTAzNGQ5NzI0NmMyYzZiODg1ZjNmYzFhMjU0 Yjc1NzYuLmNkYmRiNWZlOTk4YmIzMGVkY2YyNGVlZGM5OGY2NmFhOWVkYmI4NzUgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3JvdXAuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlvL3JhZGlvLWdyb3VwLmh0bWwKQEAgLTM1LDYgKzM1 LDE3IEBAIHNob3VsZEJlVHJ1ZSgnJCgicmFkaW8xLTIiKS5jaGVja2VkJyk7CiAkKCdyYWRpbzEt MicpLm5hbWUgPSAnbmFtZTEnOwogc2hvdWxkQmVGYWxzZSgnJCgicmFkaW8xLTEiKS5jaGVja2Vk Jyk7CiBzaG91bGRCZVRydWUoJyQoInJhZGlvMS0yIikuY2hlY2tlZCcpOworc2hvdWxkQmVUcnVl KCckKCJyYWRpbzEtMSIpLmNoZWNrZWQgPSB0cnVlOyAkKCJyYWRpbzEtMSIpLmNoZWNrZWQnKTsK K3Nob3VsZEJlRmFsc2UoJyQoInJhZGlvMS0yIikuY2hlY2tlZCcpOworCitkZWJ1ZygnXG5EZXRh Y2ggdGhlIGZyb20gZnJvbSB0aGUgZG9jdW1lbnQgdHJlZTonKTsKK3ZhciBvcnBoYW5Gb3JtID0g cGFyZW50LmZpcnN0Q2hpbGQ7CitwYXJlbnQucmVtb3ZlQ2hpbGQob3JwaGFuRm9ybSk7Cit2YXIg cmFkaW9CdXR0b25zID0gb3JwaGFuRm9ybS5nZXRFbGVtZW50c0J5VGFnTmFtZSgnaW5wdXQnKTsK K3Nob3VsZEJlVHJ1ZSgncmFkaW9CdXR0b25zWzBdLmNoZWNrZWQnKTsKK3Nob3VsZEJlRmFsc2Uo J3JhZGlvQnV0dG9uc1sxXS5jaGVja2VkJyk7CitzaG91bGRCZUZhbHNlKCdyYWRpb0J1dHRvbnNb MV0uY2hlY2tlZCA9IHRydWU7IHJhZGlvQnV0dG9uc1swXS5jaGVja2VkJyk7CitzaG91bGRCZVRy dWUoJ3JhZGlvQnV0dG9uc1sxXS5jaGVja2VkJyk7CiAKIGRlYnVnKCcnKTsKIGRlYnVnKCdDaGFu Z2luZyB0aGUgdHlwZSBvZiBhbiBpbnB1dCBlbGVtZW50IHRvIHJhZGlvOicpOwo= 147033 2012-06-12 01:28:33 -0700 2012-06-12 14:04:22 -0700 Patch 2 bug-88835-20120612172832.patch text/plain 6389 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQ1YmVjYmRlNDc0MWRi MjJjMTYwMDhmNDM2Y2U5MzcxNjc5YjBiOC4uZjQ2MmM1Mzg0NWE5ODQzZjBhMTRiOGM0ZDdkMmEw ZTUwZmViYjRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ5IEBACisyMDEyLTA2LTExICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBDaGVja2luZyBhIHJhZGlv IGJ1dHRvbiBkb2Vzbid0IHVuY2hlY2sgb3RoZXIgYnV0dG9ucyBpbiB0aGUgc2FtZSBncm91cCBp biBzb21lIGNhc2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODg4MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGNoYW5nZSBmaXhlcyBhIGJ1ZyB0aGF0IGNoZWNraW5nIGEgcmFkaW8gYnV0dG9u IGluIGEgcmFkaW8gYnV0dG9uCisgICAgICAgIGdyb3VwIGluIGEgZm9ybSBkZXRhY2hlZCBmcm9t IGEgZG9jdW1lbnQgdHJlZSBkb2Vzbid0IHVuY2hlY2sgYW5vdGhlcgorICAgICAgICBjaGVja2Vk IHJhZGlvIGJ1dHRvbiBpbiB0aGUgcmFkaW8gYnV0dG9uIGdyb3VwLgorCisgICAgICAgIEEgcmFk aW8gYnV0dG9uIHBhcnRpY2lwYXRlcyBpbiBhIHJhZGlvIGJ1dHRvbiBncm91cCBpbiB0aGUgZm9s bG93aW5nCisgICAgICAgIGNvbmRpdGlvbnM6CisgICAgICAgIC0gSWYgaXQgaXMgb3duZWQgYnkg YSBmb3JtIGVsZW1lbnQgcmVnYXJkbGVzcyBvZiB0aGUgZm9ybSBpcyBpbiBhCisgICAgICAgIGRv Y3VtZW50IHRyZWUgb3Igbm90LCBvcgorCisgICAgICAgIC0gSWYgaXQgaXMgbm90IG93bmVkIGJ5 IGFueSBmb3JtIGVsZW1lbnRzIGFuZCBpdCBpcyBpbiBhIGRvY3VtZW50IHRyZWUuCisgICAgICAg IEEgcmFkaW8gYnV0dG9uIGdyb3VwIGZvciB0aGUgcmFkaW8gYnV0dG9uIGlzIG93bmVkIGJ5IHRo ZSBkb2N1bWVudC4KKworICAgICAgICBGb3IgSFRNTElucHV0RWxlbWVudDo6cmVtb3ZlZEZyb20o KToKKyAgICAgICAgVGhlIG9sZCBjb2RlIGFsd2F5cyB1bnJlZ2lzdGVyZWQgdGhlIHJhZGlvIGJ1 dHRvbiBpZiBpdCB3YXMgcmVtb3ZlZCBmcm9tCisgICAgICAgIHRoZSBkb2N1bWVudCB0cmVlLiBJ dCB3YXMgaW5jb3JyZWN0IGJlY2F1c2Ugd2UgZG9uJ3QgbmVlZCB0byB1bnJlZ2lzdGVyCisgICAg ICAgIGl0IGlmIGl0IGhhcyBhbiBvd25lciBmb3JtIGFuZCB0aGUgb3duZXIgZm9ybSBpcyBub3Qg Y2hhbmdlZCBieQorICAgICAgICByZW1vdmVkRnJvbSgpLgorICAgICAgICBJZiB0aGUgb3duZXIg Zm9ybSBpcyBjbGVhcmVkIGJ5IHJlbW92ZWRGcm9tKCksIHdpbGxDaGFuZ2VGb3JtKCkKKyAgICAg ICAgdW5yZWdpc3RlcnMgdGhlIHJhZGlvIGJ1dHRvbi4gU28gd2hhdCB3ZSBzaG91bGQgZG8gaW4g cmVtb3ZlZEZyb20oKSBpcworICAgICAgICB0byB1bnJlZ2lzdGVyIHRoZSByYWRpbyBidXR0b24g b25seSBpZiB0aGUgcmFkaW8gYnV0dG9uIGdyb3VwIGlzIG93bmVkCisgICAgICAgIGJ5IHRoZSBk b2N1bWVudC4KKworICAgICAgICBGb3IgSFRNTElucHV0RWxlbWVudDo6aW5zZXJ0ZWRJbnRvKCk6 CisgICAgICAgIFRoZSBvbGQgY29kZSBhbHdheXMgcmVnaXN0ZXJlZCB0aGUgcmFkaW8gYnV0dG9u IGlmIGl0IGlzIGluc2VydGVkIGludG8KKyAgICAgICAgdGhlIGRvY3VtZW50IHRyZWUuIEl0IHdh cyBpbmNvcnJlY3QgYmVjYXVzZSB3ZSBkb24ndCBuZWVkIHRvIHJlZ2lzdGVyIGl0CisgICAgICAg IGlmIGl0IGhhcyBhbiBvd25lciBmb3JtIGFuZCB0aGUgb3duZXIgZm9ybSBpcyBub3QgY2hhbmdl ZCBieQorICAgICAgICBpbnNlcnRlZEludG8oKS4KKyAgICAgICAgSWYgdGhlIG93bmVyIGZvcm0g aXMgY2hhbmdlZCBieSBpbnNlcnRlZEludG8oKSwgZGlkQ2hhbmdlRm9ybSgpCisgICAgICAgIHJl Z2lzdGVycyB0aGUgcmFkaW8gYnV0dG9uLiBTbyBXZSBzaG91bGQgcmVnaXN0ZXIgdGhlIHJhZGlv IGJ1dHRvbiBvbmx5CisgICAgICAgIGlmIGl0cyByYWRpbyBidXR0b24gZ3JvdXAgd2lsbCBiZSBv d25lZCBieSB0aGUgZG9jdW1lbnQuCisKKyAgICAgICAgVGVzdDogQWRkIHRlc3QgY2FzZXMgdG8g ZmFzdC9mb3Jtcy9yYWRpby9yYWRpby1ncm91cC5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxJ bnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6aW5z ZXJ0ZWRJbnRvKToKKyAgICAgICAgUmVnaXN0ZXIgdGhpcyB0byBDaGVja2VkUmFkaW9CdXR0b25z IG9ubHkgaWYgbmV3IGdyb3VwIG93bmVyIGlzIERvY3VtZW50LgorICAgICAgICAoV2ViQ29yZTo6 SFRNTElucHV0RWxlbWVudDo6cmVtb3ZlZEZyb20pOgorICAgICAgICBVbnJlZ2lzdGVyIHRoaXMg ZnJvbSBDaGVja2VkUmFkaW9CdXR0b25zIG9ubHkgaWYgb2xkIGdyb3VwIG93bmVyIHdhcyBEb2N1 bWVudC4KKwogMjAxMi0wNi0xMCAgUGFibG8gRmxvdXJldCAgPHBhYmxvZkBtb3Rvcm9sYS5jb20+ CiAKICAgICAgICAgQWNjZXNzIGNvbnRyb2wgYWxsb3cgbGlzdHMgc3RhcnRpbmcgd2l0aCBhIGNv bW1hIGFyZSBwYXJzZWQgaW5jb3JyZWN0bHkgKENPUlMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M SW5wdXRFbGVtZW50LmNwcAppbmRleCBjNmNmMWY0OTcxZTZhZDYyZGRiYzVmMzc5ZGRiNzhiOTNj MzRjZThjLi5lMmViZGI1Mjc1OTMzM2Y0YjAyYmI2M2UwZWQ5ZGYxZGU2NjQ3MTUyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTEzNTIsMTYgKzEzNTIsMTQg QEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50OjpkaWRDaGFuZ2VGb3JtKCkKIE5vZGU6Okluc2VydGlv bk5vdGlmaWNhdGlvblJlcXVlc3QgSFRNTElucHV0RWxlbWVudDo6aW5zZXJ0ZWRJbnRvKENvbnRh aW5lck5vZGUqIGluc2VydGlvblBvaW50KQogewogICAgIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVt ZW50OjppbnNlcnRlZEludG8oaW5zZXJ0aW9uUG9pbnQpOwotICAgIGlmICghaW5zZXJ0aW9uUG9p bnQtPmluRG9jdW1lbnQoKSkKLSAgICAgICAgcmV0dXJuIEluc2VydGlvbkRvbmU7Ci0gICAgQVNT RVJUKGluRG9jdW1lbnQoKSk7Ci0gICAgYWRkVG9SYWRpb0J1dHRvbkdyb3VwKCk7CisgICAgaWYg KGluc2VydGlvblBvaW50LT5pbkRvY3VtZW50KCkgJiYgIWZvcm0oKSkKKyAgICAgICAgYWRkVG9S YWRpb0J1dHRvbkdyb3VwKCk7CiAgICAgcmV0dXJuIEluc2VydGlvbkRvbmU7CiB9CiAKIHZvaWQg SFRNTElucHV0RWxlbWVudDo6cmVtb3ZlZEZyb20oQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9uUG9p bnQpCiB7Ci0gICAgaWYgKGluc2VydGlvblBvaW50LT5pbkRvY3VtZW50KCkpCisgICAgaWYgKGlu c2VydGlvblBvaW50LT5pbkRvY3VtZW50KCkgJiYgIWZvcm0oKSkKICAgICAgICAgcmVtb3ZlRnJv bVJhZGlvQnV0dG9uR3JvdXAoKTsKICAgICBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6cmVt b3ZlZEZyb20oaW5zZXJ0aW9uUG9pbnQpOwogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE1ZDRiMGU5ZWI1YTQxZGRiYzAz YTYzMjc3NGZhOGQyODE4MzBkZmYuLjk4MDc1MjZhOTdmZWM3YzQzYWUxNGIzYWM3MzdkYTZlY2Ri MTYyMDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNi0xMSAgS2VudCBUYW11cmEgIDx0 a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hlY2tpbmcgYSByYWRpbyBidXR0b24gZG9l c24ndCB1bmNoZWNrIG90aGVyIGJ1dHRvbnMgaW4gdGhlIHNhbWUgZ3JvdXAgaW4gc29tZSBjYXNl cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4ODM1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0 L2Zvcm1zL3JhZGlvL3JhZGlvLWdyb3VwLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2Zv cm1zL3JhZGlvL3JhZGlvLWdyb3VwLmh0bWw6IEFkZCB0ZXN0IGNhc2VzLgorCiAyMDEyLTA2LTEw ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEV4cG9zZSBsYXlv dXRUZXN0Q29udHJvbGxlciBhcyB0ZXN0UnVubmVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL3JhZGlvL3JhZGlvLWdyb3VwLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3JvdXAtZXhwZWN0ZWQudHh0CmluZGV4IGJhNzA4OTVmZTA4 NTkyMzk4YzMwMGViOTk1MmM4ZjczYjMxOTU2OGQuLjZhNmI5YzUzODQ2NjE5ZWU2MTZmYWQzNmVm ZDgzMzQwNzhmMDI3YTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8v cmFkaW8tZ3JvdXAtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFk aW8vcmFkaW8tZ3JvdXAtZXhwZWN0ZWQudHh0CkBAIC04LDYgKzgsMTQgQEAgUEFTUyAkKCJyYWRp bzEtMSIpLmNoZWNrZWQgaXMgdHJ1ZQogUEFTUyAkKCJyYWRpbzEtMiIpLmNoZWNrZWQgaXMgdHJ1 ZQogUEFTUyAkKCJyYWRpbzEtMSIpLmNoZWNrZWQgaXMgZmFsc2UKIFBBU1MgJCgicmFkaW8xLTIi KS5jaGVja2VkIGlzIHRydWUKK1BBU1MgJCgicmFkaW8xLTEiKS5jaGVja2VkID0gdHJ1ZTsgJCgi cmFkaW8xLTEiKS5jaGVja2VkIGlzIHRydWUKK1BBU1MgJCgicmFkaW8xLTIiKS5jaGVja2VkIGlz IGZhbHNlCisKK0RldGFjaCB0aGUgZnJvbSBmcm9tIHRoZSBkb2N1bWVudCB0cmVlOgorUEFTUyBy YWRpb0J1dHRvbnNbMF0uY2hlY2tlZCBpcyB0cnVlCitQQVNTIHJhZGlvQnV0dG9uc1sxXS5jaGVj a2VkIGlzIGZhbHNlCitQQVNTIHJhZGlvQnV0dG9uc1sxXS5jaGVja2VkID0gdHJ1ZTsgcmFkaW9C dXR0b25zWzBdLmNoZWNrZWQgaXMgZmFsc2UKK1BBU1MgcmFkaW9CdXR0b25zWzFdLmNoZWNrZWQg aXMgdHJ1ZQogCiBDaGFuZ2luZyB0aGUgdHlwZSBvZiBhbiBpbnB1dCBlbGVtZW50IHRvIHJhZGlv OgogUEFTUyAkKCJyYWRpbzEtMSIpLmNoZWNrZWQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9yYWRpby9yYWRpby1ncm91cC5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9yYWRpby9yYWRpby1ncm91cC5odG1sCmluZGV4IGNlN2ZhYjllOTAzNGQ5NzI0NmMy YzZiODg1ZjNmYzFhMjU0Yjc1NzYuLmNkYmRiNWZlOTk4YmIzMGVkY2YyNGVlZGM5OGY2NmFhOWVk YmI4NzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFkaW8vcmFkaW8tZ3Jv dXAuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhZGlvL3JhZGlvLWdyb3VwLmh0 bWwKQEAgLTM1LDYgKzM1LDE3IEBAIHNob3VsZEJlVHJ1ZSgnJCgicmFkaW8xLTIiKS5jaGVja2Vk Jyk7CiAkKCdyYWRpbzEtMicpLm5hbWUgPSAnbmFtZTEnOwogc2hvdWxkQmVGYWxzZSgnJCgicmFk aW8xLTEiKS5jaGVja2VkJyk7CiBzaG91bGRCZVRydWUoJyQoInJhZGlvMS0yIikuY2hlY2tlZCcp Oworc2hvdWxkQmVUcnVlKCckKCJyYWRpbzEtMSIpLmNoZWNrZWQgPSB0cnVlOyAkKCJyYWRpbzEt MSIpLmNoZWNrZWQnKTsKK3Nob3VsZEJlRmFsc2UoJyQoInJhZGlvMS0yIikuY2hlY2tlZCcpOwor CitkZWJ1ZygnXG5EZXRhY2ggdGhlIGZyb20gZnJvbSB0aGUgZG9jdW1lbnQgdHJlZTonKTsKK3Zh ciBvcnBoYW5Gb3JtID0gcGFyZW50LmZpcnN0Q2hpbGQ7CitwYXJlbnQucmVtb3ZlQ2hpbGQob3Jw aGFuRm9ybSk7Cit2YXIgcmFkaW9CdXR0b25zID0gb3JwaGFuRm9ybS5nZXRFbGVtZW50c0J5VGFn TmFtZSgnaW5wdXQnKTsKK3Nob3VsZEJlVHJ1ZSgncmFkaW9CdXR0b25zWzBdLmNoZWNrZWQnKTsK K3Nob3VsZEJlRmFsc2UoJ3JhZGlvQnV0dG9uc1sxXS5jaGVja2VkJyk7CitzaG91bGRCZUZhbHNl KCdyYWRpb0J1dHRvbnNbMV0uY2hlY2tlZCA9IHRydWU7IHJhZGlvQnV0dG9uc1swXS5jaGVja2Vk Jyk7CitzaG91bGRCZVRydWUoJ3JhZGlvQnV0dG9uc1sxXS5jaGVja2VkJyk7CiAKIGRlYnVnKCcn KTsKIGRlYnVnKCdDaGFuZ2luZyB0aGUgdHlwZSBvZiBhbiBpbnB1dCBlbGVtZW50IHRvIHJhZGlv OicpOwo=