88809 2012-06-11 14:27:49 -0700 [BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation 2012-06-11 15:04:22 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo tonikitoo oldest_to_newest 646266 0 tonikitoo 2012-06-11 14:27:49 -0700 SSIA patch coming.. 646277 1 146914 tonikitoo 2012-06-11 14:35:18 -0700 Created attachment 146914 (committed r120010, r=rbuis) patch 646299 2 146914 rwlbuis 2012-06-11 15:02:18 -0700 Comment on attachment 146914 (committed r120010, r=rbuis) patch View in context: https://bugs.webkit.org/attachment.cgi?id=146914&action=review Looks good, but please fix before landing. > Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:740 > fullScreenRenderer->style()->setWidth(Length(width, Fixed)); As discussed, better check fullScreenRenderer->style as well. 146914 2012-06-11 14:35:18 -0700 2012-06-11 15:05:46 -0700 (committed r120010, r=rbuis) patch 0001-BlackBerry-BlackBerry-browser-video-player-fullscree.patch text/plain 4409 tonikitoo RnJvbSA1YmE3YWUxNTA4ZDZmNzM5NTQ5MzQ0NWFjZGQyYjgwMmU5MWY2Y2I0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog TW9uLCAxMSBKdW4gMjAxMiAxNzozMzowOSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja0Jl cnJ5XSBbQmxhY2tCZXJyeV0gYnJvd3NlciB2aWRlbyBwbGF5ZXIgZnVsbHNjcmVlbgogbW9kZSAo cG9ydHJhaXQpIGRvZXMgbm90IHBsYXkgd2VsbCB3aXRoIHJvdGF0aW9uCiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg4MDkKClJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KCkFkanVzdCB0aGUg bWVkaWEgY29udGFpbmVyIGRpbWVuc2lvbnMsIHdoZW5ldmVyIHRoZSBGcmFtZVZpZXc6OmZyYW1l UmVjdAooYWthIHZpZXdwb3J0IHJlY3QpIGNoYW5nZXMKClJldmlld2VkIGludGVybmFsbHkgYnkg SmFja3kgSmlhbmcuCgoqIEFwaS9XZWJQYWdlLmNwcDoKKEJsYWNrQmVycnk6OldlYktpdDo6V2Vi UGFnZVByaXZhdGU6OnVwZGF0ZVZpZXdwb3J0U2l6ZSk6CiogV2ViQ29yZVN1cHBvcnQvQ2hyb21l Q2xpZW50QmxhY2tCZXJyeS5jcHA6CihXZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFja0JlcnJ5Ojpm dWxsU2NyZWVuUmVuZGVyZXJDaGFuZ2VkKToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFNvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysr KysrKysrKysrKwogLi4uL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3Bw ICAgICAgfCAgICAzIC0tLQogMyBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4 IGJmZTdkNzQuLmEwNGMzNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdl LmNwcApAQCAtOTMsNiArOTMsOSBAQAogI2luY2x1ZGUgIlBsdWdpblZpZXcuaCIKICNpbmNsdWRl ICJSZW5kZXJMYXllckJhY2tpbmcuaCIKICNpbmNsdWRlICJSZW5kZXJMYXllckNvbXBvc2l0b3Iu aCIKKyNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCisjaW5jbHVkZSAiUmVuZGVyRnVsbFNjcmVl bi5oIgorI2VuZGlmCiAjaW5jbHVkZSAiUmVuZGVyVGV4dC5oIgogI2luY2x1ZGUgIlJlbmRlclRo ZW1lQmxhY2tCZXJyeS5oIgogI2luY2x1ZGUgIlJlbmRlclRyZWVBc1RleHQuaCIKQEAgLTE0NTIs NiArMTQ1NSwxNyBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjp1cGRhdGVWaWV3cG9ydFNpemUoYm9v bCBzZXRGaXhlZFJlcG9ydGVkU2l6ZSwgYm9vbCBzZW5kUmVzaQogICAgIGlmIChmcmFtZVJlY3Qg IT0gbV9tYWluRnJhbWUtPnZpZXcoKS0+ZnJhbWVSZWN0KCkpIHsKICAgICAgICAgbV9tYWluRnJh bWUtPnZpZXcoKS0+c2V0RnJhbWVSZWN0KGZyYW1lUmVjdCk7CiAgICAgICAgIG1fbWFpbkZyYW1l LT52aWV3KCktPmFkanVzdFZpZXdTaXplKCk7CisKKyNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkp CisgICAgICAgIC8vIElmIHdlIGFyZSBpbiBmdWxsc2NyZWVuIHZpZGVvIG1vZGUsIGFuZCB3ZSBj aGFuZ2UgdGhlIEZyYW1lVmlldzo6dmlld3BvcnRSZWN0LAorICAgICAgICAvLyB3ZSBuZWVkIHRv IGFkanVzdCB0aGUgbWVkaWEgY29udGFpbmVyIHRvIHRoZSBuZXcgc2l6ZS4KKyAgICAgICAgaWYg KG1fZnVsbHNjcmVlblZpZGVvTm9kZSkgeworICAgICAgICAgICAgRG9jdW1lbnQqIGRvY3VtZW50 ID0gbV9mdWxsc2NyZWVuVmlkZW9Ob2RlLT5kb2N1bWVudCgpOworICAgICAgICAgICAgQVNTRVJU KGRvY3VtZW50KTsKKyAgICAgICAgICAgIGludCB3aWR0aCA9IG1fbWFpbkZyYW1lLT52aWV3KCkt PnZpc2libGVDb250ZW50UmVjdCgpLnNpemUoKS53aWR0aCgpOworICAgICAgICAgICAgZG9jdW1l bnQtPmZ1bGxTY3JlZW5SZW5kZXJlcigpLT5zdHlsZSgpLT5zZXRXaWR0aChMZW5ndGgod2lkdGgs IEZpeGVkKSk7CisgICAgICAgIH0KKyNlbmRpZgogICAgIH0KIAogICAgIC8vIFdlJ3JlIGdvaW5n IHRvIG5lZWQgdG8gc2VuZCBhIHJlc2l6ZSBldmVudCB0byBKYXZhU2NyaXB0IGJlY2F1c2UKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDE3YjFlMzQuLmYzMzRjNmEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTExICBBbnRv bmlvIEdvbWVzICA8YWdvbWVzQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFtCbGFj a0JlcnJ5XSBicm93c2VyIHZpZGVvIHBsYXllciBmdWxsc2NyZWVuIG1vZGUgKHBvcnRyYWl0KSBk b2VzIG5vdCBwbGF5IHdlbGwgd2l0aCByb3RhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg4MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGp1c3QgdGhlIG1lZGlhIGNvbnRhaW5lciBkaW1lbnNp b25zLCB3aGVuZXZlciB0aGUgRnJhbWVWaWV3OjpmcmFtZVJlY3QKKyAgICAgICAgKGFrYSB2aWV3 cG9ydCByZWN0KSBjaGFuZ2VzCisKKyAgICAgICAgUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBKYWNr eSBKaWFuZy4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVy cnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OnVwZGF0ZVZpZXdwb3J0U2l6ZSk6CisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDaHJvbWVDbGllbnRCbGFja0JlcnJ5OjpmdWxsU2NyZWVuUmVuZGVyZXJDaGFuZ2Vk KToKKwogMjAxMi0wNi0wOSAgQW50b25pbyBHb21lcyAgPGFnb21lc0ByaW0uY29tPgogCiAgICAg ICAgIFtCbGFja0JlcnJ5XSBicm93c2VyIHZpZGVvIHBsYXllciBmdWxsc2NyZWVuIG1vZGUgKHBv cnRyYWl0KSBkb2VzIG5vdCBwbGF5IHdlbGwgd2l0aCB2aWV3cG9ydCBtZXRhdGFnIC0gQ29udHJv bHMgYXJlIG9mZiBzY3JlZW4gc28gY2Fubm90IGV4aXQgZnVsbHNjcmVlbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNr QmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Nocm9t ZUNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IDZhNjk3MmMuLjUyZjkwYTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFj a0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQv Q2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTczNiw5ICs3MzYsNiBAQCB2b2lkIENocm9t ZUNsaWVudEJsYWNrQmVycnk6OmZ1bGxTY3JlZW5SZW5kZXJlckNoYW5nZWQoUmVuZGVyQm94KiBm dWxsU2NyZWVuUmVuZAogICAgIC8vIE9uY2Ugd2UgZ28gZnVsbHNjcmVlbiB1c2luZyB0aGUgbmV3 IEZVTExTQ1JFRU5fQVBJIGNvZGUgcGF0aCwgd2UgaGF2ZSB0byB0YWtlIGludG8gYWNjb3VudAog ICAgIC8vIG91ciBwb3J0IHNwZWNpZmljIHBhZ2Ugc2NhbGluZy4KICAgICBpZiAoZnVsbFNjcmVl blJlbmRlcmVyKSB7Ci0gICAgICAgIC8vIEZJWE1FOiBTaW5jZSB3ZSBhcmUgc2V0dGluZyBhbiBh YnNvbHV0ZSB3aWR0aCB2YWx1ZSBoZXJlLCBpdCB3b24ndCB3b3JrIGZvciBjYXNlcwotICAgICAg ICAvLyB3aGVyZSB3ZSBjaGFuZ2UgdGhlIHZpZXdwb3J0IHNpemUgYXMgd2UgZ28uIEZvciBleGFt cGxlLCByb3RhdGUgdGhlIGRldmljZSB3aGlsZQotICAgICAgICAvLyBpbiBmdWxsc2NyZWVuIG1v ZGUuCiAgICAgICAgIGludCB3aWR0aCA9IG1fd2ViUGFnZVByaXZhdGUtPm1fbWFpbkZyYW1lLT52 aWV3KCktPnZpc2libGVDb250ZW50UmVjdCgpLnNpemUoKS53aWR0aCgpOwogICAgICAgICBmdWxs U2NyZWVuUmVuZGVyZXItPnN0eWxlKCktPnNldFdpZHRoKExlbmd0aCh3aWR0aCwgRml4ZWQpKTsK ICAgICB9Ci0tIAoxLjcuNS40Cgo=