88786 2012-06-11 09:27:12 -0700 TextureMapperLayer: invisible layers do not let their children to be painted 2012-06-18 01:13:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar alex mrobinson noam svillar oldest_to_newest 646029 0 svillar 2012-06-11 09:27:12 -0700 [GTK] TextureMapperLayer: invisible layers do not let their children to be painted 646032 1 146866 svillar 2012-06-11 09:29:46 -0700 Created attachment 146866 Patch 646035 2 svillar 2012-06-11 09:32:21 -0700 In the particular case of the bug mentioned in the ChangeLog there are 3 boxes, the first one (the bigger) has the second inside, and this one has another one inside (the smaller). The second box is rotated 180º and it becomes invisible because the backface is marked as invisible. Then the third box is rotated another 180º so it becomes visible but it was not painted because its father was declared as invisible and thus it was not rendering their children. 646042 3 mrobinson 2012-06-11 09:46:49 -0700 A link to a test case would be pretty useful here, I think. 646060 4 146866 noam 2012-06-11 10:10:08 -0700 Comment on attachment 146866 Patch I understand the bug, but the fix is not right. We still want to exit early if the opacity is 0, the size is empty etc. We should add specific tests of culling, and only paint the children if we're preserving 3D. 646062 5 svillar 2012-06-11 10:11:17 -0700 (In reply to comment #3) > A link to a test case would be pretty useful here, I think. This is the one I used for testing: http://svn.webkit.org/repository/webkit/trunk/LayoutTests/compositing/backface-visibility/backface-visibility-3d.html 647797 6 147258 svillar 2012-06-13 01:14:18 -0700 Created attachment 147258 Patch 647963 7 147258 noam 2012-06-13 06:09:34 -0700 Comment on attachment 147258 Patch This is not the right logic. It should be: - opacity 0, empty size, or (backfacing and backface-visibility is false and we're not preserving 3D)? return early at paintRecursive - (backfacing and backface-visibility is false) ? return early and paintSelf 648138 8 svillar 2012-06-13 09:38:09 -0700 (In reply to comment #7) > (From update of attachment 147258 [details]) > This is not the right logic. It should be: > - opacity 0, empty size, or (backfacing and backface-visibility is false and we're not preserving 3D)? return early at paintRecursive > - (backfacing and backface-visibility is false) ? return early and paintSelf (In reply to comment #7) > (From update of attachment 147258 [details]) > This is not the right logic. It should be: > - opacity 0, empty size, or (backfacing and backface-visibility is false and we're not preserving 3D)? return early at paintRecursive That preserves3D is interesting because I don't understand the expected results of the third test case of http://svn.webkit.org/repository/webkit/trunk/LayoutTests/compositing/backface-visibility/backface-visibility-non3d.html. Shouldn't the lime div be not visible? 649275 9 svillar 2012-06-14 10:23:01 -0700 (In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 147258 [details] [details]) > > This is not the right logic. It should be: > > - opacity 0, empty size, or (backfacing and backface-visibility is false and we're not preserving 3D)? return early at paintRecursive > > That preserves3D is interesting because I don't understand the expected results of the third test case of http://svn.webkit.org/repository/webkit/trunk/LayoutTests/compositing/backface-visibility/backface-visibility-non3d.html. Shouldn't the lime div be not visible? Well that's is really not that important now so ignore it. So please correct me if I'm wrong, but this is how I understand the issue: - we cannot skip a whole hierarchy in paintRecursive() just because we're backfacing and not preserving 3D because even in that case we could have a visible child (including childs backfacing with backface-visibility: visible). See for example test #3 in LayoutTests/compositing/backface-visibility/backface-visibility-non3d.html. Not preserving 3d as I understand it, does not invalidate the CSS painting order. - in paintSelf() we should basically early return if (!m_state.visible) (which already takes into account the backface and its visiblity) Following this rationale I cooked a 3rd patch that makes both LayoutTests/compositing/backface-visibility/backface-visibility-non3d.html and LayoutTests/compositing/backface-visibility/backface-visibility-3d.html work fine. But before uploading it I'd like to know your opinion about what I said above. 649939 10 147748 svillar 2012-06-15 00:03:31 -0700 Created attachment 147748 Patch Noam, I was talking about something like this 651235 11 svillar 2012-06-18 01:13:08 -0700 Committed r120577: <http://trac.webkit.org/changeset/120577> 146866 2012-06-11 09:29:46 -0700 2012-06-13 01:14:13 -0700 Patch bug-88786-20120611182944.patch text/plain 2190 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNlOGQ4Y2JmNzVjY2M3 MWNiODk2ZjJiNjcxNDRmMDQ3NzRlNTM3OC4uMTkyNWYwMDVmNTk4NGM5ODBmMWRkYjhkZDNiYTg4 N2NiNTA3MDA3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTExICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFRl eHR1cmVNYXBwZXJMYXllcjogaW52aXNpYmxlIGxheWVycyBkbyBub3QgbGV0IHRoZWlyIGNoaWxk cmVuIHRvIGJlIHBhaW50ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg4Nzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIGF0IGxlYXN0IGZpeGVzCisgICAgICAg IGNvbXBvc2l0aW5nL2JhY2tmYWNlLXZpc2liaWxpdHkvYmFja2ZhY2UtdmlzaWJpbGl0eS0zZC5o dG1sLiBUZXN0cworICAgICAgICB3aWxsIGJlIHNraXBwZWQgb25jZSBBQyBpcyBlbmFibGVkIGJ5 IGRlZmF1bHQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6cGFp bnRTZWxmKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRSZWN1 cnNpdmUpOgorCiAyMDEyLTA2LTA2ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBQb3NpdGlvbkl0ZXJhdG9yOjtzZXRPZmZzZXRJbkxlYWZOb2RlKCkg aXMgbm90IHVzZWQgYW55d2hlcmUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IDk2 Y2FmYWM0MmViZmZjMDdkYmJjM2Y2YWRlNjViM2M0MmIwZjljYTYuLjdmMjc5Yzk2ZGVjM2MzMzJj N2RjMmMyMDc1ZjVlNjFmMzVlMjNiOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkBA IC0xNTQsNiArMTU0LDkgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50KCkKIAogdm9p ZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50U2VsZihjb25zdCBUZXh0dXJlTWFwcGVyUGFpbnRP cHRpb25zJiBvcHRpb25zKQogeworICAgIGlmICghaXNWaXNpYmxlKCkpCisgICAgICAgIHJldHVy bjsKKwogICAgIC8vIFdlIGFwcGx5IHRoZSBmb2xsb3dpbmcgdHJhbnNmb3JtIHRvIGNvbXBlbnNh dGUgZm9yIHBhaW50aW5nIGludG8gYSBzdXJmYWNlLCBhbmQgdGhlbiBhcHBseSB0aGUgb2Zmc2V0 IHNvIHRoYXQgdGhlIHBhaW50aW5nIGZpdHMgaW4gdGhlIHRhcmdldCByZWN0LgogICAgIFRyYW5z Zm9ybWF0aW9uTWF0cml4IHRyYW5zZm9ybTsKICAgICB0cmFuc2Zvcm0udHJhbnNsYXRlKG9wdGlv bnMub2Zmc2V0LndpZHRoKCksIG9wdGlvbnMub2Zmc2V0LmhlaWdodCgpKTsKQEAgLTMxOCw5ICsz MjEsNiBAQCBzdGF0aWMgUGFzc1JlZlB0cjxCaXRtYXBUZXh0dXJlPiBhcHBseUZpbHRlcnMoY29u c3QgRmlsdGVyT3BlcmF0aW9ucyYgZmlsdGVycywgVAogCiB2b2lkIFRleHR1cmVNYXBwZXJMYXll cjo6cGFpbnRSZWN1cnNpdmUoY29uc3QgVGV4dHVyZU1hcHBlclBhaW50T3B0aW9ucyYgb3B0aW9u cykKIHsKLSAgICBpZiAoIWlzVmlzaWJsZSgpKQotICAgICAgICByZXR1cm47Ci0KICAgICBmbG9h dCBvcGFjaXR5ID0gb3B0aW9ucy5vcGFjaXR5ICogbV9vcGFjaXR5OwogICAgIFJlZlB0cjxCaXRt YXBUZXh0dXJlPiBtYXNrVGV4dHVyZSA9IG1fc3RhdGUubWFza0xheWVyID8gbV9zdGF0ZS5tYXNr TGF5ZXItPnRleHR1cmUoKSA6IDA7CiAK 147258 2012-06-13 01:14:18 -0700 2012-06-15 00:03:24 -0700 Patch bug-88786-20120613101417.patch text/plain 3532 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNlOGQ4Y2JmNzVjY2M3 MWNiODk2ZjJiNjcxNDRmMDQ3NzRlNTM3OC4uOTU1Mjg2ZTk0NjgyYTE1OThjOGFhMzA3ZDFiNTcx OWQ4MzNlNmQxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA2LTEzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFRleHR1cmVN YXBwZXJMYXllcjogaW52aXNpYmxlIGxheWVycyBkbyBub3QgbGV0IHRoZWlyIGNoaWxkcmVuIHRv IGJlIHBhaW50ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4Nzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG8gbm90IGVhcmx5IHJldHVybiB3aGVuIHJlY3Vyc2l2ZWx5IHBhaW50aW5nIGFuIGludmlz aWJsZSBsYXllciBpZgorICAgICAgICBpdCBoYXMgYXQgbGVhc3Qgb25lIHZpc2libGUgY2hpbGQu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIGF0IGxlYXN0IGZpeGVzCisgICAg ICAgIGNvbXBvc2l0aW5nL2JhY2tmYWNlLXZpc2liaWxpdHkvYmFja2ZhY2UtdmlzaWJpbGl0eS0z ZC5odG1sLiBUZXN0cworICAgICAgICB3aWxsIGJlIHNraXBwZWQgb25jZSBBQyBpcyBlbmFibGVk IGJ5IGRlZmF1bHQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OnBh aW50U2VsZik6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6Omhhc1Zpc2li bGVDaGlsZHJlbik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1 cmVNYXBwZXJMYXllcjo6cGFpbnRSZWN1cnNpdmUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuaDoKKyAgICAgICAgKFRleHR1cmVNYXBwZXJM YXllcik6CisKIDIwMTItMDYtMDYgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFBvc2l0aW9uSXRlcmF0b3I6O3NldE9mZnNldEluTGVhZk5vZGUoKSBp cyBub3QgdXNlZCBhbnl3aGVyZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKaW5kZXggOTZj YWZhYzQyZWJmZmMwN2RiYmMzZjZhZGU2NWIzYzQyYjBmOWNhNi4uYWJlYWY4NTQ4Mjg3NjAyYmUz MmZlNjkyNmQ0MWZhNjdiYjk2NmYyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAKQEAg LTE1NCw2ICsxNTQsOSBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnQoKQogCiB2b2lk IFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmKGNvbnN0IFRleHR1cmVNYXBwZXJQYWludE9w dGlvbnMmIG9wdGlvbnMpCiB7CisgICAgaWYgKCFpc1Zpc2libGUoKSkKKyAgICAgICAgcmV0dXJu OworCiAgICAgLy8gV2UgYXBwbHkgdGhlIGZvbGxvd2luZyB0cmFuc2Zvcm0gdG8gY29tcGVuc2F0 ZSBmb3IgcGFpbnRpbmcgaW50byBhIHN1cmZhY2UsIGFuZCB0aGVuIGFwcGx5IHRoZSBvZmZzZXQg c28gdGhhdCB0aGUgcGFpbnRpbmcgZml0cyBpbiB0aGUgdGFyZ2V0IHJlY3QuCiAgICAgVHJhbnNm b3JtYXRpb25NYXRyaXggdHJhbnNmb3JtOwogICAgIHRyYW5zZm9ybS50cmFuc2xhdGUob3B0aW9u cy5vZmZzZXQud2lkdGgoKSwgb3B0aW9ucy5vZmZzZXQuaGVpZ2h0KCkpOwpAQCAtMjc3LDYgKzI4 MCwxOCBAQCBib29sIFRleHR1cmVNYXBwZXJMYXllcjo6aXNWaXNpYmxlKCkgY29uc3QKICAgICBy ZXR1cm4gdHJ1ZTsKIH0KIAorYm9vbCBUZXh0dXJlTWFwcGVyTGF5ZXI6Omhhc1Zpc2libGVDaGls ZHJlbigpCit7CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBtX2NoaWxkcmVuLnNpemUoKTsgKytp KSB7CisgICAgICAgIGlmIChtX2NoaWxkcmVuW2ldLT5pc1Zpc2libGUoKSkKKyAgICAgICAgICAg IHJldHVybiB0cnVlOworICAgICAgICBpZiAobV9jaGlsZHJlbltpXS0+aGFzVmlzaWJsZUNoaWxk cmVuKCkpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAgICByZXR1cm4gZmFs c2U7Cit9CisKIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpwYWludFNlbGZBbmRDaGlsZHJlbldp dGhSZXBsaWNhKGNvbnN0IFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9wdGlvbnMpCiB7CiAg ICAgaWYgKG1fc3RhdGUucmVwbGljYUxheWVyKSB7CkBAIC0zMTgsNyArMzMzLDcgQEAgc3RhdGlj IFBhc3NSZWZQdHI8Qml0bWFwVGV4dHVyZT4gYXBwbHlGaWx0ZXJzKGNvbnN0IEZpbHRlck9wZXJh dGlvbnMmIGZpbHRlcnMsIFQKIAogdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50UmVjdXJz aXZlKGNvbnN0IFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9wdGlvbnMpCiB7Ci0gICAgaWYg KCFpc1Zpc2libGUoKSkKKyAgICBpZiAoIWlzVmlzaWJsZSgpICYmIG1fc3RhdGUucHJlc2VydmVz M0QgJiYgIWhhc1Zpc2libGVDaGlsZHJlbigpKQogICAgICAgICByZXR1cm47CiAKICAgICBmbG9h dCBvcGFjaXR5ID0gb3B0aW9ucy5vcGFjaXR5ICogbV9vcGFjaXR5OwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJM YXllci5oCmluZGV4IDY0MTcyZDFkNmY5ODAwODM5M2ExZThmYTg4NjIzYzVmZGVjMjBmNGMuLjNj ZGIyMjQyMjNhMDAyZTdkYzAzNTZhNjI4OGUzYjE2NGM5NWRmOGYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckxheWVyLmgKQEAgLTE2MSw2ICsxNjEsOCBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBzeW5jQW5p bWF0aW9ucygpOwogICAgIGJvb2wgaXNWaXNpYmxlKCkgY29uc3Q7CisgICAgYm9vbCBoYXNWaXNp YmxlQ2hpbGRyZW4oKTsKKwogICAgIGVudW0gQ29udGVudHNMYXllckNvdW50IHsKICAgICAgICAg Tm9MYXllcnNXaXRoQ29udGVudCwKICAgICAgICAgU2luZ2xlTGF5ZXJXaXRoQ29udGVudHMsCg== 147748 2012-06-15 00:03:31 -0700 2012-06-15 06:06:00 -0700 Patch bug-88786-20120615090330.patch text/plain 2937 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2FmOGQwNTU3MjcwNDMw YzM4YjY3NDgzZWYwOGNjMmM2MjAyOGZlNi4uYzkwNmRmZjk5YWFjYTI2M2E3ZTM2Mjg2NzQ4MDBj M2JkMzdjMTk4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA2LTE0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFRleHR1cmVN YXBwZXJMYXllcjogaW52aXNpYmxlIGxheWVycyBkbyBub3QgbGV0IHRoZWlyIGNoaWxkcmVuIHRv IGJlIHBhaW50ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4Nzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG8gbm90IGVhcmx5IGRpc2NhcmQgcmVjdXJzaXZlbHkgcGFpbnRpbmcgY2hpbGRyZW4gbGF5 ZXJzIGlmIHRoZQorICAgICAgICBjdXJyZW50IGxheWVyIGlzIG5vdCB2aXNpYmxlLgorCisgICAg ICAgIENoYW5nZXMgYWxyZWFkeSBjb3ZlcmVkIGJ5IGNvbXBvc2l0aW5nIHRlc3RzLiBUaGlzIGZp eGVzIGJvdGgKKyAgICAgICAgY29tcG9zaXRpbmcvYmFja2ZhY2UtdmlzaWJpbGl0eS9iYWNrZmFj ZS12aXNpYmlsaXR5LTNkLmh0bWwgYW5kCisgICAgICAgIGNvbXBvc2l0aW5nL2JhY2tmYWNlLXZp c2liaWxpdHkvYmFja2ZhY2UtdmlzaWJpbGl0eS1ub24zZC5odG1sLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5ZXI6OmNvbXB1dGVUcmFuc2Zvcm1zUmVjdXJzaXZlKToK KyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmKToKKyAgICAg ICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6aXNWaXNpYmxlKToKKwogMjAxMi0wNi0x NCAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgY29s b3IgcHJvcGVydHkgdG8gaW5wdXQgdHlwZT1yYW5nZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNw cAppbmRleCBiMzBiNGIxZDA1Y2Y4ZDUyOTc5ZTgzYzJjMWNmMDkxYmFmZjY5MzU1Li5jY2ZjMGYy NjMxMDE4MDY3NjNlZDk5MjVjNTJiNGNiOWYxZDU2YTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxh eWVyLmNwcApAQCAtNzcsNyArNzcsNyBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6Y29tcHV0 ZVRyYW5zZm9ybXNSZWN1cnNpdmUoKQogICAgICAgICBwYXJlbnRUcmFuc2Zvcm0gPSBtX2VmZmVj dFRhcmdldC0+bV90cmFuc2Zvcm0uY29tYmluZWQoKTsKICAgICBtX3RyYW5zZm9ybS5jb21iaW5l VHJhbnNmb3JtcyhwYXJlbnRUcmFuc2Zvcm0pOwogCi0gICAgbV9zdGF0ZS52aXNpYmxlID0gbV9z dGF0ZS5iYWNrZmFjZVZpc2liaWxpdHkgfHwgbV90cmFuc2Zvcm0uY29tYmluZWQoKS5pbnZlcnNl KCkubTMzKCkgPj0gMDsKKyAgICBtX3N0YXRlLnZpc2libGUgPSBtX3N0YXRlLmJhY2tmYWNlVmlz aWJpbGl0eSB8fCAhbV90cmFuc2Zvcm0uY29tYmluZWQoKS5pc0JhY2tGYWNlVmlzaWJsZSgpOwog CiAgICAgaWYgKG1fcGFyZW50ICYmIG1fcGFyZW50LT5tX3N0YXRlLnByZXNlcnZlczNEKQogICAg ICAgICBtX2NlbnRlclogPSBtX3RyYW5zZm9ybS5jb21iaW5lZCgpLm1hcFBvaW50KEZsb2F0UG9p bnQzRChtX3NpemUud2lkdGgoKSAvIDIsIG1fc2l6ZS5oZWlnaHQoKSAvIDIsIDApKS56KCk7CkBA IC0xNTQsNiArMTU0LDkgQEAgdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50KCkKIAogdm9p ZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnBhaW50U2VsZihjb25zdCBUZXh0dXJlTWFwcGVyUGFpbnRP cHRpb25zJiBvcHRpb25zKQogeworICAgIGlmICghbV9zdGF0ZS52aXNpYmxlKQorICAgICAgICBy ZXR1cm47CisKICAgICAvLyBXZSBhcHBseSB0aGUgZm9sbG93aW5nIHRyYW5zZm9ybSB0byBjb21w ZW5zYXRlIGZvciBwYWludGluZyBpbnRvIGEgc3VyZmFjZSwgYW5kIHRoZW4gYXBwbHkgdGhlIG9m ZnNldCBzbyB0aGF0IHRoZSBwYWludGluZyBmaXRzIGluIHRoZSB0YXJnZXQgcmVjdC4KICAgICBU cmFuc2Zvcm1hdGlvbk1hdHJpeCB0cmFuc2Zvcm07CiAgICAgdHJhbnNmb3JtLnRyYW5zbGF0ZShv cHRpb25zLm9mZnNldC53aWR0aCgpLCBvcHRpb25zLm9mZnNldC5oZWlnaHQoKSk7CkBAIC0yODYs NyArMjg5LDkgQEAgYm9vbCBUZXh0dXJlTWFwcGVyTGF5ZXI6OmlzVmlzaWJsZSgpIGNvbnN0CiB7 CiAgICAgaWYgKG1fc2l6ZS5pc0VtcHR5KCkgJiYgKG1fc3RhdGUubWFza3NUb0JvdW5kcyB8fCBt X3N0YXRlLm1hc2tMYXllciB8fCBtX2NoaWxkcmVuLmlzRW1wdHkoKSkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKLSAgICBpZiAoIW1fc3RhdGUudmlzaWJsZSB8fCBtX29wYWNpdHkgPCAwLjAxKQor ICAgIGlmICghbV9zdGF0ZS52aXNpYmxlICYmIG1fY2hpbGRyZW4uaXNFbXB0eSgpKQorICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgaWYgKG1fb3BhY2l0eSA8IDAuMDEpCiAgICAgICAgIHJldHVy biBmYWxzZTsKICAgICByZXR1cm4gdHJ1ZTsKIH0K