88775 2012-06-11 05:36:45 -0700 [Chromium] Theme updates for Android in menu list rendering and selection backgrounds 2012-06-11 11:14:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 peter peter abarth eric webkit.review.bot oldest_to_newest 645916 0 peter 2012-06-11 05:36:45 -0700 [Chromium] Theme updates for Android in menu list rendering and selection backgrounds 645921 1 146838 peter 2012-06-11 05:42:51 -0700 Created attachment 146838 Patch 645925 2 peter 2012-06-11 05:51:54 -0700 Adam, are you comfortable reviewing this as Eric's still on holiday? 646068 3 146838 abarth 2012-06-11 10:20:18 -0700 Comment on attachment 146838 Patch Thanks! 646112 4 146838 webkit.review.bot 2012-06-11 11:14:15 -0700 Comment on attachment 146838 Patch Clearing flags on attachment: 146838 Committed r119987: <http://trac.webkit.org/changeset/119987> 646113 5 webkit.review.bot 2012-06-11 11:14:19 -0700 All reviewed patches have been landed. Closing bug. 146838 2012-06-11 05:42:51 -0700 2012-06-11 11:14:15 -0700 Patch bug-88775-20120611134250.patch text/plain 5905 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWNjMmEzNmViN2IxMjgx NGIxMzI5NzViYTNjYzM5NTBiY2M1MzU0OC4uNzIxYTg4OGVlNWM5NmE5MGFjZTc2MDY0NGViYjA2 OWY2MjcwNzFkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTA2LTExICBQZXRl ciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFRo ZW1lIHVwZGF0ZXMgZm9yIEFuZHJvaWQgaW4gbWVudSBsaXN0IHJlbmRlcmluZyBhbmQgc2VsZWN0 aW9uIGJhY2tncm91bmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04ODc3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZvciBDaHJvbWUgb24gQW5kcm9pZCwgdXNlIHRoZSB3aWR0aCBvZiB0aGUgc2Nyb2xs YmFyIGRvd24gYXJyb3cgaW5zdGVhZAorICAgICAgICBvZiB0aGUgc2Nyb2xsYmFyJ3Mgd2lkdGgg Zm9yIGRldGVybWluaW5nIHRoZSBhcnJvdyBwYWRkaW5nIHRvIGFwcGx5IGZvcgorICAgICAgICBt ZW51IGxpc3QgcmVuZGVyaW5nLCBhcyBXZWJLaXQgaXNuJ3QgZHJhd2luZyBhIHNjcm9sbGJhciAo dGh1cyB3aWR0aD0wKS4KKworICAgICAgICBGdXJ0aGVybW9yZSwgY2hhbmdlIHRoZSBkZWZhdWx0 IGFjdGl2ZSBzZWxlY3Rpb24gYmFja2dyb3VuZCBjb2xvciB0byBiZQorICAgICAgICBlcXVhbCB0 byB0aGUgdGFwIGhpZ2hsaWdodGluZyBjb2xvci4KKworICAgICAgICBUaGVzZSBjaGFuZ2VzIHNo b3VsZCBiZSBjb3ZlcmVkIGJ5IGV4aXN0aW5nIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZDo6bWVudUxpc3RBcnJvd1BhZGRpbmcpOgorICAg ICAgICAoV2ViQ29yZSk6IFJldHJpZXZlIHRoZSBzY3JvbGxiYXIgZG93biBhcnJvdydzIHNpemUg dmlhIFBsYXRmb3JtU3VwcG9ydC4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJv bWl1bUFuZHJvaWQuaDogT3ZlcnJpZGUgdGhlIG1lbnVMaXN0QXJyb3dQYWRkaW5nCisgICAgICAg ICAgICBhbmQgcGxhdGZvcm1BY3RpdmVTZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3IgbWV0aG9kcywg YW5kIGFkZCBhIHN0YXRpYworICAgICAgICAgICAgc3RhdGljIFJHQkEzMiBjb2xvciBmb3IgdGhl IGRlZmF1bHQgYWN0aXZlIHNlbGVjdGlvbiBiZyBjb2xvci4KKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhl bWVDaHJvbWl1bVNraWE6Om1lbnVMaXN0QXJyb3dQYWRkaW5nKTogRGVmYXVsdCB0bworICAgICAg ICAgICAgdGhlIHNjcm9sbGJhciB0aGlja25lc3MsIG5vdCBjaGFuZ2luZyBiZWhhdmlvciBmb3Ig bm9uLUFuZHJvaWQuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6 bWVudUxpc3RJbnRlcm5hbFBhZGRpbmcpOiBJbnN0ZWFkCisgICAgICAgICAgICBvZiBwb2xsaW5n IHRoZSBzY3JvbGxiYXIgdGhpY2tuZXNzLCBjYWxsIG1lbnVMaXN0QXJyb3dQYWRkaW5nKCkuCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmg6IAorICAgICAgICAo UmVuZGVyVGhlbWVDaHJvbWl1bVNraWEpOiBBZGQgdGhlIG1lbnVMaXN0QXJyb3dQYWRkaW5nKCkg YXMgYSBwcm90ZWN0ZWQgbWV0aG9kLgorCiAyMDEyLTA2LTExICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XVtXaW5dIEZpeCBVU3RyaW5nIHJlbGF0 ZWQgYnVpbGQgcHJvYmxlbSBpbiBTb3VyY2UvV2ViQ29yZS9icmlkZ2UvcXQvcXRfaW5zdGFuY2Uu Y3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJv bWl1bUFuZHJvaWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hy b21pdW1BbmRyb2lkLmNwcAppbmRleCA4YjcxMjMwODgzNjVkYzZiZjJiNjQ1NTdmMDZjOGUzNWJm ZDI5YzM5Li45N2Y1ODc0NTUzNDJkYzJiZjMwOThhNTI5YTI0NWQ5ZmYwY2FhZTkxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5k cm9pZC5jcHAKQEAgLTk5LDQgKzk5LDEyIEBAIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJv aWQ6OnBhaW50TWVkaWFGdWxsc2NyZWVuQnV0dG9uKFJlbmRlck9iamVjdCogb2JqZWN0CiAjZW5k aWYKIH0KIAoraW50IFJlbmRlclRoZW1lQ2hyb21pdW1BbmRyb2lkOjptZW51TGlzdEFycm93UGFk ZGluZygpIGNvbnN0Cit7CisgICAgLy8gV2UgY2Fubm90IHVzZSB0aGUgc2Nyb2xsYmFyIHRoaWNr bmVzcyBoZXJlLCBhcyBpdCdzIHdpZHRoIGlzIDAgb24gQW5kcm9pZC4KKyAgICAvLyBJbnN0ZWFk LCB1c2UgdGhlIHdpZHRoIG9mIHRoZSBzY3JvbGxiYXIgZG93biBhcnJvdy4KKyAgICBJbnRTaXpl IHNjcm9sbGJhclNpemUgPSBQbGF0Zm9ybVN1cHBvcnQ6OmdldFRoZW1lUGFydFNpemUoUGxhdGZv cm1TdXBwb3J0OjpQYXJ0U2Nyb2xsYmFyRG93bkFycm93KTsKKyAgICByZXR1cm4gc2Nyb2xsYmFy U2l6ZS53aWR0aCgpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQuaCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5oCmluZGV4 IDNkY2Q2ZGY5MzY2ZDVlNTBiNzdkZDFkY2VjNjJmNzE2NDIyOTA4ZGEuLmY3YWFmYWExOGNkNTcy MmQ2OTY0OWMwMmQ3ZmE4ZWRkMzc0OTk2ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZC5oCkBAIC00MSw3ICs0MSw3IEBA IHB1YmxpYzoKIAogICAgIHZpcnR1YWwgYm9vbCBkZWxlZ2F0ZXNNZW51TGlzdFJlbmRlcmluZygp IGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7IH0KIAotICAgIHZpcnR1YWwgYm9vbCBwYWlu dE1lZGlhRnVsbHNjcmVlbkJ1dHRvbihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBj b25zdCBJbnRSZWN0Jik7CisgICAgdmlydHVhbCBib29sIHBhaW50TWVkaWFGdWxsc2NyZWVuQnV0 dG9uKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKSBPVkVS UklERTsKIAogI2lmIEVOQUJMRShWSURFTykKICAgICB2aXJ0dWFsIFN0cmluZyBleHRyYU1lZGlh Q29udHJvbHNTdHlsZVNoZWV0KCkgT1ZFUlJJREU7CkBAIC01NCwxMCArNTQsMTkgQEAgcHVibGlj OgogICAgIH0KICNlbmRpZgogCisgICAgdmlydHVhbCBDb2xvciBwbGF0Zm9ybUFjdGl2ZVNlbGVj dGlvbkJhY2tncm91bmRDb2xvcigpIGNvbnN0IE9WRVJSSURFCisgICAgeworICAgICAgICByZXR1 cm4gUmVuZGVyVGhlbWVDaHJvbWl1bUFuZHJvaWQ6OmRlZmF1bHRBY3RpdmVTZWxlY3Rpb25CYWNr Z3JvdW5kQ29sb3I7CisgICAgfQorCitwcm90ZWN0ZWQ6CisgICAgdmlydHVhbCBpbnQgbWVudUxp c3RBcnJvd1BhZGRpbmcoKSBjb25zdCBPVkVSUklERTsKKwogcHJpdmF0ZToKICAgICB2aXJ0dWFs IH5SZW5kZXJUaGVtZUNocm9taXVtQW5kcm9pZCgpOwogCiAgICAgc3RhdGljIGNvbnN0IFJHQkEz MiBkZWZhdWx0VGFwSGlnaGxpZ2h0Q29sb3IgPSAweDY2MzNiNWU1OworICAgIHN0YXRpYyBjb25z dCBSR0JBMzIgZGVmYXVsdEFjdGl2ZVNlbGVjdGlvbkJhY2tncm91bmRDb2xvciA9IDB4NjYzM2I1 ZTU7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcAppbmRleCA3YWQyYzEyYzM1 MDQxZDgxOWUzN2UzYWQ5YjY1YWJkMjdkYjYzYjg1Li4wMzg2YzAxMzc0MWU3ZWYzYzM1MTFkODgy MmYwODlhN2VkMTM2NzM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVDaHJvbWl1bVNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZUNocm9taXVtU2tpYS5jcHAKQEAgLTUxOSw2ICs1MTksMTEgQEAgZG91YmxlIFJl bmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpjYXJldEJsaW5rSW50ZXJ2YWxJbnRlcm5hbCgpIGNvbnN0 CiAgICAgcmV0dXJuIFJlbmRlclRoZW1lOjpjYXJldEJsaW5rSW50ZXJ2YWwoKTsKIH0KIAoraW50 IFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjptZW51TGlzdEFycm93UGFkZGluZygpIGNvbnN0Cit7 CisgICAgcmV0dXJuIFNjcm9sbGJhclRoZW1lOjp0aGVtZSgpLT5zY3JvbGxiYXJUaGlja25lc3Mo KTsKK30KKwogLy8gc3RhdGljCiB2b2lkIFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjpzZXRTaXpl SWZBdXRvKFJlbmRlclN0eWxlKiBzdHlsZSwgY29uc3QgSW50U2l6ZSYgc2l6ZSkKIHsKQEAgLTU0 MSw3ICs1NDYsNyBAQCBpbnQgUmVuZGVyVGhlbWVDaHJvbWl1bVNraWE6Om1lbnVMaXN0SW50ZXJu YWxQYWRkaW5nKFJlbmRlclN0eWxlKiBzdHlsZSwgaW50IHBhZAogICAgIC8vIHdlIGRvbid0IGRy YXcgYSBidXR0b24sIHNvIGRvbid0IHJlc2VydmUgc3BhY2UgZm9yIGl0LgogICAgIGNvbnN0IGlu dCBiYXJUeXBlID0gc3R5bGUtPmRpcmVjdGlvbigpID09IExUUiA/IFJpZ2h0UGFkZGluZyA6IExl ZnRQYWRkaW5nOwogICAgIGlmIChwYWRkaW5nVHlwZSA9PSBiYXJUeXBlICYmIHN0eWxlLT5hcHBl YXJhbmNlKCkgIT0gTm9Db250cm9sUGFydCkKLSAgICAgICAgcGFkZGluZyArPSBTY3JvbGxiYXJU aGVtZTo6dGhlbWUoKS0+c2Nyb2xsYmFyVGhpY2tuZXNzKCk7CisgICAgICAgIHBhZGRpbmcgKz0g bWVudUxpc3RBcnJvd1BhZGRpbmcoKTsKIAogICAgIHJldHVybiBwYWRkaW5nOwogfQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmgg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuaAppbmRl eCAyODk4OTNlMzEzMTc4MjAxNGYxMzUwYjc0NjU2MDk4NmY2ZGYzY2I3Li4wMDI4ZWJiNWE3Zjhi YzIwZmFhYjQ3N2MxMzBkMWZiNzAxMjdiZWIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNraWEuaApAQCAtMTQ2LDYgKzE0Niw4IEBAIGNs YXNzIFJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhIDogcHVibGljIFJlbmRlclRoZW1lIHsKIAogICAg ICAgICB2aXJ0dWFsIGRvdWJsZSBjYXJldEJsaW5rSW50ZXJ2YWxJbnRlcm5hbCgpIGNvbnN0Owog CisgICAgICAgIHZpcnR1YWwgaW50IG1lbnVMaXN0QXJyb3dQYWRkaW5nKCkgY29uc3Q7CisKICAg ICAgICAgc3RhdGljIHZvaWQgc2V0U2l6ZUlmQXV0byhSZW5kZXJTdHlsZSosIGNvbnN0IEludFNp emUmKTsKIAogI2lmIEVOQUJMRShQUk9HUkVTU19UQUcpCg==