88774 2012-06-11 04:15:45 -0700 [GTK] Memory leaks in DRT EventSender.cpp 2012-06-11 12:50:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gustavo mrobinson webkit.review.bot oldest_to_newest 645895 0 naginenis 2012-06-11 04:15:45 -0700 Possible memory leaks in DRT EventSender code. ==26953== 136 bytes in 1 blocks are still reachable in loss record 11,373 of 12,819 ==26953== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26953== by 0xC59EA38: g_malloc (gmem.c:159) ==26953== by 0xC5B1C62: g_slice_alloc (gslice.c:1003) ==26953== by 0xC5B21A5: g_slice_alloc0 (gslice.c:1029) ==26953== by 0xB8CB5AF: gdk_event_new (gdkevents.c:426) ==26953== by 0x4633A5: mouseDownCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:317) ==26953== by 0x525460B: JSC::JSCallbackFunction::call(JSC::ExecState*) (JSCallbackFunction.cpp:73) ==26953== by 0x5435722: JSC::LLInt::handleHostCall(JSC::ExecState*, JSC::Instruction*, JSC::JSValue, JSC::CodeSpecializationKind) (LLIntSlowPaths.cpp:1283) ==26953== by 0x54383F5: JSC::LLInt::setUpCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*) (LLIntSlowPaths.cpp:1327) ==26953== by 0x543896F: JSC::LLInt::genericCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind) (LLIntSlowPaths.cpp:1383) ==26953== 136 bytes in 1 blocks are still reachable in loss record 11,374 of 12,819 ==26953== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==26953== by 0xC59EA38: g_malloc (gmem.c:159) ==26953== by 0xC5B1C62: g_slice_alloc (gslice.c:1003) ==26953== by 0xC5B21A5: g_slice_alloc0 (gslice.c:1029) ==26953== by 0xB8CB5AF: gdk_event_new (gdkevents.c:426) ==26953== by 0x463557: mouseUpCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:365) ==26953== by 0x525460B: JSC::JSCallbackFunction::call(JSC::ExecState*) (JSCallbackFunction.cpp:73) ==26953== by 0x5435722: JSC::LLInt::handleHostCall(JSC::ExecState*, JSC::Instruction*, JSC::JSValue, JSC::CodeSpecializationKind) (LLIntSlowPaths.cpp:1283) ==26953== by 0x54383F5: JSC::LLInt::setUpCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*) (LLIntSlowPaths.cpp:1327) ==26953== by 0x543896F: JSC::LLInt::genericCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind) (LLIntSlowPaths.cpp:1383) ==17417== 136 bytes in 1 blocks are still reachable in loss record 11,013 of 12,261 ==17417== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==17417== by 0xC59EA38: g_malloc (gmem.c:159) ==17417== by 0xC5B1C62: g_slice_alloc (gslice.c:1003) ==17417== by 0xC5B21A5: g_slice_alloc0 (gslice.c:1029) ==17417== by 0xB8CB5AF: gdk_event_new (gdkevents.c:426) ==17417== by 0x462D8A: contextClickCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:206) ==17417== by 0x525460B: JSC::JSCallbackFunction::call(JSC::ExecState*) (JSCallbackFunction.cpp:73) ==17417== by 0x5435722: JSC::LLInt::handleHostCall(JSC::ExecState*, JSC::Instruction*, JSC::JSValue, JSC::CodeSpecializationKind) (LLIntSlowPaths.cpp:1283) ==17417== by 0x54383F5: JSC::LLInt::setUpCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*) (LLIntSlowPaths.cpp:1327) ==17417== by 0x543896F: JSC::LLInt::genericCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind) (LLIntSlowPaths.cpp:1383) 645905 1 146830 naginenis 2012-06-11 04:29:32 -0700 Created attachment 146830 Patch Fixed possible memory leaks. 646181 2 146830 webkit.review.bot 2012-06-11 12:50:16 -0700 Comment on attachment 146830 Patch Clearing flags on attachment: 146830 Committed r119999: <http://trac.webkit.org/changeset/119999> 646182 3 webkit.review.bot 2012-06-11 12:50:20 -0700 All reviewed patches have been landed. Closing bug. 146830 2012-06-11 04:29:32 -0700 2012-06-11 12:50:16 -0700 Patch 88774.patch text/plain 2798 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4Yjhm MTliLi4yOTM0MDljIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMTEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gTWVt b3J5IGxlYWtzIGluIERSVCBFdmVudFNlbmRlci5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4Nzc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEgZmV3IHBvc3NpYmxlIG1lbW9yeSBsZWFrcyBp biBFdmVudFNlbmRlciBjb2RlLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50 U2VuZGVyLmNwcDoKKyAgICAgICAgKGNvbnRleHRDbGlja0NhbGxiYWNrKTogRnJlZSB0aGUgZXZl bnQgcmV0dXJuZWQgYnkgZ2RrX2V2ZW50X25ldygpLgorICAgICAgICAobW91c2VEb3duQ2FsbGJh Y2spOiBEaXR0by4KKyAgICAgICAgKG1vdXNlVXBDYWxsYmFjayk6IERpdHRvLgorCiAyMDEyLTA2 LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEV4cG9zZSBs YXlvdXRUZXN0Q29udHJvbGxlciBhcyB0ZXN0UnVubmVyCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3Rr L0V2ZW50U2VuZGVyLmNwcAppbmRleCBiYzM4YTIwLi4xMDJiYjY2IDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9ndGsvRXZlbnRTZW5kZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKQEAgLTIwNSw4ICsyMDUsMTAgQEAgc3RhdGljIEpT VmFsdWVSZWYgY29udGV4dENsaWNrQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2Jq ZWN0UmVmIGZ1bmN0aW8KIHsKICAgICBHZGtFdmVudCogcHJlc3NFdmVudCA9IGdka19ldmVudF9u ZXcoR0RLX0JVVFRPTl9QUkVTUyk7CiAKLSAgICBpZiAoIXByZXBhcmVNb3VzZUJ1dHRvbkV2ZW50 KHByZXNzRXZlbnQsIDIsIDApKQorICAgIGlmICghcHJlcGFyZU1vdXNlQnV0dG9uRXZlbnQocHJl c3NFdmVudCwgMiwgMCkpIHsKKyAgICAgICAgZ2RrX2V2ZW50X2ZyZWUocHJlc3NFdmVudCk7CiAg ICAgICAgIHJldHVybiBKU09iamVjdE1ha2VBcnJheShjb250ZXh0LCAwLCAwLCAwKTsKKyAgICB9 CiAKICAgICBHZGtFdmVudCogcmVsZWFzZUV2ZW50ID0gZ2RrX2V2ZW50X2NvcHkocHJlc3NFdmVu dCk7CiAgICAgc2VuZE9yUXVldWVFdmVudChwcmVzc0V2ZW50KTsKQEAgLTMxNSwxMiArMzE3LDE2 IEBAIHN0YXRpYyBKU1ZhbHVlUmVmIG1vdXNlRG93bkNhbGxiYWNrKEpTQ29udGV4dFJlZiBjb250 ZXh0LCBKU09iamVjdFJlZiBmdW5jdGlvbiwKICAgICBndWludCBtb2RpZmllcnMgPSBhcmd1bWVu dENvdW50ID49IDIgPyBnZGtNb2RpZmVyc0Zyb21KU1ZhbHVlKGNvbnRleHQsIGFyZ3VtZW50c1sx XSkgOiAwOwogCiAgICAgR2RrRXZlbnQqIGV2ZW50ID0gZ2RrX2V2ZW50X25ldyhHREtfQlVUVE9O X1BSRVNTKTsKLSAgICBpZiAoIXByZXBhcmVNb3VzZUJ1dHRvbkV2ZW50KGV2ZW50LCBidXR0b24s IG1vZGlmaWVycykpCisgICAgaWYgKCFwcmVwYXJlTW91c2VCdXR0b25FdmVudChldmVudCwgYnV0 dG9uLCBtb2RpZmllcnMpKSB7CisgICAgICAgIGdka19ldmVudF9mcmVlKGV2ZW50KTsKICAgICAg ICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVkKGNvbnRleHQpOworICAgIH0KIAogICAgIC8v IElmIHRoZSBzYW1lIG1vdXNlIGJ1dHRvbiBpcyBhbHJlYWR5IGluIHRoZSBkb3duIHBvc2l0aW9u IGRvbid0IHNlbmQgYW5vdGhlciBldmVudCBhcyBpdCBtYXkgY29uZnVzZSBYdmZiLgotICAgIGlm IChidXR0b25DdXJyZW50bHlEb3duID09IGV2ZW50LT5idXR0b24uYnV0dG9uKQorICAgIGlmIChi dXR0b25DdXJyZW50bHlEb3duID09IGV2ZW50LT5idXR0b24uYnV0dG9uKSB7CisgICAgICAgIGdk a19ldmVudF9mcmVlKGV2ZW50KTsKICAgICAgICAgcmV0dXJuIEpTVmFsdWVNYWtlVW5kZWZpbmVk KGNvbnRleHQpOworICAgIH0KIAogICAgIGJ1dHRvbkN1cnJlbnRseURvd24gPSBldmVudC0+YnV0 dG9uLmJ1dHRvbjsKIApAQCAtMzYzLDggKzM2OSwxMCBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBtb3Vz ZVVwQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBK UwogICAgIGd1aW50IG1vZGlmaWVycyA9IGFyZ3VtZW50Q291bnQgPj0gMiA/IGdka01vZGlmZXJz RnJvbUpTVmFsdWUoY29udGV4dCwgYXJndW1lbnRzWzFdKSA6IDA7CiAKICAgICBHZGtFdmVudCog ZXZlbnQgPSBnZGtfZXZlbnRfbmV3KEdES19CVVRUT05fUkVMRUFTRSk7Ci0gICAgaWYgKCFwcmVw YXJlTW91c2VCdXR0b25FdmVudChldmVudCwgYnV0dG9uLCBtb2RpZmllcnMpKQorICAgIGlmICgh cHJlcGFyZU1vdXNlQnV0dG9uRXZlbnQoZXZlbnQsIGJ1dHRvbiwgbW9kaWZpZXJzKSkgeworICAg ICAgICBnZGtfZXZlbnRfZnJlZShldmVudCk7CiAgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVu ZGVmaW5lZChjb250ZXh0KTsKKyAgICB9CiAKICAgICBsYXN0Q2xpY2tQb3NpdGlvblggPSBsYXN0 TW91c2VQb3NpdGlvblg7CiAgICAgbGFzdENsaWNrUG9zaXRpb25ZID0gbGFzdE1vdXNlUG9zaXRp b25ZOwo=