88773 2012-06-11 03:22:54 -0700 [BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside 2014-01-28 08:12:10 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 88965 1 mawu mawu andersca leo.yang rwlbuis tonikitoo webkit.review.bot oldest_to_newest 645876 0 mawu 2012-06-11 03:22:54 -0700 if there's no data in the page, we should still pass on the dataReceived event to client. It's critical to two cases: plugin and download. Otherwise if we only send notifyClose without dataReceived, FrameLoaderBlackBerry will create pluginView in close and have no chance to clear it later; download will create DownloadFilterStream in notifyClose and can't get any update afterwards since NetworkStream already closed. 645885 1 mawu 2012-06-11 03:41:05 -0700 related to RIM PR# 164563 645886 2 146820 mawu 2012-06-11 03:42:12 -0700 Created attachment 146820 Patch 645964 3 146820 rwlbuis 2012-06-11 06:56:22 -0700 Comment on attachment 146820 Patch Looks good. 646598 4 146820 webkit.review.bot 2012-06-11 20:46:51 -0700 Comment on attachment 146820 Patch Clearing flags on attachment: 146820 Committed r120036: <http://trac.webkit.org/changeset/120036> 646599 5 webkit.review.bot 2012-06-11 20:46:56 -0700 All reviewed patches have been landed. Closing bug. 647722 6 webkit.review.bot 2012-06-12 23:10:07 -0700 Re-opened since this is blocked by 88965 146820 2012-06-11 03:42:12 -0700 2012-06-11 20:46:51 -0700 Patch bug-88773-20120611184209.patch text/plain 2042 mawu U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZkMTIwZTcxOTliYTBj Zjg5OTNmMWY0ODI1YTM3ZjhkYjljNTcwMS4uZTZjNDM1ZTJmYTAxNGJlMjdmZjM0NDA2M2Q2NDk4 ZWVmYTZkMDE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA2LTExICBNYXJ5 IFd1ICA8bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnld IEFkZCBoYW5kbGluZyBvZiBub3RpZnlEYXRhUmVjZWl2ZWQgaW4gTmV0d29ya0pvYiBldmVuIHRo ZXJlJ3Mgbm8gZGF0YSBpbnNpZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg4NzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSGFuZGxpbmcgbm90aWZ5RGF0YVJlY2VpdmVkIGV2ZW50IGV2ZW4gaWYgdGhl cmUgaXMgbm8gZGF0YSBpbnNpZGUuCisgICAgICAgIFRoaXMgZXZlbnQgd2FzIGNyaXRpY2FsIGJl Y2F1c2UgaXQgZ2l2ZXMgZG93bmxvYWRGaWx0ZXJTdHJlYW0gYSBjaGFuY2UKKyAgICAgICAgdG8g Zm9sbG93IHVwIE5ldHdvcmtTdHJlYW0gY2xvc2UgZXZlbnQsIGFuZCBpdCBhbHNvIG1ha2UgcGx1 Z2luVmlldyBpbgorICAgICAgICBGcmFtZUxvYWRlckJsYWNrQmVycnkgcmV0dXJuIG5vcm1hbCBs b2dpYy4KKworICAgICAgICBSSU0gUFIjIDE2NDU2MworCisgICAgICAgIFJldmlld2VkIGludGVy bmFsbHkgYnkgTGVvIFlhbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVy cnkvTmV0d29ya0pvYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9iOjpoYW5kbGVO b3RpZnlEYXRhUmVjZWl2ZWQpOgorCiAyMDEyLTA2LTA4ICBLZW50IFRhbXVyYSAgPHRrZW50QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBNb3ZlIGZvcm0tcmVsYXRlZCBmdW5jdGlvbnMgb2YgRG9j dW1lbnQgdG8gRm9ybUNvbnRyb2xsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCBkNTQzNjE2M2Nm MGU2ZWE5OWMyYWU5MWEyOTBmNDQ2ZDNmNmMxMmJkLi44NDQzNTBjMWJhMDVhYWU2NDhkNjczZGI4 NDNkMjAxMDFjZmZkZjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC0zODUsOSArMzg1LDEyIEBA IHZvaWQgTmV0d29ya0pvYjo6aGFuZGxlTm90aWZ5RGF0YVJlY2VpdmVkKGNvbnN0IGNoYXIqIGJ1 Ziwgc2l6ZV90IGxlbikKICAgICBpZiAoKCFtX2lzRmlsZSAmJiAhbV9zdGF0dXNSZWNlaXZlZCkg fHwgbV9jYW5jZWxsZWQpCiAgICAgICAgIHJldHVybjsKIAotICAgIGlmICghYnVmIHx8ICFsZW4p CisgICAgaWYgKCFidWYgfHwgIWxlbikgeworICAgICAgICBzZW5kUmVzcG9uc2VJZk5lZWRlZCgp OworICAgICAgICBpZiAoaXNDbGllbnRBdmFpbGFibGUoKSkKKyAgICAgICAgICAgIG1faGFuZGxl LT5jbGllbnQoKS0+ZGlkUmVjZWl2ZURhdGEobV9oYW5kbGUuZ2V0KCksIDAsIDAsIDApOwogICAg ICAgICByZXR1cm47Ci0KKyAgICB9CiAgICAgLy8gVGhlIGxvYWRGaWxlIEFQSSBzZXRzIHRoZSBv dmVycmlkZSBjb250ZW50IHR5cGUsCiAgICAgLy8gdGhpcyB3aWxsIGFsd2F5cyBiZSB1c2VkIGFz IHRoZSBjb250ZW50IHR5cGUgYW5kIHNob3VsZCBub3QgYmUgb3ZlcnJpZGRlbi4KICAgICBpZiAo IW1fZGF0YVJlY2VpdmVkICYmICFtX2lzT3ZlcnJpZGVDb250ZW50VHlwZSkgewo=