88770 2012-06-11 01:44:59 -0700 REGRESSION(r119944): test http/tests/security/mixedContent/filesystem-url-in-iframe.html fails 2012-06-11 04:28:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 szledan mkwst abarth mkwst ossy webkit.review.bot oldest_to_newest 645836 0 szledan 2012-06-11 01:44:59 -0700 This test: http/tests/security/mixedContent/filesystem-url-in-iframe.html fails after r119944 on qt. --- /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/http/tests/security/mixedContent/filesystem-url-in-iframe-actual.txt @@ -1,8 +1,10 @@ -ALERT: PASS (1/2): File written +CONSOLE MESSAGE: line 28: ReferenceError: Can't find variable: TEMPORARY +CONSOLE MESSAGE: line 28: ReferenceError: Can't find variable: TEMPORARY +FAIL: Timed out waiting for notifyDone to be called This tests that filesystem URLs created in a secure context are treated as secure origins. This test passes if the iframe renders PASS correctly, and no console warning appears. -------- Frame: '<!--framePath //<!--frame0-->-->' -------- -PASS (2/2): File displayed + 645838 1 mkwst 2012-06-11 01:50:28 -0700 I'll take a look. 645841 2 ossy 2012-06-11 02:02:59 -0700 Skipped on Qt to paint the bot green by http://trac.webkit.org/changeset/119964/trunk/LayoutTests/platform/qt/Skipped . Please unskip it with the proper fix. 645843 3 mkwst 2012-06-11 02:04:34 -0700 Actually, it looks like ENABLE(FILE_SYSTEM) is disabled on QT. I'll move the skip to the proper section of the Skipped file so that it can be reenabled if and when the port enables the feature. 645846 4 146813 mkwst 2012-06-11 02:13:05 -0700 Created attachment 146813 Patch 645850 5 146813 mkwst 2012-06-11 02:13:53 -0700 Comment on attachment 146813 Patch Would you mind taking a look, and throwing it into the queue if you're happy? 645877 6 146813 ossy 2012-06-11 03:23:48 -0700 Comment on attachment 146813 Patch r=me, thanks for looking into the root of the problem. 645903 7 146813 webkit.review.bot 2012-06-11 04:28:00 -0700 Comment on attachment 146813 Patch Clearing flags on attachment: 146813 Committed r119971: <http://trac.webkit.org/changeset/119971> 645904 8 webkit.review.bot 2012-06-11 04:28:05 -0700 All reviewed patches have been landed. Closing bug. 146813 2012-06-11 02:13:05 -0700 2012-06-11 04:28:00 -0700 Patch bug-88770-20120611111259.patch text/plain 2127 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTY0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGQyMmZlMzllNWY4NzVlZGRmN2Zm MmRjZDhmOGRlZmQwNWJhMGZmOS4uZjQ4YjFiOGY3MjdmMTFlM2QxN2ZiMDQwZmI4MDliYzQyZGJk YzNhZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTExICBNaWtlIFdlc3QgIDxta3dz dEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1F0XSBTa2lwcGluZyBodHRwL3Rlc3RzL3NlY3Vy aXR5L21peGVkQ29udGVudC9maWxlc3lzdGVtLXVybC1pbi1pZnJhbWUuaHRtbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg3NzAKKworICAgICAgICBF TkFCTEUoRklMRV9TWVNURU0pIGlzIGRpc2FibGVkOyB0aGlzIHRlc3Qgc2hvdWxkIGJlIHNraXBw ZWQgdW50aWwKKyAgICAgICAgdGhhdCBmZWF0dXJlIGlzIGVuYWJsZWQuIE1vdmluZyBpdCB1cCBp bnRvIHRoZSBwcm9wZXIgc2VjdGlvbiBvZiB0aGUKKyAgICAgICAgU2tpcHBlZCBmaWxlIHRvIG1h a2Ugc3VyZSBpdCdzIGVuYWJsZWQgaWYgYW5kIHdoZW4gdGhlIGZlYXR1cmUgbWFrZXMKKyAgICAg ICAgaXQgaW50byB0aGUgcG9ydC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisKIDIwMTItMDYtMTEgIFN6aWxh cmQgTGVkYW4gIDxzemxlZGFuQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdIEdhcmRl bmluZywgc2tpcCBuZXcgZmFpbGluZyB0ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL3F0L1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4 IDIwNGNmZWU1OWMxMzJmNGIyMTUxZDAzYWI1N2RiYWRhODcxN2UwYWEuLjYwNzRmOWUzOGEyYzI3 YzRjOTMzM2Y0YjM5NTA3OTU1ZmU3Y2Q4OGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAt MTE4LDYgKzExOCw3IEBAIHN2Zy93ZWJhcmNoaXZlCiBmYXN0L2ZpbGVzeXN0ZW0KIGh0dHAvdGVz dHMvZmlsZXN5c3RlbQogaHR0cC90ZXN0cy9zZWN1cml0eS9maWxlc3lzdGVtLWlmcmFtZS1mcm9t LXJlbW90ZS5odG1sCitodHRwL3Rlc3RzL3NlY3VyaXR5L21peGVkQ29udGVudC9maWxlc3lzdGVt LXVybC1pbi1pZnJhbWUuaHRtbAogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9zZW5k LWZpbGUtYmxvYi5odG1sCiBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL3NlbmQtZmls ZS1ibG9iLWZhaWwuaHRtbAogZmFzdC9tdXRhdGlvbi9maWxlc3lzdGVtLWNhbGxiYWNrLWRlbGl2 ZXJ5Lmh0bWwKQEAgLTY4NCwxMCArNjg1LDYgQEAgaHR0cC90ZXN0cy9jb29raWVzL2pzLWdldC1h bmQtc2V0LWh0dHAtb25seS1jb29raWUucGhwCiAjIGh0dHAvdGVzdHMvY2FjaGUvY2FuY2VsLWlu LXByb2dyZXNzLWxvYWQuaHRtbCBmYWlscyBvbiBRdCBmcm9tIHIxMTg2MTgKIGh0dHAvdGVzdHMv Y2FjaGUvY2FuY2VsLWluLXByb2dyZXNzLWxvYWQuaHRtbAogCi0jIFJFR1JFU1NJT04ocjExOTk0 NCk6IHRlc3QgaHR0cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvZmlsZXN5c3RlbS11cmwt aW4taWZyYW1lLmh0bWwgZmFpbHMKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg4NzcwCi1odHRwL3Rlc3RzL3NlY3VyaXR5L21peGVkQ29udGVudC9maWxlc3lzdGVt LXVybC1pbi1pZnJhbWUuaHRtbAotCiAjIE5ldyB0ZXN0IGh0dHAvdGVzdHMvY29va2llcy9qcy1n ZXQtYW5kLXNldC1odHRwLW9ubHktY29va2llLnBocCBmYWlscyBvbiBNYWMsIEdUSywgUXQsIEVG TCAoaW50cm9kdWNlZCBpbiByMTE5OTQ3KQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODcyMDgKIGh0dHAvdGVzdHMvY29va2llcy9qcy1nZXQtYW5kLXNldC1odHRw LW9ubHktY29va2llLmh0bWwK