88764 2012-06-11 00:48:50 -0700 [WK2] Fix client interface size for WKPageLoaderClient 2012-06-14 00:04:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski andersca ap sam webkit.review.bot oldest_to_newest 645802 0 g.czajkowski 2012-06-11 00:48:50 -0700 Fixes offset of WKPageLoaderClient for version 0 by adding didDetectXSSForFrame. 645803 1 146801 g.czajkowski 2012-06-11 00:50:30 -0700 Created attachment 146801 proposed patch 646180 2 ap 2012-06-11 12:49:56 -0700 I don't understand the versioning scheme enough to tell what this does exactly. Could you please explain what this actually fixes? One would expect version 0 to have stabilized long ago. 646896 3 g.czajkowski 2012-06-12 06:40:43 -0700 (In reply to comment #2) > I don't understand the versioning scheme enough to tell what this does exactly. Could you please explain what this actually fixes? One would expect version 0 to have stabilized long ago. interfaceSizesByVersion it's a table that keeps size of structure for each version of client interface. If someone wants to change it (because of API change) then the structure should be extended by adding a new callback to the current and bump version. For example, version 0 of WKBundlePageLoaderClient includes members of structure from 0 to 17. To include last callback (didHandleOnloadEventsForFrame) we have to give offset to next one (didLayoutForFrame) but it isn't attached. This patch adds didDetectXSSForFrame callback for version 0 of WKPageLoaderClient because offset should be set to next member of structure. 647048 4 146801 andersca 2012-06-12 10:30:54 -0700 Comment on attachment 146801 proposed patch Please explain in the ChangeLog that the offset should be of the first new callback that was added in the new version. Looks fine otherwise! 647753 5 147246 g.czajkowski 2012-06-13 00:14:10 -0700 Created attachment 147246 updated ChangeLog according to Anders' review Thanks Anders for review! 648867 6 147246 webkit.review.bot 2012-06-14 00:04:34 -0700 Comment on attachment 147246 updated ChangeLog according to Anders' review Clearing flags on attachment: 147246 Committed r120290: <http://trac.webkit.org/changeset/120290> 648868 7 webkit.review.bot 2012-06-14 00:04:39 -0700 All reviewed patches have been landed. Closing bug. 146801 2012-06-11 00:50:30 -0700 2012-06-13 00:14:10 -0700 proposed patch fix_client_interface_size_wkpageloaderclient.patch text/plain 1268 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNDI4NjYwLi5jOWUyZDNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDYtMTEgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW1dLMl0gRml4IGNsaWVudCBpbnRlcmZhY2Ugc2l6ZSBmb3IgV0tQ YWdlTG9hZGVyQ2xpZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODg3NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXhlcyBvZmZzZXQgb2YgV0tQYWdlTG9hZGVyQ2xpZW50IGZvciB2ZXJzaW9uIDAg YnkgYWRkaW5nIGRpZERldGVjdFhTU0ZvckZyYW1lLgorCisgICAgICAgICogU2hhcmVkL0FQSUNs aWVudFRyYWl0cy5jcHA6CisgICAgICAgIChXZWJLaXQpOgorCiAyMDEyLTA2LTEwICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW5uZWVkZWQgY2FsbFJl bW92ZWRMYXN0UmVmIGZ1bmN0aW9uIGZyb20gVHJlZVNoYXJlZCByZWZhY3RvcmluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudFRyYWl0cy5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmNwcAppbmRleCA2OWM2YmJmLi5lYWE3MzA2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmNwcApAQCAtNTQsNyAr NTQsNyBAQCBjb25zdCBzaXplX3QgQVBJQ2xpZW50VHJhaXRzPFdLUGFnZUNvbnRleHRNZW51Q2xp ZW50Pjo6aW50ZXJmYWNlU2l6ZXNCeVZlcnNpb25bXQogfTsKIAogY29uc3Qgc2l6ZV90IEFQSUNs aWVudFRyYWl0czxXS1BhZ2VMb2FkZXJDbGllbnQ+OjppbnRlcmZhY2VTaXplc0J5VmVyc2lvbltd ID0gewotICAgIG9mZnNldG9mKFdLUGFnZUxvYWRlckNsaWVudCwgZGlkRmFpbFRvSW5pdGlhbGl6 ZVBsdWdpbl9kZXByZWNhdGVkRm9yVXNlV2l0aFYwKSwKKyAgICBvZmZzZXRvZihXS1BhZ2VMb2Fk ZXJDbGllbnQsIGRpZERldGVjdFhTU0ZvckZyYW1lKSwKICAgICBzaXplb2YoV0tQYWdlTG9hZGVy Q2xpZW50KQogfTsKIAo= 147246 2012-06-13 00:14:10 -0700 2012-06-14 00:04:34 -0700 updated ChangeLog according to Anders' review fix_client_interface_size_wkpageloaderclient.patch text/plain 1362 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1M2YwMzA3Li43NjE4M2JiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDYtMTMgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW1dLMl0gRml4IGNsaWVudCBpbnRlcmZhY2Ugc2l6ZSBmb3IgV0tQ YWdlTG9hZGVyQ2xpZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODg3NjQKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCisK KyAgICAgICAgRml4ZXMgb2Zmc2V0IG9mIFdLUGFnZUxvYWRlckNsaWVudCBmb3IgdmVyc2lvbiAw IGJ5IGFkZGluZyBkaWREZXRlY3RYU1NGb3JGcmFtZS4KKyAgICAgICAgVGhlIG9mZnNldCBzaG91 bGQgYmUgb2ZmIHRoZSBmaXJzdCBuZXcgY2FsbGJhY2sgdGhhdCB3YXMgYWRkZWQgaW4gdGhlIG5l dyB2ZXJzaW9uLgorCisgICAgICAgICogU2hhcmVkL0FQSUNsaWVudFRyYWl0cy5jcHA6CisgICAg ICAgIChXZWJLaXQpOgorCiAyMDEyLTA2LTEyICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29n bGUuY29tPgogCiAgICAgICAgIFNoYWRvdyBQc2V1ZG8gSUQgc2hvdWxkIGJlIGFibGUgdG8gbmVz dCB0byBwb2ludCBuZXN0ZWQgc2hhZG93IERPTS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9BUElDbGllbnRUcmFpdHMuY3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNs aWVudFRyYWl0cy5jcHAKaW5kZXggNjljNmJiZi4uZWFhNzMwNiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudFRyYWl0cy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv U2hhcmVkL0FQSUNsaWVudFRyYWl0cy5jcHAKQEAgLTU0LDcgKzU0LDcgQEAgY29uc3Qgc2l6ZV90 IEFQSUNsaWVudFRyYWl0czxXS1BhZ2VDb250ZXh0TWVudUNsaWVudD46OmludGVyZmFjZVNpemVz QnlWZXJzaW9uW10KIH07CiAKIGNvbnN0IHNpemVfdCBBUElDbGllbnRUcmFpdHM8V0tQYWdlTG9h ZGVyQ2xpZW50Pjo6aW50ZXJmYWNlU2l6ZXNCeVZlcnNpb25bXSA9IHsKLSAgICBvZmZzZXRvZihX S1BhZ2VMb2FkZXJDbGllbnQsIGRpZEZhaWxUb0luaXRpYWxpemVQbHVnaW5fZGVwcmVjYXRlZEZv clVzZVdpdGhWMCksCisgICAgb2Zmc2V0b2YoV0tQYWdlTG9hZGVyQ2xpZW50LCBkaWREZXRlY3RY U1NGb3JGcmFtZSksCiAgICAgc2l6ZW9mKFdLUGFnZUxvYWRlckNsaWVudCkKIH07CiAK