88738 2012-06-10 10:47:55 -0700 Some additional tweaks to keep TreeShared code simple/clean 2019-02-06 09:02:49 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin ap cdumez haraken sam webkit.review.bot oldest_to_newest 645580 0 darin 2012-06-10 10:47:55 -0700 Some additional tweaks to keep TreeShared code simple/clean 645581 1 146745 darin 2012-06-10 10:50:09 -0700 Created attachment 146745 Patch 645582 2 darin 2012-06-10 10:50:44 -0700 Just a tiny tweak I missed when doing the last patch. 645583 3 146745 haraken 2012-06-10 10:55:07 -0700 Comment on attachment 146745 Patch Looks good to me. But I'd like to delegate the review to experts. 645587 4 146745 abarth 2012-06-10 11:28:18 -0700 Comment on attachment 146745 Patch Having a destructor be virtual or not based on NDEBUG sounds scary! That can lead to behavior differences between Release and Debug that are hard to track down. 645589 5 darin 2012-06-10 11:30:44 -0700 (In reply to comment #4) > Having a destructor be virtual or not based on NDEBUG sounds scary! Yes, fixing that was my main motivation for this patch. I was in the shower and thinking about that virtual keyword there and came back to my computer to do this patch. 645599 6 146745 webkit.review.bot 2012-06-10 12:19:37 -0700 Comment on attachment 146745 Patch Clearing flags on attachment: 146745 Committed r119943: <http://trac.webkit.org/changeset/119943> 645600 7 webkit.review.bot 2012-06-10 12:19:42 -0700 All reviewed patches have been landed. Closing bug. 1502850 8 lforschler 2019-02-06 09:02:49 -0800 Mass moving XML DOM bugs to the "DOM" Component. 146745 2012-06-10 10:50:09 -0700 2012-06-10 12:19:37 -0700 Patch bug-88738-20120610105009.patch text/plain 1865 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTkzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTEwICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBTb21lIGFkZGl0aW9uYWwgdHdlYWtz IHRvIGtlZXAgVHJlZVNoYXJlZCBjb2RlIHNpbXBsZS9jbGVhbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg3MzgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL1RyZWVTaGFyZWQuaDogTWFr ZSBjb25zdHJ1Y3RvciBhbmQgZGVzdHJ1Y3RvciBib3RoIHByb3RlY3RlZC4KKyAgICAgICAgSXQn cyBzbGlnaHRseSBkYW5nZXJvdXMgdG8gaGF2ZSBhIHB1YmxpYyBub24tdmlydHVhbCBkZXN0cnVj dG9yLCBhbmQgdGhlcmUKKyAgICAgICAgaXMgbm8gcmVhc29uIGl0IG5lZWRzIHRvIGJlIHB1Ymxp Yy4KKyAgICAgICAgKFdlYkNvcmU6OlRyZWVTaGFyZWQ6On5UcmVlU2hhcmVkKTogTWFrZSBkZWJ1 Zy1vbmx5IGRlc3RydWN0b3Igbm9uLXZpcnR1YWw7CisgICAgICAgIHdlIHdlcmUgZ2V0dGluZyBu byB2YWx1ZSBmcm9tIGl0IGJlaW5nIHZpcnR1YWwuIE5vdyB0aGF0IGl0J3Mgbm9uLXZpcnR1YWws CisgICAgICAgIHRoZXJlIGlzIG5vIG5lZWQgdG8gdXNlIGFuICNpZiBvbiBpdCBzaW5jZSBpdCdz IGFuIGVtcHR5IGlubGluZSBkZXN0cnVjdG9yCisgICAgICAgIGluIG5vbi1kZWJ1ZyBidWlsZHMu CisKIDIwMTItMDYtMTAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJlbW92ZSB1bm5lZWRlZCBjYWxsUmVtb3ZlZExhc3RSZWYgZnVuY3Rpb24gZnJvbSBUcmVlU2hh cmVkIHJlZmFjdG9yaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UcmVlU2hhcmVk LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVHJlZVNoYXJlZC5oCShy ZXZpc2lvbiAxMTk5MzcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UcmVlU2hhcmVkLmgJ KHdvcmtpbmcgY29weSkKQEAgLTM0LDcgKzM0LDcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgTm9kZVR5 cGUsIHR5cGVuYW1lIFBhcgogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBOb2RlVHlwZSwgdHlwZW5hbWUg UGFyZW50Tm9kZVR5cGU+IGNsYXNzIFRyZWVTaGFyZWQgewogICAgIFdURl9NQUtFX05PTkNPUFlB QkxFKFRyZWVTaGFyZWQpOwotcHVibGljOgorcHJvdGVjdGVkOgogICAgIFRyZWVTaGFyZWQoKQog ICAgICAgICA6IG1fcGFyZW50KDApCiAgICAgICAgICwgbV9yZWZDb3VudCgxKQpAQCAtNDksMTYg KzQ5LDE1IEBAIHB1YmxpYzoKICNlbmRpZgogICAgIH0KIAotI2lmbmRlZiBOREVCVUcKLSAgICB2 aXJ0dWFsIH5UcmVlU2hhcmVkKCkKKyAgICB+VHJlZVNoYXJlZCgpCiAgICAgewogICAgICAgICBB U1NFUlQoaXNNYWluVGhyZWFkKCkpOwogICAgICAgICBBU1NFUlQoIW1fcmVmQ291bnQpOwogICAg ICAgICBBU1NFUlQobV9kZWxldGlvbkhhc0JlZ3VuKTsKICAgICAgICAgQVNTRVJUKCFtX2Fkb3B0 aW9uSXNSZXF1aXJlZCk7CiAgICAgfQotI2VuZGlmCiAKK3B1YmxpYzoKICAgICB2b2lkIHJlZigp CiAgICAgewogICAgICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwo=