88736 2012-06-10 09:06:00 -0700 http/tests/security/mixedContent/blob-url-in-iframe.html fails on Mac 2012-08-09 19:12:19 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED LayoutTestFailure, MakingBotsRed P2 Normal --- 1 mitz mkwst abarth ap darin kinuko mkwst rniwa webkit.review.bot oldest_to_newest 645541 0 mitz 2012-06-10 09:06:00 -0700 http/tests/security/mixedContent/blob-url-in-iframe.html and http/tests/security/mixedContent/filesystem-url-in-iframe.html have been failing on Lion ever since they were added in <http://trac.webkit.org/r119883>. See for example <http://build.webkit.org/results/Lion%20Release%20(Tests)/r119928%20(9214)/results.html> 645545 1 abarth 2012-06-10 09:09:22 -0700 Looks like these are failing because this port doesn't have these features enabled. 645551 2 mitz 2012-06-10 09:11:33 -0700 (In reply to comment #1) > Looks like these are failing because this port doesn't have these features enabled. Can http/tests/security/mixedContent/blob-url-in-iframe.html be rewritten to not use the legacy WebKitBlobBuilder class? 645557 3 abarth 2012-06-10 09:13:42 -0700 > Can http/tests/security/mixedContent/blob-url-in-iframe.html be rewritten to not use the legacy WebKitBlobBuilder class? I haven't been following the blob builder discussion, but I believe it just needs to create a blob so that it can test how blob URLs are treated. If there's a better way to create a blob, I suspect the test could use that. 645560 4 mitz 2012-06-10 09:15:20 -0700 Added filesystem-url-in-iframe.html to the Mac skip list in <http://trac.webkit.org/r119934>. 645564 5 mkwst 2012-06-10 09:20:42 -0700 Sure, I'm happy to change the test. I'll admit that I haven't been following the API's growth either: I'm guessing you'd prefer the `Blob()` constructor? http://trac.webkit.org/browser/trunk/LayoutTests/fast/files/script-tests/blob-constructor.js looks like a good example I can pull from.. If that's not what you'd like to see, point me in the right direction, and I'm happy to fix the test. 645566 6 mitz 2012-06-10 09:24:44 -0700 (In reply to comment #5) > Sure, I'm happy to change the test. I'll admit that I haven't been following the API's growth either: I'm guessing you'd prefer the `Blob()` constructor? http://trac.webkit.org/browser/trunk/LayoutTests/fast/files/script-tests/blob-constructor.js looks like a good example I can pull from.. Yes, that one appears to be the replacement for WebKitBlobBuilder, and is enabled in OS X WebKit. 645567 7 mkwst 2012-06-10 09:29:57 -0700 Easy, thanks. I'll upload a patch when I get home tonight. 645569 8 mitz 2012-06-10 09:33:59 -0700 (In reply to comment #7) > Easy, thanks. I'll upload a patch when I get home tonight. Thank you. I’ve temporarily added the test to platform/mac/Skipped in <http://trac.webkit.org/r119935>. Please include removing it from the skip list in your patch that makes it not depend on WebKitBlobBuilder. 645595 9 146746 mkwst 2012-06-10 11:53:46 -0700 Created attachment 146746 Patch 645596 10 146746 mkwst 2012-06-10 11:55:31 -0700 Comment on attachment 146746 Patch The attached patch should run correctly in the absence of WebKitBlobBuilder, and reenables the test for the mac platform. WDYT? 645598 11 146746 abarth 2012-06-10 12:14:34 -0700 Comment on attachment 146746 Patch Thanks Mike! 645607 12 146746 webkit.review.bot 2012-06-10 12:49:11 -0700 Comment on attachment 146746 Patch Clearing flags on attachment: 146746 Committed r119944: <http://trac.webkit.org/changeset/119944> 645608 13 webkit.review.bot 2012-06-10 12:49:16 -0700 All reviewed patches have been landed. Closing bug. 646511 14 mitz 2012-06-11 18:13:04 -0700 Re-added blob-url-in-iframe.html to the Mac skip list in <http://trac.webkit.org/r120025> since it continued to fail intermittently. 646705 15 mkwst 2012-06-12 00:46:43 -0700 Hi Kinuko! Would you mind taking a look at this? http/tests/security/mixedContent/blob-url-in-iframe.html is failing, but only on Lion WebKit. I don't see anything in the code that would have this sort of platform-specific behavior, but I'm hoping you might have some insight. :) 646957 16 kinuko 2012-06-12 08:23:14 -0700 (In reply to comment #15) > Hi Kinuko! Would you mind taking a look at this? > > http/tests/security/mixedContent/blob-url-in-iframe.html is failing, but only on Lion WebKit. I don't see anything in the code that would have this sort of platform-specific behavior, but I'm hoping you might have some insight. :) Hmm I can't think of any platform-specific issue here, but the test seems to fail on my local Lion WebKit. 646960 17 mkwst 2012-06-12 08:27:09 -0700 On my machine, it's simply not loading the blob URL into the iframe. The onload event isn't generated, but neither is an onerror event. It just doesn't do anything at all. I'll investigate a bit more tonight, but I'm hoping you can point me at some bits of the code that might be responsible. It seems like a real bug, not a bad test. 647756 18 kinuko 2012-06-13 00:15:09 -0700 (In reply to comment #17) > On my machine, it's simply not loading the blob URL into the iframe. The onload event isn't generated, but neither is an onerror event. It just doesn't do anything at all. > > I'll investigate a bit more tonight, but I'm hoping you can point me at some bits of the code that might be responsible. It seems like a real bug, not a bad test. Yeah it looks like a real bug. I also observed that it's not loading the blob URL into the iframe. The method that is modified when the test is added, isMixedContent, doesn't seem to be called for the blob either. For non-chromium port Blob code goes through BlobResourceHandle and BlobRegistryImpl in platform/network. The part may have some clue? 666716 19 kinuko 2012-07-11 06:45:43 -0700 I think I found what's happening. In short, mac's decidePolicyForNavigationAction() is returning PolicyIgnore for blob: URLs therefore the request is silently discarded. 666717 20 151696 kinuko 2012-07-11 06:46:59 -0700 Created attachment 151696 Patch 689929 21 151696 rniwa 2012-08-07 22:55:18 -0700 Comment on attachment 151696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151696&action=review This patch looks sane but maybe ap or mitz should review it? > Source/WebKit/mac/ChangeLog:8 > + WebView::_canHandleRequest should return true for "blob: URL so that it can be shown in iframe. Nit: dangling ". 690397 22 151696 ap 2012-08-08 09:25:43 -0700 Comment on attachment 151696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=151696&action=review > Source/WebKit/mac/WebView/WebView.mm:1765 > + return [scheme _webkit_isCaseInsensitiveEqualToString:@"applewebdata"] || [scheme _webkit_isCaseInsensitiveEqualToString:@"blob"]; Shouldn't the new case should be inside #if ENABLE(BLOB)? 691200 23 151696 kinuko 2012-08-08 22:21:32 -0700 Comment on attachment 151696 Patch Thanks for reviewing, View in context: https://bugs.webkit.org/attachment.cgi?id=151696&action=review >> Source/WebKit/mac/ChangeLog:8 >> + WebView::_canHandleRequest should return true for "blob: URL so that it can be shown in iframe. > > Nit: dangling ". Fixed. >> Source/WebKit/mac/WebView/WebView.mm:1765 >> + return [scheme _webkit_isCaseInsensitiveEqualToString:@"applewebdata"] || [scheme _webkit_isCaseInsensitiveEqualToString:@"blob"]; > > Shouldn't the new case should be inside #if ENABLE(BLOB)? Fixed. 691204 24 157387 kinuko 2012-08-08 22:22:20 -0700 Created attachment 157387 Patch 692105 25 157387 webkit.review.bot 2012-08-09 19:12:14 -0700 Comment on attachment 157387 Patch Clearing flags on attachment: 157387 Committed r125235: <http://trac.webkit.org/changeset/125235> 692106 26 webkit.review.bot 2012-08-09 19:12:19 -0700 All reviewed patches have been landed. Closing bug. 146746 2012-06-10 11:53:46 -0700 2012-07-11 06:46:44 -0700 Patch bug-88736-20120610205345.patch text/plain 3803 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTZmNzMxYTkyOTdjNzdlNDU4ZmE4 Y2M5MmQ4ODAzZWFjN2QwOTg4ZS4uYThmN2Q4NjZkMzJlYzI3MGQxZjM3ZjVlZDYxZThkNTY5YjQ1 NjlhMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTEwICBNaWtlIFdlc3QgIDxta3dz dEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZpbmcgbWl4ZWQgY29udGVudCB0ZXN0cycg ZGVwZW5kZW5jeSBvbiBXZWJLaXRCbG9iQnVpbGRlcjoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NzM2CisKKyAgICAgICAgaHR0cC90ZXN0cy9zZWN1 cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZyYW1lLmh0bWwgYW5kCisgICAgICAgIGh0 dHAvdGVzdHMvc2VjdXJpdHkvbWl4ZWRDb250ZW50L2ZpbGVzeXN0ZW0tdXJsLWluLWlmcmFtZS5o dG1sIGJvdGgKKyAgICAgICAgcmVsaWVkIG9uIFdlYktpdEJsb2JCdWlsZGVyLCB3aGljaCBpcyBk aXNhYmxlZCBvbiBzb21lIGJ1aWxkcy4gYG5ldworICAgICAgICBCbG9iKClgIGlzIHRoZSBuZXcg aG90bmVzcyB0aGF0IHRoZXNlIHRlc3RzIHNob3VsZCBiZSB1c2luZyBpbnN0ZWFkLiBUaGlzCisg ICAgICAgIHBhdGNoIG1pZ3JhdGVzIGJvdGggdGVzdHMgdG8gdGhlIG5ldyBBUEkuCisgICAgICAg IAorICAgICAgICBJdCBhbHNvIHJlZW5hYmxlcyBibG9iLXVybC1pbi1pZnJhbWUuaHRtbCBvbiBt YWMgKGZpbGVzeXN0ZW0tdXJsLWluLWlmcmFtZS5odG1sCisgICAgICAgIHJlbWFpbnMgZGlzYWJs ZWQsIGFzIHRoZSBmaWxlc3lzdGVtIEFQSXMgYXJlIGRpc2FibGVkIGVudGlyZWx5KS4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvdGVzdHMv c2VjdXJpdHkvbWl4ZWRDb250ZW50L2Jsb2ItdXJsLWluLWlmcmFtZS5odG1sOgorICAgICAgICAq IGh0dHAvdGVzdHMvc2VjdXJpdHkvbWl4ZWRDb250ZW50L2ZpbGVzeXN0ZW0tdXJsLWluLWlmcmFt ZS5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9Ta2lwcGVkOgorCiAyMDEyLTA2LTEwICBa YW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCBHVEsgZ2FyZGVuaW5nLiBVcGRhdGluZyBhIGZldyBhbmltYXRpb25zIHRlc3RzIGJhc2VsaW5l cywKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvbWl4ZWRDb250 ZW50L2Jsb2ItdXJsLWluLWlmcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1 cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZyYW1lLmh0bWwKaW5kZXggZmQ4NDU3ZWIw NzEzZGExYTQyMzc4MTlmODMzOTUwMzMwN2Y0NTVjNC4uNDYxYmUxMGQ1ZjZmOTg5OWVhM2JkNjg2 MWE2NmZiMTFjYTZiODBiMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1 cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZyYW1lLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZyYW1lLmh0 bWwKQEAgLTE4LDE0ICsxOCwxMyBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7 CiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwogfQogdmFyIGlmcmFt ZSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ2lmcmFtZScpOwotdmFyIGJiID0gbmV3IFdlYktp dEJsb2JCdWlsZGVyKCk7Ci1iYi5hcHBlbmQoJzxoMT5QQVNTICgxLzEpPC9oMT4nKTsKLWJiLmdl dEJsb2IoJ3RleHQvaHRtbCcpOwogaWZyYW1lLm9ubG9hZCA9IGZ1bmN0aW9uICgpIHsKICAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7CiB9OwotaWZyYW1lLnNyYyA9IHdlYmtpdFVSTC5jcmVhdGVPYmpl Y3RVUkwoYmIuZ2V0QmxvYigndGV4dC9odG1sJykpOworCit2YXIgYiA9IG5ldyBCbG9iKFsnPGgx PlBBU1MgKDEvMSk8L2gxPiddLCB7IHR5cGU6ICd0ZXh0L2h0bWwnIH0pOworaWZyYW1lLnNyYyA9 IHdlYmtpdFVSTC5jcmVhdGVPYmplY3RVUkwoYik7CiA8L3NjcmlwdD4KIDwvYm9keT4KIDwvaHRt bD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvbWl4ZWRDb250 ZW50L2ZpbGVzeXN0ZW0tdXJsLWluLWlmcmFtZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9taXhlZENvbnRlbnQvZmlsZXN5c3RlbS11cmwtaW4taWZyYW1lLmh0bWwKaW5k ZXggMzMxZTY5ZGRiYWY4NTkyMDMyMTg2YTU5NzRmM2QyNWMzNDNlMWJjZC4uZTFjMDE1YjZiZGYw MmRkYjNlZWMxOGU1MDdlNjkwMzMzMDRkYTI2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvZmlsZXN5c3RlbS11cmwtaW4taWZyYW1lLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvZmls ZXN5c3RlbS11cmwtaW4taWZyYW1lLmh0bWwKQEAgLTM0LDkgKzM0LDggQEAgd2luZG93LndlYmtp dFJlcXVlc3RGaWxlU3lzdGVtKFRFTVBPUkFSWSwgMTAyNCoxMDI0IC8qMU1CKi8sIGZ1bmN0aW9u KGZzKSB7CiAgICAgICAgICAgICB9OwogCiAgICAgICAgICAgICAvLyBDcmVhdGUgYSBuZXcgQmxv YiBhbmQgd3JpdGUgaXQgdG8gbG9nLnR4dC4KLSAgICAgICAgICAgIHZhciBiYiA9IG5ldyBXZWJL aXRCbG9iQnVpbGRlcigpOwotICAgICAgICAgICAgYmIuYXBwZW5kKCdQQVNTICgyLzIpOiBGaWxl IGRpc3BsYXllZCcpOwotICAgICAgICAgICAgZmlsZVdyaXRlci53cml0ZShiYi5nZXRCbG9iKCd0 ZXh0L2h0bWwnKSk7CisgICAgICAgICAgICB2YXIgYiA9IG5ldyBCbG9iKFsnUEFTUyAoMi8yKTog RmlsZSBkaXNwbGF5ZWQnXSwgeyB0eXBlOiAndGV4dC9odG1sJyB9KTsKKyAgICAgICAgICAgIGZp bGVXcml0ZXIud3JpdGUoYik7CiAgICAgICAgIH0pOwogICAgIH0pOwogfSk7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9Ta2lwcGVkCmluZGV4IGZlNDhlYWJkMzZlMTYwYjQyMDYzNTYwZTU0ZTA0YjFlMzA3NGVh NTQuLmQ1YjE3NjU1YjMzZWM1NjkyYmUwN2FhMmZiNjQ2ZDkyNmM1MTdlNzQgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9Ta2lwcGVkCkBAIC03OTEsOCArNzkxLDYgQEAgZmFzdC9wcm9maWxlci9kZWFkLXRp bWUuaHRtbAogCiAjIFRoZSBNYWMgcG9ydCBkb2VzIG5vdCBzdXBwb3J0IHRoZSBsZWdhY3kgV2Vi S2l0QmxvYkJ1aWxkZXIgY2xhc3MuCiBmYXN0L2ZpbGVzL2Jsb2ItYnVpbGRlci1jcmFzaC5odG1s Ci0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODczNgotaHR0cC90 ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZyYW1lLmh0bWwKIAogIyBb TWFjXSBpbnNwZWN0b3IvZGVidWdnZXIvbGlua2lmaWVyLmh0bWwgaXMgZmxha2V5CiAjIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTMxOQo= 151696 2012-07-11 06:46:59 -0700 2012-08-08 22:22:14 -0700 Patch bug-88736-20120711224657.patch text/plain 2853 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggYzg5Y2JjZjFm YTVmMDFiNWJiMWMxZDkyZTc1NjRkNTliZGRiNTQyOS4uYzRhZWJiMzljOGE2Zjg0ZGVmOWVjYjBk M2VlZjQ5ZGE2NWM5ODM2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTA3LTExICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBo dHRwL3Rlc3RzL3NlY3VyaXR5L21peGVkQ29udGVudC9ibG9iLXVybC1pbi1pZnJhbWUuaHRtbCBm YWlscyBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4NzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViVmlldzo6X2NhbkhhbmRsZVJlcXVlc3Qgc2hvdWxkIHJldHVybiB0cnVlIGZvciAiYmxv YjogVVJMIHNvIHRoYXQgaXQgY2FuIGJlIHNob3duIGluIGlmcmFtZS4KKworICAgICAgICAqIFdl YlZpZXcvV2ViVmlldy5tbToKKyAgICAgICAgKCtbV2ViVmlldyBfY2FuSGFuZGxlUmVxdWVzdDpm b3JNYWluRnJhbWU6XSk6CisKIDIwMTItMDctMTAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBXZWJDb3JlOjpTZXR0aW5ncyBmb3IgSGl4aWU3NiBXZWJTb2NrZXQg cHJvdG9jb2wgZG9lc24ndCBkbyBhbnl0aGluZyBhbmQgc2hvdWxkIGJlIHJlbW92ZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQppbmRleCBjMzViODczZjQwZTljZmE5M2Q5YjY0YzRm YmFkN2JlMGQyNDIxNzlkLi4yYWJlOTllNTYxOWY2NDUyYWQwYmVjOGNjYzMzM2Y0YTFmOWY3MzZh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KKysrIGIv U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCkBAIC0xNzYyLDcgKzE3NjIsNyBA QCBzdGF0aWMgaW5saW5lIElNUCBnZXRNZXRob2QoaWQgbywgU0VMIHMpCiAgICAgaWYgKGZvck1h aW5GcmFtZSAmJiBbc2VsZiBfcmVwcmVzZW50YXRpb25FeGlzdHNGb3JVUkxTY2hlbWU6c2NoZW1l XSkKICAgICAgICAgcmV0dXJuIFlFUzsKICAgICAgICAgCi0gICAgcmV0dXJuIFtzY2hlbWUgX3dl YmtpdF9pc0Nhc2VJbnNlbnNpdGl2ZUVxdWFsVG9TdHJpbmc6QCJhcHBsZXdlYmRhdGEiXTsKKyAg ICByZXR1cm4gW3NjaGVtZSBfd2Via2l0X2lzQ2FzZUluc2Vuc2l0aXZlRXF1YWxUb1N0cmluZzpA ImFwcGxld2ViZGF0YSJdIHx8IFtzY2hlbWUgX3dlYmtpdF9pc0Nhc2VJbnNlbnNpdGl2ZUVxdWFs VG9TdHJpbmc6QCJibG9iIl07CiB9CiAKICsgKEJPT0wpX2NhbkhhbmRsZVJlcXVlc3Q6KE5TVVJM UmVxdWVzdCAqKXJlcXVlc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3ZTNiZjM2NzFjYmI0ZjQ4NjE3MjBlOTYyMTUyN2Fh NDcyZWRhMzNkLi41OWYyYzM4OTkwZTFmZjhkZGVjMWNjYjMxMTUxNGMxZjBiMjY4ODI0IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDctMTEgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hy b21pdW0ub3JnPgorCisgICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkvbWl4ZWRDb250ZW50L2Js b2ItdXJsLWluLWlmcmFtZS5odG1sIGZhaWxzIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg3MzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgc2VjdXJpdHkvbWl4ZWRDb250ZW50L2Js b2ItdXJsLWluLWlmcmFtZS5odG1sIGFzIGl0IHNob3VsZCBwYXNzIHdpdGggdGhpcyBwYXRjaC4K KworICAgICAgICAqIHBsYXRmb3JtL21hYy9Ta2lwcGVkOgorCiAyMDEyLTA3LTExICBDc2FiYSBP c3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBVbnJldmlld2Vk IGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVk IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKaW5kZXggY2U5MmRkYzE5YTU2NTVi ZWM5OThjYjdhNzhlNTk0MmJmYmQ4YmU5Zi4uNWVjMTBkN2JkMTQyMDhlZTBiMTg3MGQ3MTUyZjM5 OGRkZGEzODBjYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKQEAgLTg5Miw5ICs4OTIsNiBA QCBzdmcvZmlsdGVycy9jb2xvci1zcGFjZS1jb252ZXJzaW9uLnN2Zwogc3ZnL2ZpbHRlcnMvY29u dGFpbmVyLXdpdGgtZmlsdGVycy5zdmcKIHN2Zy9maWx0ZXJzL2ZlU3BlY3VsYXJMaWdodC1wcmVt dWx0aXBsaWVkLnN2ZwogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODczNgotaHR0cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZy YW1lLmh0bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk2 ODAKIGZhc3QvY2FudmFzL2NhbnZhcy1pbWFnZVNtb290aGluZ0VuYWJsZWQtcmVwYWludC5odG1s CiAK 157387 2012-08-08 22:22:20 -0700 2012-08-09 19:12:14 -0700 Patch bug-88736-20120809142153.patch text/plain 3039 kinuko U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggMTNiOTdjYjhj N2RlMjU4MDY1YmM1MWFmNzFiZGJlYWE1ZjIwZDFjNS4uNGY4N2EyMDE1NDE0ZjdlNWI2ZTk2NDg2 NmE1MWNjMzAxN2VjZDg5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTA4LTA5ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KKworICAgICAgICBo dHRwL3Rlc3RzL3NlY3VyaXR5L21peGVkQ29udGVudC9ibG9iLXVybC1pbi1pZnJhbWUuaHRtbCBm YWlscyBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg4NzM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViVmlldzo6X2NhbkhhbmRsZVJlcXVlc3Qgc2hvdWxkIHJldHVybiB0cnVlIGZvciAiYmxv YjoiIFVSTCBzbyB0aGF0IGl0IGNhbiBiZSBzaG93biBpbiBpZnJhbWUuCisKKyAgICAgICAgKiBX ZWJWaWV3L1dlYlZpZXcubW06CisgICAgICAgICgrW1dlYlZpZXcgX2NhbkhhbmRsZVJlcXVlc3Q6 Zm9yTWFpbkZyYW1lOl0pOgorCiAyMDEyLTA4LTA1ICBQZXRlciBXYW5nICA8cGV0ZXIud2FuZ0B0 b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW0pTQ10gaW1wbGVt ZW50IHNldHRpbmcgYnJlYWtwb2ludHMgYnkgbGluZTpjb2x1bW4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViVmlldy5tbQppbmRleCBhNjJmMjdlY2I4ZTEwMGZjYTcxZTY2NTcyOTg0ODNmMTQ3MTBm NzU1Li4zMzkxYWI5NjcxYTliYjVjYTFiZmEzMWEwMDU0ZjE2YjA2ZGM4ZDI0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktp dC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCkBAIC0xNzYwLDggKzE3NjAsMTYgQEAgc3RhdGljIGlu bGluZSBJTVAgZ2V0TWV0aG9kKGlkIG8sIFNFTCBzKQogICAgIC8vIFJlcHJlc2VudGF0aW9ucyBm b3IgVVJMIHNjaGVtZXMgd29yayBhdCB0aGUgdG9wIGxldmVsLgogICAgIGlmIChmb3JNYWluRnJh bWUgJiYgW3NlbGYgX3JlcHJlc2VudGF0aW9uRXhpc3RzRm9yVVJMU2NoZW1lOnNjaGVtZV0pCiAg ICAgICAgIHJldHVybiBZRVM7Ci0gICAgICAgIAotICAgIHJldHVybiBbc2NoZW1lIF93ZWJraXRf aXNDYXNlSW5zZW5zaXRpdmVFcXVhbFRvU3RyaW5nOkAiYXBwbGV3ZWJkYXRhIl07CisKKyAgICBp ZiAoW3NjaGVtZSBfd2Via2l0X2lzQ2FzZUluc2Vuc2l0aXZlRXF1YWxUb1N0cmluZzpAImFwcGxl d2ViZGF0YSJdKQorICAgICAgICByZXR1cm4gWUVTOworCisjaWYgRU5BQkxFKEJMT0IpCisgICAg aWYgKFtzY2hlbWUgX3dlYmtpdF9pc0Nhc2VJbnNlbnNpdGl2ZUVxdWFsVG9TdHJpbmc6QCJibG9i Il0pCisgICAgICAgIHJldHVybiBZRVM7CisjZW5kaWYKKworICAgIHJldHVybiBOTzsKIH0KIAog KyAoQk9PTClfY2FuSGFuZGxlUmVxdWVzdDooTlNVUkxSZXF1ZXN0ICopcmVxdWVzdApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGI2NDAwYmQ2MTE5MmQxMTlmODEwMTRhZjY1NmU0NTZjYzVlMzI2YjguLjE3Yjc3ODY1MmNiNzAy YjQ2NDdhZGQ5OTQxYThhZDdiNWI3Mjk1ZWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0w OC0wOSAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaHR0 cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZyYW1lLmh0bWwgZmFp bHMgb24gTWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04ODczNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSBzZWN1cml0eS9taXhlZENvbnRlbnQvYmxvYi11cmwtaW4taWZyYW1lLmh0bWwgYXMg aXQgc2hvdWxkIHBhc3Mgd2l0aCB0aGlzIHBhdGNoLgorCisgICAgICAgICogcGxhdGZvcm0vbWFj L1NraXBwZWQ6CisKIDIwMTItMDgtMDggIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRv YmUuY29tPgogCiAgICAgICAgIFtDU1MgU2hhZGVyc10gSW52YWxpZCBzaGFkZXJzIHNob3VsZCBh Y3QgYXMgcGFzcy10aHJvdWdoIGZpbHRlcnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKaW5kZXgg YWQ2ZGY0YTY3MWE2NzM3ZTIwNmUyNDM2YTBmZGRmOGU2Y2Y3YjZkNi4uMGU5MDI5ODgxZDY0MWYx YmU2MTVjNzBlZGMyOGZkYTUwYzMxM2M2MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKQEAg LTkwNSw5ICs5MDUsNiBAQCBzdmcvZmlsdGVycy9jb2xvci1zcGFjZS1jb252ZXJzaW9uLnN2Zwog c3ZnL2ZpbHRlcnMvY29udGFpbmVyLXdpdGgtZmlsdGVycy5zdmcKIHN2Zy9maWx0ZXJzL2ZlU3Bl Y3VsYXJMaWdodC1wcmVtdWx0aXBsaWVkLnN2ZwogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODczNgotaHR0cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQv YmxvYi11cmwtaW4taWZyYW1lLmh0bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODk2ODAKIGZhc3QvY2FudmFzL2NhbnZhcy1pbWFnZVNtb290aGluZ0VuYWJs ZWQtcmVwYWludC5odG1sCiAK