88732 2012-06-10 07:04:04 -0700 [BlackBerry] Seek calls are being unnecessarily delayed 2012-11-02 12:45:26 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other CLOSED FIXED P2 Normal --- 1 mfeil mfeil eric.carlson feature-media-reviews tonikitoo webkit.review.bot oldest_to_newest 645498 0 mfeil 2012-06-10 07:04:04 -0700 There is a problem with the way the m_userDrivenSeekTimer is implemented. When MediaPlayerPrivate::seek() is called, there is always a 100ms delay even if the timer is not running. The timer is supposed to space out (i.e. throttle) repeated seeks that come in too soon after a previous seek, but currently it is slowing down even single seeks and seeks that come in with adequate delay after a previous seek. I fixed this in my patch by improving the way the timer fired function is called. I would like to propose not including a layout test with this fix. Doing timing tests for 100ms delays is tricky from Javascript, and I don't think the benefit of such a test outweighs the extra time it would take to develop one. The test would also be a problem to maintain as it may give different results over different runs and across different target hardware. 646276 1 146913 mfeil 2012-06-11 14:33:57 -0700 Created attachment 146913 Patch 646438 2 146913 webkit.review.bot 2012-06-11 17:02:24 -0700 Comment on attachment 146913 Patch Clearing flags on attachment: 146913 Committed r120020: <http://trac.webkit.org/changeset/120020> 646439 3 webkit.review.bot 2012-06-11 17:02:29 -0700 All reviewed patches have been landed. Closing bug. 757484 4 mfeil 2012-11-02 12:45:26 -0700 Closing bug for patch that landed a long time ago. 146913 2012-06-11 14:33:57 -0700 2012-06-11 17:02:24 -0700 Patch bug-88732-20120611173356.patch text/plain 4832 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU4Mzc1NTk2M2RhMjkw MTU5NDU2OWY4ZjBiZGUyNjAxYjgwYTJhZC4uOTE4OTJkY2ZlMmJkY2EzNDE5YTJhMTgyODkxZjIz ODVlNTA5MTBlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQzIEBACisyMDEyLTA2LTExICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFNlZWsgY2FsbHMg YXJlIGJlaW5nIHVubmVjZXNzYXJpbHkgZGVsYXllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg3MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBhIHByb2JsZW0gd2l0aCB0aGUgd2F5IHRo ZSBtX3VzZXJEcml2ZW5TZWVrVGltZXIgaXMKKyAgICAgICAgaW1wbGVtZW50ZWQuIFdoZW4gTWVk aWFQbGF5ZXJQcml2YXRlOjpzZWVrKCkgaXMgY2FsbGVkLCB0aGVyZQorICAgICAgICBpcyBhbHdh eXMgYSAxMDBtcyBkZWxheSBldmVuIGlmIHRoZSB0aW1lciBpcyBub3QgcnVubmluZy4gVGhlCisg ICAgICAgIHRpbWVyIGlzIHN1cHBvc2VkIHRvIHNwYWNlIG91dCAoaS5lLiB0aHJvdHRsZSkgcmVw ZWF0ZWQgc2Vla3MKKyAgICAgICAgdGhhdCBjb21lIGluIHRvbyBzb29uIGFmdGVyIGEgcHJldmlv dXMgc2VlaywgYnV0IGN1cnJlbnRseSBpdAorICAgICAgICBpcyBzbG93aW5nIGRvd24gZXZlbiBz aW5nbGUgc2Vla3MgYW5kIHNlZWtzIHRoYXQgY29tZSBpbiB3aXRoCisgICAgICAgIGFkZXF1YXRl IGRlbGF5IGFmdGVyIGEgcHJldmlvdXMgc2Vlay4gSSBmaXhlZCB0aGlzIGluIG15IHBhdGNoCisg ICAgICAgIGJ5IGltcHJvdmluZyB0aGUgd2F5IHRoZSB0aW1lciBmaXJlZCBmdW5jdGlvbiBpcyBj YWxsZWQuCisgICAgICAgIAorICAgICAgICBBIG5vdGUgb24gdGhlIG5ldyBtX2xhc3RTZWVrVGlt ZVBlbmRpbmcgZmxhZzogVGhpcyBmbGFnIGlzCisgICAgICAgIG5lZWRlZCBzbyB0aGF0IHVzZXJE cml2ZW5TZWVrVGltZXJGaXJlZCgpIGtub3dzIHdoZXRoZXIgb3Igbm90CisgICAgICAgIHRvIHBl cmZvcm0gdGhlIHNlZWsuIFRoZSBvbmx5IGNhc2Ugd2hlcmUgdGhpcyBmbGFnIHdpbGwgbm90IGJl CisgICAgICAgIHNldCBpcyBpZiBubyBNZWRpYVBsYXllclByaXZhdGU6OnNlZWsoKSBjYWxsIGNh bWUgaW4gd2hpbGUgdGhlCisgICAgICAgIHRpbWVyIHdhcyBhY3RpdmUsIGluIHdoaWNoIGNhc2Ug aXQncyBpbXBvcnRhbnQgdG8gZG8gbm90aGluZy4KKyAgICAgICAgSSBjb3VsZCBlbmNvZGUgdGhp cyBmbGFnJ3MgaW5mb3JtYXRpb24gaW50byB0aGUgbV9sYXN0U2Vla1RpbWUKKyAgICAgICAgZmxv YXQsIGZvciBleGFtcGxlIGJ5IGluaXRpYWxpemluZyBpdCBhbmQgcmVzZXR0aW5nIGl0IHRvIE5B TgorICAgICAgICBhbmQgdXNpbmcgaXNuYW4oKS4gQnV0IEkgZmVlbCB0aGF0IHVzaW5nIGEgc2Vw YXJhdGUgYm9vbCBpcyBhCisgICAgICAgIG1vcmUgcG9ydGFibGUgYXBwcm9hY2guCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLiBJIHdvdWxkIGxpa2UgdG8gcHJvcG9zZSBub3QgaW5jbHVkaW5nIGEg bGF5b3V0IHRlc3QKKyAgICAgICAgd2l0aCB0aGlzIGZpeC4gRG9pbmcgdGltaW5nIHRlc3RzIGZv ciAxMDBtcyBkZWxheXMgaXMgdHJpY2t5CisgICAgICAgIGZyb20gSmF2YXNjcmlwdCwgYW5kIEkg ZG9uJ3QgdGhpbmsgdGhlIGJlbmVmaXQgb2Ygc3VjaCBhIHRlc3QKKyAgICAgICAgb3V0d2VpZ2hz IHRoZSBleHRyYSB0aW1lIGl0IHdvdWxkIHRha2UgdG8gZGV2ZWxvcCBvbmUuIFRoZSB0ZXN0Cisg ICAgICAgIHdvdWxkIGFsc28gYmUgYSBwcm9ibGVtIHRvIG1haW50YWluIGFzIGl0IG1heSBnaXZl IGRpZmZlcmVudAorICAgICAgICByZXN1bHRzIG92ZXIgZGlmZmVyZW50IHJ1bnMgYW5kIGFjcm9z cyBkaWZmZXJlbnQgdGFyZ2V0IGhhcmR3YXJlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6TWVkaWFQbGF5ZXJQcml2YXRlKToKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6c2Vlayk6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGU6OnVzZXJEcml2ZW5TZWVrVGltZXJGaXJlZCk6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0Jl cnJ5Lmg6CisgICAgICAgIChNZWRpYVBsYXllclByaXZhdGUpOgorCiAyMDEyLTA2LTExICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU1ZHSW1hZ2VD YWNoZSBsZWFrcyBpbWFnZSBkYXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclBy aXZhdGVCbGFja0JlcnJ5LmNwcAppbmRleCAzYWM5M2U4YjRjNjdlZDJmMTRmZTM2NmFmNjUxMjYy ODQwYTExMDk3Li4yMjZmMzU4ZDAwMDRiOGFiOGY0NWRmM2E2MmFlNGM5YWY5OTAwYmJjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlh UGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKQEAg LTExMCw2ICsxMTAsNyBAQCBNZWRpYVBsYXllclByaXZhdGU6Ok1lZGlhUGxheWVyUHJpdmF0ZShN ZWRpYVBsYXllciogcGxheWVyKQogI2VuZGlmCiAgICAgLCBtX3VzZXJEcml2ZW5TZWVrVGltZXIo dGhpcywgJk1lZGlhUGxheWVyUHJpdmF0ZTo6dXNlckRyaXZlblNlZWtUaW1lckZpcmVkKQogICAg ICwgbV9sYXN0U2Vla1RpbWUoMCkKKyAgICAsIG1fbGFzdFNlZWtUaW1lUGVuZGluZyhmYWxzZSkK ICAgICAsIG1fd2FpdE1ldGFkYXRhVGltZXIodGhpcywgJk1lZGlhUGxheWVyUHJpdmF0ZTo6d2Fp dE1ldGFkYXRhVGltZXJGaXJlZCkKICAgICAsIG1fd2FpdE1ldGFkYXRhUG9wRGlhbG9nQ291bnRl cigwKQogewpAQCAtMjM2LDEzICsyMzcsMTggQEAgc3RhdGljIGNvbnN0IGRvdWJsZSBTZWVrU3Vi bWlzc2lvbkRlbGF5ID0gMC4xOyAvLyBSZWFzb25hYmxlIHRocm90dGxpbmcgdmFsdWUuCiB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZTo6c2VlayhmbG9hdCB0aW1lKQogewogICAgIG1fbGFzdFNlZWtU aW1lID0gdGltZTsKKyAgICBtX2xhc3RTZWVrVGltZVBlbmRpbmcgPSB0cnVlOwogICAgIGlmICgh bV91c2VyRHJpdmVuU2Vla1RpbWVyLmlzQWN0aXZlKCkpCi0gICAgICAgIG1fdXNlckRyaXZlblNl ZWtUaW1lci5zdGFydE9uZVNob3QoU2Vla1N1Ym1pc3Npb25EZWxheSk7CisgICAgICAgIHVzZXJE cml2ZW5TZWVrVGltZXJGaXJlZCgwKTsKIH0KIAogdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OnVz ZXJEcml2ZW5TZWVrVGltZXJGaXJlZChUaW1lcjxNZWRpYVBsYXllclByaXZhdGU+KikKIHsKLSAg ICBtX3BsYXRmb3JtUGxheWVyLT5zZWVrKG1fbGFzdFNlZWtUaW1lKTsKKyAgICBpZiAobV9sYXN0 U2Vla1RpbWVQZW5kaW5nKSB7CisgICAgICAgIG1fcGxhdGZvcm1QbGF5ZXItPnNlZWsobV9sYXN0 U2Vla1RpbWUpOworICAgICAgICBtX2xhc3RTZWVrVGltZVBlbmRpbmcgPSBmYWxzZTsKKyAgICAg ICAgbV91c2VyRHJpdmVuU2Vla1RpbWVyLnN0YXJ0T25lU2hvdChTZWVrU3VibWlzc2lvbkRlbGF5 KTsKKyAgICB9CiB9CiAKIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlOjpzZWVraW5nKCkgY29uc3QK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkv TWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmgKaW5kZXgg MGFjNDY2YmVjOGVlODg4MTFhMWIxNjQwYjczNTJhOTA5Yzg1MzY1ZS4uMTliNjU0Y2ZmN2U1ODcx Y2VkNGYzMGI4ODNmZTFlMzIyODlkZjU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBs YXllclByaXZhdGVCbGFja0JlcnJ5LmgKQEAgLTE2Niw2ICsxNjYsNyBAQCBwcml2YXRlOgogICAg IHZvaWQgdXNlckRyaXZlblNlZWtUaW1lckZpcmVkKFRpbWVyPE1lZGlhUGxheWVyUHJpdmF0ZT4q KTsKICAgICBUaW1lcjxNZWRpYVBsYXllclByaXZhdGU+IG1fdXNlckRyaXZlblNlZWtUaW1lcjsK ICAgICBmbG9hdCBtX2xhc3RTZWVrVGltZTsKKyAgICBib29sIG1fbGFzdFNlZWtUaW1lUGVuZGlu ZzsKICAgICB2b2lkIHdhaXRNZXRhZGF0YVRpbWVyRmlyZWQoVGltZXI8TWVkaWFQbGF5ZXJQcml2 YXRlPiopOwogICAgIFRpbWVyPE1lZGlhUGxheWVyUHJpdmF0ZT4gbV93YWl0TWV0YWRhdGFUaW1l cjsKICAgICBpbnQgbV93YWl0TWV0YWRhdGFQb3BEaWFsb2dDb3VudGVyOwo=