88721 2012-06-09 18:23:46 -0700 Compile error: 'bool std::isinf(float)' is not 'constexpr' with GCC 4.6 in C++11 mode 2012-06-21 06:26:59 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P1 Normal --- 1 bos kbalazs allan.jensen ap kbalazs ossy webkit.review.bot oldest_to_newest 645439 0 bos 2012-06-09 18:23:46 -0700 Compile error: == [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isinf(float)': [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:292:63: error: 'bool std::isinf(float)' is not 'constexpr' [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isinf(double)': [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:293:64: error: 'bool std::isinf(double)' is not 'constexpr' [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isnan(float)': [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:294:63: error: 'bool std::isnan(float)' is not 'constexpr' [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h: In function 'bool std::wtf_isnan(double)': [...]/WebKit-r119255/Source/WTF/wtf/MathExtras.h:295:64: error: 'bool std::isnan(double)' is not 'constexpr' == Concerns the following code: == #if COMPILER_QUIRK(GCC11_GLOBAL_ISINF_ISNAN) // A workaround to avoid conflicting declarations of isinf and isnan when compiling with GCC in C++11 mode. namespace std { constexpr bool wtf_isinf(float f) { return std::isinf(f); } constexpr bool wtf_isinf(double d) { return std::isinf(d); } constexpr bool wtf_isnan(float f) { return std::isnan(f); } constexpr bool wtf_isnan(double d) { return std::isnan(d); } }; using std::wtf_isinf; using std::wtf_isnan; #define isinf(x) wtf_isinf(x) #define isnan(x) wtf_isnan(x) #endif == Seems that with the gcc 4.6.3 the function std::isinf() is not marked constexpr, so wtf_isinf() may not be that either. After replacing "constexpr" with "inline" it does compile. 646708 1 allan.jensen 2012-06-12 00:55:09 -0700 (In reply to comment #0) > Seems that with the gcc 4.6.3 the function std::isinf() is not marked constexpr, so wtf_isinf() may not be that either. > After replacing "constexpr" with "inline" it does compile. Ah, interesting. It should be harmless to replace constexpr with inline for gcc 4.7 as well. 646709 2 allan.jensen 2012-06-12 00:58:44 -0700 (In reply to comment #1) > (In reply to comment #0) > > Seems that with the gcc 4.6.3 the function std::isinf() is not marked constexpr, so wtf_isinf() may not be that either. > > After replacing "constexpr" with "inline" it does compile. > > Ah, interesting. It should be harmless to replace constexpr with inline for gcc 4.7 as well. I wouldn't call it regression though. C++11 mode was not work 652586 3 ap 2012-06-19 10:45:03 -0700 *** Bug 89463 has been marked as a duplicate of this bug. *** 653322 4 148531 kbalazs 2012-06-20 03:28:00 -0700 Created attachment 148531 Patch 653325 5 webkit.review.bot 2012-06-20 03:31:20 -0700 Attachment 148531 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ma..." exit_code: 1 Source/WTF/wtf/MathExtras.h:285: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WTF/wtf/MathExtras.h:285: wtf_isinf is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/MathExtras.h:286: wtf_isinf is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/MathExtras.h:287: wtf_isnan is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/MathExtras.h:288: wtf_isnan is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 653331 6 148531 allan.jensen 2012-06-20 03:41:59 -0700 Comment on attachment 148531 Patch LGTM 654428 7 148531 ossy 2012-06-21 06:06:14 -0700 Comment on attachment 148531 Patch LGTM, r=me. 654438 8 148531 kbalazs 2012-06-21 06:26:53 -0700 Comment on attachment 148531 Patch Clearing flags on attachment: 148531 Committed r120922: <http://trac.webkit.org/changeset/120922> 654439 9 kbalazs 2012-06-21 06:26:59 -0700 All reviewed patches have been landed. Closing bug. 148531 2012-06-20 03:28:00 -0700 2012-06-21 06:26:52 -0700 Patch bug-88721-20120620122756.patch text/plain 1776 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE3NTYzM2E2NmIxOWYxMzQwOGZjOTE2 YjU5NDBiMTFjYTkwNDY1NTAuLmY5NDYxMjBiNjNkOGVjNjljYzYwMmZkMzA2ZDU0YTM0NDg5NTJl MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMjAgIEJhbGF6cyBLZWxlbWVuICA8a2Jh bGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIENvbXBpbGUgZXJyb3I6ICdib29sIHN0ZDo6aXNp bmYoZmxvYXQpJyBpcyBub3QgJ2NvbnN0ZXhwcicgd2l0aCBHQ0MgNC42IGluIEMrKzExIG1vZGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NzIxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgZGVm aW5lIHRoZXNlIGFzIGNvbnNleHByIGJlY2F1c2Ugd2l0aCBnY2MgNC42CisgICAgICAgIHRoZXkg Y2FsbCBub24gY29uc3RleHByIGZ1bmN0aW9ucy4KKyAgICAgICAgKiB3dGYvTWF0aEV4dHJhcy5o OgorICAgICAgICAoc3RkOjp3dGZfaXNpbmYpOgorICAgICAgICAoc3RkOjp3dGZfaXNuYW4pOgor CiAyMDEyLTA2LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg SXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGxvb2sgYXQgZGlzYXNzZW1ibHkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaCBiL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMu aAppbmRleCAzY2M5NDc0NDc2ZDdkNDBjYjA3YmM2ZTllYjRmN2FhMTc3YjI0M2NmLi5lNDRhYjZj NmI4ZDg5YTY1YjA3OWMyNmIzYjEwMWY4ZTFkODEyNWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9NYXRoRXh0cmFzLmgKKysrIGIvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCkBAIC0y ODIsMTAgKzI4MiwxMCBAQCB1c2luZyBzdGQ6OnNpZ25iaXQ7CiAjaWYgQ09NUElMRVJfUVVJUkso R0NDMTFfR0xPQkFMX0lTSU5GX0lTTkFOKQogLy8gQSB3b3JrYXJvdW5kIHRvIGF2b2lkIGNvbmZs aWN0aW5nIGRlY2xhcmF0aW9ucyBvZiBpc2luZiBhbmQgaXNuYW4gd2hlbiBjb21waWxpbmcgd2l0 aCBHQ0MgaW4gQysrMTEgbW9kZS4KIG5hbWVzcGFjZSBzdGQgewotICAgIGNvbnN0ZXhwciBib29s IHd0Zl9pc2luZihmbG9hdCBmKSB7IHJldHVybiBzdGQ6OmlzaW5mKGYpOyB9Ci0gICAgY29uc3Rl eHByIGJvb2wgd3RmX2lzaW5mKGRvdWJsZSBkKSB7IHJldHVybiBzdGQ6OmlzaW5mKGQpOyB9Ci0g ICAgY29uc3RleHByIGJvb2wgd3RmX2lzbmFuKGZsb2F0IGYpIHsgcmV0dXJuIHN0ZDo6aXNuYW4o Zik7IH0KLSAgICBjb25zdGV4cHIgYm9vbCB3dGZfaXNuYW4oZG91YmxlIGQpIHsgcmV0dXJuIHN0 ZDo6aXNuYW4oZCk7IH0KKyAgICBpbmxpbmUgYm9vbCB3dGZfaXNpbmYoZmxvYXQgZikgeyByZXR1 cm4gc3RkOjppc2luZihmKTsgfQorICAgIGlubGluZSBib29sIHd0Zl9pc2luZihkb3VibGUgZCkg eyByZXR1cm4gc3RkOjppc2luZihkKTsgfQorICAgIGlubGluZSBib29sIHd0Zl9pc25hbihmbG9h dCBmKSB7IHJldHVybiBzdGQ6OmlzbmFuKGYpOyB9CisgICAgaW5saW5lIGJvb2wgd3RmX2lzbmFu KGRvdWJsZSBkKSB7IHJldHVybiBzdGQ6OmlzbmFuKGQpOyB9CiB9OwogCiB1c2luZyBzdGQ6Ond0 Zl9pc2luZjsK