88719 2012-06-09 14:03:33 -0700 [BlackBerry] browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen 2012-06-11 15:05:54 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo tonikitoo oldest_to_newest 645420 0 tonikitoo 2012-06-09 14:03:33 -0700 From PRzilla: +++ This PR was initially created as a clone of PR #162991 +++ This is essentially the same problem as PR158266 which was landed, but Antonio asked that continued problems be PR'd separately. Go to the following simple html5 video example on my server: (...) http://toolswinxp.ott.qnx.com/qvtest_meta.html In this case the fullscreen rectangle is the wrong size as well, but too skinny instead of too wide. (...) 645436 1 146720 tonikitoo 2012-06-09 16:38:39 -0700 Created attachment 146720 (committed r120009, r=rbuis) patch 645980 2 146720 rwlbuis 2012-06-11 07:09:59 -0700 Comment on attachment 146720 (committed r120009, r=rbuis) patch Looks good. 645982 3 146720 rwlbuis 2012-06-11 07:10:35 -0700 Comment on attachment 146720 (committed r120009, r=rbuis) patch View in context: https://bugs.webkit.org/attachment.cgi?id=146720&action=review > Source/WebKit/blackberry/ChangeLog:15 > + fullscreen, and webpage had viewport metatag set. Oh you may want to add the internal reviewer, good for future reference/blame :) 146720 2012-06-09 16:38:39 -0700 2012-06-11 15:05:25 -0700 (committed r120009, r=rbuis) patch 0001-BlackBerry-browser-video-player-fullscreen-mode-port.patch text/plain 3230 tonikitoo RnJvbSA1ZTJjNjlkY2QyZmYyN2YzYWMwYmE1ZDMzNzdhNDQ3ZDVlODczZTBlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog U2F0LCA5IEp1biAyMDEyIDE5OjI5OjI5IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVy cnldIGJyb3dzZXIgdmlkZW8gcGxheWVyIGZ1bGxzY3JlZW4gbW9kZSAocG9ydHJhaXQpCiBkb2Vz IG5vdCBwbGF5IHdlbGwgd2l0aCB2aWV3cG9ydCBtZXRhdGFnIC0gQ29udHJvbHMgYXJlIG9mZgog c2NyZWVuIHNvIGNhbm5vdCBleGl0IGZ1bGxzY3JlZW4KIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODcxOSBQUiAjMTY0MDI2CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KUGF0Y2ggYnkgQW50b25pbyBHb21lcyA8YWdvbWVzQHJpbS5jb20+CgpJbnN0ZWFkIG9m IHVzaW5nIFdlYlBhZ2UncyB2aWV3cG9ydCBzaXplLCB3aGljaCBzdWZmZXJzIGZyb20KZGVhbGlu ZyB3aXRoIHRyYW5zZm9ybWVkIGNvb3JkaW5hdGVzLCB2aWV3cG9ydCBtZXRhdGFnIGNoYW5nZXMs CmV0YywgbGV0cyB1c2UgV2ViQ29yZTo6RnJhbWVWaWV3J3MgdmlzaWJsZUNvbnRlbnRSZWN0OjpT aXplOjpXaWR0aCwKd2hpY2ggYWJzdHJhY3QgYWxsIHRoZXNlIHZhcmlhdGlvbnMuCgpJdCBmaXhl cyBhbiBvdmVyc2NhbGUgaXNzdWUgd2Ugd2VyZSBoYXZpbmcgd2hlbiB2aWRlbyBwbGF5ZXIgZW50 ZXJlZApmdWxsc2NyZWVuLCBhbmQgd2VicGFnZSBoYWQgdmlld3BvcnQgbWV0YXRhZyBzZXQuCgoq IFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwOgooV2ViQ29yZTo6Q2hy b21lQ2xpZW50QmxhY2tCZXJyeTo6ZnVsbFNjcmVlblJlbmRlcmVyQ2hhbmdlZCk6Ci0tLQogU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDE5ICsr KysrKysrKysrKysrKysrKysKIC4uLi9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0Jl cnJ5LmNwcCAgICAgIHwgICAgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygr KSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCBhN2Y2 NGIxLi5kMzgyOGI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MiBAQAorMjAxMi0wNi0wOSAgQW50b25pbyBHb21lcyAgPGFnb21lc0ByaW0uY29tPgorCisgICAg ICAgIFtCbGFja0JlcnJ5XSBicm93c2VyIHZpZGVvIHBsYXllciBmdWxsc2NyZWVuIG1vZGUgKHBv cnRyYWl0KSBkb2VzIG5vdCBwbGF5IHdlbGwgd2l0aCB2aWV3cG9ydCBtZXRhdGFnIC0gQ29udHJv bHMgYXJlIG9mZiBzY3JlZW4gc28gY2Fubm90IGV4aXQgZnVsbHNjcmVlbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg3MTkKKyAgICAgICAgUFIgIzE2 NDAyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu c3RlYWQgb2YgdXNpbmcgV2ViUGFnZSdzIHZpZXdwb3J0IHNpemUsIHdoaWNoIHN1ZmZlcnMgZnJv bQorICAgICAgICBkZWFsaW5nIHdpdGggdHJhbnNmb3JtZWQgY29vcmRpbmF0ZXMsIHZpZXdwb3J0 IG1ldGF0YWcgY2hhbmdlcywKKyAgICAgICAgZXRjLCBsZXRzIHVzZSBXZWJDb3JlOjpGcmFtZVZp ZXcncyB2aXNpYmxlQ29udGVudFJlY3Q6OlNpemU6OldpZHRoLAorICAgICAgICB3aGljaCBhYnN0 cmFjdCBhbGwgdGhlc2UgdmFyaWF0aW9ucy4KKworICAgICAgICBJdCBmaXhlcyBhbiBvdmVyc2Nh bGUgaXNzdWUgd2Ugd2VyZSBoYXZpbmcgd2hlbiB2aWRlbyBwbGF5ZXIgZW50ZXJlZAorICAgICAg ICBmdWxsc2NyZWVuLCBhbmQgd2VicGFnZSBoYWQgdmlld3BvcnQgbWV0YXRhZyBzZXQuCisKKyAg ICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEJsYWNrQmVycnk6OmZ1bGxTY3JlZW5SZW5kZXJlckNo YW5nZWQpOgorCiAyMDEyLTA2LTA4ICBDcnlzdGFsIFpoYW5nICA8aGFpemhhbmdAcmltLmNvbT4K IAogICAgICAgICBbQmxhY2tCZXJyeV0gRml4IGNyYXNoIG9uIFBhZ2VQb3B1cENocm9tZUNsaWVu dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0No cm9tZUNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNv cmVTdXBwb3J0L0Nocm9tZUNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGMyYWU0YzkuLjZhNjk3 MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9D aHJvbWVDbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTczOSw3ICs3Mzks OCBAQCB2b2lkIENocm9tZUNsaWVudEJsYWNrQmVycnk6OmZ1bGxTY3JlZW5SZW5kZXJlckNoYW5n ZWQoUmVuZGVyQm94KiBmdWxsU2NyZWVuUmVuZAogICAgICAgICAvLyBGSVhNRTogU2luY2Ugd2Ug YXJlIHNldHRpbmcgYW4gYWJzb2x1dGUgd2lkdGggdmFsdWUgaGVyZSwgaXQgd29uJ3Qgd29yayBm b3IgY2FzZXMKICAgICAgICAgLy8gd2hlcmUgd2UgY2hhbmdlIHRoZSB2aWV3cG9ydCBzaXplIGFz IHdlIGdvLiBGb3IgZXhhbXBsZSwgcm90YXRlIHRoZSBkZXZpY2Ugd2hpbGUKICAgICAgICAgLy8g aW4gZnVsbHNjcmVlbiBtb2RlLgotICAgICAgICBmdWxsU2NyZWVuUmVuZGVyZXItPnN0eWxlKCkt PnNldFdpZHRoKExlbmd0aChtX3dlYlBhZ2VQcml2YXRlLT52aWV3cG9ydFNpemUoKS53aWR0aCgp LCBGaXhlZCkpOworICAgICAgICBpbnQgd2lkdGggPSBtX3dlYlBhZ2VQcml2YXRlLT5tX21haW5G cmFtZS0+dmlldygpLT52aXNpYmxlQ29udGVudFJlY3QoKS5zaXplKCkud2lkdGgoKTsKKyAgICAg ICAgZnVsbFNjcmVlblJlbmRlcmVyLT5zdHlsZSgpLT5zZXRXaWR0aChMZW5ndGgod2lkdGgsIEZp eGVkKSk7CiAgICAgfQogfQogI2VuZGlmCi0tIAoxLjcuNS40Cgo=