88718 2012-06-09 13:56:37 -0700 Make WebGL mark draws for compositing even if the draw count is zero 2012-06-11 15:19:45 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 gman gman kbr webkit.review.bot zmo oldest_to_newest 645418 0 gman 2012-06-09 13:56:37 -0700 Make WebGL mark draws for compositing even if the draw count is zero 645419 1 146717 gman 2012-06-09 13:58:17 -0700 Created attachment 146717 Patch 645448 2 146717 kbr 2012-06-09 22:51:03 -0700 Comment on attachment 146717 Patch Looks fine. Is there any way we could adjust one of the pixel tests which uses requestAnimationFrame to verify this behavior? r=me in the meantime. 645451 3 146717 webkit.review.bot 2012-06-09 23:36:43 -0700 Comment on attachment 146717 Patch Clearing flags on attachment: 146717 Committed r119922: <http://trac.webkit.org/changeset/119922> 645452 4 webkit.review.bot 2012-06-09 23:36:47 -0700 All reviewed patches have been landed. Closing bug. 646319 5 gman 2012-06-11 15:19:27 -0700 Unfortunately there's no way I know of to test this automatically example of bug clear canvas to green wait for composite at this point any read will be 0,0,0,0 but display will be green draw with count of 0 at this point composite should show cleared canvas since the draw should have forced a composite but there's no way to test, at least not with layout tests. a screen capture could test this. Put manual tests here for now. https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/manual/ 146717 2012-06-09 13:58:17 -0700 2012-06-11 15:19:45 -0700 Patch bug-88718-20120609140008.patch text/plain 1958 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDNlZTI3MDg5M2ZiNDNj M2VlMWIxN2NhOTg2MThlNWY0ZmIzYWQ1Yy4uZjEyYjAxYWYwZjVhNjhmNGVmMDFmZjAzNWE5N2Y1 ZGJiMzMxZTM2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTA5ICBHcmVn ZyBUYXZhcmVzICA8Z21hbkBnb29nbGUuY29tPgorCisgICAgICAgIE1ha2UgV2ViR0wgbWFyayBk cmF3cyBmb3IgY29tcG9zaXRpbmcgZXZlbiBpZiB0aGUgZHJhdyBjb3VudCBpcyB6ZXJvCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODcxOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBh cyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVu ZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6 OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6ZHJhd0FycmF5cyk6CisgICAgICAgIChXZWJDb3JlOjpX ZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmRyYXdFbGVtZW50cyk6CisKIDIwMTItMDYtMDkgIEZsb3Jp biBNYWxpdGEgIDxmbWFsaXRhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXhlZC1wb3NpdGlv biBmb3JlaWduT2JqZWN0IGRlc2NlbmRhbnRzIHNob3VsZCBiZSByZWxhdGl2ZSB0byB0aGUgZm9y ZWlnbk9iamVjdCB2aWV3cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFz L1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggMDM4ZWRjMjJjYTEyNWE4YWZmMWViYWM0 ZmQ4OTA2NmMxNmQxMzI2Zi4uNzJkNzZhY2E1NWFlZTcyMWM4ZjRjMTNhYzNjMWEwZTExMDlmM2M1 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdD b250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmlu Z0NvbnRleHQuY3BwCkBAIC0xODY1LDggKzE4NjUsMTAgQEAgdm9pZCBXZWJHTFJlbmRlcmluZ0Nv bnRleHQ6OmRyYXdBcnJheXMoR0MzRGVudW0gbW9kZSwgR0MzRGludCBmaXJzdCwgR0MzRHNpemVp IGMKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmICghY291bnQpCisgICAgaWYgKCFj b3VudCkgeworICAgICAgICBjbGVhbnVwQWZ0ZXJHcmFwaGljc0NhbGwodHJ1ZSk7CiAgICAgICAg IHJldHVybjsKKyAgICB9CiAKICAgICBpZiAoIWlzRXJyb3JHZW5lcmF0ZWRPbk91dE9mQm91bmRz QWNjZXNzZXMoKSkgewogICAgICAgICAvLyBFbnN1cmUgd2UgaGF2ZSBhIHZhbGlkIHJlbmRlcmlu ZyBzdGF0ZQpAQCAtMTkyOSw4ICsxOTMxLDEwIEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0 OjpkcmF3RWxlbWVudHMoR0MzRGVudW0gbW9kZSwgR0MzRHNpemVpIGNvdW50LCBHQzNEZW51CiAg ICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBpZiAoIWNvdW50KQorICAgIGlmICghY291bnQp IHsKKyAgICAgICAgY2xlYW51cEFmdGVyR3JhcGhpY3NDYWxsKHRydWUpOwogICAgICAgICByZXR1 cm47CisgICAgfQogCiAgICAgaWYgKCFtX2JvdW5kVmVydGV4QXJyYXlPYmplY3QtPmdldEVsZW1l bnRBcnJheUJ1ZmZlcigpKSB7CiAgICAgICAgIHN5bnRoZXNpemVHTEVycm9yKEdyYXBoaWNzQ29u dGV4dDNEOjpJTlZBTElEX09QRVJBVElPTiwgImRyYXdFbGVtZW50cyIsICJubyBFTEVNRU5UX0FS UkFZX0JVRkZFUiBib3VuZCIpOwo=