88717 2012-06-09 11:47:49 -0700 [EFL] Remove CMakeCache.txt before building 2012-07-16 10:32:23 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91387 1 cdumez cdumez d-r gyuyoung.kim gyuyoung.kim lucas.de.marchi mrobinson mxie rwlbuis tmpsantos tonikitoo webkit.review.bot oldest_to_newest 645376 0 cdumez 2012-06-09 11:47:49 -0700 The CMakeCache.txt file gets outdated when build DEFINES are changed (e.g. a feature is enabled). This leads to unexpected behavior when a flag such as "SHADOW_DOM" is added but is not taken into consideration because of the CMake cache. Newly unskipped tests will then fail on the bot because the functionality has not been enabled. This already happened several times. As a consequence, I'm proposing to edit the build script to remove the CMakeCache.txt before every build. This will effectively prevent this problem from happening again. 645378 1 146713 cdumez 2012-06-09 11:50:59 -0700 Created attachment 146713 Patch 645473 2 gyuyoung.kim 2012-06-10 03:57:36 -0700 I think CMakeCache.txt is still useful when we wanna build cmake project with other options. However, in this case, it looks we don't need to keep CMakeCache.txt because "build-webkit --efl" always uses same build directory. To my quick test, there is no big performance gain when we use CMakeCache.txt. So, I agree with this removal. 645801 3 d-r 2012-06-11 00:46:57 -0700 LGTM, too. We need that. 646572 4 146713 webkit.review.bot 2012-06-11 20:04:42 -0700 Comment on attachment 146713 Patch Clearing flags on attachment: 146713 Committed r120032: <http://trac.webkit.org/changeset/120032> 646573 5 webkit.review.bot 2012-06-11 20:04:48 -0700 All reviewed patches have been landed. Closing bug. 657576 6 tmpsantos 2012-06-26 06:49:18 -0700 *** Bug 87222 has been marked as a duplicate of this bug. *** 146713 2012-06-09 11:50:59 -0700 2012-06-11 20:04:42 -0700 Patch 88717_remove_cmake_cache.patch text/plain 1538 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3OTMx YmZlLi5hMTIwYzBkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMDkgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBSZW1vdmUgQ01ha2VD YWNoZS50eHQgYmVmb3JlIGJ1aWxkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04ODcxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbW92ZSBDTWFrZSBjYWNoZSBmaWxlIGJlZm9yZSBldmVyeSBidWls ZCB0byBhdm9pZCB1c2luZyBvdXRkYXRlZAorICAgICAgICBidWlsZCBmbGFncyB3aGVuIG5ldyBm ZWF0dXJlcyBnZXQgZW5hYmxlZC4gVGhpcyB3aWxsIGF2b2lkIHVuZXhwZWN0ZWQKKyAgICAgICAg ZmFpbHVyZXMgb24gdGhlIGJvdHMgZHVlIHRvIG91dGRhdGVkIGJ1aWxkIGZsYWdzLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3Rl bUZyb21DTWFrZVByb2plY3QpOgorCiAyMDEyLTA2LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIHdlYmtpdC1wYXRjaCBsYW5kLXNhZmVseSBzaG91bGQgc2V0 IGNxPyBpZiB0aGUgcGF0Y2ggYXV0aG9yIGlzIG5vdCBpbiBjb21taXR0ZXJzLnB5CmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KaW5kZXggYjcyOGJhZC4uNDk1MWEwNSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjA5NSw2 ICsyMDk1LDEyIEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdAogICAg ICAgICAkRU5WeydDWFhGTEFHUyd9ID0gIi1tYXJjaD1wZW50aXVtNCAtbXNzZTIgLW1mcG1hdGg9 c3NlICIgLiAoJEVOVnsnQ1hYRkxBR1MnfSB8fCAiIik7CiAgICAgfQogCisgICAgIyBSZW1vdmUg Q01ha2VDYWNoZS50eHQgdG8gYXZvaWQgdXNpbmcgb3V0ZGF0ZWQgYnVpbGQgZmxhZ3MKKyAgICBp ZiAoaXNFZmwoKSkgeworICAgICAgICBteSAkY2FjaGVGaWxlUGF0aCA9IEZpbGU6OlNwZWMtPmNh dGRpcigkYnVpbGRQYXRoLCAiQ01ha2VDYWNoZS50eHQiKTsKKyAgICAgICAgdW5saW5rKCRjYWNo ZUZpbGVQYXRoKSBpZiAtZSAkY2FjaGVGaWxlUGF0aDsKKyAgICB9CisKICAgICAjIFdlIGNhbGwg c3lzdGVtKCJjbWFrZSBAYXJncyIpIGluc3RlYWQgb2Ygc3lzdGVtKCJjbWFrZSIsIEBhcmdzKSBz byB0aGF0IEBhcmdzIGlzCiAgICAgIyBwYXJzZWQgZm9yIHNoZWxsIG1ldGFjaGFyYWN0ZXJzLgog ICAgIG15ICR3cmFwcGVyID0gamhidWlsZFdyYXBwZXJQcmVmaXhJZk5lZWRlZCgpIC4gIiAiOwo=