88710 2012-06-09 07:40:58 -0700 Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise. 2012-06-09 09:53:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein janx joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 645323 0 vsevik 2012-06-09 07:40:58 -0700 Patch to follow. 645331 1 146704 vsevik 2012-06-09 08:25:00 -0700 Created attachment 146704 Patch 645336 2 vsevik 2012-06-09 08:34:43 -0700 *** Bug 88025 has been marked as a duplicate of this bug. *** 645348 3 146704 pfeldman 2012-06-09 09:40:14 -0700 Comment on attachment 146704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146704&action=review > Source/WebCore/inspector/front-end/inspector.js:974 > + preferredPanels.push(this.panels["scripts"]); this.panels.scripts > Source/WebCore/inspector/front-end/inspector.js:975 > + if (this.panels["resources"]) Nit: we should remove the hiddenPanels altogether and get rid of these checks. > Source/WebCore/inspector/front-end/inspector.js:976 > + preferredPanels.push(this.panels["resources"]); ditto > Source/WebCore/inspector/front-end/inspector.js:978 > + preferredPanels.push(this.panels["network"]); ditto 645352 4 vsevik 2012-06-09 09:53:31 -0700 Committed r119906: <http://trac.webkit.org/changeset/119906> 146704 2012-06-09 08:25:00 -0700 2012-06-09 09:40:14 -0700 Patch bug-88710-20120609192459.patch text/plain 2568 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5OTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmZkMDljNDg3ZDVmNjVi ZmEzYzUxNjc0MjBkZjA3N2ExMGNmYmU0NC4uNTY1ODZmZTE2M2U4YjI4NWVhNjQ2NjFmYzMxNWE0 Yjc0ZGU4NTA0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTA5ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IE9wZW4gbGlua3MgaW4gU291cmNlcyBwYW5lbCBieSBkZWZhdWx0IGFuZCBmYWxsYmFjayB0 byBSZXNvdXJjZXMgYW5kIE5ldHdvcmsgcGFuZWwgb3RoZXJ3aXNlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg3MTAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmRvY3VtZW50Q2xpY2suZm9sbG93TGlu ayk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuZG9jdW1lbnRDbGljayk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuX3Nob3dBbmNob3JMb2NhdGlvbik6CisKIDIwMTItMDYtMDkgIEFuZHJleSBLb3N5 YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbcmVm YWN0b3JpbmddIHJlbmFtZSBUaW1lbGluZVZlcnRpY2FsT3ZlcnZpZXcgaW50byBUaW1lbGluZUZy YW1lT3ZlcnZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuanMKaW5kZXggYWE3Yjg0MzkyMTU1NjgyYjdlNTFiMzY5OGEzMzUyNWJkMmY3MmI5My4u Y2NkZTgwYjFkMGE0OWYxMzZhYTNlZDlkNzIzZDU5ZDNhMDRjMzNlZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAgLTYzNiw3ICs2MzYs NyBAQCBXZWJJbnNwZWN0b3IuZG9jdW1lbnRDbGljayA9IGZ1bmN0aW9uKGV2ZW50KQogICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgV2ViSW5zcGVjdG9yLnNob3dQYW5l bCgicmVzb3VyY2VzIik7CisgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5vcGVuSW5OZXdU YWIoYW5jaG9yLmhyZWYpOwogICAgIH0KIAogICAgIGlmIChXZWJJbnNwZWN0b3IuZm9sbG93TGlu a1RpbWVvdXQpCkBAIC05NjcsMTEgKzk2NywxOSBAQCBXZWJJbnNwZWN0b3IuX3Nob3dBbmNob3JM b2NhdGlvbiA9IGZ1bmN0aW9uKGFuY2hvcikKIHsKICAgICBpZiAoV2ViSW5zcGVjdG9yLm9wZW5B bmNob3JMb2NhdGlvblJlZ2lzdHJ5LmRpc3BhdGNoKHsgdXJsOiBhbmNob3IuaHJlZiwgbGluZU51 bWJlcjogYW5jaG9yLmxpbmVOdW1iZXJ9KSkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgdmFy IHByZWZlcmVkUGFuZWwgPSB0aGlzLnBhbmVsc1thbmNob3IucHJlZmVycmVkUGFuZWwgfHwgInJl c291cmNlcyJdOwotICAgIGlmIChXZWJJbnNwZWN0b3IuX3Nob3dBbmNob3JMb2NhdGlvbkluUGFu ZWwoYW5jaG9yLCBwcmVmZXJlZFBhbmVsKSkKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgaWYg KHByZWZlcmVkUGFuZWwgIT09IHRoaXMucGFuZWxzLnJlc291cmNlcyAmJiBXZWJJbnNwZWN0b3Iu X3Nob3dBbmNob3JMb2NhdGlvbkluUGFuZWwoYW5jaG9yLCB0aGlzLnBhbmVscy5yZXNvdXJjZXMp KQotICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB2YXIgcHJlZmVycmVkUGFuZWxzID0gW107Cisg ICAgaWYgKHRoaXMucGFuZWxzW2FuY2hvci5wcmVmZXJyZWRQYW5lbF0pCisgICAgICAgIHByZWZl cnJlZFBhbmVscy5wdXNoKHRoaXMucGFuZWxzW2FuY2hvci5wcmVmZXJyZWRQYW5lbF0pOworICAg IGlmICh0aGlzLnBhbmVsc1sic2NyaXB0cyJdKQorICAgICAgICBwcmVmZXJyZWRQYW5lbHMucHVz aCh0aGlzLnBhbmVsc1sic2NyaXB0cyJdKTsKKyAgICBpZiAodGhpcy5wYW5lbHNbInJlc291cmNl cyJdKQorICAgICAgICBwcmVmZXJyZWRQYW5lbHMucHVzaCh0aGlzLnBhbmVsc1sicmVzb3VyY2Vz Il0pOworICAgIGlmICh0aGlzLnBhbmVsc1sibmV0d29yayJdKQorICAgICAgICBwcmVmZXJyZWRQ YW5lbHMucHVzaCh0aGlzLnBhbmVsc1sibmV0d29yayJdKTsKKyAgICBmb3IgKHZhciBpID0gMDsg aSA8IHByZWZlcnJlZFBhbmVscy5sZW5ndGg7ICsraSkgeworICAgICAgICBpZiAoV2ViSW5zcGVj dG9yLl9zaG93QW5jaG9yTG9jYXRpb25JblBhbmVsKGFuY2hvciwgcHJlZmVycmVkUGFuZWxzW2ld KSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KICAgICByZXR1cm4gZmFsc2U7CiB9 CiAK