8871 2006-05-12 06:12:53 -0700 REGRESSION: Pressing Enter/Return in a text input removes the selected text 2006-07-15 08:24:46 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix, HasReduction, InRadar, Regression P1 Normal --- 1 ap darin adele darin ian oldest_to_newest 42097 0 ap 2006-05-12 06:12:53 -0700 Pressing Enter or Return in a text field when there is a selection removes the selected part (provided there's no submit button in the form). 42098 1 8265 ap 2006-05-12 06:13:14 -0700 Created attachment 8265 test case 42104 2 eric 2006-05-12 09:35:45 -0700 This could be related to bug 8741 42238 3 darin 2006-05-13 18:47:47 -0700 The issue isn't whether the form has a submit button. It's whether there's a form element at all. Here's the code from HTMLInputElement::defaultEventHandler: } else if (clickDefaultFormButton && form()) { form()->submitClick(); evt->setDefaultHandled(); } instead, the code should say: } else if (clickDefaultFormButton) { if (form()) form()->submitClick(); evt->setDefaultHandled(); } Whether Enter is "eaten" by the input element should not depend on whether there's a form or not. 42532 4 adele 2006-05-16 13:52:12 -0700 I have this fix in my tree 44877 5 alice.barraclough 2006-06-06 10:52:04 -0700 <rdar://problem/4575417> 49804 6 9450 darin 2006-07-14 09:41:06 -0700 Created attachment 9450 patch with detailed change log and a layout test 49933 7 darin 2006-07-15 08:16:06 -0700 Committed revision 15454. 8265 2006-05-12 06:13:14 -0700 2006-05-12 06:13:14 -0700 test case input-return.html text/html 360 ap U2VsZWN0IHNvbWUgY2hhcmFjdGVycywgdGhlbiBwcmVzcyBFbnRlciBvciBSZXR1cm4uIEZpcmVm b3ggZG9lcyBub3RoaW5nOyBDb2NvYSBiZWhhdmlvciBpcyB0byBzZWxlY3QgdGhlIHdob2xlIHRl eHQuPGJyPgo8aW5wdXQgdmFsdWU9IjEyMzQ1Njc4OSI+PC9pbnB1dD48YnI+CjxpbnB1dD48L2lu cHV0Pjxicj4KRG9uJ3Qgb3Zlcmxvb2sgT3B0aW9uK1JldHVybiwgQ21kK1JldHVybiBldGMuLi4g U3RvY2sgMTAuNC42IFNhZmFyaSBiZWhhdmlvciBkZXBlbmRzIG9uIHdoZXRoZXIgdGhlIGlucHV0 IGhhcyBpbiBpbml0aWFsIHZhbHVlIChpZiBpdCBkb2VzLCB0aGUgY2FyZXQgbW92ZXMgdG8gdGhl IGVuZCBvZiB0aGUgdGV4dCku 9450 2006-07-14 09:41:06 -0700 2006-07-14 09:46:16 -0700 patch with detailed change log and a layout test EnterKeyPatch.txt text/plain 6464 darin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NDI3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDYtMDctMTQgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVn LmNnaT9pZD04ODcxCisgICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ1NzU0MTc+CisgICAgICAg ICAgUkVHUkVTU0lPTjogUHJlc3NpbmcgRW50ZXIvUmV0dXJuIGluIGEgdGV4dCBpbnB1dCByZW1v dmVzIHRoZSBzZWxlY3RlZCB0ZXh0CisgICAgICAgICAgYW5kIGh0dHA6Ly9idWd6aWxsYS5vcGVu ZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc0MworICAgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80NjE0MjI4PgorICAgICAgICAgIFJFR1JFU1NJT046IGNyYXNoIGRpc3BhdGNoaW5nIEphdmFT Y3JpcHQtY3JlYXRlZCBrZXlib2FyZCBldmVudCB0byBpbnB1dCBlbGVtZW50CisKKyAgICAgICAg KiBmYXN0L2Zvcm1zL2lucHV0LXRleHQtZW50ZXItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2Zvcm1zL2lucHV0LXRleHQtZW50ZXIuaHRtbDogQWRkZWQuCisKIDIwMDYtMDct MTQgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0 LXRleHQtZW50ZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvaW5wdXQtdGV4dC1lbnRlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9mYXN0L2Zvcm1zL2lucHV0LXRleHQtZW50ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDcgQEAKK0VESVRJTkcgREVMRUdBVEU6IHdlYlZpZXdEaWRDaGFuZ2VT ZWxlY3Rpb246V2ViVmlld0RpZENoYW5nZVNlbGVjdGlvbk5vdGlmaWNhdGlvbgorVGhpcyB0ZXN0 IHNlbGVjdHMgc29tZSBjaGFyYWN0ZXJzLCB0aGVuIHNpbXVsYXRlcyBhIHByZXNzIG9mIHRoZSBF bnRlciBrZXkgKG1hcmtlZCBSZXR1cm4gb24gTWFjaW50b3NoIGtleWJvYXJkcykuCisKKworQ29u dGVudCBvZiBpbnB1dCBhZnRlciBwcmVzc2luZyByZXR1cm4gaXMgIjEyMzQ1Njc4Ii4gSXQgc2hv dWxkIGJlICIxMjM0NTY3OCIuCisKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9pbnB1dC10ZXh0LWVudGVyLWV4cGVjdGVkLnR4dApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6 IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2lucHV0LXRleHQtZW50ZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL2lucHV0LXRleHQtZW50ZXIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvZm9ybXMvaW5wdXQtdGV4dC1lbnRlci5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1 IEBACis8cD5UaGlzIHRlc3Qgc2VsZWN0cyBzb21lIGNoYXJhY3RlcnMsIHRoZW4gc2ltdWxhdGVz IGEgcHJlc3Mgb2YgdGhlIEVudGVyIGtleSAobWFya2VkIFJldHVybiBvbiBNYWNpbnRvc2gga2V5 Ym9hcmRzKS48L3A+Cis8cD48aW5wdXQgaWQ9ImlucHV0IiB2YWx1ZT0iMTIzNDU2NzgiPjwvaW5w dXQ+PC9wPgorPHA+Q29udGVudCBvZiBpbnB1dCBhZnRlciBwcmVzc2luZyByZXR1cm4gaXMgIjxz cGFuIGlkPSJyZXN1bHQiPjwvc3Bhbj4iLiBJdCBzaG91bGQgYmUgIjEyMzQ1Njc4Ii48L3A+Cis8 c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit2YXIgaW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiaW5wdXQiKTsKK2lucHV0LnNldFNlbGVjdGlvblJhbmdlKDIsIDYpOwordmFyIGV2ZW50 ID0gZG9jdW1lbnQuY3JlYXRlRXZlbnQoIktleWJvYXJkRXZlbnRzIik7CitldmVudC5pbml0S2V5 Ym9hcmRFdmVudCgia2V5cHJlc3MiLCB0cnVlLCB0cnVlLCBkb2N1bWVudC5kZWZhdWx0Vmlldywg IkVudGVyIiwgMCwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIGZhbHNlKTsKK2lucHV0LmRp c3BhdGNoRXZlbnQoZXZlbnQpOworaWYgKHdpbmRvdy5ldmVudFNlbmRlcikKKyAgICBldmVudFNl bmRlci5rZXlEb3duKCdcbicsIFtdKTsKK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQi KS5pbm5lclRleHQgPSBpbnB1dC52YWx1ZTsKKzwvc2NyaXB0PgoKUHJvcGVydHkgY2hhbmdlcyBv bjogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnB1dC10ZXh0LWVudGVyLmh0bWwKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9odG1sCk5hbWU6IHN2bjplb2wtc3R5bGUK ICAgKyBuYXRpdmUKCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU0MjcpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDA2LTA3LTE0ICBEYXJpbiBBZGxlciAgPGRh cmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dp P2lkPTg4NzEKKyAgICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDU3NTQxNz4KKyAgICAgICAgICBS RUdSRVNTSU9OOiBQcmVzc2luZyBFbnRlci9SZXR1cm4gaW4gYSB0ZXh0IGlucHV0IHJlbW92ZXMg dGhlIHNlbGVjdGVkIHRleHQKKworICAgICAgICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRh cndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDMKKyAgICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDYxNDIyOD4KKyAgICAgICAgICBSRUdSRVNTSU9OOiBjcmFzaCBkaXNwYXRjaGluZyBKYXZhU2Ny aXB0LWNyZWF0ZWQga2V5Ym9hcmQgZXZlbnQgdG8gaW5wdXQgZWxlbWVudAorCisgICAgICAgICog YnJpZGdlL21hYy9GcmFtZU1hYy5tbTogKFdlYkNvcmU6OkZyYW1lTWFjOjpkb1RleHRGaWVsZENv bW1hbmRGcm9tRXZlbnQpOgorICAgICAgICBBZGQgYSBudWxsIGNoZWNrIHRvIGZpeCB0aGUgY3Jh c2gsIGFuZCBhIEZJWE1FIGV4cGxhaW5pbmcgd2h5IHRoaXMgaXMgbm90IG5lY2Vzc2FyaWx5Cisg ICAgICAgIGVub3VnaCBmb3IgdGhlIGZ1dHVyZS4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0 RWxlbWVudC5jcHA6IChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5k bGVyKToKKyAgICAgICAgQ29uc3VtZSBFbnRlciBrZXkga2V5cHJlc3MgZXZlbnRzIGV2ZW4gaWYg dGhlIGVsZW1lbnQgaXMgbm90IGluIGEgZm9ybS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9L ZXlFdmVudE1hYy5tbTogKFdlYkNvcmU6OmtleUlkZW50aWZpZXJGb3JLZXlFdmVudCk6IEFkZGVk IFxuIHRvIHRoZQorICAgICAgICBjaGFyYWN0ZXJzIHRoYXQgdHVybiBpbnRvICJFbnRlciIuIEFj dHVhbCBrZXlib2FyZCBldmVudHMgYWx3YXlzIGFyZSBcciBvciBcMDAzIG9uCisgICAgICAgIHRo ZSBNYWNpbnRvc2gsIGJ1dCBpbiBsYXlvdXQgdGVzdHMgd2UgY2FuIHVzZSBcbiwgYW5kIGV2ZXJ5 dGhpbmcgb3RoZXIgdGhhbiB0aGUKKyAgICAgICAgY29kZSBwYXRoIGhlcmUgd29ya3MsIHNvIHdv cnRoIGZpeGluZy4KKwogMjAwNi0wNy0xNCAgTWl0eiBQZXR0ZWwgIDxvcGVuZGFyd2luLm9yZ0Bt aXR6cGV0dGVsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4KSW5kZXg6IFdlYkNv cmUvYnJpZGdlL21hYy9GcmFtZU1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9t YWMvRnJhbWVNYWMubW0JKHJldmlzaW9uIDE1NDAyKQorKysgV2ViQ29yZS9icmlkZ2UvbWFjL0Zy YW1lTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMjU3LDYgKzMyNTcsMTEgQEAgdm9pZCBGcmFt ZU1hYzo6dGV4dERpZENoYW5nZUluVGV4dEFyZWEoRQogCiBib29sIEZyYW1lTWFjOjpkb1RleHRG aWVsZENvbW1hbmRGcm9tRXZlbnQoRWxlbWVudCogaW5wdXQsIGNvbnN0IFBsYXRmb3JtS2V5Ym9h cmRFdmVudCogZXZlbnQpCiB7CisgICAgLy8gRklYTUU6IFdlIG1pZ2h0IGV2ZW50dWFsbHkgbmVl ZCB0byBtYWtlIHN1cmUga2V5IGJpbmRpbmdzIGZvciBlZGl0aW5nIHdvcmsgZXZlbiB3aXRoCisg ICAgLy8gZXZlbnRzIGNyZWF0ZWQgd2l0aCB0aGUgRE9NIEFQSS4gVGhvc2UgZG9uJ3QgaGF2ZSBh IFBsYXRmb3JtS2V5Ym9hcmRFdmVudC4KKyAgICBpZiAoIWV2ZW50KQorICAgICAgICByZXR1cm4g ZmFsc2U7CisKICAgICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiAgICAgcmV0dXJuIFtf YnJpZGdlIHRleHRGaWVsZDooRE9NSFRNTElucHV0RWxlbWVudCAqKVtET01FbGVtZW50IF9lbGVt ZW50V2l0aDppbnB1dF0gZG9Db21tYW5kQnlTZWxlY3RvcjpzZWxlY3RvckZvcktleUV2ZW50KGV2 ZW50KV07CiAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKSW5kZXg6IFdlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5jcHAJKHJldmlzaW9uIDE1NDAyKQorKysgV2ViQ29yZS9odG1sL0hUTUxJbnB1 dEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQwLDggKzEzNDAsOSBAQCB2b2lkIEhU TUxJbnB1dEVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsCiAgICAgICAgIGlmIChjbGlja0VsZW1l bnQpIHsKICAgICAgICAgICAgIGNsaWNrKGZhbHNlKTsKICAgICAgICAgICAgIGV2dC0+c2V0RGVm YXVsdEhhbmRsZWQoKTsKLSAgICAgICAgfSBlbHNlIGlmIChjbGlja0RlZmF1bHRGb3JtQnV0dG9u ICYmIGZvcm0oKSkgewotICAgICAgICAgICAgZm9ybSgpLT5zdWJtaXRDbGljaygpOworICAgICAg ICB9IGVsc2UgaWYgKGNsaWNrRGVmYXVsdEZvcm1CdXR0b24pIHsKKyAgICAgICAgICAgIGlmIChm b3JtKCkpCisgICAgICAgICAgICAgICAgZm9ybSgpLT5zdWJtaXRDbGljaygpOwogICAgICAgICAg ICAgZXZ0LT5zZXREZWZhdWx0SGFuZGxlZCgpOwogICAgICAgICB9CiAgICAgfQpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvS2V5RXZlbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9tYWMvS2V5RXZlbnRNYWMubW0JKHJldmlzaW9uIDE1NDAyKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9tYWMvS2V5RXZlbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTc4LDcgKzc4LDcg QEAgc3RhdGljIFN0cmluZyBrZXlJZGVudGlmaWVyRm9yS2V5RXZlbnQoTgogICAgICAgICBjYXNl IE5TRW5kRnVuY3Rpb25LZXk6CiAgICAgICAgICAgICByZXR1cm4gIkVuZCI7CiAgICAgICAgIC8v ICJFbnRlciIKLSAgICAgICAgY2FzZSAweDM6IGNhc2UgMHhEOiAvLyBNYWNpbnRvc2ggY2FsbHMg dGhlIG9uZSBvbiB0aGUgbWFpbiBrZXlib2FyZCBSZXR1cm4sIGJ1dCBXaW5kb3dzIGNhbGxzIGl0 IEVudGVyLCBzbyB3ZSdsbCBkbyB0aGUgc2FtZSBmb3IgdGhlIERPTQorICAgICAgICBjYXNlIDB4 MzogY2FzZSAweEE6IGNhc2UgMHhEOiAvLyBNYWNpbnRvc2ggY2FsbHMgdGhlIG9uZSBvbiB0aGUg bWFpbiBrZXlib2FyZCBSZXR1cm4sIGJ1dCBXaW5kb3dzIGNhbGxzIGl0IEVudGVyLCBzbyB3ZSds bCBkbyB0aGUgc2FtZSBmb3IgdGhlIERPTQogICAgICAgICAgICAgcmV0dXJuICJFbnRlciI7CiAK ICAgICAgICAgLy8gIkVyYXNlRW9mIgo=