88660 2012-06-08 08:58:20 -0700 Web Inspector: Fix several compiler warnings and errors. 2012-06-08 09:57:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 644704 0 vsevik 2012-06-08 08:58:20 -0700 Patch to follow 644705 1 146579 vsevik 2012-06-08 09:00:06 -0700 Created attachment 146579 Patch 644762 2 146579 webkit.review.bot 2012-06-08 09:57:26 -0700 Comment on attachment 146579 Patch Clearing flags on attachment: 146579 Committed r119839: <http://trac.webkit.org/changeset/119839> 644763 3 webkit.review.bot 2012-06-08 09:57:31 -0700 All reviewed patches have been landed. Closing bug. 146579 2012-06-08 09:00:06 -0700 2012-06-08 09:57:26 -0700 Patch bug-88660-20120608200005.patch text/plain 5464 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWFkYjQzMTNiZjBiYWZh NTY3MjA2ZmRhYWM4Y2ZmZjQzN2U5YjY3Ny4uNjc4MDFjZjk1ZGI3OGM1ZWJiYWI5NjRhYWJmNmQx M2IzZTk4NDdlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTA4ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEZpeCBzZXZlcmFsIGNvbXBpbGVyIHdhcm5pbmdzIGFuZCBlcnJvcnMuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODY2MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHNldmVyYWwgY29tcGls ZXIgd2FybmluZ3MgYW5kIGVycm9ycy4KKyAgICAgICAgUmVtb3ZlZCBpc0VtcHR5IG1ldGhvZCBm cm9tIE9iamVjdC5wcm90b3R5cGUgYW5kIG1hZGUgaXQgc3RhdGljIG1ldGhvZCBvbiBPYmplY3Qu CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRFeHRlcm5zLmpzOgorICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvRmlsZVN5c3RlbU1vZGVsLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkZpbGVTeXN0ZW1Nb2RlbC5wcm90b3R5cGUuX2RldGFjaEZyYW1lKToKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdC5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90eXBlLl9idWlsZERvbWluYXRvclRyZWUpOgorICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzOgorICAgICAgICAoT2JqZWN0 LmlzRW1wdHkpOgorCiAyMDEyLTA2LTA4ICBCcnlhbiBNY1F1YWRlICA8Ym1jcXVhZGVAZ29vZ2xl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBbm5vdGF0ZSB0aW1lbGluZSByZWNvcmRz IHdpdGggYSBmcmFtZSBpZGVudGlmaWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5qZWN0ZWRTY3JpcHRFeHRlcm5zLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luamVjdGVkU2NyaXB0RXh0ZXJucy5qcwppbmRleCAyNTQ2ZjJjMTliNjc3ZTU2ODEwYjA3ZmFh NWY0MGUzYjE1OWI1ODVlLi44MTEzM2I3ZWNjODcwNDA4MTRhY2IxOTI4ZGJiNDMyMTdkZjcwYjIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRFeHRl cm5zLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEV4dGVy bnMuanMKQEAgLTk4LDUgKzk4LDEzIEBAIGZ1bmN0aW9uIEphdmFTY3JpcHRDYWxsRnJhbWUoKQog ICovCiBKYXZhU2NyaXB0Q2FsbEZyYW1lLnByb3RvdHlwZS5zY29wZVR5cGUgPSBmdW5jdGlvbihp bmRleCkgeyB9CiAKKy8qKgorICogQGNvbnN0cnVjdG9yCisgKi8KK2Z1bmN0aW9uIEphdmFTY3Jp cHRGdW5jdGlvbigpCit7CisgICAgLyoqIEB0eXBlIHtBcnJheX0gKi8KKyAgICB0aGlzLnJhd1Nj b3BlczsKK30KIAogdmFyIEluc3BlY3RvckJhY2tlbmQgPSB7IH07CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbGVTeXN0ZW1Nb2RlbC5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmlsZVN5c3RlbU1vZGVsLmpzCmluZGV4IDFl NzljNzVjZTczMGQwNTUyMWNkNjM5YmMzMmE3MTYwNTk4MzJmMzkuLjE5NDM1NGE4OWIwNDI4NTQ3 NjZkZTcxMzg4MjUwNTdmNmQ5MzAwNjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRmlsZVN5c3RlbU1vZGVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvRmlsZVN5c3RlbU1vZGVsLmpzCkBAIC0xMjQsNyArMTI0LDcgQEAg V2ViSW5zcGVjdG9yLkZpbGVTeXN0ZW1Nb2RlbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGRlbGV0 ZSB0aGlzLl9vcmlnaW5Gb3JGcmFtZUlkW2ZyYW1lLmlkXTsKICAgICAgICAgZGVsZXRlIHRoaXMu X2ZyYW1lSWRzRm9yT3JpZ2luW29yaWdpbl1bZnJhbWUuaWRdOwogCi0gICAgICAgIHZhciBsYXN0 T3JpZ2luID0gdGhpcy5fZnJhbWVJZHNGb3JPcmlnaW5bb3JpZ2luXS5pc0VtcHR5KCk7CisgICAg ICAgIHZhciBsYXN0T3JpZ2luID0gT2JqZWN0LmlzRW1wdHkodGhpcy5fZnJhbWVJZHNGb3JPcmln aW5bb3JpZ2luXSk7CiAgICAgICAgIGlmIChsYXN0T3JpZ2luKSB7CiAgICAgICAgICAgICBkZWxl dGUgdGhpcy5fZnJhbWVJZHNGb3JPcmlnaW5bb3JpZ2luXTsKICAgICAgICAgICAgIHRoaXMuX29y aWdpblJlbW92ZWQob3JpZ2luKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9IZWFwU25hcHNob3QuanMKaW5kZXggZGU3ZjQ4OGU5YWM3ZTNhYTRmMGRiZTNmMDlk MDI3NzgyYzY1YzA3NC4uMGFkOTNmZDlkZTdhNjI5MWMzYjRhYjhkNmZlOWVmMTM4MmY0NWQ5NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo b3QuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNo b3QuanMKQEAgLTExODgsOSArMTE4OCwxMCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnBy b3RvdHlwZSA9IHsKICAgICAgICAgLy8gVGhlIGFmZmVjdGVkIGFycmF5IGlzIHVzZWQgdG8gbWFy ayBlbnRyaWVzIHdoaWNoIGRvbWluYXRvcnMKICAgICAgICAgLy8gaGF2ZSB0byBiZSByYWNhbGN1 bGF0ZWQgYmVjYXVzZSBvZiBjaGFuZ2VzIGluIHRoZWlyIHJldGFpbmVycy4KICAgICAgICAgdmFy IGFmZmVjdGVkID0gbmV3IFVpbnQ4QXJyYXkobm9kZXNDb3VudCk7CisgICAgICAgIHZhciBub2Rl T3JkaW5hbDsKIAogICAgICAgICB7IC8vIE1hcmsgdGhlIHJvb3QgZGlyZWN0IGNoaWxkcmVuIGFz IGFmZmVjdGVkLgotICAgICAgICAgICAgdmFyIG5vZGVPcmRpbmFsID0gdGhpcy5fcm9vdE5vZGVJ bmRleCAvIG5vZGVGaWVsZENvdW50OworICAgICAgICAgICAgbm9kZU9yZGluYWwgPSB0aGlzLl9y b290Tm9kZUluZGV4IC8gbm9kZUZpZWxkQ291bnQ7CiAgICAgICAgICAgICB2YXIgYmVnaW5FZGdl VG9Ob2RlRmllbGRJbmRleCA9IGZpcnN0RWRnZUluZGV4ZXNbbm9kZU9yZGluYWxdICsgZWRnZVRv Tm9kZU9mZnNldDsKICAgICAgICAgICAgIHZhciBlbmRFZGdlVG9Ob2RlRmllbGRJbmRleCA9IGZp cnN0RWRnZUluZGV4ZXNbbm9kZU9yZGluYWwgKyAxXTsKICAgICAgICAgICAgIGZvciAodmFyIHRv Tm9kZUZpZWxkSW5kZXggPSBiZWdpbkVkZ2VUb05vZGVGaWVsZEluZGV4OwpAQCAtMTIxMiw3ICsx MjEzLDcgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUgPSB7CiAgICAgICAg ICAgICAgICAgLy8gdGhlbiBpdCBjYW4ndCBwcm9wYWdhdGUgYW55IGZ1cnRoZXIuCiAgICAgICAg ICAgICAgICAgaWYgKGRvbWluYXRvcnNbcG9zdE9yZGVySW5kZXhdID09PSByb290UG9zdE9yZGVy ZWRJbmRleCkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAg dmFyIG5vZGVPcmRpbmFsID0gcG9zdE9yZGVySW5kZXgyTm9kZU9yZGluYWxbcG9zdE9yZGVySW5k ZXhdOworICAgICAgICAgICAgICAgIG5vZGVPcmRpbmFsID0gcG9zdE9yZGVySW5kZXgyTm9kZU9y ZGluYWxbcG9zdE9yZGVySW5kZXhdOwogICAgICAgICAgICAgICAgIHZhciBub2RlRmxhZyA9ICEh KGZsYWdzW25vZGVPcmRpbmFsXSAmIGZsYWcpOwogICAgICAgICAgICAgICAgIHZhciBuZXdEb21p bmF0b3JJbmRleCA9IG5vRW50cnk7CiAgICAgICAgICAgICAgICAgdmFyIGJlZ2luUmV0YWluZXJJ bmRleCA9IGZpcnN0UmV0YWluZXJJbmRleFtub2RlT3JkaW5hbF07CkBAIC0xMjY1LDcgKzEyNjYs NyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsKIAogICAgICAgICB2 YXIgZG9taW5hdG9yc1RyZWUgPSBuZXcgVWludDMyQXJyYXkobm9kZXNDb3VudCk7CiAgICAgICAg IGZvciAodmFyIHBvc3RPcmRlckluZGV4ID0gMCwgbCA9IGRvbWluYXRvcnMubGVuZ3RoOyBwb3N0 T3JkZXJJbmRleCA8IGw7ICsrcG9zdE9yZGVySW5kZXgpIHsKLSAgICAgICAgICAgIHZhciBub2Rl T3JkaW5hbCA9IHBvc3RPcmRlckluZGV4Mk5vZGVPcmRpbmFsW3Bvc3RPcmRlckluZGV4XTsKKyAg ICAgICAgICAgIG5vZGVPcmRpbmFsID0gcG9zdE9yZGVySW5kZXgyTm9kZU9yZGluYWxbcG9zdE9y ZGVySW5kZXhdOwogICAgICAgICAgICAgZG9taW5hdG9yc1RyZWVbbm9kZU9yZGluYWxdID0gcG9z dE9yZGVySW5kZXgyTm9kZU9yZGluYWxbZG9taW5hdG9yc1twb3N0T3JkZXJJbmRleF1dOwogICAg ICAgICB9CiAgICAgICAgIHJldHVybiBkb21pbmF0b3JzVHJlZTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKaW5kZXggOGRlMTQzYjRlMTU0ZWYz MDdjNzNhMjY2YzcwMTE0YTBiYTg1M2ViYi4uZTc3ZmY2MzgzYzkzNTE5NzEyNjVmZDM5N2RjYmRm Nzc3OTcyZmExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC91dGlsaXRpZXMuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91 dGlsaXRpZXMuanMKQEAgLTI3LDYgKzI3LDEzIEBACiAgKiBUSElTIFNPRlRXQVJFLCBFVkVOIElG IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogICovCiAKK09iamVj dC5pc0VtcHR5ID0gZnVuY3Rpb24ob2JqKQoreworICAgIGZvciAodmFyIGkgaW4gb2JqKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIFN0cmluZy5wcm90b3R5 cGUuaGFzU3Vic3RyaW5nID0gZnVuY3Rpb24oc3RyaW5nLCBjYXNlSW5zZW5zaXRpdmUpCiB7CiAg ICAgaWYgKCFjYXNlSW5zZW5zaXRpdmUpCkBAIC02NzYsMTMgKzY4MywzIEBAIE1hcC5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHRoaXMuX21hcCA9IHt9OwogICAgIH0KIH07Ci0KLU9iamVjdC5kZWZp bmVQcm9wZXJ0eShPYmplY3QucHJvdG90eXBlLCAiaXNFbXB0eSIsCi17Ci0gICAgdmFsdWU6IGZ1 bmN0aW9uKCkKLSAgICB7Ci0gICAgICAgIGZvciAodmFyIGkgaW4gdGhpcykKLSAgICAgICAgICAg IHJldHVybiBmYWxzZTsKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotfSk7Cg==